[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=28553=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28553
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 09/Sep/16 02:04
Start Date: 09/Sep/16 02:04
Worklog Time Spent: 10m 
  Work Description: Github user maskit closed the pull request at:

https://github.com/apache/trafficserver/pull/913


Issue Time Tracking
---

Worklog Id: (was: 28553)
Time Spent: 6h  (was: 5h 50m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 6h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=28479=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28479
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 08/Sep/16 18:42
Start Date: 08/Sep/16 18:42
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/913
  
Looks good to me.


Issue Time Tracking
---

Worklog Id: (was: 28479)
Time Spent: 5h 50m  (was: 5h 40m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=28423=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28423
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 08/Sep/16 09:06
Start Date: 08/Sep/16 09:06
Worklog Time Spent: 10m 
  Work Description: Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/913
  
Rebased to obtain the functions from master.


Issue Time Tracking
---

Worklog Id: (was: 28423)
Time Spent: 5h 40m  (was: 5.5h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=28422=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28422
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 08/Sep/16 08:44
Start Date: 08/Sep/16 08:44
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/913
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/640/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28422)
Time Spent: 5.5h  (was: 5h 20m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=28421=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28421
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 08/Sep/16 08:41
Start Date: 08/Sep/16 08:41
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/913
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/744/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28421)
Time Spent: 5h 20m  (was: 5h 10m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=28293=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28293
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 07/Sep/16 16:22
Start Date: 07/Sep/16 16:22
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/913
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/723/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28293)
Time Spent: 5h 10m  (was: 5h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=28292=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28292
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 07/Sep/16 16:21
Start Date: 07/Sep/16 16:21
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/913
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/619/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28292)
Time Spent: 5h  (was: 4h 50m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=28290=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28290
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 07/Sep/16 16:10
Start Date: 07/Sep/16 16:10
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/913
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 28290)
Time Spent: 4h 50m  (was: 4h 40m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=28283=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28283
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 07/Sep/16 16:00
Start Date: 07/Sep/16 16:00
Worklog Time Spent: 10m 
  Work Description: Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/866


Issue Time Tracking
---

Worklog Id: (was: 28283)
Time Spent: 4h 40m  (was: 4.5h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=27034=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27034
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 24/Aug/16 06:26
Start Date: 24/Aug/16 06:26
Worklog Time Spent: 10m 
  Work Description: Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/913
  
CI builds fail because the functions are not in the code yet.


Issue Time Tracking
---

Worklog Id: (was: 27034)
Time Spent: 4.5h  (was: 4h 20m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=27033=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27033
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 24/Aug/16 05:31
Start Date: 24/Aug/16 05:31
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/913
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/496/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27033)
Time Spent: 4h 20m  (was: 4h 10m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=27032=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27032
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 24/Aug/16 05:26
Start Date: 24/Aug/16 05:26
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/913
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/600/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27032)
Time Spent: 4h 10m  (was: 4h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=27031=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27031
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 24/Aug/16 05:20
Start Date: 24/Aug/16 05:20
Worklog Time Spent: 10m 
  Work Description: GitHub user maskit opened a pull request:

https://github.com/apache/trafficserver/pull/913

TS-2237: Add unit tests for escapify_url and pure_escapify_url

Unit tests for #866

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maskit/trafficserver ts2237

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/913.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #913






Issue Time Tracking
---

Worklog Id: (was: 27031)
Time Spent: 4h  (was: 3h 50m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26858=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26858
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 23/Aug/16 01:23
Start Date: 23/Aug/16 01:23
Worklog Time Spent: 10m 
  Work Description: Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
 


Issue Time Tracking
---

Worklog Id: (was: 26858)
Time Spent: 3h 50m  (was: 3h 40m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26777=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26777
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 22/Aug/16 15:54
Start Date: 22/Aug/16 15:54
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/470/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 26777)
Time Spent: 3h 40m  (was: 3.5h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26776=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26776
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 22/Aug/16 15:48
Start Date: 22/Aug/16 15:48
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/574/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 26776)
Time Spent: 3.5h  (was: 3h 20m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26775=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26775
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 22/Aug/16 15:39
Start Date: 22/Aug/16 15:39
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
@maskit I pushed up a new version that separates escapify_url into 
pure_escapify_url (which does not attempt to detect the double encoding case) 
and regular escapify_url (which does).  I updated the InkAPI call to use 
pure_escapify_url so plugins will not be affected by this change.  I tried to 
fix some const correctness issues along the way, but ran into issues so just 
added comments on what I found there.


Issue Time Tracking
---

Worklog Id: (was: 26775)
Time Spent: 3h 20m  (was: 3h 10m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26730=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26730
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 21/Aug/16 09:01
Start Date: 21/Aug/16 09:01
Worklog Time Spent: 10m 
  Work Description: Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
> are you ok with the change if we make a new version of 
LogUtils::escapify_url that does not include this change that is used by 
TSStringPercentEncode? So the change only affects core logic?

@shinrich Yes, I'm fine with that. I would file another JIRA to track down 
the root cause of double-encoding.



Issue Time Tracking
---

Worklog Id: (was: 26730)
Time Spent: 3h 10m  (was: 3h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26683=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26683
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 19/Aug/16 23:26
Start Date: 19/Aug/16 23:26
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
Ok just to be clear.  The current PR will change the behavior of 
TSStringPercentEncode.  Strings that included "%20" would have been double 
encoded and with this change they will not.

@maskit are you ok with the change if we make a new version of 
LogUtils::escapify_url that does not include this change that is used by 
TSStringPercentEncode?  So the change only affects core logic?


Issue Time Tracking
---

Worklog Id: (was: 26683)
Time Spent: 3h  (was: 2h 50m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26560=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26560
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 18/Aug/16 00:58
Start Date: 18/Aug/16 00:58
Worklog Time Spent: 10m 
  Work Description: Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
I'd say it is not sufficient.

As a workaround for most cases, it works, and personally I'm OK with it as 
is. However, I think the behavior of `TSStringPercentEncode` shouldn't be 
changed because it's just a workaround for logging issue.

So, if the API keeps current behavior, then I'm fine with landing this 
change.


Issue Time Tracking
---

Worklog Id: (was: 26560)
Time Spent: 2h 50m  (was: 2h 40m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26553=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26553
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 18/Aug/16 00:24
Start Date: 18/Aug/16 00:24
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
@maskit Are you saying the patch as is is not good / sufficient?


Issue Time Tracking
---

Worklog Id: (was: 26553)
Time Spent: 2h 40m  (was: 2.5h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Assignee: Sudheer Vinukonda
>Priority: Minor
>  Labels: yahoo
> Fix For: 7.0.0
>
> Attachments: TS-2237.diff
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26477=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26477
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 16/Aug/16 00:18
Start Date: 16/Aug/16 00:18
Worklog Time Spent: 10m 
  Work Description: Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
``HttpRequestData::get_string()`` unescapes an URL and it is called from 
``UrlMatcher::Match(RequestData *rdata, Result *result)``. I 
think this is the code Sudheer mentioned.

However, at least, the unescaped URL doesn't come out from the function. If 
we could assure that no unescaped string flows into the logging system, we will 
be able to simply remove some of calls of ``LogUtils::url_escapify``.

Also, I realized that ``TSStringPercentEncode`` uses 
``LogUtils::url_escapify`` internally. So changing behavior of 
``LogUtils::url_escapify`` would affect plugins.


Issue Time Tracking
---

Worklog Id: (was: 26477)
Time Spent: 2.5h  (was: 2h 20m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26427=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26427
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 15/Aug/16 15:03
Start Date: 15/Aug/16 15:03
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/431/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 26427)
Time Spent: 2h 20m  (was: 2h 10m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26426=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26426
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 15/Aug/16 14:58
Start Date: 15/Aug/16 14:58
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/534/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 26426)
Time Spent: 2h 10m  (was: 2h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26425=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26425
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 15/Aug/16 14:31
Start Date: 15/Aug/16 14:31
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
Reviewing the bug comments Sudheer says "Yes, the external URLs should be 
already encoded - however, internally, I see code that decodes the URL strings 
(e.g. UrlMatcher::Match). So, by the time logging receives the URL, it may be 
in the decoded format and needs to be re-encoded."

I'm not familiar enough with the logging subsystem to track down these 
internal cases quickly.  


Issue Time Tracking
---

Worklog Id: (was: 26425)
Time Spent: 2h  (was: 1h 50m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26424=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26424
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 15/Aug/16 13:31
Start Date: 15/Aug/16 13:31
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
@maskit, you list some lovely tricky cases.  Abort encode on detect seems 
like a reasonable approach too.  Ideally, we just could declare that nothing 
comes in already encoded, but that doesn't seem to be the case right now.  Let 
me research the original cause for this bug some more, and perhaps we can 
define away the problem.


Issue Time Tracking
---

Worklog Id: (was: 26424)
Time Spent: 1h 50m  (was: 1h 40m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26423=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26423
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 15/Aug/16 13:28
Start Date: 15/Aug/16 13:28
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/866#discussion_r74760880
  
--- Diff: proxy/logging/LogUtils.cc ---
@@ -359,6 +359,23 @@ LogUtils::escapify_url(Arena *arena, char *url, size_t 
len_in, int *len_out, cha
   while (from < in_url_end) {
 unsigned char c = *from;
 if (map[c / 8] & (1 << (7 - c % 8))) {
+  /*
+   * If two characters following a '%' don't need to be encoded, then 
it must
+   * mean that the three character sequence is already encoded.  Just 
copy it over.
+   */
+  if ((*from == '%') && ((from + 2) < in_url_end)) {
+unsigned char c1   = *(from + 1);
+unsigned char c2   = *(from + 2);
+bool needsEncoding = ((map[c1 / 8] & (1 << (7 - c1 % 8))) || 
(map[c2 / 8] & (1 << (7 - c2 % 8;
+if (!needsEncoding) {
+  out_len -= 2;
+  *to++ = *from;
+  from++;
+  Debug("log-utils", "character already encoded..skipping %c, %c, 
%c", *from, *(from + 1), *(from + 2));
--- End diff --

Yes, *to++ = *from++ should be equivalent.  And moving up the Debug 
statement looks like the right thing to do.


Issue Time Tracking
---

Worklog Id: (was: 26423)
Time Spent: 1h 40m  (was: 1.5h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26422=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26422
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 15/Aug/16 13:26
Start Date: 15/Aug/16 13:26
Worklog Time Spent: 10m 
  Work Description: Github user shinrich commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/866#discussion_r74760536
  
--- Diff: configure.ac ---
@@ -49,7 +49,7 @@ AM_INIT_AUTOMAKE([-Wall -Werror -Wno-portability 
tar-ustar foreign no-installinf
 AM_MAINTAINER_MODE([enable])
 
 # Enable a recursive "tidy" rule for clang-tidy.
-AM_EXTRA_RECURSIVE_TARGETS([tidy])
+#AM_EXTRA_RECURSIVE_TARGETS([tidy])
--- End diff --

Sorry.  Will fix.  Really need to figure out how to get the newer autotools 
working in my environment


Issue Time Tracking
---

Worklog Id: (was: 26422)
Time Spent: 1.5h  (was: 1h 20m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26419=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26419
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 14/Aug/16 20:20
Start Date: 14/Aug/16 20:20
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/866#discussion_r74707817
  
--- Diff: proxy/logging/LogUtils.cc ---
@@ -359,6 +359,23 @@ LogUtils::escapify_url(Arena *arena, char *url, size_t 
len_in, int *len_out, cha
   while (from < in_url_end) {
 unsigned char c = *from;
 if (map[c / 8] & (1 << (7 - c % 8))) {
+  /*
+   * If two characters following a '%' don't need to be encoded, then 
it must
+   * mean that the three character sequence is already encoded.  Just 
copy it over.
+   */
+  if ((*from == '%') && ((from + 2) < in_url_end)) {
+unsigned char c1   = *(from + 1);
+unsigned char c2   = *(from + 2);
+bool needsEncoding = ((map[c1 / 8] & (1 << (7 - c1 % 8))) || 
(map[c2 / 8] & (1 << (7 - c2 % 8;
+if (!needsEncoding) {
+  out_len -= 2;
+  *to++ = *from;
+  from++;
+  Debug("log-utils", "character already encoded..skipping %c, %c, 
%c", *from, *(from + 1), *(from + 2));
--- End diff --

AH, I see, out_len is padded with count*2 (where count is the number of 
special characters). So, out_len -=2 is correct.


Issue Time Tracking
---

Worklog Id: (was: 26419)
Time Spent: 1h 20m  (was: 1h 10m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26418=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26418
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 14/Aug/16 20:07
Start Date: 14/Aug/16 20:07
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/866#discussion_r74707669
  
--- Diff: proxy/logging/LogUtils.cc ---
@@ -359,6 +359,23 @@ LogUtils::escapify_url(Arena *arena, char *url, size_t 
len_in, int *len_out, cha
   while (from < in_url_end) {
 unsigned char c = *from;
 if (map[c / 8] & (1 << (7 - c % 8))) {
+  /*
+   * If two characters following a '%' don't need to be encoded, then 
it must
+   * mean that the three character sequence is already encoded.  Just 
copy it over.
+   */
+  if ((*from == '%') && ((from + 2) < in_url_end)) {
+unsigned char c1   = *(from + 1);
+unsigned char c2   = *(from + 2);
+bool needsEncoding = ((map[c1 / 8] & (1 << (7 - c1 % 8))) || 
(map[c2 / 8] & (1 << (7 - c2 % 8;
+if (!needsEncoding) {
+  out_len -= 2;
+  *to++ = *from;
+  from++;
+  Debug("log-utils", "character already encoded..skipping %c, %c, 
%c", *from, *(from + 1), *(from + 2));
--- End diff --

Hmmm, so some questions on this:

1) Why not  *to++ = *from++;  ?
2) Since we now moved from forward, is the Debug() line still correct? 
Seems that it'd be one too much ?
3) I'm not sure I understand this logic, it seems it consumes 2 bytes 
(out_len -= 2), but it only writes one (*to++ = *from) ? Shouldn't this consume 
/ copy all 3 bytes ? That's sort of what the comments imply, no?
4) It might be nice to explain (comment) what all that bit shifting and 
logic is actually doing? Presumably it's checking if c1 or c2 is of a 
particular value, but what values are those?


Issue Time Tracking
---

Worklog Id: (was: 26418)
Time Spent: 1h 10m  (was: 1h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26417=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26417
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 14/Aug/16 19:49
Start Date: 14/Aug/16 19:49
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/866#discussion_r74707413
  
--- Diff: configure.ac ---
@@ -49,7 +49,7 @@ AM_INIT_AUTOMAKE([-Wall -Werror -Wno-portability 
tar-ustar foreign no-installinf
 AM_MAINTAINER_MODE([enable])
 
 # Enable a recursive "tidy" rule for clang-tidy.
-AM_EXTRA_RECURSIVE_TARGETS([tidy])
+#AM_EXTRA_RECURSIVE_TARGETS([tidy])
--- End diff --

Probably shouldn't remove this?


Issue Time Tracking
---

Worklog Id: (was: 26417)
Time Spent: 1h  (was: 50m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26416=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26416
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 14/Aug/16 16:15
Start Date: 14/Aug/16 16:15
Worklog Time Spent: 10m 
  Work Description: Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
I wrote a unit test for CURRENT `escapify_url`.
http://pastebin.com/XZ4x8bKg

With your change, you would need to change the last expected value in the 
test cases.


Issue Time Tracking
---

Worklog Id: (was: 26416)
Time Spent: 50m  (was: 40m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26415=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26415
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 14/Aug/16 16:08
Start Date: 14/Aug/16 16:08
Worklog Time Spent: 10m 
  Work Description: Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
I don't think this is the right approach. With this change, "%%20" will be 
encoded to "%25%20", right? What if "%%20" was not encoded string? It should be 
encoded to "%25%2520".
Shouldn't we make sure that all callers of this function pass decoded URLs?

Another options is to abort encoding and return inputs as outputs if input 
URLs seem to be already encoded. It can't handle mixed cases but I think it 
would't happen. (If it happens, it should be a bug.)



Issue Time Tracking
---

Worklog Id: (was: 26415)
Time Spent: 40m  (was: 0.5h)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26402=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26402
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 12/Aug/16 22:18
Start Date: 12/Aug/16 22:18
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/430/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 26402)
Time Spent: 0.5h  (was: 20m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26401=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26401
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 12/Aug/16 22:18
Start Date: 12/Aug/16 22:18
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/866
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/533/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 26401)
Time Spent: 20m  (was: 10m)

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-2237) URL encoding wrong in squid.blog

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26399=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26399
 ]

ASF GitHub Bot logged work on TS-2237:
--

Author: ASF GitHub Bot
Created on: 12/Aug/16 22:06
Start Date: 12/Aug/16 22:06
Worklog Time Spent: 10m 
  Work Description: GitHub user shinrich opened a pull request:

https://github.com/apache/trafficserver/pull/866

TS-2237: Fix double encoding of URLs in squid logs.

Resurrecting @sudheerv's fix.  We've been running with this fix for over a 
year.  The logic to lookup the character in the bitfield array is a bit odd, 
but it is the same indexing done for the original character lookup.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shinrich/trafficserver ts-2237

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/866.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #866


commit 22c286947308de594564ac2cde8d72463417ea24
Author: shinrich 
Date:   2016-08-12T22:04:04Z

TS-2237: Fix double encoding of URLs in squid logs.




Issue Time Tracking
---

Worklog Id: (was: 26399)
Time Spent: 10m
Remaining Estimate: 0h

> URL encoding wrong in squid.blog
> 
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: David Carlin
>Priority: Minor
>  Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the % and % log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)