[GitHub] ivankelly opened a new pull request #1131: Split all versions images into released and latest

ivankelly opened a new pull request #1131: Split all versions images into released and latest URL: https://github.com/apache/bookkeeper/pull/1131 The released tarballs rarely change, while the latest changes every build. This patch splits the all version image into a base images with

[GitHub] ivankelly opened a new pull request #1132: Fix shutdown race which left ZK session open

ivankelly opened a new pull request #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132 There was a race when shutting down a bookie, where both the main thread and the shutdown hook thread would try to close the bookie service. This

[GitHub] ivankelly opened a new pull request #1133: Integration smoke test

ivankelly opened a new pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133 Most basic integration test we can have. - Boots a cluster - Writes a ledger - Reads back the ledger - Shutdown the cluster If this test fails, something i

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r167180844 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly opened a new pull request #1134: Remove spammy log messages in Journal

ivankelly opened a new pull request #1134: Remove spammy log messages in Journal URL: https://github.com/apache/bookkeeper/pull/1134 Looks like they were put in while debugging and not cleaned up. This is an automated mess

[GitHub] ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r167209456 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly opened a new pull request #1135: Specify repo in MavenClassLoader

ivankelly opened a new pull request #1135: Specify repo in MavenClassLoader URL: https://github.com/apache/bookkeeper/pull/1135 This is required for testing yahoo's custom bookkeeper client, as it doesn't reside in maven central. --

[GitHub] ivankelly opened a new pull request #1136: Entry count parameters for BenchBookie

ivankelly opened a new pull request #1136: Entry count parameters for BenchBookie URL: https://github.com/apache/bookkeeper/pull/1136 So that they can be added in the test, to make the test run faster and not timeout in CI and ruin an otherwise good test run. ---

[GitHub] eolivelli commented on a change in pull request #1135: Specify repo in MavenClassLoader

eolivelli commented on a change in pull request #1135: Specify repo in MavenClassLoader URL: https://github.com/apache/bookkeeper/pull/1135#discussion_r167220208 ## File path: tests/integration-tests-utils/src/test/java/org/apache/bookkeeper/tests/MavenClassLoaderTest.java ###

[GitHub] eolivelli commented on a change in pull request #1135: Specify repo in MavenClassLoader

eolivelli commented on a change in pull request #1135: Specify repo in MavenClassLoader URL: https://github.com/apache/bookkeeper/pull/1135#discussion_r167220208 ## File path: tests/integration-tests-utils/src/test/java/org/apache/bookkeeper/tests/MavenClassLoaderTest.java ###

[GitHub] eolivelli commented on a change in pull request #1133: Integration smoke test

eolivelli commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167221292 ## File path: tests/integration/smoke/pom.xml ## @@ -0,0 +1,56 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns

[GitHub] eolivelli commented on a change in pull request #1133: Integration smoke test

eolivelli commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167221004 ## File path: tests/integration/smoke/src/test/java/org/apache/bookkeeper/tests/integration/TestSmoke.java ## @@ -0,0 +1,

[GitHub] eolivelli commented on a change in pull request #1133: Integration smoke test

eolivelli commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167221161 ## File path: tests/integration/smoke/src/test/java/org/apache/bookkeeper/tests/integration/TestSmoke.java ## @@ -0,0 +1,

[GitHub] eolivelli commented on a change in pull request #1133: Integration smoke test

eolivelli commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167221061 ## File path: tests/integration/smoke/src/test/java/org/apache/bookkeeper/tests/integration/TestSmoke.java ## @@ -0,0 +1,

Jenkins build is still unstable: bookkeeper_release_branch #54

See

[GitHub] ivankelly commented on a change in pull request #1133: Integration smoke test

ivankelly commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167223773 ## File path: tests/integration/smoke/src/test/java/org/apache/bookkeeper/tests/integration/TestSmoke.java ## @@ -0,0 +1,

[GitHub] ivankelly commented on a change in pull request #1133: Integration smoke test

ivankelly commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167223710 ## File path: tests/integration/smoke/pom.xml ## @@ -0,0 +1,56 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns

[GitHub] ivankelly commented on a change in pull request #1133: Integration smoke test

ivankelly commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167223751 ## File path: tests/integration/smoke/src/test/java/org/apache/bookkeeper/tests/integration/TestSmoke.java ## @@ -0,0 +1,

[GitHub] eolivelli commented on a change in pull request #1133: Integration smoke test

eolivelli commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167224883 ## File path: tests/integration/smoke/pom.xml ## @@ -0,0 +1,56 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns

[GitHub] ivankelly commented on issue #1132: Fix shutdown race which left ZK session open

ivankelly commented on issue #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132#issuecomment-364432260 retest this please This is an automated message from the Apache Git Se

[GitHub] ivankelly opened a new pull request #1132: Fix shutdown race which left ZK session open

ivankelly opened a new pull request #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132 There was a race when shutting down a bookie, where both the main thread and the shutdown hook thread would try to close the bookie service. This

[GitHub] ivankelly closed pull request #1132: Fix shutdown race which left ZK session open

ivankelly closed pull request #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] ivankelly commented on issue #1133: Integration smoke test

ivankelly commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364432617 regarding the api, I'd like to see some issues resolved with it before I start using it in tests. It's something I'm planning to come back to, but I wanted

[GitHub] eolivelli commented on issue #1133: Integration smoke test

eolivelli commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364432841 fine for me, it makes sense to use the new API once is will be considered stable or 'beta'

[GitHub] ivankelly commented on a change in pull request #1135: Specify repo in MavenClassLoader

ivankelly commented on a change in pull request #1135: Specify repo in MavenClassLoader URL: https://github.com/apache/bookkeeper/pull/1135#discussion_r167226700 ## File path: tests/integration-tests-utils/src/test/java/org/apache/bookkeeper/tests/MavenClassLoaderTest.java ###

[GitHub] ivankelly closed pull request #1136: Entry count parameters for BenchBookie

ivankelly closed pull request #1136: Entry count parameters for BenchBookie URL: https://github.com/apache/bookkeeper/pull/1136 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] ivankelly closed pull request #1134: Remove spammy log messages in Journal

ivankelly closed pull request #1134: Remove spammy log messages in Journal URL: https://github.com/apache/bookkeeper/pull/1134 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

Jenkins build is still unstable: bookkeeper_postcommit_master_java8 #36

See

[GitHub] ivankelly opened a new pull request #1137: Fix test regression due to change in default ledger manager

ivankelly opened a new pull request #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137 TestBenchmark#testReadThroughputLatency() regressed due to the change in 3ddc5db, where the default ledger manager was changed from f

Jenkins build is still unstable: bookkeeper_postcommit_master_java9 #37

See

Jenkins build is unstable: bookkeeper_release_nightly_snapshot #54

See

[GitHub] sijie commented on issue #1132: Fix shutdown race which left ZK session open

sijie commented on issue #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132#issuecomment-364482709 If I understand this change right, the fix can be just a simple 2-lines change, no? in ComponentShutdownHook, move `aliveLatch.count

[GitHub] sijie commented on issue #1130: handle zookeeper session expire in zk ledger manager

sijie commented on issue #1130: handle zookeeper session expire in zk ledger manager URL: https://github.com/apache/bookkeeper/pull/1130#issuecomment-364601850 @jvrao now this change is ready for review. This is an automated

[GitHub] sijie commented on issue #1130: handle zookeeper session expire in zk ledger manager

sijie commented on issue #1130: handle zookeeper session expire in zk ledger manager URL: https://github.com/apache/bookkeeper/pull/1130#issuecomment-363826829 I think this change was actually in master when we contributed back ensemble watcher. but it was commented out on waiting the retr

[GitHub] sijie commented on a change in pull request #1137: Fix test regression due to change in default ledger manager

sijie commented on a change in pull request #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167375782 ## File path: bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.ja

[GitHub] sijie commented on a change in pull request #1137: Fix test regression due to change in default ledger manager

sijie commented on a change in pull request #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167375931 ## File path: bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.ja

[GitHub] sijie commented on a change in pull request #1135: Specify repo in MavenClassLoader

sijie commented on a change in pull request #1135: Specify repo in MavenClassLoader URL: https://github.com/apache/bookkeeper/pull/1135#discussion_r167381007 ## File path: tests/integration-tests-utils/src/test/java/org/apache/bookkeeper/tests/MavenClassLoaderTest.java ##

[GitHub] sijie commented on issue #1133: Integration smoke test

sijie commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364611287 > it makes sense to use the new API once is will be considered stable or 'beta' I think it is the reverse, we should make tests to use API before conside

[GitHub] sijie commented on issue #1133: Integration smoke test

sijie commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364611365 > regarding the api, I'd like to see some issues resolved with it before I start using it in tests. what are the issues blocking using it in tests. -

[GitHub] sijie commented on a change in pull request #1133: Integration smoke test

sijie commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167385376 ## File path: tests/integration/smoke/src/test/java/org/apache/bookkeeper/tests/integration/TestSmoke.java ## @@ -0,0 +1,89 @

[GitHub] sijie commented on a change in pull request #1133: Integration smoke test

sijie commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167381304 ## File path: tests/integration/smoke/pom.xml ## @@ -0,0 +1,56 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi

[GitHub] sijie commented on a change in pull request #1133: Integration smoke test

sijie commented on a change in pull request #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#discussion_r167385340 ## File path: tests/integration/smoke/src/test/java/org/apache/bookkeeper/tests/integration/TestSmoke.java ## @@ -0,0 +1,89 @

[GitHub] sijie commented on a change in pull request #1131: Split all versions images into released and latest

sijie commented on a change in pull request #1131: Split all versions images into released and latest URL: https://github.com/apache/bookkeeper/pull/1131#discussion_r167386034 ## File path: tests/docker-all-versions-image/latest-image/pom.xml ## @@ -0,0 +1,111 @@ + + +http

[GitHub] sijie commented on a change in pull request #1131: Split all versions images into released and latest

sijie commented on a change in pull request #1131: Split all versions images into released and latest URL: https://github.com/apache/bookkeeper/pull/1131#discussion_r167385649 ## File path: tests/docker-all-versions-image/all-released-image/Dockerfile ## @@ -17,16 +17,16 @

[GitHub] sijie commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

sijie commented on a change in pull request #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#discussion_r167386140 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/exceptions/package-info.java ##

[GitHub] sijie commented on issue #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

sijie commented on issue #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#issuecomment-364619629 @eolivelli @jvrao I already addressed your comments. please review this again. ---

[GitHub] sijie closed pull request #1120: [Merge Yahoo repo]: Only reorder read sequence if any bookie is not available

sijie closed pull request #1120: [Merge Yahoo repo]: Only reorder read sequence if any bookie is not available URL: https://github.com/apache/bookkeeper/pull/1120 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[GitHub] sijie commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest

sijie commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#discussion_r167386946 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replicat

[GitHub] sijie commented on issue #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)

sijie commented on issue #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#issuecomment-364621361 @dlg99 any ideas on my comment? ---

[GitHub] sijie commented on issue #1085: [Merge Yahoo repo]: YBK-160: Doing distributed random verification of ledger fragments

sijie commented on issue #1085: [Merge Yahoo repo]: YBK-160: Doing distributed random verification of ledger fragments URL: https://github.com/apache/bookkeeper/pull/1085#issuecomment-364621459 @eolivelli since you were involved in this pr, can you review this PR again? I think @jiazhai al

[GitHub] sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping

sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping URL: https://github.com/apache/bookkeeper/pull/1012#issuecomment-364621406 @merlimat can you check if we still need this PR? --

[GitHub] sijie commented on issue #970: ISSUE #966: Expose quorum write complete latency to the client

sijie commented on issue #970: ISSUE #966: Expose quorum write complete latency to the client URL: https://github.com/apache/bookkeeper/pull/970#issuecomment-364621467 ping @eolivelli This is an automated message from the Ap

[GitHub] sijie commented on issue #1087: ISSUE #1075: Add a noop digest implentation

sijie commented on issue #1087: ISSUE #1075: Add a noop digest implentation URL: https://github.com/apache/bookkeeper/pull/1087#issuecomment-364621484 ping @eolivelli This is an automated message from the Apache Git Service.