[GitHub] eolivelli closed pull request #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli closed pull request #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177035776 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ##

[GitHub] ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177033723 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177034732 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177035373 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177033940 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] ivankelly commented on a change in pull request #1292: Avoid acquiring closeLock.readLock() on every add/read operation

ivankelly commented on a change in pull request #1292: Avoid acquiring closeLock.readLock() on every add/read operation URL: https://github.com/apache/bookkeeper/pull/1292#discussion_r177016752 ## File path:

[GitHub] ivankelly commented on a change in pull request #1292: Avoid acquiring closeLock.readLock() on every add/read operation

ivankelly commented on a change in pull request #1292: Avoid acquiring closeLock.readLock() on every add/read operation URL: https://github.com/apache/bookkeeper/pull/1292#discussion_r177016874 ## File path:

[GitHub] ivankelly commented on issue #1283: Issue #1282: call to appendLedgersMap in flushCompactionLog

ivankelly commented on issue #1283: Issue #1282: call to appendLedgersMap in flushCompactionLog URL: https://github.com/apache/bookkeeper/pull/1283#issuecomment-376112510 @reddycharan will you update the PR description with the description from the issue, so we'll be able to see the

[GitHub] eolivelli opened a new pull request #1293: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli opened a new pull request #1293: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1293 This change is mostly a clean up/refactor which drops intermediate MessageToMessageEncoder and

[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-376063582 retest this please This

[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-376063680 I am going to merge this PR and cherry pick to 4.6 today, as soon as CI ends with success

[GitHub] ivankelly commented on issue #1283: Issue #1282: call to appendLedgersMap in flushCompactionLog

ivankelly commented on issue #1283: Issue #1282: call to appendLedgersMap in flushCompactionLog URL: https://github.com/apache/bookkeeper/pull/1283#issuecomment-376113964 retest this please This is an automated message from

[GitHub] ivankelly commented on issue #567: Make bookie automatically create folders on new machine.

ivankelly commented on issue #567: Make bookie automatically create folders on new machine. URL: https://github.com/apache/bookkeeper/issues/567#issuecomment-376124249 Closing this as it's not a feature we will implement.

[GitHub] ivankelly closed issue #567: Make bookie automatically create folders on new machine.

ivankelly closed issue #567: Make bookie automatically create folders on new machine. URL: https://github.com/apache/bookkeeper/issues/567 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] eolivelli commented on issue #577: Clean up internal Bookkeeper constructors

eolivelli commented on issue #577: Clean up internal Bookkeeper constructors URL: https://github.com/apache/bookkeeper/issues/577#issuecomment-376126101 We could deprecate current constructors in 4.8. Once we are OK with new API

[GitHub] ivankelly closed issue #584: Jenkins failed while test BookieClientTest.testWriteGaps

ivankelly closed issue #584: Jenkins failed while test BookieClientTest.testWriteGaps URL: https://github.com/apache/bookkeeper/issues/584 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ivankelly commented on issue #584: Jenkins failed while test BookieClientTest.testWriteGaps

ivankelly commented on issue #584: Jenkins failed while test BookieClientTest.testWriteGaps URL: https://github.com/apache/bookkeeper/issues/584#issuecomment-376126324 Closing. This is an automated message from the Apache

[GitHub] ivankelly commented on a change in pull request #1293: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

ivankelly commented on a change in pull request #1293: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1293#discussion_r177057026 ## File path:

[GitHub] ivankelly commented on issue #587: Re-replicator: bookie checking should handle flapping bookie registration

ivankelly commented on issue #587: Re-replicator: bookie checking should handle flapping bookie registration URL: https://github.com/apache/bookkeeper/issues/587#issuecomment-376127971 Implemented in #58 This is an

[GitHub] ivankelly closed issue #587: Re-replicator: bookie checking should handle flapping bookie registration

ivankelly closed issue #587: Re-replicator: bookie checking should handle flapping bookie registration URL: https://github.com/apache/bookkeeper/issues/587 This is an automated message from the Apache Git Service. To

[GitHub] ivankelly closed issue #588: Bk vs gluster docs

ivankelly closed issue #588: Bk vs gluster docs URL: https://github.com/apache/bookkeeper/issues/588 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] ivankelly commented on issue #585: make pushing a docker image as part of the release procedure

ivankelly commented on issue #585: make pushing a docker image as part of the release procedure URL: https://github.com/apache/bookkeeper/issues/585#issuecomment-376128240 Already part of the Release guide. This is an

[GitHub] ivankelly closed issue #585: make pushing a docker image as part of the release procedure

ivankelly closed issue #585: make pushing a docker image as part of the release procedure URL: https://github.com/apache/bookkeeper/issues/585 This is an automated message from the Apache Git Service. To respond to the

[GitHub] ivankelly commented on issue #588: Bk vs gluster docs

ivankelly commented on issue #588: Bk vs gluster docs URL: https://github.com/apache/bookkeeper/issues/588#issuecomment-376128353 Won't do This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ivankelly commented on issue #577: Clean up internal Bookkeeper constructors

ivankelly commented on issue #577: Clean up internal Bookkeeper constructors URL: https://github.com/apache/bookkeeper/issues/577#issuecomment-376125719 This should be done as part of new api work. Ideally there should be no constructor for the BookKeeper object, but everything should go

[GitHub] ivankelly commented on issue #578: make MajorCompaction and MinorCompactions controlled by at least time of the day/day of the week

ivankelly commented on issue #578: make MajorCompaction and MinorCompactions controlled by at least time of the day/day of the week URL: https://github.com/apache/bookkeeper/issues/578#issuecomment-376126018 This is being implemented in #851

[GitHub] reddycharan commented on issue #1283: Issue #1282: call to appendLedgersMap in flushCompactionLog

reddycharan commented on issue #1283: Issue #1282: call to appendLedgersMap in flushCompactionLog URL: https://github.com/apache/bookkeeper/pull/1283#issuecomment-376239538 @ivankelly updated PR description. This is an

[GitHub] ivankelly commented on issue #589: command line options

ivankelly commented on issue #589: command line options URL: https://github.com/apache/bookkeeper/issues/589#issuecomment-376128524 @sijie this will be handled automatically by jcommander in the new CLI, no? This is an

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177174411 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

Jenkins build became unstable: bookkeeper_postcommit_master_java9 #82

See

Jenkins build became unstable: bookkeeper_release_branch #100

See

[GitHub] sijie opened a new pull request #1294: BK configuration file updates

sijie opened a new pull request #1294: BK configuration file updates URL: https://github.com/apache/bookkeeper/pull/1294 Descriptions of the changes in this PR: - Change two default values: `fileInfoCacheInitialCapacity` to 1/4 of openFileLimit() and `journalRemoveFromPageCache` to

[GitHub] sijie commented on issue #1294: BK configuration file updates

sijie commented on issue #1294: BK configuration file updates URL: https://github.com/apache/bookkeeper/pull/1294#issuecomment-376337056 https://sijie.github.io/bookkeeper-staging-site/docs/latest/reference/config/ => This is how the configuration settings are organized

[GitHub] sijie commented on issue #1283: Issue #1282: call to appendLedgersMap in flushCompactionLog

sijie commented on issue #1283: Issue #1282: call to appendLedgersMap in flushCompactionLog URL: https://github.com/apache/bookkeeper/pull/1283#issuecomment-376330512 @reddycharan did you look at @yzang 's comment? This is

[GitHub] sijie commented on issue #1281: Issue #570: Introducing EntryLogManager.

sijie commented on issue #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#issuecomment-376311538 @ivankelly : > Move into its own java file. EntryLogger is already huge. > Move into it's own file. I see you left a few

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177236857 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] sijie opened a new pull request #245: Update README status about distributedlog project

sijie opened a new pull request #245: Update README status about distributedlog project URL: https://github.com/apache/distributedlog/pull/245 Descriptions of the changes in this PR: As distributedlog modules are merged into Apache BookKeeper, update the `README` status to reflect