[GitHub] reddycharan commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
reddycharan commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222747824 ## File path:

[GitHub] reddycharan edited a comment on issue #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
reddycharan edited a comment on issue #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#issuecomment-427089980 i vaguely remember raising concern about this issue in this fix in @merlimat fix -

[GitHub] eolivelli commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
eolivelli commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222774605 ## File path:

[GitHub] reddycharan commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
reddycharan commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222750446 ## File path:

[GitHub] dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222747394 ## File path:

[GitHub] reddycharan commented on issue #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
reddycharan commented on issue #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#issuecomment-427089980 i vaguely remember raising concern about this issue in this fix in @merlimat fix -

[GitHub] dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222746532 ## File path:

Jenkins build is still unstable: bookkeeper_codecoverage #228

2018-10-04 Thread Apache Jenkins Server
See

[GitHub] dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222754629 ## File path:

[GitHub] sijie commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
sijie commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222768959 ## File path:

[GitHub] sijie commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
sijie commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222770031 ## File path:

[GitHub] sijie commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
sijie commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222769081 ## File path:

[GitHub] reddycharan commented on issue #1736: ReadEntryCallback in ReadLedgerEntriesCmd shouldn't release buffer.

2018-10-04 Thread GitBox
reddycharan commented on issue #1736: ReadEntryCallback in ReadLedgerEntriesCmd shouldn't release buffer. URL: https://github.com/apache/bookkeeper/pull/1736#issuecomment-427145793 @ivankelly related to your change 8d048abce486c63d428041f77ee9a506756f4d1e

[GitHub] reddycharan opened a new pull request #1736: ReadEntryCallback in ReadLedgerEntriesCmd shouldn't release buffer.

2018-10-04 Thread GitBox
reddycharan opened a new pull request #1736: ReadEntryCallback in ReadLedgerEntriesCmd shouldn't release buffer. URL: https://github.com/apache/bookkeeper/pull/1736 Descriptions of the changes in this PR: - ReadEntryCallback in ReadLedgerEntriesCmd shouldn't release buffer,

[GitHub] dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

2018-10-04 Thread GitBox
dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222780654 ## File path:

[GitHub] athanatos opened a new issue #1737: EntryMemTable.newEntry retains reference to passed ByteBuffer array, can cause corruption on journal replay

2018-10-04 Thread GitBox
athanatos opened a new issue #1737: EntryMemTable.newEntry retains reference to passed ByteBuffer array, can cause corruption on journal replay URL: https://github.com/apache/bookkeeper/issues/1737 Journal.scanJournal reuses the same ByteBuffers for each entry, but (if the entry is large

[GitHub] dlg99 opened a new issue #1740: IOUtils.close() only accepts Closeable as a vararg which results in unnecessary Object[] created if only one Closeable passed there

2018-10-04 Thread GitBox
dlg99 opened a new issue #1740: IOUtils.close() only accepts Closeable as a vararg which results in unnecessary Object[] created if only one Closeable passed there URL: https://github.com/apache/bookkeeper/issues/1740 **BUG REPORT** 1. Please describe the issue you observed:

[GitHub] dlg99 opened a new pull request #1741: Issue #1740: IOUtils.close() only accepts Closeable as a vararg which results in unnecessary Object[] created if only one Closeable passed there

2018-10-04 Thread GitBox
dlg99 opened a new pull request #1741: Issue #1740: IOUtils.close() only accepts Closeable as a vararg which results in unnecessary Object[] created if only one Closeable passed there URL: https://github.com/apache/bookkeeper/pull/1741 Descriptions of the changes in this PR: added

[GitHub] sijie closed pull request #1726: Introduce lifecycle components for managing components in AutoRecovery

2018-10-04 Thread GitBox
sijie closed pull request #1726: Introduce lifecycle components for managing components in AutoRecovery URL: https://github.com/apache/bookkeeper/pull/1726 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

Jenkins build is back to normal : bookkeeper-seed #334

2018-10-04 Thread Apache Jenkins Server
See

[GitHub] sijie closed pull request #1734: [table service][client] provide scripts for uploading python clients to pypi

2018-10-04 Thread GitBox
sijie closed pull request #1734: [table service][client] provide scripts for uploading python clients to pypi URL: https://github.com/apache/bookkeeper/pull/1734 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] sijie commented on issue #1734: [table service][client] provide scripts for uploading python clients to pypi

2018-10-04 Thread GitBox
sijie commented on issue #1734: [table service][client] provide scripts for uploading python clients to pypi URL: https://github.com/apache/bookkeeper/pull/1734#issuecomment-426907859 > I wonder if it better to send an explicit email to dev list. we can have a CI job to upload to

Build failed in Jenkins: bookkeeper-seed #332

2018-10-04 Thread Apache Jenkins Server
See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on H28 (ubuntu xenial) in workspace > git

Build failed in Jenkins: bookkeeper_release_branch_47_java8 #177

2018-10-04 Thread Apache Jenkins Server
See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on H29 (ubuntu xenial) in workspace

Build failed in Jenkins: bookkeeper_release_branch_48_java9 #50

2018-10-04 Thread Apache Jenkins Server
See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on H32 (ubuntu xenial) in workspace

Build failed in Jenkins: bookkeeper_release_branch_47_java9 #177

2018-10-04 Thread Apache Jenkins Server
See -- [...truncated 504.08 KB...] 2018-10-04T12:38:55.128 [INFO] Downloaded:

Build failed in Jenkins: bookkeeper_release_branch_47_integrationtests #165

2018-10-04 Thread Apache Jenkins Server
See -- [...truncated 516.45 KB...] 2018-10-04\T\12:41:26.496 [INFO] Downloading:

Build failed in Jenkins: bookkeeper_release_branch_48_integrationtests #50

2018-10-04 Thread Apache Jenkins Server
See -- [...truncated 1.35 MB...] --- T E S T S ---

Jenkins build is unstable: bookkeeper_postcommit_master_java8 #277

2018-10-04 Thread Apache Jenkins Server
See

Jenkins build is still unstable: bookkeeper_postcommit_master_java9 #278

2018-10-04 Thread Apache Jenkins Server
See