merlimat commented on pull request #3036:
URL: https://github.com/apache/bookkeeper/pull/3036#issuecomment-1043091358
@StevenLuMT can you add in the motivation section the reasons for this
change and what are the trade offs here?
--
This is an automated message from the Apache Git
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042894104
> What about making this new behaviour configurable?
Like adding a new boolean parameter 'autoShrink'?
The default is false, to keep previous behaviour.
eolivelli commented on pull request #2995:
URL: https://github.com/apache/bookkeeper/pull/2995#issuecomment-1042941763
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042920147
> I agree that the condition foe the expansion is not good and probably we
should fix it, but maybe not in this PR
OK, I will create another PR to fix the
lordcheng10 commented on pull request #2970:
URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1042930683
@eolivelli PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Shoothzj commented on pull request #2995:
URL: https://github.com/apache/bookkeeper/pull/2995#issuecomment-1042974075
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
eolivelli commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809008320
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
StevenLuMT commented on pull request #3036:
URL: https://github.com/apache/bookkeeper/pull/3036#issuecomment-1042917544
@eolivelli @pkumar-singh @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the
StevenLuMT removed a comment on pull request #3036:
URL: https://github.com/apache/bookkeeper/pull/3036#issuecomment-1039760286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042918594
@eolivelli @pkumar-singh @zymap @mauricebarnum
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042894104
> What about making this new behaviour configurable?
Like adding a new boolean parameter 'autoShrink'?
The default is false, to keep previous behaviour.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042917916
@eolivelli @pkumar-singh @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042894104
> What about making this new behaviour configurable?
Like adding a new boolean parameter 'autoShrink'?
The default is false, to keep previous behaviour.
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042894104
> What about making this new behaviour configurable?
Like adding a new boolean parameter 'autoShrink'?
The default is false, to keep previous behaviour.
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042920147
> I agree that the condition foe the expansion is not good and probably we
should fix it, but maybe not in this PR
OK, I will reopen a PR to fix this expansion
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042923877
> What about making this new behaviour configurable?
Like adding a new boolean parameter 'autoShrink'?
In the constructor method of this class of
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042923877
> What about making this new behaviour configurable?
Like adding a new boolean parameter 'autoShrink'?
In the constructor of this class, pass in the
lordcheng10 removed a comment on pull request #2970:
URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1013806991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
nicoloboschi closed pull request #3054:
URL: https://github.com/apache/bookkeeper/pull/3054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nicoloboschi commented on pull request #3054:
URL: https://github.com/apache/bookkeeper/pull/3054#issuecomment-1042941809
I close this since I intended to create it to my own repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lordcheng10 commented on pull request #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1044018150
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
merlimat commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809689655
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +440,16 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809689076
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +440,16 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809733512
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -75,26 +133,21 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809741234
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -75,26 +133,21 @@
Shoothzj commented on pull request #2995:
URL: https://github.com/apache/bookkeeper/pull/2995#issuecomment-1044069026
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Shoothzj removed a comment on pull request #2995:
URL: https://github.com/apache/bookkeeper/pull/2995#issuecomment-1042974075
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Shoothzj commented on pull request #2995:
URL: https://github.com/apache/bookkeeper/pull/2995#issuecomment-1044071093
push code to retrigger ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
eolivelli commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1044071079
@dlg99 @pkumar-singh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809694862
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +440,16 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809694762
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -336,9 +399,10 @@
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1044077101
In the following structures, this change is also introduced? @eolivelli
@merlimat
ConcurrentLongHashMap: Map
ConcurrentLongHashSet: Set
merlimat commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809685911
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +440,16 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809741234
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -75,26 +133,21 @@
eolivelli commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809730137
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -75,26 +133,21 @@
Shoothzj removed a comment on pull request #2995:
URL: https://github.com/apache/bookkeeper/pull/2995#issuecomment-1044069026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dlg99 commented on pull request #3064:
URL: https://github.com/apache/bookkeeper/pull/3064#issuecomment-1043738311
@sijie @merlimat You are more familiar with the dlog, can you please review
this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message,
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809629204
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -336,9 +339,10 @@
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1043865594
@eolivelli @merlimat PTAL,thanks!
Based on your suggestions, I have made the following adjustments:
1.add builder;
2.add config:
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809629204
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -336,9 +339,10 @@
dlg99 opened a new issue #3066:
URL: https://github.com/apache/bookkeeper/issues/3066
from CI log of the "Remaining Tests" job:
```
org.apache.bookkeeper.bookie.FileInfoBackingCacheTest
Test testRaceGuavaEvictAndReleaseBeforeRetain PASSED (47m 41s)
Test testRefCountRace
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809607002
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -48,6 +48,7 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809622344
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -388,6 +401,18 @@
dlg99 opened a new pull request #3065:
URL: https://github.com/apache/bookkeeper/pull/3065
Descriptions of the changes in this PR:
### Motivation
MockExecutorControllerWithSchedulerTest is flaky
### Changes
testExecute flakes because runnable runs actually
dlg99 commented on issue #3057:
URL: https://github.com/apache/bookkeeper/issues/3057#issuecomment-1043696249
DigestManager isn't used for the security but for the checksum/checksum
validation.
CRC32 should be the default:
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809629498
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -336,9 +339,10 @@
315157973 commented on pull request #3062:
URL: https://github.com/apache/bookkeeper/pull/3062#issuecomment-1043775208
> 1. read request doesn't wait for the completion on that threadpool.
>
> > When cold data is read, it will take a long time. At this time, the read
request will be
dlg99 commented on issue #3058:
URL: https://github.com/apache/bookkeeper/issues/3058#issuecomment-1043696864
Correct, this is just for the benchmarks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dlg99 closed issue #3058:
URL: https://github.com/apache/bookkeeper/issues/3058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809629498
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -336,9 +339,10 @@
315157973 commented on pull request #3062:
URL: https://github.com/apache/bookkeeper/pull/3062#issuecomment-1042717597
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808782656
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808782656
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042692672
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042641702
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
eolivelli commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808794125
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808805872
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808805872
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
lordcheng10 removed a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042720701
> What about making this new behaviour configurable?
Or when constructing the class, pass in the MapIdleFactor parameter to
control whether to support
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042735210
> What about making this new behaviour configurable?
I think this is a memory leak bug, so I think that configuration should not
be added, and the unused
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042720701
> What about making this new behaviour configurable?
Or when constructing the class, pass in the MapIdleFactor parameter to
control whether to support shrinking.
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042735210
> What about making this new behaviour configurable?
I think this is a memory leak bug, so I think that configuration should not
be added, and the unused
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042735210
> What about making this new behaviour configurable?
I think this is a memory leak bug, so I think that configuration should not
be added, and the unused memory
merlimat commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809394336
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
dlg99 commented on pull request #3055:
URL: https://github.com/apache/bookkeeper/pull/3055#issuecomment-1043560077
@wuYin can you please take care of checkstyle errors and add/extend the
tests?
Take a look at SlowBookieTest and BookieBackpressureTest as starting points.
I hope we
mauricebarnum commented on issue #3057:
URL: https://github.com/apache/bookkeeper/issues/3057#issuecomment-1043322589
This is required by the V2 wire protocol. I don't know what's required to
remove that, but at the least I see that Pulsar is still defaulting to v2.
Maybe there's
dlg99 opened a new issue #3063:
URL: https://github.com/apache/bookkeeper/issues/3063
happens on attempt to create second writer immediately after the first one.
i only was able to repro this by running the whole suite, rtest passses if I
run just this test alone.
Sleep between
dlg99 opened a new pull request #3064:
URL: https://github.com/apache/bookkeeper/pull/3064
Descriptions of the changes in this PR:
### Motivation
DLM test suite was flaky.
Repro/troubleshooting shows that DLM can skip over a data segment on read.
### Changes
Test
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808877551
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
lordcheng10 removed a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042735210
> What about making this new behaviour configurable?
I think this is a memory leak bug, so I think that configuration should not
be added, and the unused
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808960746
##
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMapTest.java
##
@@ -113,6 +113,22
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808960395
##
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMapTest.java
##
@@ -113,6 +113,22
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042894104
> What about making this new behaviour configurable?
Like adding a new boolean parameter 'autoShrink'?
The default is false, to keep previous behaviour.
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808866151
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808866151
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
lordcheng10 removed a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042747023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808882801
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042751827
usedBuckets does not represent the actual usage size. Considering such a
scenario, expansion will be triggered even if there is excess space. Assuming
that there are 4
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042751827
usedBuckets does not represent the actual usage size.
Considering such a scenario, expansion will be triggered even if there is
excess space. Assuming that
eolivelli commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808854261
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808866151
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -376,7 +380,16 @@
hangc0276 commented on pull request #3060:
URL: https://github.com/apache/bookkeeper/pull/3060#issuecomment-1042782053
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042747023
> What about making this new behaviour configurable?
Regardless of the scenario, unused memory should be reclaimed, and it should
be noted that the expansion
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042747023
> What about making this new behaviour configurable?
Regardless of the scenario, unused memory should be reclaimed, and it should
be noted that the
eolivelli commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808897847
##
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMapTest.java
##
@@ -113,6 +113,22 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808949324
##
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMapTest.java
##
@@ -113,6 +113,22
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042894104
> What about making this new behaviour configurable?
Like adding a new boolean parameter 'autoShrink'?
The default is false, to keep previous behaviour.
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042894104
> What about making this new behaviour configurable?
Like adding a new boolean parameter 'autoShrink'?
The default is false, to keep previous behaviour.
My
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1042894104
> What about making this new behaviour configurable?
Like adding a new boolean parameter 'autoShrink'?
The default is false, to keep previous behaviour.
89 matches
Mail list logo
