[GitHub] ivankelly closed pull request #645: Fix concurrent v2 reads on the same ledger/entry

2017-10-18 Thread GitBox
ivankelly closed pull request #645: Fix concurrent v2 reads on the same ledger/entry URL: https://github.com/apache/bookkeeper/pull/645 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145631534 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java ## @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145633790 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145633637 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ##

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145640557 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -73,6 +74,14 @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145634439 ## File path: bookkeeper-server/src/main/proto/DataFormats.proto ## @@ -58,6 +58,15 @@ message

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145634367 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -136,6 +147,11 @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145632181 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -73,6 +74,14 @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145632683 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -136,6 +147,11 @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145632702 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -193,3 +212,9 @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145631841 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java ##

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145633907 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] eolivelli commented on issue #591: Clean up Public Client Bootstrap API

2017-10-18 Thread GitBox
eolivelli commented on issue #591: Clean up Public Client Bootstrap API URL: https://github.com/apache/bookkeeper/issues/591#issuecomment-337569978 Resolved with bp15 This is an automated message from the Apache Git Service.

[GitHub] eolivelli closed issue #591: Clean up Public Client Bootstrap API

2017-10-18 Thread GitBox
eolivelli closed issue #591: Clean up Public Client Bootstrap API URL: https://github.com/apache/bookkeeper/issues/591 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145684461 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperClientStats.java ## @@

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145684063 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java ## @@ -160,6

[GitHub] eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145684060 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java ## @@ -160,6

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145631534 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java ## @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145680332 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -193,3 +212,9 @@

[GitHub] asfgit commented on issue #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
asfgit commented on issue #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-337656565 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
asfgit commented on issue #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#issuecomment-337638751 Refer to this link for build results (access rights to CI server needed):

[GitHub] eolivelli closed issue #530: BP-14 Relax Durability - protocol changes preview

2017-10-18 Thread GitBox
eolivelli closed issue #530: BP-14 Relax Durability - protocol changes preview URL: https://github.com/apache/bookkeeper/issues/530 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit commented on issue #644: Fixed ref counting release on read errors

2017-10-18 Thread GitBox
asfgit commented on issue #644: Fixed ref counting release on read errors URL: https://github.com/apache/bookkeeper/pull/644#issuecomment-337698613 Refer to this link for build results (access rights to CI server needed):

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338789477 retest this please This is an automated

[GitHub] sijie opened a new issue #656: Enable tests running with advertised address "127.0.0.1"

2017-10-23 Thread GitBox
sijie opened a new issue #656: Enable tests running with advertised address "127.0.0.1" URL: https://github.com/apache/bookkeeper/issues/656 **Why** tests can be slow when DNS resolution is slow. running bookies with advertised address "127.0.0.1" will make tests running faster and

[GitHub] asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338802231 Refer to this link for build results (access rights to CI server needed):

[GitHub] ivankelly commented on issue #644: Fixed ref counting release on read errors

2017-10-18 Thread GitBox
ivankelly commented on issue #644: Fixed ref counting release on read errors URL: https://github.com/apache/bookkeeper/pull/644#issuecomment-337717529 Test failures are flakes. This is an automated message from the Apache Git

[GitHub] ivankelly closed pull request #644: Fixed ref counting release on read errors

2017-10-18 Thread GitBox
ivankelly closed pull request #644: Fixed ref counting release on read errors URL: https://github.com/apache/bookkeeper/pull/644 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145535636 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperClientStats.java ## @@ -32,6

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145544977 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ## @@

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145534484 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java ## @@ -293,7 +294,9 @@

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145538292 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingSyncOp.java ## @@ -0,0 +1,110

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145537764 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java ## @@ -198,21

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r14559 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/SyncSupported.java ## @@ -0,0

[GitHub] ivankelly commented on issue #645: Fix concurrent v2 reads on the same ledger/entry

2017-10-18 Thread GitBox
ivankelly commented on issue #645: Fix concurrent v2 reads on the same ledger/entry URL: https://github.com/apache/bookkeeper/pull/645#issuecomment-337733438 There is a later change with tests, but it depends on a bunch of other things in between. @eolivelli

[GitHub] ivankelly commented on issue #645: Fix concurrent v2 reads on the same ledger/entry

2017-10-18 Thread GitBox
ivankelly commented on issue #645: Fix concurrent v2 reads on the same ledger/entry URL: https://github.com/apache/bookkeeper/pull/645#issuecomment-337733438 There is a later change with tests, but it depends on a bunch of other things in between.

[GitHub] asfgit commented on issue #645: Fix concurrent v2 reads on the same ledger/entry

2017-10-18 Thread GitBox
asfgit commented on issue #645: Fix concurrent v2 reads on the same ledger/entry URL: https://github.com/apache/bookkeeper/pull/645#issuecomment-337739488 Refer to this link for build results (access rights to CI server needed):

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r14556 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java ## @@

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145531204 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -73,6 +74,14 @@ message

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145536889 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -84,15 +85,32

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145537353 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -1343,17

[GitHub] eolivelli commented on issue #531: Issue-530 BP-14 BP-14 Relax Durability - protocol changes preview

2017-10-18 Thread GitBox
eolivelli commented on issue #531: Issue-530 BP-14 BP-14 Relax Durability - protocol changes preview URL: https://github.com/apache/bookkeeper/pull/531#issuecomment-337721735 Closing. Superseded by new set of patches This is

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145538441 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingSyncOp.java ## @@ -0,0 +1,110

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145543045 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingSyncOp.java ## @@ -0,0 +1,110

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145545156 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ## @@

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145535784 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperClientStats.java ## @@

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145537325 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -1343,17

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145538317 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingSyncOp.java ## @@ -0,0 +1,110

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145538138 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingSyncOp.java ## @@ -0,0 +1,110

[GitHub] sijie commented on a change in pull request #643: BP-14 part 2 - client side changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #643: BP-14 part 2 - client side changes URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145544706 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java ## @@ -224,15 +225,47

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145556774 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145557421 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -193,3 +212,9 @@

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145556916 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145557168 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -136,6 +147,11 @@

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r14855 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java ##

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145557540 ## File path: bookkeeper-server/src/main/proto/DataFormats.proto ## @@ -58,6 +58,15 @@ message

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145499216 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145499417 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145501811 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145501999 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145540992 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145500487 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145551983 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145548754 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145502271 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145542490 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145502370 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145493594 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145493659 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145543784 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145551162 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145549021 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145495100 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145494666 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145492698 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-18 Thread GitBox
ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145542430 ## File path:

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145789040 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ## @@

[GitHub] ivankelly commented on a change in pull request #649: Pool AddCompletions

2017-10-24 Thread GitBox
ivankelly commented on a change in pull request #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#discussion_r146470461 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ## @@ -832,28 +836,7 @@

[GitHub] eolivelli commented on a change in pull request #649: Pool AddCompletions

2017-10-24 Thread GitBox
eolivelli commented on a change in pull request #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#discussion_r146470714 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ## @@ -832,28 +836,7 @@

[GitHub] ivankelly commented on issue #649: Pool AddCompletions

2017-10-24 Thread GitBox
ivankelly commented on issue #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#issuecomment-338899120 Latest push is a straight rebase onto master to get rid of conflicts. In fact their was no conflicts, it rebased without issue.

[GitHub] ivankelly commented on issue #649: Pool AddCompletions

2017-10-24 Thread GitBox
ivankelly commented on issue #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#issuecomment-338899120 Latest push is a straight rebase onto master to get rid of conflicts. This is an automated

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146355670 ## File path:

[GitHub] sijie commented on issue #655: Use Lambda expression when possible

2017-10-23 Thread GitBox
sijie commented on issue #655: Use Lambda expression when possible URL: https://github.com/apache/bookkeeper/issues/655#issuecomment-338758593 @merlimat +1 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie closed pull request #647: Fix a typo in PCBC logging

2017-10-23 Thread GitBox
sijie closed pull request #647: Fix a typo in PCBC logging URL: https://github.com/apache/bookkeeper/pull/647 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146349344 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146355111 ## File path:

[GitHub] jvrao commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
jvrao commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338758125 @sijie will review it today. This is an

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146359096 ## File path:

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338747907 @ivankelly I used merge than rebase, because I had the impression that github will lose commit related

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146350639 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146350662 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146352189 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146360130 ## File path:

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338760553 @jvrao thank you This is an automated

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146351206 ## File path:

[GitHub] merlimat commented on issue #655: Use Lambda expression when possible

2017-10-23 Thread GitBox
merlimat commented on issue #655: Use Lambda expression when possible URL: https://github.com/apache/bookkeeper/issues/655#issuecomment-338751727 > bookkeeper uses a lot of callbacks. those callbacks can be written in lambda expressions. It would be good to clean them up. In

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146354598 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146357086 ## File path:

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338761747 @ivankelly - I addressed your comments. please review it when you have time.

[GitHub] asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

2017-10-23 Thread GitBox
asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338770970 Refer to this link for build results (access rights to CI server needed):

  1   2   3   4   5   6   7   8   9   10   >