[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

2018-11-16 Thread GitBox
ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r234236380 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java ##

[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

2018-11-16 Thread GitBox
ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r234229005 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java

[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

2018-11-16 Thread GitBox
ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r234228770 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java ##

[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

2018-11-16 Thread GitBox
ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r234228416 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java ##

[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

2018-11-16 Thread GitBox
ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r234209071 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java

[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

2018-11-13 Thread GitBox
ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233205362 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java

[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

2018-11-13 Thread GitBox
ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233204066 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java

[GitHub] ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

2018-11-13 Thread GitBox
ivankelly commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233203737 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java