[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233207589 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java ##

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233207255 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java ##

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233128066 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233121099 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java ##

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233123746 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233128211 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233123083 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233124668 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java ##

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233120404 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java ## @@

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233118965 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java ## @@

[GitHub] sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture

sijie commented on a change in pull request #1809: Change LedgerManager to use CompletableFuture URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233127634 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java ##