[jira] [Comment Edited] (CALCITE-2947) Type mismatch assertion error when converting NOT IN subquery

[ https://issues.apache.org/jira/browse/CALCITE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801427#comment-16801427 ] Xiening Dai edited comment on CALCITE-2947 at 3/26/19 6:38 AM: --- This is

[jira] [Comment Edited] (CALCITE-2947) Type mismatch assertion error when converting NOT IN subquery

[ https://issues.apache.org/jira/browse/CALCITE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801427#comment-16801427 ] Xiening Dai edited comment on CALCITE-2947 at 3/26/19 6:41 AM: --- This is

[jira] [Commented] (CALCITE-2947) Type mismatch assertion error when converting NOT IN subquery

[ https://issues.apache.org/jira/browse/CALCITE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801427#comment-16801427 ] Xiening Dai commented on CALCITE-2947: -- This is different than CALCITE-2901. In Haisheng's test,

[jira] [Commented] (CALCITE-2893) Type mismatch assertion error when creating join condition

[ https://issues.apache.org/jira/browse/CALCITE-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801889#comment-16801889 ] Xiening Dai commented on CALCITE-2893: -- I think this is a duplication of CALCITE-2947. > Type

[jira] [Updated] (CALCITE-3257) Need to clear RelMetaDataQuery cache after dumping RelNodes and Graphviz

[ https://issues.apache.org/jira/browse/CALCITE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai updated CALCITE-3257: - Description: To repro - 1. Set Log4J log level to TRACE. So planner will dump rel node info

[jira] [Comment Edited] (CALCITE-3257) Need to clear RelMetaDataQuery cache after dumping RelNodes and Graphviz

[ https://issues.apache.org/jira/browse/CALCITE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909156#comment-16909156 ] Xiening Dai edited comment on CALCITE-3257 at 8/16/19 4:05 PM: --- Based on

[jira] [Updated] (CALCITE-3257) Need to clear RelMetaDataQuery cache after dumping RelNodes and Graphviz

[ https://issues.apache.org/jira/browse/CALCITE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai updated CALCITE-3257: - Description: To repro - 1. Set Log4J log level to TRACE. So planner will dump rel node info

[jira] [Commented] (CALCITE-3257) Need to clear RelMetaDataQuery cache after dumping RelNodes and Graphviz

[ https://issues.apache.org/jira/browse/CALCITE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909156#comment-16909156 ] Xiening Dai commented on CALCITE-3257: -- Based on current design, RelMetadataQuery.map needs to be

[jira] [Created] (CALCITE-3257) Need to clear RelMetaDataQuery cache after dumping RelNodes and Graphviz

Xiening Dai created CALCITE-3257: Summary: Need to clear RelMetaDataQuery cache after dumping RelNodes and Graphviz Key: CALCITE-3257 URL: https://issues.apache.org/jira/browse/CALCITE-3257 Project:

[jira] [Updated] (CALCITE-3257) Need to clear RelMetaDataQuery cache after dumping RelNodes and Graphviz

[ https://issues.apache.org/jira/browse/CALCITE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai updated CALCITE-3257: - Description: To repro - 1. Set Log4J log level to TRACE. So planner will dump rel node info

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909415#comment-16909415 ] Xiening Dai commented on CALCITE-2018: -- Hi [~julianhyde], [~vvysotskyi] also has some questions.

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908717#comment-16908717 ] Xiening Dai commented on CALCITE-2018: -- I also run into this issue recently. I haven't looked into

[jira] [Updated] (CALCITE-3257) RelMetadataQuery cache is not invalidated when log trace is enabled

[ https://issues.apache.org/jira/browse/CALCITE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai updated CALCITE-3257: - Summary: RelMetadataQuery cache is not invalidated when log trace is enabled (was: Need to

[jira] [Commented] (CALCITE-3257) Need to clear RelMetaDataQuery cache after dumping RelNodes and Graphviz

[ https://issues.apache.org/jira/browse/CALCITE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909402#comment-16909402 ] Xiening Dai commented on CALCITE-3257: -- I believe CALCITE-2018 is a separate issue while this one

[jira] [Commented] (CALCITE-3257) Need to clear RelMetaDataQuery cache after dumping RelNodes and Graphviz

[ https://issues.apache.org/jira/browse/CALCITE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909486#comment-16909486 ] Xiening Dai commented on CALCITE-3257: -- I agree with your assumption. Current cost propagation

[jira] [Commented] (CALCITE-2166) Cumulative cost of RelSubset.best RelNode is increased after calling RelSubset.propagateCostImprovements() for input RelNodes

[ https://issues.apache.org/jira/browse/CALCITE-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911714#comment-16911714 ] Xiening Dai commented on CALCITE-2166: -- hi [~danny0405][~vvysotskyi], not sure what is the

[jira] [Commented] (CALCITE-3283) RelSubSet's best is not existed in the set

[ https://issues.apache.org/jira/browse/CALCITE-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913728#comment-16913728 ] Xiening Dai commented on CALCITE-3283: -- [~julianhyde] Sure. Will update it. Will appreciate if you

[jira] [Created] (CALCITE-3283) RelSubSet's best is not existed in the set

Xiening Dai created CALCITE-3283: Summary: RelSubSet's best is not existed in the set Key: CALCITE-3283 URL: https://issues.apache.org/jira/browse/CALCITE-3283 Project: Calcite Issue Type:

[jira] [Comment Edited] (CALCITE-3283) RelSubSet's best is not existed in the set

[ https://issues.apache.org/jira/browse/CALCITE-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913713#comment-16913713 ] Xiening Dai edited comment on CALCITE-3283 at 8/22/19 9:46 PM: --- In

[jira] [Commented] (CALCITE-3283) RelSubSet's best is not existed in the set

[ https://issues.apache.org/jira/browse/CALCITE-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913713#comment-16913713 ] Xiening Dai commented on CALCITE-3283: -- In VolcanoPlanner.rename(), the given relnode will be

[jira] [Commented] (CALCITE-2166) Cumulative cost of RelSubset.best RelNode is increased after calling RelSubset.propagateCostImprovements() for input RelNodes

[ https://issues.apache.org/jira/browse/CALCITE-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922727#comment-16922727 ] Xiening Dai commented on CALCITE-2166: -- hi [~vvysotskyi] I send out a PR using #1 proposal. Please

[jira] [Created] (CALCITE-3330) propagateCostImprovements() could result in stack overflow

Xiening Dai created CALCITE-3330: Summary: propagateCostImprovements() could result in stack overflow Key: CALCITE-3330 URL: https://issues.apache.org/jira/browse/CALCITE-3330 Project: Calcite

[jira] [Commented] (CALCITE-2166) Cumulative cost of RelSubset.best RelNode is increased after calling RelSubset.propagateCostImprovements() for input RelNodes

[ https://issues.apache.org/jira/browse/CALCITE-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930395#comment-16930395 ] Xiening Dai commented on CALCITE-2166: -- hi [~danny0405], sorry I just saw your comments here in

[jira] [Commented] (CALCITE-3376) VolcanoPlanner CannotPlanException: best rel is null even though there is an option with non-infinite cost

[ https://issues.apache.org/jira/browse/CALCITE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940621#comment-16940621 ] Xiening Dai commented on CALCITE-3376: -- Thanks [~rubenql] for root causing this issue. This is

[jira] [Assigned] (CALCITE-3487) Should not hard code RelMetadataQuery class in VolcanoPlanner.isValid()

[ https://issues.apache.org/jira/browse/CALCITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai reassigned CALCITE-3487: Assignee: Xiening Dai > Should not hard code RelMetadataQuery class in

[jira] [Updated] (CALCITE-3487) Should not hard code RelMetadataQuery class in VolcanoPlanner.isValid()

[ https://issues.apache.org/jira/browse/CALCITE-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai updated CALCITE-3487: - Description: With CALCITE-3446, a calcite user can choose to provide a sub-class of 

[jira] [Created] (CALCITE-3487) Should not hard code RelMetadataQuery class in VolcanoPlanner.isValid()

Xiening Dai created CALCITE-3487: Summary: Should not hard code RelMetadataQuery class in VolcanoPlanner.isValid() Key: CALCITE-3487 URL: https://issues.apache.org/jira/browse/CALCITE-3487 Project:

[jira] [Created] (CALCITE-3491) VolcanoPlanner.completeConversion() is bypassed by "if (true)"

Xiening Dai created CALCITE-3491: Summary: VolcanoPlanner.completeConversion() is bypassed by "if (true)" Key: CALCITE-3491 URL: https://issues.apache.org/jira/browse/CALCITE-3491 Project: Calcite

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968111#comment-16968111 ] Xiening Dai commented on CALCITE-2970: -- Thanks [~zabetak] I am not sure I understand the concern

[jira] [Updated] (CALCITE-3479) Stack overflow error thrown when running join query

[ https://issues.apache.org/jira/browse/CALCITE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai updated CALCITE-3479: - Attachment: IMG_5089.jpg > Stack overflow error thrown when running join query >

[jira] [Commented] (CALCITE-3479) Stack overflow error thrown when running join query

[ https://issues.apache.org/jira/browse/CALCITE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968634#comment-16968634 ] Xiening Dai commented on CALCITE-3479: -- !IMG_5089.jpg! > Stack overflow error thrown when running

[jira] [Issue Comment Deleted] (CALCITE-3479) Stack overflow error thrown when running join query

[ https://issues.apache.org/jira/browse/CALCITE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai updated CALCITE-3479: - Comment: was deleted (was: !IMG_5089.jpg!) > Stack overflow error thrown when running join

[jira] [Commented] (CALCITE-3479) Stack overflow error thrown when running join query

[ https://issues.apache.org/jira/browse/CALCITE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968640#comment-16968640 ] Xiening Dai commented on CALCITE-3479: -- If you remove RelSubset.java line 359[1] to line 369, the

[jira] [Commented] (CALCITE-3479) Stack overflow error thrown when running join query

[ https://issues.apache.org/jira/browse/CALCITE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968631#comment-16968631 ] Xiening Dai commented on CALCITE-3479: -- I took a brief look at this, and I believe unfortunately

[jira] [Comment Edited] (CALCITE-3479) Stack overflow error thrown when running join query

[ https://issues.apache.org/jira/browse/CALCITE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968631#comment-16968631 ] Xiening Dai edited comment on CALCITE-3479 at 11/6/19 7:27 PM: --- I took a

[jira] [Commented] (CALCITE-3479) Stack overflow error thrown when running join query

[ https://issues.apache.org/jira/browse/CALCITE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969609#comment-16969609 ] Xiening Dai commented on CALCITE-3479: -- [~achav...@gmail.com] I open a PR, please take a look

[jira] [Commented] (CALCITE-3479) Stack overflow error thrown when running join query

[ https://issues.apache.org/jira/browse/CALCITE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969774#comment-16969774 ] Xiening Dai commented on CALCITE-3479: -- [~achav...@gmail.com] I think a good starting point would

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973551#comment-16973551 ] Xiening Dai commented on CALCITE-2970: -- "Currently if we have 3 conventions we already have

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974447#comment-16974447 ] Xiening Dai commented on CALCITE-3503: -- I have a PR out -

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973992#comment-16973992 ] Xiening Dai commented on CALCITE-3503: -- Adding a quick check would just fix it - if (root ==

[jira] [Commented] (CALCITE-3491) VolcanoPlanner.completeConversion() is bypassed by "if (true)"

[ https://issues.apache.org/jira/browse/CALCITE-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974834#comment-16974834 ] Xiening Dai commented on CALCITE-3491: -- Yes, you can open a JIRA. From what I can tell, the other

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976087#comment-16976087 ] Xiening Dai commented on CALCITE-3503: -- As I've mentioned multiple times, it's meaningless to do

[jira] [Commented] (CALCITE-3491) VolcanoPlanner.completeConversion() is bypassed by "if (true)"

[ https://issues.apache.org/jira/browse/CALCITE-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972623#comment-16972623 ] Xiening Dai commented on CALCITE-3491: -- I feel the same. [~julianhyde] do you know the history

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971834#comment-16971834 ] Xiening Dai commented on CALCITE-2970: -- Currently ExpandConversionRule uses

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968747#comment-16968747 ] Xiening Dai commented on CALCITE-2970: -- Yes, I agree withConvention or push/popConvention is

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968756#comment-16968756 ] Xiening Dai commented on CALCITE-2970: -- Yes, that's fair. And I didn't propose to change copy() in

[jira] [Commented] (CALCITE-2223) ProjectMergeRule is infinitely matched when is applied after ProjectReduceExpressionsRule

[ https://issues.apache.org/jira/browse/CALCITE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988262#comment-16988262 ] Xiening Dai commented on CALCITE-2223: -- I am not able to reproduce this on the latest master. >

[jira] [Commented] (CALCITE-2223) ProjectMergeRule is infinitely matched when is applied after ProjectReduceExpressionsRule

[ https://issues.apache.org/jira/browse/CALCITE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989097#comment-16989097 ] Xiening Dai commented on CALCITE-2223: -- [~volodymyr] [~vladimirsitnikov] Thanks for your

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961227#comment-16961227 ] Xiening Dai commented on CALCITE-2018: -- [~volodymyr] Any updates on this? The issue is affecting

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952268#comment-16952268 ] Xiening Dai commented on CALCITE-2018: -- I can disable the validation in test. But I would also

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952297#comment-16952297 ] Xiening Dai commented on CALCITE-2018: -- I pushed an update to

[jira] [Assigned] (CALCITE-3455) Redundant rule firing for both logical and physical nodes

[ https://issues.apache.org/jira/browse/CALCITE-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai reassigned CALCITE-3455: Assignee: Xiening Dai > Redundant rule firing for both logical and physical nodes >

[jira] [Created] (CALCITE-3455) Redundant rule firing for both logical and physical nodes

Xiening Dai created CALCITE-3455: Summary: Redundant rule firing for both logical and physical nodes Key: CALCITE-3455 URL: https://issues.apache.org/jira/browse/CALCITE-3455 Project: Calcite

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961619#comment-16961619 ] Xiening Dai commented on CALCITE-2970: -- I spent some time debugging this issue. I think I know

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962139#comment-16962139 ] Xiening Dai commented on CALCITE-2018: -- Hi [~volodymyr] I don't know about the background of 3403.

[jira] [Commented] (CALCITE-3376) VolcanoPlanner CannotPlanException: best rel is null even though there is an option with non-infinite cost

[ https://issues.apache.org/jira/browse/CALCITE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954710#comment-16954710 ] Xiening Dai commented on CALCITE-3376: -- Great to know. Thanks for checking. > VolcanoPlanner

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957203#comment-16957203 ] Xiening Dai commented on CALCITE-2018: -- Hi [~volodymyr], are you still working on this issue? Are

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977955#comment-16977955 ] Xiening Dai commented on CALCITE-3503: -- {quote}I don't think it is meaningless to do `isValid()`

[jira] [Comment Edited] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977955#comment-16977955 ] Xiening Dai edited comment on CALCITE-3503 at 11/20/19 12:53 AM: -

[jira] [Commented] (CALCITE-3503) NPE at VolcanoPlanner#isValid when DEBUG is enabled

[ https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978665#comment-16978665 ] Xiening Dai commented on CALCITE-3503: -- I explained this before. The reason to create a new MQ

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944646#comment-16944646 ] Xiening Dai commented on CALCITE-2018: -- The cyclic metadata exception is due to the change of memo

[jira] [Comment Edited] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944646#comment-16944646 ] Xiening Dai edited comment on CALCITE-2018 at 10/4/19 4:28 PM: --- The

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951257#comment-16951257 ] Xiening Dai commented on CALCITE-2018: -- [~julianhyde][~volodymyr] Do you have any other feedback

[jira] [Created] (CALCITE-3821) RelOptUtil::containsMultisetOrWindowedAgg doesn't really check multiset

Xiening Dai created CALCITE-3821: Summary: RelOptUtil::containsMultisetOrWindowedAgg doesn't really check multiset Key: CALCITE-3821 URL: https://issues.apache.org/jira/browse/CALCITE-3821 Project:

[jira] [Updated] (CALCITE-3821) RelOptUtil::containsMultisetOrWindowedAgg doesn't really check multiset

[ https://issues.apache.org/jira/browse/CALCITE-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai updated CALCITE-3821: - Description: The check of containsMultiset() is shortcut by a "false" constant. Also what the

[jira] [Commented] (CALCITE-3821) RelOptUtil::containsMultisetOrWindowedAgg doesn't really check multiset

[ https://issues.apache.org/jira/browse/CALCITE-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044962#comment-17044962 ] Xiening Dai commented on CALCITE-3821: -- * I should have update the comments. Sorry, will do in

[jira] [Commented] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048083#comment-17048083 ] Xiening Dai commented on CALCITE-3827: -- We can just use one hash map, which maps vertex to a pair

[jira] [Commented] (CALCITE-3836) The hash codes of RelNodes are unreliable

[ https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048770#comment-17048770 ] Xiening Dai commented on CALCITE-3836: -- [~danny0405] how does this would benefit multi threading?

[jira] [Commented] (CALCITE-3836) The hash codes of RelNodes are unreliable

[ https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050501#comment-17050501 ] Xiening Dai commented on CALCITE-3836: -- [~rubenql] You are right. I read HotSpot biased lock

[jira] [Commented] (CALCITE-3836) The hash codes of RelNodes are unreliable

[ https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049972#comment-17049972 ] Xiening Dai commented on CALCITE-3836: -- [~danny0405] this article says - "simply asking for the

[jira] [Commented] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047855#comment-17047855 ] Xiening Dai commented on CALCITE-3827: -- There shouldn't be too much overhead. Every edge contains

[jira] [Created] (CALCITE-3768) VolcanoPlanner.changeTraitsUsingConverters() has parameter that's never used

Xiening Dai created CALCITE-3768: Summary: VolcanoPlanner.changeTraitsUsingConverters() has parameter that's never used Key: CALCITE-3768 URL: https://issues.apache.org/jira/browse/CALCITE-3768

[jira] [Commented] (CALCITE-3753) Always try to match and execute substitution rule first and remove rulematch ordering

[ https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027058#comment-17027058 ] Xiening Dai commented on CALCITE-3753: -- {quote} Roman Kondakov Calcite's engine always had the

[jira] [Created] (CALCITE-3807) checkForSatisfiedConverters() is unnecessary

Xiening Dai created CALCITE-3807: Summary: checkForSatisfiedConverters() is unnecessary Key: CALCITE-3807 URL: https://issues.apache.org/jira/browse/CALCITE-3807 Project: Calcite Issue

[jira] [Commented] (CALCITE-3786) Add Digest (HashStrategy?) interface to enable efficient hashCode/equals for RexNode, RelNode

[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035851#comment-17035851 ] Xiening Dai commented on CALCITE-3786: -- Agree with [~hyuan]. The only benefit of digest is because

[jira] [Created] (CALCITE-3785) HepPlanner.belongToDag() doesn't have to use mapDigestToVertex

Xiening Dai created CALCITE-3785: Summary: HepPlanner.belongToDag() doesn't have to use mapDigestToVertex Key: CALCITE-3785 URL: https://issues.apache.org/jira/browse/CALCITE-3785 Project: Calcite

[jira] [Reopened] (CALCITE-3713) Remove column names from Project#digest

[ https://issues.apache.org/jira/browse/CALCITE-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai reopened CALCITE-3713: -- The fix incurs performance overhead when using mapDigestToVertex, mapDigestToRel, since now the

[jira] [Commented] (CALCITE-3676) VolcanoPlanner. dumpGraphviz should handle exception gracefully

[ https://issues.apache.org/jira/browse/CALCITE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016185#comment-17016185 ] Xiening Dai commented on CALCITE-3676: -- Any progress on this, [~vladimirsitnikov] ? I have to

[jira] [Commented] (CALCITE-3676) VolcanoPlanner. dumpGraphviz should handle exception gracefully

[ https://issues.apache.org/jira/browse/CALCITE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017342#comment-17017342 ] Xiening Dai commented on CALCITE-3676: -- Ok, that is a good workaround for now. I am using our own

[jira] [Commented] (CALCITE-2166) Cumulative cost of RelSubset.best RelNode is increased after calling RelSubset.propagateCostImprovements() for input RelNodes

[ https://issues.apache.org/jira/browse/CALCITE-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010880#comment-17010880 ] Xiening Dai commented on CALCITE-2166: -- [~rubenql] No, part of the fix of CALCITE-3479 was to

[jira] [Commented] (CALCITE-3927) RelSubset is not fired for rule when set gets merged

[ https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084302#comment-17084302 ] Xiening Dai commented on CALCITE-3927: -- Can we come up with a test case? Just try to assess the

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077486#comment-17077486 ] Xiening Dai commented on CALCITE-2970: -- {quote} Note that you can create a physical RelBulder by

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077668#comment-17077668 ] Xiening Dai commented on CALCITE-2970: -- I think whether or not the implementation should/can do

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076709#comment-17076709 ] Xiening Dai commented on CALCITE-2970: -- Such interface already exists - which is the

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076710#comment-17076710 ] Xiening Dai commented on CALCITE-2970: -- By the way, I am not re-inventing RelBuilder. I just

[jira] [Commented] (CALCITE-3917) Revive pruned node when a rule generates RelNode that is already pruned

[ https://issues.apache.org/jira/browse/CALCITE-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082810#comment-17082810 ] Xiening Dai commented on CALCITE-3917: -- We can't because the penalty doesn't prevent it from being

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088048#comment-17088048 ] Xiening Dai commented on CALCITE-2970: -- Thanks [~hyuan] [~julianhyde]. I am working on the

[jira] [Commented] (CALCITE-3927) RelSubset is not fired for rule when set gets merged

[ https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088864#comment-17088864 ] Xiening Dai commented on CALCITE-3927: -- Creating test cases by analyzing the code is totally

[jira] [Commented] (CALCITE-3915) Add rule listener to report rule attempts and time at DEBUG log level

[ https://issues.apache.org/jira/browse/CALCITE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081075#comment-17081075 ] Xiening Dai commented on CALCITE-3915: -- The example in the description is messed up due to the

[jira] [Issue Comment Deleted] (CALCITE-3915) Add rule listener to report rule attempts and time at DEBUG log level

[ https://issues.apache.org/jira/browse/CALCITE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai updated CALCITE-3915: - Comment: was deleted (was: The example in the description is messed up due to the indents. We

[jira] [Created] (CALCITE-3915) Add rule listener to report rule attempts and time at DEBUG log level

Xiening Dai created CALCITE-3915: Summary: Add rule listener to report rule attempts and time at DEBUG log level Key: CALCITE-3915 URL: https://issues.apache.org/jira/browse/CALCITE-3915 Project:

[jira] [Assigned] (CALCITE-3915) Add rule listener to report rule attempts and time at DEBUG log level

[ https://issues.apache.org/jira/browse/CALCITE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai reassigned CALCITE-3915: Assignee: Xiening Dai > Add rule listener to report rule attempts and time at DEBUG log

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076893#comment-17076893 ] Xiening Dai commented on CALCITE-2970: -- Thanks [~danny0405] for the feedback. My comments inline -

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076923#comment-17076923 ] Xiening Dai commented on CALCITE-2970: -- [~hyuan] I have to admit that your proposal would simply

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069128#comment-17069128 ] Xiening Dai commented on CALCITE-2970: -- [~hyuan][~zabetak][~julianhyde] I create a pull request

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089171#comment-17089171 ] Xiening Dai commented on CALCITE-2970: -- Hi [~julianhyde], I am not sure I understand. Do you mean

[jira] [Commented] (CALCITE-3963) Maintains logical properties at RelSet (equivalent group) instead of RelNode

[ https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097006#comment-17097006 ] Xiening Dai commented on CALCITE-3963: -- What I mean by "maintain" is more about associating these

[jira] [Commented] (CALCITE-3963) Maintains logical properties at RelSet (equivalent group) instead of RelNode

[ https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097015#comment-17097015 ] Xiening Dai commented on CALCITE-3963: -- {quote}We shouldn't rely on the first rel or subset's

[jira] [Commented] (CALCITE-3923) Refactor how planner rules are parameterized

[ https://issues.apache.org/jira/browse/CALCITE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097074#comment-17097074 ] Xiening Dai commented on CALCITE-3923: -- I am thinking about this. Once we have the RelBuilder

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095895#comment-17095895 ] Xiening Dai commented on CALCITE-2970: -- Yes, the #1 point I mentioned. If there's a sub-class

  1   2   >