[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387467961 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ##

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387467864 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ##

[GitHub] [carbondata] ajantha-bhat commented on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
ajantha-bhat commented on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#issuecomment-594350791 I have gone through on a very high level. I need to check out code and review agian. @jackylk : It will be useful if you can

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3648: [CARBONDATA-3732] Fix ClassCastException with rand() udf function

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3648: [CARBONDATA-3732] Fix ClassCastException with rand() udf function URL: https://github.com/apache/carbondata/pull/3648#issuecomment-594358885 Build Success with Spark 2.3.4, Please check CI

[jira] [Resolved] (CARBONDATA-3696) Avoid list db's all Tables to check if table exists in the db

2020-03-03 Thread Jacky Li (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-3696. -- Fix Version/s: 2.0.0 Resolution: Fixed > Avoid list db's all Tables to check if

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387470463 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ## @@

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#discussion_r387467200 ## File path:

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387467031 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ##

[GitHub] [carbondata] asfgit closed pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
asfgit closed pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#discussion_r387472308 ## File path:

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#discussion_r387473487 ## File path:

[jira] [Resolved] (CARBONDATA-3725) Concurrent issue when materialized views are created concurrently

2020-03-03 Thread Jacky Li (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-3725. -- Fix Version/s: 2.0.0 Resolution: Fixed > Concurrent issue when materialized views

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3614: [CARBONDATA-3693] Separate Index command from DataMap command

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3614: [CARBONDATA-3693] Separate Index command from DataMap command URL: https://github.com/apache/carbondata/pull/3614#issuecomment-594357541 Build Failed with Spark 2.4.4, Please check CI

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#discussion_r387477530 ## File path:

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3648: [CARBONDATA-3732] Fix ClassCastException with rand() udf function

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3648: [CARBONDATA-3732] Fix ClassCastException with rand() udf function URL: https://github.com/apache/carbondata/pull/3648#issuecomment-594357210 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] asfgit closed pull request #3631: [CARBONDATA-3696] Avoid list db's all Tables to check table exists in the db

2020-03-03 Thread GitBox
asfgit closed pull request #3631: [CARBONDATA-3696] Avoid list db's all Tables to check table exists in the db URL: https://github.com/apache/carbondata/pull/3631 This is an automated message from the Apache Git Service. To

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3413: Bump netty-all from 4.0.42.Final to 4.1.42.Final in /core

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3413: Bump netty-all from 4.0.42.Final to 4.1.42.Final in /core URL: https://github.com/apache/carbondata/pull/3413#issuecomment-594377616 Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/596/

[GitHub] [carbondata] marchpure commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi…

2020-03-03 Thread GitBox
marchpure commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi… URL: https://github.com/apache/carbondata/pull/3620#issuecomment-593936776 retest this please This is an automated

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3631: [CARBONDATA-3696] Avoid list db's all Tables to check table exists in the db

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3631: [CARBONDATA-3696] Avoid list db's all Tables to check table exists in the db URL: https://github.com/apache/carbondata/pull/3631#issuecomment-593937254 Build Success with Spark 2.3.4, Please check CI

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit

2020-03-03 Thread GitBox
akashrn5 commented on a change in pull request #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit URL: https://github.com/apache/carbondata/pull/3651#discussion_r387008135 ## File path:

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#issuecomment-593947932 Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/584/

[GitHub] [carbondata] akashrn5 commented on issue #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures

2020-03-03 Thread GitBox
akashrn5 commented on issue #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures URL: https://github.com/apache/carbondata/pull/3629#issuecomment-593957068 LGTM This is an automated message from the Apache Git Service. To

[jira] [Created] (CARBONDATA-3734) Fix insert failure on partition table when partition column is in sort column

2020-03-03 Thread Ajantha Bhat (Jira)
Ajantha Bhat created CARBONDATA-3734: Summary: Fix insert failure on partition table when partition column is in sort column Key: CARBONDATA-3734 URL: https://issues.apache.org/jira/browse/CARBONDATA-3734

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit URL: https://github.com/apache/carbondata/pull/3651#issuecomment-593965394 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi…

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi… URL: https://github.com/apache/carbondata/pull/3620#issuecomment-594056183 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi…

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi… URL: https://github.com/apache/carbondata/pull/3620#issuecomment-594096114 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi…

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi… URL: https://github.com/apache/carbondata/pull/3620#issuecomment-594040592 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi…

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi… URL: https://github.com/apache/carbondata/pull/3620#issuecomment-594071943 Build Failed with Spark 2.3.4, Please check CI

[GitHub] [carbondata] asfgit closed pull request #3647: [CARBONDATA-3348] Fix the case insensitive validation for duplicate sort column.

2020-03-03 Thread GitBox
asfgit closed pull request #3647: [CARBONDATA-3348] Fix the case insensitive validation for duplicate sort column. URL: https://github.com/apache/carbondata/pull/3647 This is an automated message from the Apache Git

[GitHub] [carbondata] maheshrajus commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-03 Thread GitBox
maheshrajus commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#discussion_r386975490 ## File path:

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures URL: https://github.com/apache/carbondata/pull/3629#issuecomment-593933627 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2286/

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#issuecomment-593910714 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2285/

[GitHub] [carbondata] CarbonDataQA1 commented on issue #2917: [WIP]Show load/insert/update/delete row number

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #2917: [WIP]Show load/insert/update/delete row number URL: https://github.com/apache/carbondata/pull/2917#issuecomment-593911656 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2288/

[GitHub] [carbondata] akashrn5 commented on issue #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures

2020-03-03 Thread GitBox
akashrn5 commented on issue #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures URL: https://github.com/apache/carbondata/pull/3629#issuecomment-593917584 ![image](https://user-images.githubusercontent.com/21074821/75774211-785ae100-5d75-11ea-9d3d-8ff52049fbc4.png)

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit URL: https://github.com/apache/carbondata/pull/3651#discussion_r387021167 ## File path:

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi…

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi… URL: https://github.com/apache/carbondata/pull/3620#issuecomment-593979228 Build Failed with Spark 2.3.4, Please check CI

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3583: [CARBONDATA-3687] Support writing non-transactional carbondata files through hive

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3583: [CARBONDATA-3687] Support writing non-transactional carbondata files through hive URL: https://github.com/apache/carbondata/pull/3583#issuecomment-593993693 Build Success with Spark 2.3.4, Please check CI

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3642: [CARBONDATA-3725]fix concurrent creation of Materialized Views issue

2020-03-03 Thread GitBox
ajantha-bhat commented on a change in pull request #3642: [CARBONDATA-3725]fix concurrent creation of Materialized Views issue URL: https://github.com/apache/carbondata/pull/3642#discussion_r387089006 ## File path:

[GitHub] [carbondata] maheshrajus commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-03 Thread GitBox
maheshrajus commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#discussion_r386983083 ## File path:

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3653: [WIP]ExpiringMap

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3653: [WIP]ExpiringMap URL: https://github.com/apache/carbondata/pull/3653#issuecomment-593961774 Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/586/

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#issuecomment-593985123 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2290/

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit URL: https://github.com/apache/carbondata/pull/3651#issuecomment-593998502 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2293/

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3631: [CARBONDATA-3696] Avoid list db's all Tables to check table exists in the db

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3631: [CARBONDATA-3696] Avoid list db's all Tables to check table exists in the db URL: https://github.com/apache/carbondata/pull/3631#issuecomment-593911959 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3583: [CARBONDATA-3687] Support writing non-transactional carbondata files through hive

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3583: [CARBONDATA-3687] Support writing non-transactional carbondata files through hive URL: https://github.com/apache/carbondata/pull/3583#issuecomment-593954531 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3654: [CARBONDATA-3734] Fix insert failure on partition table when parition column is in sort column

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3654: [CARBONDATA-3734] Fix insert failure on partition table when parition column is in sort column URL: https://github.com/apache/carbondata/pull/3654#issuecomment-593966689 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi…

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi… URL: https://github.com/apache/carbondata/pull/3620#issuecomment-593943948 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] Indhumathi27 opened a new pull request #3653: [WIP]ExpiringMap

2020-03-03 Thread GitBox
Indhumathi27 opened a new pull request #3653: [WIP]ExpiringMap URL: https://github.com/apache/carbondata/pull/3653 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes.

[GitHub] [carbondata] ajantha-bhat opened a new pull request #3654: [CARBONDATA-3734] Fix insert to partition table when parition column is in sort column

2020-03-03 Thread GitBox
ajantha-bhat opened a new pull request #3654: [CARBONDATA-3734] Fix insert to partition table when parition column is in sort column URL: https://github.com/apache/carbondata/pull/3654 ### Why is this PR needed? When partition column is a sort column. a) currently sort columns

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3642: [CARBONDATA-3725]fix concurrent creation of Materialized Views issue

2020-03-03 Thread GitBox
akashrn5 commented on a change in pull request #3642: [CARBONDATA-3725]fix concurrent creation of Materialized Views issue URL: https://github.com/apache/carbondata/pull/3642#discussion_r386800566 ## File path:

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3654: [CARBONDATA-3734] Fix insert failure on partition table when parition column is in sort column

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3654: [CARBONDATA-3734] Fix insert failure on partition table when parition column is in sort column URL: https://github.com/apache/carbondata/pull/3654#issuecomment-594008203 Build Success with Spark 2.3.4, Please check CI

[GitHub] [carbondata] akashrn5 commented on issue #3647: [CARBONDATA-3348] Fix the case insensitive validation for duplicate sort column.

2020-03-03 Thread GitBox
akashrn5 commented on issue #3647: [CARBONDATA-3348] Fix the case insensitive validation for duplicate sort column. URL: https://github.com/apache/carbondata/pull/3647#issuecomment-593914836 LGTM This is an automated

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3653: [WIP]ExpiringMap

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3653: [WIP]ExpiringMap URL: https://github.com/apache/carbondata/pull/3653#issuecomment-59496 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2292/

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi…

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi… URL: https://github.com/apache/carbondata/pull/3620#issuecomment-594133805 Build Failed with Spark 2.3.4, Please check CI

[jira] [Resolved] (CARBONDATA-3716) Fixed spark 2.4 UT failures

2020-03-03 Thread Jacky Li (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-3716. -- Fix Version/s: 2.0.0 Resolution: Fixed > Fixed spark 2.4 UT failures >

[GitHub] [carbondata] jackylk commented on a change in pull request #3628: [CARBONDATA-3714] Support specify order type when list stage files

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3628: [CARBONDATA-3714] Support specify order type when list stage files URL: https://github.com/apache/carbondata/pull/3628#discussion_r387410408 ## File path:

[GitHub] [carbondata] CarbonDataQA1 commented on issue #984: [CARBONDATA-1008] Make Carbon table schema compatible with HIVE

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #984: [CARBONDATA-1008] Make Carbon table schema compatible with HIVE URL: https://github.com/apache/carbondata/pull/984#issuecomment-594278102 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2298/

[GitHub] [carbondata] jackylk commented on a change in pull request #3628: [CARBONDATA-3714] Support specify order type when list stage files

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3628: [CARBONDATA-3714] Support specify order type when list stage files URL: https://github.com/apache/carbondata/pull/3628#discussion_r387409789 ## File path: docs/dml-of-carbondata.md ## @@ -334,11 +335,22 @@ CarbonData

[GitHub] [carbondata] jackylk commented on a change in pull request #3628: [CARBONDATA-3714] Support specify order type when list stage files

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3628: [CARBONDATA-3714] Support specify order type when list stage files URL: https://github.com/apache/carbondata/pull/3628#discussion_r387409824 ## File path: docs/dml-of-carbondata.md ## @@ -334,11 +335,22 @@ CarbonData

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#issuecomment-594317071 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2299/

[GitHub] [carbondata] jackylk commented on issue #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
jackylk commented on issue #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#issuecomment-594326592 LGTM This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3614: [CARBONDATA-3693] Separate Index command from DataMap command

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3614: [CARBONDATA-3693] Separate Index command from DataMap command URL: https://github.com/apache/carbondata/pull/3614#issuecomment-594326418 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2301/

[GitHub] [carbondata] Indhumathi27 commented on issue #3648: [CARBONDATA-3732] Fix ClassCastException with rand() udf function

2020-03-03 Thread GitBox
Indhumathi27 commented on issue #3648: [CARBONDATA-3732] Fix ClassCastException with rand() udf function URL: https://github.com/apache/carbondata/pull/3648#issuecomment-594331788 retest this please This is an automated

[GitHub] [carbondata] asfgit closed pull request #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures

2020-03-03 Thread GitBox
asfgit closed pull request #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures URL: https://github.com/apache/carbondata/pull/3629 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [carbondata] maheshrajus commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-03 Thread GitBox
maheshrajus commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#discussion_r387450095 ## File path:

[GitHub] [carbondata] jackylk commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387406212 ## File path: integration/spark/src/main/spark2.4/org/apache/spark/sql/parser/SparkSqlAstBuilderWrapper.scala

[GitHub] [carbondata] jackylk commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387406240 ## File path: integration/spark/src/main/spark2.4/org/apache/spark/sql/parser/SparkSqlAstBuilderWrapper.scala

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi…

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi… URL: https://github.com/apache/carbondata/pull/3620#issuecomment-594302744 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387449577 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/compression/AbstractCompressor.java

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387450269 ## File path:

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3614: [CARBONDATA-3693] Separate Index command from DataMap command

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3614: [CARBONDATA-3693] Separate Index command from DataMap command URL: https://github.com/apache/carbondata/pull/3614#issuecomment-594319286 Build Success with Spark 2.4.4, Please check CI

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi…

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3620: [CARBONDATA-3700] Optimize pruning performance when prunning with multi… URL: https://github.com/apache/carbondata/pull/3620#issuecomment-594321946 Build Success with Spark 2.3.4, Please check CI

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387450269 ## File path:

[GitHub] [carbondata] jackylk commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387404541 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/EnvHelper.scala ## @@ -26,17 +28,29 @@

[GitHub] [carbondata] jackylk commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387406952 ## File path: sdk/sdk/pom.xml ## @@ -44,7 +44,6 @@ org.apache.hadoop hadoop-aws -

[GitHub] [carbondata] jackylk commented on issue #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures

2020-03-03 Thread GitBox
jackylk commented on issue #3629: [CARBONDATA-3716] Fixed spark 2.4 UT failures URL: https://github.com/apache/carbondata/pull/3629#issuecomment-594275447 LGTM This is an automated message from the Apache Git Service. To

[GitHub] [carbondata] QiangCai commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
QiangCai commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387415457 ## File path: integration/spark/src/main/spark2.4/org/apache/spark/sql/parser/SparkSqlAstBuilderWrapper.scala

[GitHub] [carbondata] QiangCai commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
QiangCai commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387415417 ## File path: integration/spark/src/main/spark2.4/org/apache/spark/sql/parser/SparkSqlAstBuilderWrapper.scala

[GitHub] [carbondata] QiangCai commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
QiangCai commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387415365 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/EnvHelper.scala ## @@ -26,17 +28,29 @@

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#issuecomment-594294770 Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/592/

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387450942 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/TestStreamingTableWithLongString.scala

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387450980 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/TestStreamingTableWithRowParser.scala

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387450914 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/TestStreamingTableQueryFilter.scala

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3652: [HOTFIX] optimize module dependency URL: https://github.com/apache/carbondata/pull/3652#discussion_r387450880 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOpName.scala

[GitHub] [carbondata] jackylk edited a comment on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk edited a comment on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#issuecomment-594351151 @ajantha-bhat In original code, 5 copies are: ``` TablePage.convertToColumnarAndAddToPages: byte[]

[GitHub] [carbondata] jackylk edited a comment on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk edited a comment on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#issuecomment-594351151 @ajantha-bhat In original code, 5 copies are: ``` TablePage.convertToColumnarAndAddToPages: byte[]

[GitHub] [carbondata] jackylk edited a comment on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk edited a comment on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#issuecomment-594351151 @ajantha-bhat In original code, 5 copies are: ``` TablePage.convertToColumnarAndAddToPages: byte[]

[GitHub] [carbondata] jackylk commented on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#issuecomment-594351151 @ajantha-bhat ``` CarbonRowDataWriterProcessorStepImpl.processBatch: CarbonRow converted = convertRowWithoutRearrange(row);

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3614: [CARBONDATA-3693] Separate Index command from DataMap command

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3614: [CARBONDATA-3693] Separate Index command from DataMap command URL: https://github.com/apache/carbondata/pull/3614#issuecomment-594357828 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2305/

[GitHub] [carbondata] asfgit closed pull request #3642: [CARBONDATA-3725]fix concurrent creation of Materialized Views issue

2020-03-03 Thread GitBox
asfgit closed pull request #3642: [CARBONDATA-3725]fix concurrent creation of Materialized Views issue URL: https://github.com/apache/carbondata/pull/3642 This is an automated message from the Apache Git Service. To respond

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
CarbonDataQA1 commented on issue #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#issuecomment-594364130 Build Failed with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/597/

[GitHub] [carbondata] jackylk commented on issue #3631: [CARBONDATA-3696] Avoid list db's all Tables to check table exists in the db

2020-03-03 Thread GitBox
jackylk commented on issue #3631: [CARBONDATA-3696] Avoid list db's all Tables to check table exists in the db URL: https://github.com/apache/carbondata/pull/3631#issuecomment-594371040 LGTM Thanks for working on this

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387465206 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/compression/Compressor.java

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-03 Thread GitBox
Indhumathi27 commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#discussion_r387454934 ## File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387469426 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/compression/Compressor.java ##

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387469248 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/compression/AbstractCompressor.java

[GitHub] [carbondata] dependabot[bot] commented on issue #3447: Bump dep.jackson.version from 2.6.5 to 2.10.1 in /store/sdk

2020-03-03 Thread GitBox
dependabot[bot] commented on issue #3447: Bump dep.jackson.version from 2.6.5 to 2.10.1 in /store/sdk URL: https://github.com/apache/carbondata/pull/3447#issuecomment-594350351 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the

[GitHub] [carbondata] dependabot[bot] commented on issue #3456: Bump solr.version from 6.3.0 to 8.3.0 in /datamap/lucene

2020-03-03 Thread GitBox
dependabot[bot] commented on issue #3456: Bump solr.version from 6.3.0 to 8.3.0 in /datamap/lucene URL: https://github.com/apache/carbondata/pull/3456#issuecomment-594350361 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387470463 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ## @@

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387470537 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ## @@

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387470422 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ## @@

  1   2   >