[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#issuecomment-737661221 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5034/

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534677732 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala ## @@ -267,15 +269,20 @@ class

[GitHub] [carbondata] kunal642 commented on pull request #4010: [CARBONDATA-4050]Avoid redundant RPC calls to get file status when CarbonFile is instantiated with fileStatus constructor

2020-12-02 Thread GitBox
kunal642 commented on pull request #4010: URL: https://github.com/apache/carbondata/pull/4010#issuecomment-737674089 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534677505 ## File path: core/src/main/java/org/apache/carbondata/core/writer/CarbonIndexFileMergeWriter.java ## @@ -241,13 +266,17 @@ public String

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4036: [WIP][Test CI]

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4036: URL: https://github.com/apache/carbondata/pull/4036#issuecomment-737675578 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3278/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4001: [CARBONDATA-4029] [CARBONDATA-3908] Issue while adding segments through alter add segment command

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4001: URL: https://github.com/apache/carbondata/pull/4001#discussion_r534681054 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -877,6 +877,10 @@ public SegmentFile

[GitHub] [carbondata] Zhangshunyu opened a new pull request #4036: [WIP][Test CI]

2020-12-02 Thread GitBox
Zhangshunyu opened a new pull request #4036: URL: https://github.com/apache/carbondata/pull/4036 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#issuecomment-737663951 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3277/

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534677231 ## File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ## @@ -672,7 +678,7 @@ public static boolean

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534677179 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -664,7 +723,8 @@ public static SegmentFile

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534677017 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -439,6 +430,73 @@ public boolean

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4035: [CARBONDATA-4067]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
vikramahuja1001 commented on a change in pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#discussion_r534678969 ## File path: core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java ## @@ -173,40 +176,62 @@ public boolean

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4035: [CARBONDATA-4067]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
vikramahuja1001 commented on a change in pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#discussion_r534678759 ## File path: core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java ## @@ -173,40 +176,62 @@ public boolean

[GitHub] [carbondata] kunal642 commented on a change in pull request #4017: [CARBONDATA-4022] Fix invalid path issue for segment added through alter table add segment query.

2020-12-02 Thread GitBox
kunal642 commented on a change in pull request #4017: URL: https://github.com/apache/carbondata/pull/4017#discussion_r534686282 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java ## @@ -219,7 +220,12 @@ public void

[GitHub] [carbondata] kunal642 commented on pull request #4017: [CARBONDATA-4022] Fix invalid path issue for segment added through alter table add segment query.

2020-12-02 Thread GitBox
kunal642 commented on pull request #4017: URL: https://github.com/apache/carbondata/pull/4017#issuecomment-737680164 update the description with the actual root cause and updated solution This is an automated message from

[GitHub] [carbondata] QiangCai commented on a change in pull request #4035: [CARBONDATA-4067]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#discussion_r534596239 ## File path: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java ## @@ -1095,7 +1099,8 @@ public static void

[GitHub] [carbondata] QiangCai commented on a change in pull request #4035: [CARBONDATA-4067]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#discussion_r534596239 ## File path: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java ## @@ -1095,7 +1099,8 @@ public static void

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4036: [WIP][Test CI]

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4036: URL: https://github.com/apache/carbondata/pull/4036#issuecomment-737672816 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5035/

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534676835 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -198,20 +208,17 @@ public boolean

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534676791 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -162,15 +162,25 @@ public static void

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534676638 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -162,15 +162,25 @@ public static void

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534678076 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/util/SecondaryIndexUtil.scala ## @@ -226,85 +233,59 @@ object

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4035: [CARBONDATA-4067]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
vikramahuja1001 commented on a change in pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#discussion_r534678032 ## File path: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java ## @@ -1039,17 +1039,19 @@ private static

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534676791 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -162,15 +162,25 @@ public static void

[GitHub] [carbondata] kunal642 commented on a change in pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-02 Thread GitBox
kunal642 commented on a change in pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#discussion_r534693837 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala ## @@ -212,17

[GitHub] [carbondata] QiangCai commented on a change in pull request #4035: [CARBONDATA-4067]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#discussion_r534596239 ## File path: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java ## @@ -1095,7 +1099,8 @@ public static void

[GitHub] [carbondata] Zhangshunyu commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-12-02 Thread GitBox
Zhangshunyu commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-737599642 @ajantha-bhat @akashrn5 pls check This is an automated message from the Apache Git Service. To respond

[GitHub] [carbondata] QiangCai commented on pull request #4035: [CARBONDATA-4067]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
QiangCai commented on pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#issuecomment-737611158 @vikramahuja1001 please change title to describe what you change This is an automated message from the

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534743440 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,12 +192,9 @@ public static void emptyTrash(String

[GitHub] [carbondata] QiangCai commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534742148 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -146,8 +146,8 @@ public static void

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
ShreelekhyaG commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534763831 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -439,6 +430,73 @@ public boolean

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4035: [CARBONDATA-4067]: Removing force option in clean files command and changing behaviour when MFD, Compacted and stale Inprogress seg

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#issuecomment-737723996 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3280/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534852698 ## File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ## @@ -482,176 +482,6 @@ public boolean

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534713302 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -208,6 +205,14 @@ public static boolean

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534713302 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -208,6 +205,14 @@ public static boolean

[GitHub] [carbondata] kunal642 commented on a change in pull request #4017: [CARBONDATA-4022] Fix invalid path issue for segment added through alter table add segment query.

2020-12-02 Thread GitBox
kunal642 commented on a change in pull request #4017: URL: https://github.com/apache/carbondata/pull/4017#discussion_r534686282 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java ## @@ -219,7 +220,12 @@ public void

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534727593 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -1044,7 +1045,7 @@ public static void

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-737695440 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5036/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534730624 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -146,8 +146,8 @@ public static void

[GitHub] [carbondata] Zhangshunyu commented on pull request #4032: [CARBONDATA-4065] Support MERGE INTO SQL Command

2020-12-02 Thread GitBox
Zhangshunyu commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-737698494 added antlr4-maven-plugin to manage the antlr files during compile This is an automated message from the

[GitHub] [carbondata] QiangCai commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534744818 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -208,6 +205,14 @@ public static boolean

[GitHub] [carbondata] QiangCai commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534746030 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,12 +192,9 @@ public static void emptyTrash(String

[GitHub] [carbondata] QiangCai commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534745677 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -1044,7 +1045,7 @@ public static void

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-02 Thread GitBox
akashrn5 commented on a change in pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#discussion_r534771957 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala ## @@ -212,17

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534784870 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,112 @@ +/* + * Licensed to the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4035: [CARBONDATA-4067]: Removing force option in clean files command and changing behaviour when MFD, Compacted and stale Inprogress seg

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#issuecomment-737723330 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5037/

[GitHub] [carbondata] Zhangshunyu closed pull request #4036: [WIP][Test CI]

2020-12-02 Thread GitBox
Zhangshunyu closed pull request #4036: URL: https://github.com/apache/carbondata/pull/4036 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534713302 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -208,6 +205,14 @@ public static boolean

[GitHub] [carbondata] nihal0107 opened a new pull request #4037: [WIP] Handle Alter long string for SI col and added FTs for SI

2020-12-02 Thread GitBox
nihal0107 opened a new pull request #4037: URL: https://github.com/apache/carbondata/pull/4037 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-737700791 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3279/

[GitHub] [carbondata] QiangCai commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534742148 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -146,8 +146,8 @@ public static void

[GitHub] [carbondata] QiangCai commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534745677 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -1044,7 +1045,7 @@ public static void

[GitHub] [carbondata] QiangCai commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534746030 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,12 +192,9 @@ public static void emptyTrash(String

[GitHub] [carbondata] QiangCai commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534746030 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,12 +192,9 @@ public static void emptyTrash(String

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534771387 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,112 @@ +/* + * Licensed to the

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
ajantha-bhat commented on a change in pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#discussion_r534825881 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonTruncateCommand.scala ## @@ -18,39 +18,31

[GitHub] [carbondata] Karan980 commented on pull request #4017: [CARBONDATA-4022] Fix invalid path issue for segment added through alter table add segment query.

2020-12-02 Thread GitBox
Karan980 commented on pull request #4017: URL: https://github.com/apache/carbondata/pull/4017#issuecomment-737728408 > update the description with the actual root cause and updated solution Done This is an automated

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533971772 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533971945 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[jira] [Resolved] (CARBONDATA-4020) Drop bloom index for single index of table having multiple index drops all indexes

2020-12-02 Thread Indhumathi Muthu Murugesh (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Indhumathi Muthu Murugesh resolved CARBONDATA-4020. --- Fix Version/s: 2.2.0 Resolution: Fixed > Drop

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-737103815 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5016/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4031: Presto UT optimization

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#issuecomment-737138681 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5019/

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533968484 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoConstants.java ## @@ -26,4 +26,34 @@ private GeoConstants() { // GeoHash type

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533972715 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533972546 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/filter/executor/PolygonFilterExecutorImpl.java ## @@ -73,8 +77,24 @@ private int

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533959413 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoHashUtils.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [WIP] support prestosql 333

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4034: URL: https://github.com/apache/carbondata/pull/4034#issuecomment-737104390 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5017/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-737120401 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5018/

[jira] [Created] (CARBONDATA-4067) Change clean files behaviour to support cleaning of in progress segments

2020-12-02 Thread Vikram Ahuja (Jira)
Vikram Ahuja created CARBONDATA-4067: Summary: Change clean files behaviour to support cleaning of in progress segments Key: CARBONDATA-4067 URL: https://issues.apache.org/jira/browse/CARBONDATA-4067

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-737152317 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5021/

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533986229 ## File path: integration/spark/src/test/scala/org/apache/carbondata/geo/GeoTest.scala ## @@ -276,17 +274,14 @@ class GeoTest extends QueryTest

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-737100516 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3260/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4035: [CARBONDATA-4067]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#issuecomment-737176415 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5023/

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533974578 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolylineListExpression.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4000: [CARBONDATA-4020] Fixed drop index when multiple index exists

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4000: URL: https://github.com/apache/carbondata/pull/4000#issuecomment-737079277 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3258/

[GitHub] [carbondata] vikramahuja1001 opened a new pull request #4035: [WIP]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
vikramahuja1001 opened a new pull request #4035: URL: https://github.com/apache/carbondata/pull/4035 ### Why is this PR needed? Change the behaviour change for clean files operation Old behaviour: Clean files command is by default force option and ignores query timeout.

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-737092372 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3259/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-737124721 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3262/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-737090938 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5015/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [WIP] support prestosql 333

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4034: URL: https://github.com/apache/carbondata/pull/4034#issuecomment-737110915 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3261/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4031: Presto UT optimization

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#issuecomment-737140156 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3263/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-737155601 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3265/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4000: [CARBONDATA-4020] Fixed drop index when multiple index exists

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4000: URL: https://github.com/apache/carbondata/pull/4000#issuecomment-737076274 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5014/

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533986229 ## File path: integration/spark/src/test/scala/org/apache/carbondata/geo/GeoTest.scala ## @@ -276,17 +274,14 @@ class GeoTest extends QueryTest

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4035: [WIP]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#issuecomment-737107889 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5022/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4035: [WIP]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#issuecomment-737107284 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3266/

[GitHub] [carbondata] QiangCai commented on a change in pull request #4026: [CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions

2020-12-02 Thread GitBox
QiangCai commented on a change in pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#discussion_r534097978 ## File path: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ## @@ -635,44 +604,89 @@ public static String

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r534107071 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoHashUtils.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533971365 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] asfgit closed pull request #4000: [CARBONDATA-4020] Fixed drop index when multiple index exists

2020-12-02 Thread GitBox
asfgit closed pull request #4000: URL: https://github.com/apache/carbondata/pull/4000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533987973 ## File path: integration/spark/src/test/scala/org/apache/carbondata/geo/GeoTest.scala ## @@ -354,16 +349,12 @@ class GeoTest extends QueryTest

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4035: [CARBONDATA-4067]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#issuecomment-737177718 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3267/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-737358091 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3276/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4026: [CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#issuecomment-737334203 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5031/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4026: [CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#issuecomment-737338281 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3274/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-737354631 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5033/

[GitHub] [carbondata] QiangCai commented on pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

2020-12-02 Thread GitBox
QiangCai commented on pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#issuecomment-737160943 @akashrn5 @ajantha-bhat @vikramahuja1001 please review this PR This is an automated message from the Apache

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-02 Thread GitBox
vikramahuja1001 commented on a change in pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#discussion_r534175368 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/util/SecondaryIndexUtil.scala ## @@ -226,85 +233,59 @@

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4035: [CARBONDATA-4067]: CleanFiles Behaviour Change

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4035: URL: https://github.com/apache/carbondata/pull/4035#issuecomment-737253057 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5026/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4017: [CARBONDATA-4022] Fix invalid path issue for segment added through alter table add segment query.

2020-12-02 Thread GitBox
CarbonDataQA2 commented on pull request #4017: URL: https://github.com/apache/carbondata/pull/4017#issuecomment-737277019 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3271/

  1   2   >