[GitHub] carbondata pull request #1615: [CARBONDATA-1592]added new parameters for cre...

2017-12-06 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1615#discussion_r155310298 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/LoadEvents.scala --- @@ -31,8 +31,10 @@ case class

[GitHub] carbondata pull request #1702: [CARBONDATA-1896] Clean files operation impro...

2017-12-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1702#discussion_r158474524 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala --- @@ -178,6 +178,7

[GitHub] carbondata pull request #1702: [CARBONDATA-1896] Clean files operation impro...

2017-12-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1702#discussion_r158477319 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/DeleteLoadFolders.java --- @@ -133,16 +138,23 @@ public static boolean

[GitHub] carbondata pull request #1702: [CARBONDATA-1896] Clean files operation impro...

2017-12-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1702#discussion_r158480429 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -418,8 +429,11 @@ object

[GitHub] carbondata pull request #1702: [CARBONDATA-1896] Clean files operation impro...

2017-12-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1702#discussion_r158480479 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/DeleteLoadFolders.java --- @@ -133,16 +138,23 @@ public static boolean

[GitHub] carbondata issue #1716: [CARBONDATA-1933] Support Spark 2.2.1 in carbon part...

2017-12-22 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/1716 retest this please ---

[GitHub] carbondata issue #1708: [CARBONDATA-1928] Seperate the properties for timeou...

2017-12-22 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/1708 retest sdv please ---

[GitHub] carbondata pull request #1767: [CARBONDATA-1993] Carbon properties default v...

2018-01-05 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1767#discussion_r159920010 --- Diff: conf/carbon.properties.template --- @@ -20,7 +20,7 @@ #Mandatory. Carbon Store path carbon.storelocation=hdfs://hacluster/Opt

[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

2018-01-12 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1790#discussion_r161213978 --- Diff: docs/data-management-on-carbondata.md --- @@ -271,6 +271,7 @@ This tutorial is going to introduce all commands and data operations on

[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

2018-01-15 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1790#discussion_r161461376 --- Diff: docs/data-management-on-carbondata.md --- @@ -271,6 +271,7 @@ This tutorial is going to introduce all commands and data operations on

[GitHub] carbondata issue #1790: [CARBONDATA-2009][Documentation] Document Refresh co...

2018-01-15 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/1790 LGTM ---

[GitHub] carbondata pull request #1821: [WIP]refactored code to support external sess...

2018-01-17 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1821#discussion_r162035296 --- Diff: core/src/main/java/org/apache/carbondata/events/OperationListenerBus.java --- @@ -57,9 +57,9 @@ public OperationListenerBus addListener

[GitHub] carbondata pull request #1831: [CARBONDATA-1993] Carbon properties default v...

2018-02-03 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1831#discussion_r165809183 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1264,18 +1231,7

[GitHub] carbondata issue #1831: [CARBONDATA-1993] Carbon properties default values f...

2018-02-03 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/1831 retest sdv please ---

[GitHub] carbondata issue #1931: [HOTFIX] Fix documentation error

2018-02-05 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/1931 LGTM ---

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168702275 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/PartitionMapFileStore.java --- @@ -279,18 +279,20 @@ public boolean

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168696420 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDropPartitionRDD.scala --- @@ -59,10 +61,12 @@ class

[GitHub] carbondata pull request #2038: [WIP]Support UTF-8 with BOM in CSVInputFormat

2018-03-06 Thread KanakaKumar
GitHub user KanakaKumar opened a pull request: https://github.com/apache/carbondata/pull/2038 [WIP]Support UTF-8 with BOM in CSVInputFormat Currently Hive table supports csv file with BOM encoding but Carbon table does not support. org.apache.hadoop.mapred.LineRecordReader

[GitHub] carbondata issue #2038: [CARBONDATA-2234] Support UTF-8 with BOM in CSVInput...

2018-03-07 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2038 retest SDV please ---

[GitHub] carbondata issue #2031: [CARBONDATA-2223] Remove unused listeners

2018-03-18 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2031 LGTM ---

[GitHub] carbondata pull request #2154: [WIP] Non Serializable extra info in session ...

2018-04-10 Thread KanakaKumar
GitHub user KanakaKumar opened a pull request: https://github.com/apache/carbondata/pull/2154 [WIP] Non Serializable extra info in session is overwritten from stale thread Problem: 1. Non Serializable extra info is copied from thread which causes stale data from old

[GitHub] carbondata issue #2154: [CARBONDATA-2329] Non Serializable extra info in ses...

2018-04-10 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2154 retest this please ---

[GitHub] carbondata issue #2154: [CARBONDATA-2329] Non Serializable extra info in ses...

2018-04-10 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2154 retest this please ---

[GitHub] carbondata issue #2154: [CARBONDATA-2329] Non Serializable extra info in ses...

2018-04-10 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2154 retest this please ---

[GitHub] carbondata pull request #2154: [CARBONDATA-2329] Non Serializable extra info...

2018-04-11 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2154#discussion_r180655982 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonSessionInfo.java --- @@ -60,11 +60,9 @@ public CarbonSessionInfo clone() throws

[GitHub] carbondata pull request #2166: [CARBONDATA-2341] Added Clean up of files for...

2018-04-16 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2166#discussion_r181731317 --- Diff: integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/PreAggregateTestCase.scala

[GitHub] carbondata pull request #2172: [CARBONDATA-2333] Block insert overwrite if a...

2018-04-17 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2172#discussion_r182136155 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -73,18 +74,9

[GitHub] carbondata pull request #2172: [CARBONDATA-2333] Block insert overwrite if a...

2018-04-19 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2172#discussion_r182956717 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -73,18 +74,9

[GitHub] carbondata pull request #2215: [wip]add documentation for lucene datamap

2018-04-26 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2215#discussion_r184317255 --- Diff: docs/datamap/lucene-datamap-guide.md --- @@ -0,0 +1,180 @@ +# CarbonData Lucene DataMap + +* [Quick Example](#quick-example

[GitHub] carbondata pull request #2215: [wip]add documentation for lucene datamap

2018-04-26 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2215#discussion_r184316398 --- Diff: docs/datamap/lucene-datamap-guide.md --- @@ -0,0 +1,180 @@ +# CarbonData Lucene DataMap + +* [Quick Example](#quick-example

[GitHub] carbondata pull request #2215: [wip]add documentation for lucene datamap

2018-04-26 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2215#discussion_r184316832 --- Diff: docs/datamap/lucene-datamap-guide.md --- @@ -0,0 +1,180 @@ +# CarbonData Lucene DataMap + +* [Quick Example](#quick-example

[GitHub] carbondata pull request #2235: [WIP]Make default replication as 3 for direct...

2018-04-26 Thread KanakaKumar
GitHub user KanakaKumar opened a pull request: https://github.com/apache/carbondata/pull/2235 [WIP]Make default replication as 3 for direct write HDFS mode Problem: At present if we enable direct write on HDFS, data is written with replication of 1 which can

[GitHub] carbondata pull request #2243: [CARBONDATA-2410] Error message correction wh...

2018-04-30 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2243#discussion_r184991452 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala --- @@ -824,9 +824,11 @@ object

[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...

2018-04-30 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2243 @mohammadshahidkhan , can you please add details on why we have to change the exception parsing now.. Did we change univocity jar recently? ---

[GitHub] carbondata pull request #2215: [CARBONDATA-2206]add documentation for lucene...

2018-05-18 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2215#discussion_r189232106 --- Diff: docs/datamap/lucene-datamap-guide.md --- @@ -0,0 +1,133 @@ +# CarbonData Lucene DataMap --- End diff -- Please mark

[GitHub] carbondata issue #2215: [CARBONDATA-2206]add documentation for lucene datama...

2018-05-18 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2215 LGTM ---

[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

2018-05-28 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2347#discussion_r191310013 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -88,9 +90,18 @@ private Object

[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

2018-05-28 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2347#discussion_r191310300 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -177,13 +188,22 @@ private static Field prepareFields

[GitHub] carbondata pull request #2391: [HOTFIX][CARBONDATA-2625] Optimize the perfor...

2018-06-27 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2391#discussion_r198715511 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1744,6 +1744,28

[GitHub] carbondata pull request #2391: [HOTFIX][CARBONDATA-2625] Optimize the perfor...

2018-06-27 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2391#discussion_r198716005 --- Diff: integration/spark-common-cluster-test/src/test/scala/org/apache/spark/sql/common/util/QueryTest.scala --- @@ -45,6 +45,7 @@ class

[GitHub] carbondata pull request #2399: [HOTFIX][CARBONDATA-2629] Support SDK carbon ...

2018-06-27 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2399#discussion_r198716317 --- Diff: examples/spark2/src/main/java/org/apache/carbondata/examples/sdk/SDKS3Example.java --- @@ -60,13 +63,19 @@ public static void main

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-08 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r200842962 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -53,11 +60,75 @@ public int fillVector

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-08 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r200843282 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java --- @@ -359,38 +412,36 @@ public void

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-08 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r200843765 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -53,11 +60,75 @@ public int fillVector

[GitHub] carbondata issue #2498: [CARBONDATA-2729][file-format] Schema Compatibility ...

2018-07-12 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2498 LGTM ---

[GitHub] carbondata pull request #2498: [CARBONDATA-2729][file-format] Schema Compati...

2018-07-13 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2498#discussion_r202263586 --- Diff: core/pom.xml --- @@ -47,7 +47,7 @@ com.google.code.gson gson - 2.3.1 + 2.4 --- End

[GitHub] carbondata pull request #2504: [CARBONDATA-2740]flat folder handling for imp...

2018-07-13 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2504#discussion_r202329272 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonRelation.scala --- @@ -173,15 +172,38 @@ case class CarbonRelation

[GitHub] carbondata pull request #2466: [CARBONDATA-2710][Spark Integration] Refactor...

2018-07-15 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2466#discussion_r202576876 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala --- @@ -169,220 +128,45 @@ class

[GitHub] carbondata pull request #2484: [WIP] added hadoop conf to thread local

2018-07-15 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2484#discussion_r202580853 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java --- @@ -43,11 +45,19 @@ */ private static

[GitHub] carbondata pull request #2484: [WIP] added hadoop conf to thread local

2018-07-15 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2484#discussion_r202580900 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonConfiguration.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #2484: [WIP] added hadoop conf to thread local

2018-07-15 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2484#discussion_r202581713 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java --- @@ -43,11 +45,19 @@ */ private static

[GitHub] carbondata pull request #2484: [WIP] added hadoop conf to thread local

2018-07-15 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2484#discussion_r202582047 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/rdd/UpdateCoalescedRDD.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to

[GitHub] carbondata issue #2466: [CARBONDATA-2710][Spark Integration] Refactor Carbon...

2018-07-16 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2466 LGTM ---

[GitHub] carbondata pull request #2511: [CARBONDATA-2745] Added atomic file operation...

2018-07-16 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2511#discussion_r202905704 --- Diff: core/src/main/java/org/apache/carbondata/core/fileoperations/AtomicFileOperationFactory.java --- @@ -0,0 +1,31

[GitHub] carbondata pull request #2511: [CARBONDATA-2745] Added atomic file operation...

2018-07-16 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2511#discussion_r202906680 --- Diff: core/src/main/java/org/apache/carbondata/core/fileoperations/AtomicFileOperationS3Impl.java --- @@ -0,0 +1,53

[GitHub] carbondata pull request #2517: [CARBONDATA-2749][dataload] In HDFS Empty tab...

2018-07-18 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2517#discussion_r203411199 --- Diff: core/src/main/java/org/apache/carbondata/core/fileoperations/AtomicFileOperationsImpl.java --- @@ -70,12 +78,20 @@ public

[GitHub] carbondata pull request #2525: [CARBONDATA-2756] refactored code to use ZSTD...

2018-07-19 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2525#discussion_r203637393 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java --- @@ -293,7 +291,12 @@ public boolean delete

[GitHub] carbondata pull request #2517: [CARBONDATA-2749][dataload] In HDFS Empty tab...

2018-07-23 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2517#discussion_r204456375 --- Diff: core/src/main/java/org/apache/carbondata/core/fileoperations/AtomicFileOperationsImpl.java --- @@ -70,12 +78,20 @@ public

[GitHub] carbondata pull request #2517: [CARBONDATA-2749][dataload] In HDFS Empty tab...

2018-07-24 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2517#discussion_r204702468 --- Diff: core/src/main/java/org/apache/carbondata/core/fileoperations/AtomicFileOperationsImpl.java --- @@ -70,12 +78,20 @@ public

[GitHub] carbondata issue #2517: [CARBONDATA-2749][dataload] In HDFS Empty tablestatu...

2018-07-24 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2517 LGTM ---

[GitHub] carbondata issue #2511: [CARBONDATA-2745] Added atomic file operations for S...

2018-07-24 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2511 LGTM ---

[GitHub] carbondata issue #2553: [HOTFIX] Fixed random test failure

2018-07-27 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2553 LGTM ---

[GitHub] carbondata pull request #2570: [wip]disable local dictionary by default

2018-07-30 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2570#discussion_r206146016 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -929,7 +929,7 @@ /** * default

[GitHub] carbondata pull request #2571: [CARBONDATA-2792][schema restructure] Create ...

2018-07-30 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2571#discussion_r206152587 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateExternalTable.scala

[GitHub] carbondata issue #2571: [CARBONDATA-2792][schema restructure] Create externa...

2018-07-31 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2571 LGTM ---

[GitHub] carbondata issue #2570: [CARBONDATA-2585]disable local dictionary by default

2018-07-31 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2570 LGTM ---

[GitHub] carbondata pull request #2576: [CARBONDATA-2795] Add documentation for S3

2018-07-31 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2576#discussion_r206515601 --- Diff: docs/data-management-on-carbondata.md --- @@ -730,6 +736,8 @@ Users can specify which columns to include and exclude for local dictionary

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r207277549 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala --- @@ -378,19 +376,65

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r207278800 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -931,6 +931,17 @@ */ public

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r207280558 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -2987,8 +2987,12 @@ public static void

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

2018-08-02 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2605#discussion_r207280921 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -306,9 +306,12 @@ abstract class

[GitHub] carbondata pull request #2594: [CARBONDATA-2809][DataMap] Skip rebuilding fo...

2018-08-03 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2594#discussion_r207460748 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonDataMapRebuildCommand.scala --- @@ -48,7 +50,17

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r211922952 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java --- @@ -407,7 +407,7 @@ private void validateLockType

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r211927982 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r211928521 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala --- @@ -64,6 +65,7

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r211930856 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -435,14 +436,16 @@ class

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r211931833 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -435,14 +436,16 @@ class

[GitHub] carbondata pull request #2647: [CARBONDATA-2872] Added Spark FileFormat inte...

2018-08-23 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2647#discussion_r212305587 --- Diff: integration/spark-datasource/pom.xml --- @@ -0,0 +1,279 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] carbondata pull request #2647: [CARBONDATA-2872] Added Spark FileFormat inte...

2018-08-23 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2647#discussion_r212314571 --- Diff: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonSparkDataSourceUtil.scala

[GitHub] carbondata pull request #2647: [CARBONDATA-2872] Added Spark FileFormat inte...

2018-08-23 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2647#discussion_r212317536 --- Diff: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonSparkDataSourceUtil.scala

[GitHub] carbondata pull request #2647: [CARBONDATA-2872] Added Spark FileFormat inte...

2018-08-23 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2647#discussion_r212318460 --- Diff: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonSparkDataSourceUtil.scala

[GitHub] carbondata pull request #2647: [CARBONDATA-2872] Added Spark FileFormat inte...

2018-08-23 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2647#discussion_r212329045 --- Diff: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/SparkCarbonFileFormat.scala

[GitHub] carbondata pull request #2647: [CARBONDATA-2872] Added Spark FileFormat inte...

2018-08-23 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2647#discussion_r212333785 --- Diff: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/readsupport/SparkUnsafeRowReadSuport.scala

[GitHub] carbondata pull request #2666: [WIP] Fix double boundary condition and clear...

2018-08-28 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2666#discussion_r213330337 --- Diff: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/SparkCarbonFileFormat.scala

[GitHub] carbondata pull request #2666: [WIP] Fix double boundary condition and clear...

2018-08-28 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2666#discussion_r213334033 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java --- @@ -341,6 +348,18 @@ public TableDataMap getDataMap

[GitHub] carbondata issue #2666: [CARBONDATA-2898] Fix double boundary condition and ...

2018-08-29 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2666 LGTM ---

[GitHub] carbondata pull request #2652: [WIP] Supported Sort Scope for SDK

2018-08-30 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2652#discussion_r213970097 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -246,8 +246,8 @@ public CarbonWriterBuilder

[GitHub] carbondata pull request #2661: [CARBONDATA-2888] Support multi level subfold...

2018-08-31 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2661#discussion_r214273342 --- Diff: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonFileIndexReplaceRule.scala

[GitHub] carbondata pull request #2661: [CARBONDATA-2888] Support multi level subfold...

2018-09-04 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2661#discussion_r214899510 --- Diff: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonFileIndexReplaceRule.scala

[GitHub] carbondata issue #2661: [CARBONDATA-2888] Support multi level subfolder for ...

2018-09-04 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2661 LGTM ---

[GitHub] carbondata pull request #2694: [CARBONDATA-2876]AVRO datatype support throug...

2018-09-05 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2694#discussion_r215499485 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -445,17 +445,13 @@ private static Field prepareFields

[GitHub] carbondata issue #2685: [CARBONDATA-2910] Support backward compatability in ...

2018-09-07 Thread KanakaKumar
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2685 LGTM ---

[GitHub] carbondata pull request #2687: [CARBONDATA-2876]Fix Avro decimal datatype wi...

2018-09-07 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2687#discussion_r216122505 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable

[GitHub] carbondata pull request #2687: [CARBONDATA-2876]Fix Avro decimal datatype wi...

2018-09-07 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2687#discussion_r216122590 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -198,14 +199,35 @@ private Object avroFieldToObject

[GitHub] carbondata pull request #2687: [CARBONDATA-2876]Fix Avro decimal datatype wi...

2018-09-07 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2687#discussion_r216122672 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable

[GitHub] carbondata pull request #2687: [CARBONDATA-2876]Fix Avro decimal datatype wi...

2018-09-07 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2687#discussion_r216122724 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -218,9 +240,10 @@ private Object avroFieldToObject

[GitHub] carbondata pull request #2687: [CARBONDATA-2876]Fix Avro decimal datatype wi...

2018-09-08 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2687#discussion_r216123042 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable

[GitHub] carbondata pull request #2687: [CARBONDATA-2876]Fix Avro decimal datatype wi...

2018-09-08 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2687#discussion_r216123279 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -525,6 +559,11 @@ private static Field prepareFields

[GitHub] carbondata pull request #2687: [CARBONDATA-2876]Fix Avro decimal datatype wi...

2018-09-08 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2687#discussion_r216123287 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -621,6 +660,11 @@ private static StructField

[GitHub] carbondata pull request #2687: [CARBONDATA-2876]Fix Avro decimal datatype wi...

2018-09-08 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2687#discussion_r216123298 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -714,6 +758,11 @@ private static DataType

  1   2   3   >