[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700264#comment-16700264
]
Gilles commented on RNG-57:
---
bq. sorry for delayed reply.
No problem. Thank you for the thoughtful contribution.
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699486#comment-16699486
]
Alex D Herbert commented on RNG-57:
---
bq. Can we resolve this issue?
Yes.
(I have been away so sorry for
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697756#comment-16697756
]
Gilles commented on RNG-57:
---
No obvious regression was caused by implementing your proposal (cache). By
using all
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695893#comment-16695893
]
Alex D Herbert commented on RNG-57:
---
{quote}I'm not sure: What ensures that the previous implementation to
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695792#comment-16695792
]
Gilles commented on RNG-57:
---
bq. The LongProviders are slower due to the use of long bit shifts instead of
int.
I
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695743#comment-16695743
]
Alex D Herbert commented on RNG-57:
---
bq. I'm worried by the nextBoolean benchmark result
It seems to be as
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695468#comment-16695468
]
Gilles commented on RNG-57:
---
I'm worried by the {{nextBoolean}} benchmark result:
{noformat}
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694903#comment-16694903
]
Gilles commented on RNG-57:
---
bq. shade plugin \[...\] PR
Thanks.
bq. I can put in my scripts
Better different
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694881#comment-16694881
]
Alex D Herbert commented on RNG-57:
---
{quote}generating a JAR with all dependencies (from a different
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694802#comment-16694802
]
Gilles commented on RNG-57:
---
{quote}Surely you also have scripts
{quote}
Yes, but it's all semi-manual: generating
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694670#comment-16694670
]
Alex D Herbert commented on RNG-57:
---
{quote}we provide a robust script that will start "DieHarder" and
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694646#comment-16694646
]
Gilles commented on RNG-57:
---
{quote}I think that this may mislead a browser of the user guide that some of
the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694613#comment-16694613
]
Alex D Herbert commented on RNG-57:
---
{quote}I'll commit the new result files
{quote}
Done.
I see that
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694594#comment-16694594
]
Alex D Herbert commented on RNG-57:
---
{quote}How do you draw that conclusion?
{quote}
Because the number of
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693829#comment-16693829
]
Gilles commented on RNG-57:
---
bq. I'll commit the new result files
Done.
We should also update the benchmarks.
>
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693792#comment-16693792
]
ASF GitHub Bot commented on RNG-57:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693722#comment-16693722
]
Gilles commented on RNG-57:
---
bq. WELL_1024_A is wrong for BigCrush (the user guide states 4,6,5)
Typo indeed.
bq.
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691772#comment-16691772
]
Alex D Herbert commented on RNG-57:
---
I have the results of DieHarder and BigCrush for the {{LongProvider}}
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689751#comment-16689751
]
ASF GitHub Bot commented on RNG-57:
---
Github user coveralls commented on the issue:
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689734#comment-16689734
]
ASF GitHub Bot commented on RNG-57:
---
GitHub user aherbert opened a pull request:
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689582#comment-16689582
]
Alex D Herbert commented on RNG-57:
---
bq. Could the "shade" plugin config be shared for making it easy to
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689530#comment-16689530
]
Gilles commented on RNG-57:
---
bq. PR so they make running the \[stress\] tests easier.
Yes, please.
Could the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689506#comment-16689506
]
Gilles commented on RNG-57:
---
bq. Do you want a PR to see the changes?
Yes!
> CachedUniformRandomProvider for
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689499#comment-16689499
]
Alex D Herbert commented on RNG-57:
---
BigCrush
I manged to get this to work using:
{code:java}
> sudo
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689433#comment-16689433
]
Alex D Herbert commented on RNG-57:
---
Using RNG-60 I have made the same changes that previously failed and
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688914#comment-16688914
]
Gilles commented on RNG-57:
---
bq. Is there a guide for how to run DieHarder
There is a {{RandomStressTester}} Java
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688792#comment-16688792
]
Alex D Herbert commented on RNG-57:
---
A post to the commons developers list mentioned a release for v1.2
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643229#comment-16643229
]
Alex D Herbert commented on RNG-57:
---
bq. How would a single test detect which of the NumberFactory methods
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643160#comment-16643160
]
Gilles commented on RNG-57:
---
bq. The test suite should satisfy the aims
I'm fine with further consolidating the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643062#comment-16643062
]
Alex D Herbert commented on RNG-57:
---
bq. Did I understand correctly that you propose to
Yes.
The test
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642648#comment-16642648
]
Gilles commented on RNG-57:
---
bq. Apologies in advance for the long post.
A very interesting analysis (and a useful
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641910#comment-16641910
]
Alex D Herbert commented on RNG-57:
---
Apologies in advance for the long post. This stems from the desire to
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641739#comment-16641739
]
Gilles commented on RNG-57:
---
{quote}Because they are not all perfect.
{quote}
I was expecting the answer.
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641616#comment-16641616
]
Alex D Herbert commented on RNG-57:
---
bq. Why should the number of expected failures be different for each
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641535#comment-16641535
]
Gilles commented on RNG-57:
---
bq. what the failure rate would be for each
Why should the number of expected
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640891#comment-16640891
]
Alex D Herbert commented on RNG-57:
---
Having though about this the simulation can be modelled as a Binomial
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640855#comment-16640855
]
Alex D Herbert commented on RNG-57:
---
I've had a look at {{ProvidersCommonParametricTest}} and why this
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640723#comment-16640723
]
Gilles commented on RNG-57:
---
bq. I am wondering if the ProvidersList should make a better attempt at
creating a
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640722#comment-16640722
]
Alex D Herbert commented on RNG-57:
---
Wow that test is hard to get to pass.
I just tried this using a 1024
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640712#comment-16640712
]
Alex D Herbert commented on RNG-57:
---
I've closed the PR and repeated the changes in a new branch.
Do you
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640698#comment-16640698
]
ASF GitHub Bot commented on RNG-57:
---
Github user aherbert closed the pull request at:
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640697#comment-16640697
]
ASF GitHub Bot commented on RNG-57:
---
Github user aherbert commented on the issue:
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640486#comment-16640486
]
Gilles commented on RNG-57:
---
There are too many things in PR 11: it should only contain the additions to
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640379#comment-16640379
]
Alex D Herbert commented on RNG-57:
---
bq. Please rebase your changes on the current "master" (sorry).
Done.
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640375#comment-16640375
]
Alex D Herbert commented on RNG-57:
---
bq. IIRC, I did this to avoid a circular dependency between
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640372#comment-16640372
]
Gilles commented on RNG-57:
---
bq. shows that the parentState == null is never hit at the moment.
Indeed. I changed
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640369#comment-16640369
]
Gilles commented on RNG-57:
---
bq. Each RNG is built using a fixed seed
IIRC, I did this to avoid a circular
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640363#comment-16640363
]
Alex D Herbert commented on RNG-57:
---
I also noticed that {{BaseProvider}} returns an empty array in
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640357#comment-16640357
]
Gilles commented on RNG-57:
---
Please rebase your changes on the current "master" (sorry).
>
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640345#comment-16640345
]
Gilles commented on RNG-57:
---
bq. So parent should be first. It is also documented to work this way.
Actually not,
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640009#comment-16640009
]
ASF GitHub Bot commented on RNG-57:
---
Github user aherbert commented on the issue:
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1663#comment-1663
]
Alex D Herbert commented on RNG-57:
---
{quote}Please review the changes made for RNG-58.
{quote}
Nice
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639951#comment-16639951
]
Alex D Herbert commented on RNG-57:
---
{quote}No need to insert paragraph formatting tags (...) in the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639023#comment-16639023
]
Gilles commented on RNG-57:
---
Nit about PR 11: No need to insert paragraph formatting tags (...) in
the Javadoc; in
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638968#comment-16638968
]
Gilles commented on RNG-57:
---
bq. when master has moved on
Please review the changes made for RNG-58.
All tests
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637066#comment-16637066
]
Alex D Herbert commented on RNG-57:
---
{quote}Or let me the chance to implement the latter.{quote}
I was
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636981#comment-16636981
]
Gilles commented on RNG-57:
---
{quote}There are also a failures for
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636816#comment-16636816
]
ASF GitHub Bot commented on RNG-57:
---
Github user aherbert commented on the issue:
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636813#comment-16636813
]
Alex D Herbert commented on RNG-57:
---
The changes to implement the cache in {{IntProvider}} and
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636788#comment-16636788
]
ASF GitHub Bot commented on RNG-57:
---
GitHub user aherbert opened a pull request:
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636686#comment-16636686
]
Alex D Herbert commented on RNG-57:
---
After some more benchmarking I cannot categorically state that one
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636050#comment-16636050
]
Gilles commented on RNG-57:
---
{quote}I think it is necessary as the nextInt from the long provider only used
the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636051#comment-16636051
]
Gilles commented on RNG-57:
---
{quote}I think it is necessary as the nextInt from the long provider only used
the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635714#comment-16635714
]
Alex D Herbert commented on RNG-57:
---
{quote}Perhaps add a table for "nextBoolean()"{quote}
Updating the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635531#comment-16635531
]
Gilles commented on RNG-57:
---
bq. I was referring to updating the User Guide by rerunning the benchmark.
So did I.
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634698#comment-16634698
]
Alex D Herbert commented on RNG-57:
---
{quote}The benchmarking code is in class GenerationPerformance in
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634651#comment-16634651
]
Gilles commented on RNG-57:
---
bq. This is an internal class. It implements the private interface
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633915#comment-16633915
]
Alex D Herbert commented on RNG-57:
---
{quote}I'm not sure whether it is your intended contribution to the
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633328#comment-16633328
]
Gilles commented on RNG-57:
---
About this:
{code}
static final class CachedLongProvider extends LongProvider
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631801#comment-16631801
]
Alex D Herbert commented on RNG-57:
---
I tried a large benchmark using 100 runs in JMH.
The results for
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630299#comment-16630299
]
Alex D Herbert commented on RNG-57:
---
{quote}So I'm going to test a version that uses int bit masking for
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627396#comment-16627396
]
Alex D Herbert commented on RNG-57:
---
{quote}I don't understand the purpose of a CachedUniformRandomProvider
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627283#comment-16627283
]
Gilles commented on RNG-57:
---
Nice results!
Concerning the design partially shown, I don't understand the purpose
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627255#comment-16627255
]
Alex D Herbert commented on RNG-57:
---
For reference this is what I tried:
{code:java}
/**
* Wrap an
[
https://issues.apache.org/jira/browse/RNG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627234#comment-16627234
]
Alex D Herbert commented on RNG-57:
---
Tried a first attempt at this. It is proving quite a challenge to
75 matches
Mail list logo
