[GitHub] flink issue #2298: [FLINK-4247] [table] CsvTableSource.getDataSet() expects ...

2016-09-20 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2298 Do we agree to stick with the current implementation? If yes, let's close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-4247) CsvTableSource.getDataSet() expects Java ExecutionEnvironment

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505911#comment-15505911 ] ASF GitHub Bot commented on FLINK-4247: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-4247) CsvTableSource.getDataSet() expects Java ExecutionEnvironment

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505919#comment-15505919 ] ASF GitHub Bot commented on FLINK-4247: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2298: [FLINK-4247] [table] CsvTableSource.getDataSet() expects ...

2016-09-20 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2298 I think adding some comments the methods doesn't hurt. I would merge this PR as it is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-4624) Gelly's summarization algorithm cannot deal with null vertex group values

2016-09-20 Thread Martin Junghanns (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505926#comment-15505926 ] Martin Junghanns commented on FLINK-4624: - You were right, I had a private member

[jira] [Created] (FLINK-4639) Make Calcite features more pluggable

2016-09-20 Thread Timo Walther (JIRA)
Timo Walther created FLINK-4639: --- Summary: Make Calcite features more pluggable Key: FLINK-4639 URL: https://issues.apache.org/jira/browse/FLINK-4639 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-4624) Gelly's summarization algorithm cannot deal with null vertex group values

2016-09-20 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505982#comment-15505982 ] Fabian Hueske commented on FLINK-4624: -- {{VertexGroupItem}} extends {{Tuple4, Long>}}

[jira] [Commented] (FLINK-3734) Unclosed DataInputView in AbstractAlignedProcessingTimeWindowOperator#restoreState()

2016-09-20 Thread Liwei Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506029#comment-15506029 ] Liwei Lin commented on FLINK-3734: -- Hi [~tedyu] do you plan to fix this? In case you don'

[jira] [Commented] (FLINK-4573) Potential resource leak due to unclosed RandomAccessFile in TaskManagerLogHandler

2016-09-20 Thread Liwei Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506033#comment-15506033 ] Liwei Lin commented on FLINK-4573: -- Hi [~tedyu] do you plan to fix this? In case you don'

[jira] [Commented] (FLINK-3222) Incorrect shift amount in OperatorCheckpointStats#hashCode()

2016-09-20 Thread Liwei Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506035#comment-15506035 ] Liwei Lin commented on FLINK-3222: -- Hi [~tedyu] do you plan to fix this? In case you don'

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2016-09-20 Thread Liwei Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506034#comment-15506034 ] Liwei Lin commented on FLINK-4534: -- Hi [~tedyu] do you plan to fix this? In case you don'

[jira] [Commented] (FLINK-4533) Unprotected access to meters in StatsDReporter#report()

2016-09-20 Thread Liwei Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506038#comment-15506038 ] Liwei Lin commented on FLINK-4533: -- Hi [~tedyu] do you plan to fix this? In case you don'

[GitHub] flink issue #2337: [FLINK-3042] [FLINK-3060] [types] Define a way to let typ...

2016-09-20 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2337 I have added some documentation for type factories. If there are no objections, I will merge this later today. --- If your project is set up for it, you can reply to this email and have your reply a

[jira] [Commented] (FLINK-3042) Define a way to let types create their own TypeInformation

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506044#comment-15506044 ] ASF GitHub Bot commented on FLINK-3042: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-4557) Table API Stream Aggregations

2016-09-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506053#comment-15506053 ] Timo Walther commented on FLINK-4557: - [~shijinkui] I will create issues for the subta

[jira] [Assigned] (FLINK-4639) Make Calcite features more pluggable

2016-09-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-4639: --- Assignee: Timo Walther > Make Calcite features more pluggable > -

[jira] [Commented] (FLINK-4533) Unprotected access to meters in StatsDReporter#report()

2016-09-20 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506074#comment-15506074 ] Chesnay Schepler commented on FLINK-4533: - we intentionally don't protect the acce

[GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...

2016-09-20 Thread mxm
Github user mxm closed the pull request at: https://github.com/apache/flink/pull/2463 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] flink issue #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allocation ...

2016-09-20 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2463 Merged to continue development in other places. Thanks for the comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506080#comment-15506080 ] ASF GitHub Bot commented on FLINK-4538: --- Github user mxm commented on the issue:

[jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506081#comment-15506081 ] ASF GitHub Bot commented on FLINK-4538: --- Github user mxm closed the pull request at:

[jira] [Commented] (FLINK-4624) Gelly's summarization algorithm cannot deal with null vertex group values

2016-09-20 Thread Martin Junghanns (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506100#comment-15506100 ] Martin Junghanns commented on FLINK-4624: - Thanks for the explanation. As I need {

[jira] [Updated] (FLINK-4520) Integrate Siddhi as a lightweight CEP Library

2016-09-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-4520: - Assignee: Hao Chen > Integrate Siddhi as a lightweight CEP Library > -

[GitHub] flink pull request #2472: [FLINK-4361] Introduce Flink's own future abstract...

2016-09-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2472#discussion_r79565763 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkCompletableFuture.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[jira] [Commented] (FLINK-4361) Introduce Flink's own future abstraction

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506106#comment-15506106 ] ASF GitHub Bot commented on FLINK-4361: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4361) Introduce Flink's own future abstraction

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506109#comment-15506109 ] ASF GitHub Bot commented on FLINK-4361: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2472: [FLINK-4361] Introduce Flink's own future abstract...

2016-09-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2472#discussion_r79565983 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkCompletableFuture.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[jira] [Commented] (FLINK-4361) Introduce Flink's own future abstraction

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506113#comment-15506113 ] ASF GitHub Bot commented on FLINK-4361: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2472: [FLINK-4361] Introduce Flink's own future abstraction

2016-09-20 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2472 Thanks for your review @KurtYoung. Will address your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[jira] [Created] (FLINK-4640) Serialization of the initialValue of a Fold on WindowedStream fails

2016-09-20 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-4640: Summary: Serialization of the initialValue of a Fold on WindowedStream fails Key: FLINK-4640 URL: https://issues.apache.org/jira/browse/FLINK-4640 Project: Flink

[jira] [Updated] (FLINK-4640) Serialization of the initialValue of a Fold on WindowedStream fails

2016-09-20 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-4640: - Description: The following program {code} DataStream> src = env.fromElements(new Tuple2("a", 1L))

[GitHub] flink issue #2298: [FLINK-4247] [table] CsvTableSource.getDataSet() expects ...

2016-09-20 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2298 Agreed @twalthr. IMO, +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[jira] [Commented] (FLINK-4247) CsvTableSource.getDataSet() expects Java ExecutionEnvironment

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506162#comment-15506162 ] ASF GitHub Bot commented on FLINK-4247: --- Github user fhueske commented on the issue:

[jira] [Updated] (FLINK-4640) Serialization of the initialValue of a Fold on WindowedStream fails

2016-09-20 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-4640: Priority: Blocker (was: Critical) > Serialization of the initialValue of a Fold on Windowed

[GitHub] flink pull request #2516: [FLINK-4563] [metrics] Delimiter should be configu...

2016-09-20 Thread ex00
GitHub user ex00 opened a pull request: https://github.com/apache/flink/pull/2516 [FLINK-4563] [metrics] Delimiter should be configured per reporter Hi It is my fix FLINK-4563. I want fix this issue, please send me your comments about this implementation. I could assign to m

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506191#comment-15506191 ] ASF GitHub Bot commented on FLINK-4563: --- GitHub user ex00 opened a pull request:

[jira] [Commented] (FLINK-4268) Add a parsers for BigDecimal/BigInteger

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506206#comment-15506206 ] ASF GitHub Bot commented on FLINK-4268: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4268) Add a parsers for BigDecimal/BigInteger

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506207#comment-15506207 ] ASF GitHub Bot commented on FLINK-4268: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2304: [FLINK-4268] [core] Add parsers for BigDecimal/Big...

2016-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2304#discussion_r79573034 --- Diff: flink-core/src/main/java/org/apache/flink/types/parser/BigDecParser.java --- @@ -120,7 +132,14 @@ public static final BigDecimal parseField(byte[]

[GitHub] flink pull request #2304: [FLINK-4268] [core] Add parsers for BigDecimal/Big...

2016-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2304#discussion_r79572080 --- Diff: flink-core/src/main/java/org/apache/flink/types/parser/BigDecParser.java --- @@ -55,9 +56,20 @@ public int parseField(byte[] bytes, int startPos, in

[GitHub] flink pull request #2304: [FLINK-4268] [core] Add parsers for BigDecimal/Big...

2016-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2304#discussion_r79572690 --- Diff: flink-core/src/main/java/org/apache/flink/types/parser/BigDecParser.java --- @@ -55,9 +56,20 @@ public int parseField(byte[] bytes, int startPos, in

[jira] [Commented] (FLINK-4268) Add a parsers for BigDecimal/BigInteger

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506205#comment-15506205 ] ASF GitHub Bot commented on FLINK-4268: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4624) Gelly's summarization algorithm cannot deal with null vertex group values

2016-09-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506211#comment-15506211 ] Timo Walther commented on FLINK-4624: - You can get rid of the {{ClassCastException}} b

[GitHub] flink issue #2516: [FLINK-4564] [metrics] Delimiter should be configured per...

2016-09-20 Thread ex00
Github user ex00 commented on the issue: https://github.com/apache/flink/pull/2516 Sorry. I made a mistake. In comment for commit I writed error of issue number. This PR for issue FLINK-4564 --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-4564) [metrics] Delimiter should be configured per reporter

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506231#comment-15506231 ] ASF GitHub Bot commented on FLINK-4564: --- Github user ex00 commented on the issue:

[GitHub] flink pull request #2516: [FLINK-4564] [metrics] Delimiter should be configu...

2016-09-20 Thread ex00
Github user ex00 closed the pull request at: https://github.com/apache/flink/pull/2516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[jira] [Commented] (FLINK-4564) [metrics] Delimiter should be configured per reporter

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506248#comment-15506248 ] ASF GitHub Bot commented on FLINK-4564: --- Github user ex00 closed the pull request at

[GitHub] flink pull request #2517: [FLINK-4564] [metrics] Delimiter should be configu...

2016-09-20 Thread ex00
GitHub user ex00 opened a pull request: https://github.com/apache/flink/pull/2517 [FLINK-4564] [metrics] Delimiter should be configured per reporter Hi It is my fix FLINK-4564. I want fix this issue, please send me your comments about this implementation. I could assign to m

[GitHub] flink pull request #2303: [FLINK-4248] [core] [table] CsvTableSource does no...

2016-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2303#discussion_r79579583 --- Diff: flink-core/src/test/java/org/apache/flink/types/parser/SqlTimeParserTest.java --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software

[GitHub] flink issue #2490: [FLINK-4609] Remove redundant check for null in CrossOper...

2016-09-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2490 All right, +1 then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2452: [Flink-4450] add a new module "flink-apache-storm" to sup...

2016-09-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2452 Agreed, let's proceed with #2439. Sorry for the back and forth, but these things are important to discuss so that everyone is on board and we make a good decision. --- If your project is set up

[GitHub] flink pull request #2513: [hotfix] RescalingITCase

2016-09-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2513#discussion_r79598970 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescalingITCase.java --- @@ -670,12 +676,15 @@ public void run(SourceContext ctx

[GitHub] flink pull request #2472: [FLINK-4361] Introduce Flink's own future abstract...

2016-09-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2472#discussion_r79599026 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/Future.java --- @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Commented] (FLINK-4361) Introduce Flink's own future abstraction

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506417#comment-15506417 ] ASF GitHub Bot commented on FLINK-4361: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2472: [FLINK-4361] Introduce Flink's own future abstract...

2016-09-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2472#discussion_r79597647 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/Future.java --- @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Commented] (FLINK-4361) Introduce Flink's own future abstraction

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506416#comment-15506416 ] ASF GitHub Bot commented on FLINK-4361: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2519: [docs] Small improvements to the docs.

2016-09-20 Thread alpinegizmo
GitHub user alpinegizmo opened a pull request: https://github.com/apache/flink/pull/2519 [docs] Small improvements to the docs. This pull request only affects documentation -- fixing small mistakes and improving awkward phrases. You can merge this pull request into a Git repository

[GitHub] flink issue #640: [scheduling] implement backtracking of intermediate result...

2016-09-20 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/640 While this may provide some help for future implementations, the code is outdated and needs an overhaul. Closing for now. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] flink pull request #640: [scheduling] implement backtracking of intermediate...

2016-09-20 Thread mxm
Github user mxm closed the pull request at: https://github.com/apache/flink/pull/640 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] flink issue #2517: [FLINK-4564] [metrics] Delimiter should be configured per...

2016-09-20 Thread ex00
Github user ex00 commented on the issue: https://github.com/apache/flink/pull/2517 Thanks zentol! > Something i thought of was to create a "front" metric group for every reporter that is aware of this index. Do you mean new MetricGroup implementation with name like

[jira] [Commented] (FLINK-4564) [metrics] Delimiter should be configured per reporter

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506441#comment-15506441 ] ASF GitHub Bot commented on FLINK-4564: --- Github user ex00 commented on the issue:

[jira] [Updated] (FLINK-4641) Support branching CEP patterns

2016-09-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-4641: - Description: We should add support for branching CEP patterns to the Pattern API. {code} |-

[jira] [Created] (FLINK-4641) Support branching CEP patterns

2016-09-20 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4641: Summary: Support branching CEP patterns Key: FLINK-4641 URL: https://issues.apache.org/jira/browse/FLINK-4641 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-4641) Support branching CEP patterns

2016-09-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-4641: - Description: We should add support for branching CEP patterns to the Pattern API. {code} |--

[jira] [Updated] (FLINK-4641) Support branching CEP patterns

2016-09-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-4641: - Description: We should add support for branching CEP patterns to the Pattern API. {code} |-

[jira] [Commented] (FLINK-3921) StringParser not specifying encoding to use

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506458#comment-15506458 ] ASF GitHub Bot commented on FLINK-3921: --- Github user greghogan commented on the issu

[GitHub] flink issue #2060: [FLINK-3921] StringParser encoding

2016-09-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2060 Apologies for the long delay. I'd like to attempt to summarize this ticket and pull request to validate my understanding. Previously StringParser was using the system encoding and `Generic

[GitHub] flink issue #2434: [FLINK-4496] Refactor the TimeServiceProvider to take a T...

2016-09-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2434 R: @mxm @aljoscha @rmetzger This is ready for review. Thanks a lot for the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[jira] [Commented] (FLINK-4496) Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506466#comment-15506466 ] ASF GitHub Bot commented on FLINK-4496: --- Github user kl0u commented on the issue:

[GitHub] flink issue #2515: [FLINK-4638] [core] Fix exception message for MemorySegme...

2016-09-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2515 Thanks for reporting and fixing! Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] flink issue #2490: [FLINK-4609] Remove redundant check for null in CrossOper...

2016-09-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2490 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[jira] [Commented] (FLINK-4609) Remove redundant check for null in CrossOperator

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506479#comment-15506479 ] ASF GitHub Bot commented on FLINK-4609: --- Github user greghogan commented on the issu

[jira] [Commented] (FLINK-4638) Fix exception message for MemorySegment

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506478#comment-15506478 ] ASF GitHub Bot commented on FLINK-4638: --- Github user greghogan commented on the issu

[GitHub] flink issue #2517: [FLINK-4564] [metrics] Delimiter should be configured per...

2016-09-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2517 Currently, when a metric is registered the reporter also receives the group it was registered on as an argument. Since this group is shared by all reporters we can't do any tricks in them to be report

[jira] [Commented] (FLINK-4564) [metrics] Delimiter should be configured per reporter

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506516#comment-15506516 ] ASF GitHub Bot commented on FLINK-4564: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-4624) Gelly's summarization algorithm cannot deal with null vertex group values

2016-09-20 Thread Martin Junghanns (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506539#comment-15506539 ] Martin Junghanns commented on FLINK-4624: - Yes, I looked into the two constructors

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2016-09-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506583#comment-15506583 ] Ted Yu commented on FLINK-4534: --- Feel free to work on this. > Lack of synchronization in Bu

[jira] [Commented] (FLINK-3222) Incorrect shift amount in OperatorCheckpointStats#hashCode()

2016-09-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506581#comment-15506581 ] Ted Yu commented on FLINK-3222: --- Feel free to work on this. > Incorrect shift amount in Ope

[jira] [Commented] (FLINK-3734) Unclosed DataInputView in AbstractAlignedProcessingTimeWindowOperator#restoreState()

2016-09-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506585#comment-15506585 ] Ted Yu commented on FLINK-3734: --- Feel free to work on this. > Unclosed DataInputView in >

[GitHub] flink pull request #2520: Jira 4530

2016-09-20 Thread zhuhaifengleon
GitHub user zhuhaifengleon opened a pull request: https://github.com/apache/flink/pull/2520 Jira 4530 This PR implement a more generalized and reusable RPC connection components. It encapsulates the RPC connection management and pulling out the strong dependency on the 'TaskExecuto

[jira] [Commented] (FLINK-4533) Unprotected access to meters in StatsDReporter#report()

2016-09-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506596#comment-15506596 ] Ted Yu commented on FLINK-4533: --- Adding a comment in code to the above effect would be nice.

[jira] [Commented] (FLINK-4573) Potential resource leak due to unclosed RandomAccessFile in TaskManagerLogHandler

2016-09-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506590#comment-15506590 ] Ted Yu commented on FLINK-4573: --- Feel free to work on this. > Potential resource leak due t

[GitHub] flink pull request #2521: [FLINK-4639] [table] Make Calcite features more pl...

2016-09-20 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2521 [FLINK-4639] [table] Make Calcite features more pluggable Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If

[jira] [Commented] (FLINK-4639) Make Calcite features more pluggable

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506607#comment-15506607 ] ASF GitHub Bot commented on FLINK-4639: --- GitHub user twalthr opened a pull request:

[GitHub] flink issue #2514: [FLINK-4555] add test case to test Yarn cluster shutdown

2016-09-20 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2514 Actually, I have written a much better test case for this some time ago, see https://github.com/apache/flink/blob/142912b031df42d2abe43b41e98be5596cb3a7f9/flink-runtime/src/test/java/org/apache/flink/run

[jira] [Commented] (FLINK-4555) Explicitly kill TaskManager on YARN when ApplicationMaster is shutting down

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506586#comment-15506586 ] ASF GitHub Bot commented on FLINK-4555: --- Github user mxm commented on the issue:

[jira] [Commented] (FLINK-3222) Incorrect shift amount in OperatorCheckpointStats#hashCode()

2016-09-20 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506636#comment-15506636 ] Greg Hogan commented on FLINK-3222: --- This isn't a bug and the compiler should optimize a

[jira] [Commented] (FLINK-4247) CsvTableSource.getDataSet() expects Java ExecutionEnvironment

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506648#comment-15506648 ] ASF GitHub Bot commented on FLINK-4247: --- Github user asfgit closed the pull request

[GitHub] flink pull request #2298: [FLINK-4247] [table] CsvTableSource.getDataSet() e...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (FLINK-4247) CsvTableSource.getDataSet() expects Java ExecutionEnvironment

2016-09-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4247. - Resolution: Fixed Assignee: Timo Walther Fix Version/s: 1.2.0 Fixed in 0975d9f11dc

[jira] [Assigned] (FLINK-4301) Parameterize Flink version in Quickstart bash script

2016-09-20 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Robutti reassigned FLINK-4301: - Assignee: Simone Robutti > Parameterize Flink version in Quickstart bash script > ---

[GitHub] flink pull request #2469: [FLINK-4572] [gelly] Convert to negative in LongVa...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2515: [FLINK-4638] [core] Fix exception message for Memo...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2481: [FLINK-4594] [core] Validate lower bound in MathUt...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4609) Remove redundant check for null in CrossOperator

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506669#comment-15506669 ] ASF GitHub Bot commented on FLINK-4609: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-4594) Validate lower bound in MathUtils.checkedDownCast

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1550#comment-1550 ] ASF GitHub Bot commented on FLINK-4594: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-4572) Convert to negative in LongValueToIntValue

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506667#comment-15506667 ] ASF GitHub Bot commented on FLINK-4572: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-4572) Convert to negative in LongValueToIntValue

2016-09-20 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-4572. - Resolution: Fixed Fixed in e58fd6e001b319aa7325a0544735f8c0680141d8 > Convert to negative in LongValueToI

[jira] [Updated] (FLINK-4609) Remove redundant check for null in CrossOperator

2016-09-20 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-4609: -- Fix Version/s: 1.2.0 > Remove redundant check for null in CrossOperator > --

  1   2   3   >