[jira] [Commented] (FLINK-5524) Support early out for code generated conjunctive conditions

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1587#comment-1587 ] ASF GitHub Bot commented on FLINK-5524: --- Github user twalthr commented on a diff in the pull

[GitHub] flink issue #3107: [FLINK-5441] [table] Directly allow SQL queries on a Tabl...

2017-02-22 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/3107 @twalthr do you mean register table in his `toString` method ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #3107: [FLINK-5441] [table] Directly allow SQL queries on a Tabl...

2017-02-22 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3107 It's for this reason that I think that Flink needs a "source catalog" somewhere.. On 22 February 2017 at 09:35, twalthr wrote: > We don't have to

[jira] [Commented] (FLINK-5441) Directly allow SQL queries on a Table

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877785#comment-15877785 ] ASF GitHub Bot commented on FLINK-5441: --- Github user fpompermaier commented on the issue:

[GitHub] flink issue #3107: [FLINK-5441] [table] Directly allow SQL queries on a Tabl...

2017-02-22 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3107 An external catalog would not help in this case. It's actually quite the opposite. The issue is to run a SQL query on an ad-hoc table without the need to explicitly add it to a catalog. --- If

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
GitHub user hongyuhong opened a pull request: https://github.com/apache/flink/pull/3386 [FLINK-5658][table] support unbounded eventtime over window 1. Add LogicalOverWindow extends calcite Window with attribute isEventtime 2. Add LogicalWindowRule to convert calcite

[GitHub] flink issue #3107: [FLINK-5441] [table] Directly allow SQL queries on a Tabl...

2017-02-22 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3107 @wuchong if `toString` is called for the first time. It calls `tEnv.registerTableInternal(this)` which uses an atomic counter and generates a unique identifier such as `UnnamedTable$232`. This

[jira] [Commented] (FLINK-5710) Add ProcTime() function to indicate StreamSQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1582#comment-1582 ] ASF GitHub Bot commented on FLINK-5710: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-5441) Directly allow SQL queries on a Table

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877792#comment-15877792 ] ASF GitHub Bot commented on FLINK-5441: --- Github user fhueske commented on the issue:

[GitHub] flink pull request #3372: [FLINK-5524] [table] Support early out for code ge...

2017-02-22 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3372#discussion_r102407744 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/CalcITCase.scala --- @@ -217,6 +217,21 @@ class

[jira] [Commented] (FLINK-5441) Directly allow SQL queries on a Table

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1589#comment-1589 ] ASF GitHub Bot commented on FLINK-5441: --- Github user wuchong commented on the issue:

[GitHub] flink issue #3107: [FLINK-5441] [table] Directly allow SQL queries on a Tabl...

2017-02-22 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3107 We don't have to intercept inline string arguments. We just have to make sure that `Table.toString()` returns an unique identifier that the method previously registered in it's table environment.

[GitHub] flink issue #3302: [FLINK-5710] Add ProcTime() function to indicate StreamSQ...

2017-02-22 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3302 That would be great @huawei-flink! There are a few contributions waiting for this addition. Thank you! --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-5441) Directly allow SQL queries on a Table

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1581#comment-1581 ] ASF GitHub Bot commented on FLINK-5441: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877800#comment-15877800 ] ASF GitHub Bot commented on FLINK-5658: --- GitHub user hongyuhong opened a pull request:

[jira] [Commented] (FLINK-5441) Directly allow SQL queries on a Table

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877802#comment-15877802 ] ASF GitHub Bot commented on FLINK-5441: --- Github user twalthr commented on the issue:

[GitHub] flink pull request #3388: [FLINK-5815] Add resource files configuration for ...

2017-02-22 Thread wenlong88
GitHub user wenlong88 opened a pull request: https://github.com/apache/flink/pull/3388 [FLINK-5815] Add resource files configuration for Yarn Mode This PR add three common resource configuration options to yarn mode, which allow user to set single file resource from both local

[jira] [Commented] (FLINK-5815) Add resource files configuration for Yarn Mode

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877859#comment-15877859 ] ASF GitHub Bot commented on FLINK-5815: --- GitHub user wenlong88 opened a pull request:

[jira] [Commented] (FLINK-5524) Support early out for code generated conjunctive conditions

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877882#comment-15877882 ] ASF GitHub Bot commented on FLINK-5524: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3372: [FLINK-5524] [table] Support early out for code ge...

2017-02-22 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3372#discussion_r102421601 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/CalcITCase.scala --- @@ -217,6 +217,21 @@ class

[jira] [Commented] (FLINK-5865) Throw original exception in states

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877965#comment-15877965 ] ASF GitHub Bot commented on FLINK-5865: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3380: [FLINK-5865][state] Throw original exception in the state...

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3380 I think it is a good idea to avoid exception wrapping where ever possible, so +1 to that. I was wondering if we can improve exception handling even further for the state abstraction,

[jira] [Commented] (FLINK-5692) Add an Option to Deactivate Kryo Fallback for Serializers

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877970#comment-15877970 ] ASF GitHub Bot commented on FLINK-5692: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-5854) Introduce some Flink-specific base Exception types

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877972#comment-15877972 ] ASF GitHub Bot commented on FLINK-5854: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #3368: [FLINK-5854] [core] Add base Flink Exception class...

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3368#discussion_r102431100 --- Diff: flink-core/src/main/java/org/apache/flink/util/DynamicCodeLoadingException.java --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache

[GitHub] flink issue #3368: [FLINK-5854] [core] Add base Flink Exception classes

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3368 Any reservations against merging this after addressing the comments above? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-5830) OutOfMemoryError during notify final state in TaskExecutor may cause job stuck

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877984#comment-15877984 ] ASF GitHub Bot commented on FLINK-5830: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5763) Make savepoints self-contained and relocatable

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878016#comment-15878016 ] ASF GitHub Bot commented on FLINK-5763: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3345: [FLINK-5763] [checkpoints] Minor meta data refactorings

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3345 Very good change! Looked through it, nothing to complain about ;-) Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-5863) Unify the serialization of queryable list states in different backends

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878019#comment-15878019 ] ASF GitHub Bot commented on FLINK-5863: --- Github user uce commented on the issue:

[GitHub] flink issue #3387: [FLINK-5863][queryable state] Add the serialization of li...

2017-02-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3387 If I understand this correctly, this gets rid of duplicated code. I think this is in general very valuable, but the problem is queryable state right now is that we need to refactor this for 1.3 anyways.

[GitHub] flink issue #3360: [FLINK-5830][Distributed Coordination] Handle OutOfMemory...

2017-02-22 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3360 Thanks for the clarification @zhijiangW. I know understand the problem that we effectively introduce via `RpcEndpoint.runAsync` another message which might get "lost" (e.g. due to OOM

[jira] [Commented] (FLINK-5863) Unify the serialization of queryable list states in different backends

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878034#comment-15878034 ] ASF GitHub Bot commented on FLINK-5863: --- Github user shixiaogang commented on the issue:

[GitHub] flink pull request #3387: [FLINK-5863][queryable state] Add the serializatio...

2017-02-22 Thread shixiaogang
Github user shixiaogang closed the pull request at: https://github.com/apache/flink/pull/3387 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #3387: [FLINK-5863][queryable state] Add the serialization of li...

2017-02-22 Thread shixiaogang
Github user shixiaogang commented on the issue: https://github.com/apache/flink/pull/3387 The PR is just some cleaning of the code. Now that we are planning to refactor the implementation, I agree to close the PR and I am very willing to contribute to the FLIP. --- If your project

[jira] [Commented] (FLINK-5863) Unify the serialization of queryable list states in different backends

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878035#comment-15878035 ] ASF GitHub Bot commented on FLINK-5863: --- Github user shixiaogang closed the pull request at:

[jira] [Commented] (FLINK-5546) java.io.tmpdir setted as project build directory in surefire plugin

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877907#comment-15877907 ] ASF GitHub Bot commented on FLINK-5546: --- Github user StephanEwen commented on the issue:

[jira] [Created] (FLINK-5880) Add documentation for object reuse for DataStream API

2017-02-22 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5880: --- Summary: Add documentation for object reuse for DataStream API Key: FLINK-5880 URL: https://issues.apache.org/jira/browse/FLINK-5880 Project: Flink

[jira] [Commented] (FLINK-4856) Add MapState for keyed streams

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877936#comment-15877936 ] ASF GitHub Bot commented on FLINK-4856: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #3336: [FLINK-4856][state] Add MapState in KeyedState

2017-02-22 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3336 I had to very minor comments about typos in Javadoc. Otherwise this looks very good now, @shixiaogang 👍 @StefanRRichter Could you please go ahead and merge when you are satisfied with

[jira] [Commented] (FLINK-4422) Convert all time interval measurements to System.nanoTime()

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877941#comment-15877941 ] ASF GitHub Bot commented on FLINK-4422: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #3384: [FLINK-4422] Convert all time interval measurement...

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3384#discussion_r102428106 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientConnectionTest.java --- @@ -115,13 +115,13 @@ public void run() {

[jira] [Updated] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-02-22 Thread Zhuoluo Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoluo Yang updated FLINK-5881: Summary: ScalarFunction(UDF) should support variable types and variable arguments (was: Scalar

[jira] [Created] (FLINK-5881) Scalar should support variable types and variable arguments

2017-02-22 Thread Zhuoluo Yang (JIRA)
Zhuoluo Yang created FLINK-5881: --- Summary: Scalar should support variable types and variable arguments Key: FLINK-5881 URL: https://issues.apache.org/jira/browse/FLINK-5881 Project: Flink

[GitHub] flink issue #3360: [FLINK-5830][Distributed Coordination] Handle OutOfMemory...

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3360 Looking at this from another angle: If any Runnable that is scheduled ever lets an exception bubble out, can we still assume that the JobManager is in a sane state? Or should be actually make

[GitHub] flink issue #3336: [FLINK-4856][state] Add MapState in KeyedState

2017-02-22 Thread shixiaogang
Github user shixiaogang commented on the issue: https://github.com/apache/flink/pull/3336 @aljoscha Thanks a lot for your hard work. I have fixed the typos in the documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-4856) Add MapState for keyed streams

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877982#comment-15877982 ] ASF GitHub Bot commented on FLINK-4856: --- Github user shixiaogang commented on the issue:

[jira] [Commented] (FLINK-5863) Unify the serialization of queryable list states in different backends

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877854#comment-15877854 ] ASF GitHub Bot commented on FLINK-5863: --- GitHub user shixiaogang opened a pull request:

[GitHub] flink pull request #3387: [FLINK-5863][queryable state] Add the serializatio...

2017-02-22 Thread shixiaogang
GitHub user shixiaogang opened a pull request: https://github.com/apache/flink/pull/3387 [FLINK-5863][queryable state] Add the serialization of list states in KvStateRequestSerializer 1. Add `serializeList()` in `KvStateRequestSerialization` 2. Modify the unit tests of

[jira] [Commented] (FLINK-5854) Introduce some Flink-specific base Exception types

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877977#comment-15877977 ] ASF GitHub Bot commented on FLINK-5854: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5854) Introduce some Flink-specific base Exception types

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877975#comment-15877975 ] ASF GitHub Bot commented on FLINK-5854: --- Github user StephanEwen commented on a diff in the pull

[jira] [Updated] (FLINK-5879) ExecutionAttemptID should invoke super() in constructor

2017-02-22 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu updated FLINK-5879: Component/s: Core > ExecutionAttemptID should invoke super() in constructor >

[GitHub] flink issue #3348: [FLINK-5090] [network] Add metrics for details about inbo...

2017-02-22 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3348 The metrics documentation must be update to contain the new metrics. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #3336: [FLINK-4856][state] Add MapState in KeyedState

2017-02-22 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3336#discussion_r102426841 --- Diff: docs/dev/stream/state.md --- @@ -118,6 +118,11 @@ added to the state. Contrary to `ReducingState`, the aggregate type may be diffe of

[jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877929#comment-15877929 ] ASF GitHub Bot commented on FLINK-5090: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-5546) java.io.tmpdir setted as project build directory in surefire plugin

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878000#comment-15878000 ] ASF GitHub Bot commented on FLINK-5546: --- Github user shijinkui commented on the issue:

[GitHub] flink issue #3190: [FLINK-5546][build] java.io.tmpdir setted as project buil...

2017-02-22 Thread shijinkui
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3190 Get it. Run single test, having no temp created, it should use the default java.io.tmpdir property. Let me check that. In the base test class have a double check about the target --- If

[jira] [Commented] (FLINK-5830) OutOfMemoryError during notify final state in TaskExecutor may cause job stuck

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878018#comment-15878018 ] ASF GitHub Bot commented on FLINK-5830: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #3380: [FLINK-5865][state] Throw original exception in the state...

2017-02-22 Thread shixiaogang
Github user shixiaogang commented on the issue: https://github.com/apache/flink/pull/3380 I think we may borrow some ideas from Java. For example, the methods in `Map` do not throw any exception in their signatures. But the interfaces define a set of specific `RuntimeException` that

[jira] [Commented] (FLINK-5865) Throw original exception in states

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878038#comment-15878038 ] ASF GitHub Bot commented on FLINK-5865: --- Github user shixiaogang commented on the issue:

[jira] [Commented] (FLINK-5854) Introduce some Flink-specific base Exception types

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878037#comment-15878037 ] ASF GitHub Bot commented on FLINK-5854: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #3368: [FLINK-5854] [core] Add base Flink Exception classes

2017-02-22 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3368 Big +1 from my side. I think that more specific exceptions helps to make people think more about the cause of an exception and, thus, also how it should be handled. Especially the fact that we

[jira] [Created] (FLINK-5882) TableFunction (UDTF) should support variable types and variable arguments

2017-02-22 Thread Zhuoluo Yang (JIRA)
Zhuoluo Yang created FLINK-5882: --- Summary: TableFunction (UDTF) should support variable types and variable arguments Key: FLINK-5882 URL: https://issues.apache.org/jira/browse/FLINK-5882 Project: Flink

[GitHub] flink pull request #3368: [FLINK-5854] [core] Add base Flink Exception class...

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3368#discussion_r102430926 --- Diff: flink-core/src/main/java/org/apache/flink/util/DynamicCodeLoadingException.java --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3373: [FLINK-5692] [config] Add an Option to Deactivate ...

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3373#discussion_r102429969 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/ExecutionConfigTest.java --- @@ -64,4 +68,15 @@ public void

[jira] [Commented] (FLINK-5854) Introduce some Flink-specific base Exception types

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877981#comment-15877981 ] ASF GitHub Bot commented on FLINK-5854: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-4422) Convert all time interval measurements to System.nanoTime()

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877999#comment-15877999 ] ASF GitHub Bot commented on FLINK-4422: --- Github user jinmingjian commented on a diff in the pull

[GitHub] flink pull request #3384: [FLINK-4422] Convert all time interval measurement...

2017-02-22 Thread jinmingjian
Github user jinmingjian commented on a diff in the pull request: https://github.com/apache/flink/pull/3384#discussion_r102435330 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientConnectionTest.java --- @@ -115,13 +115,13 @@ public void run() {

[jira] [Commented] (FLINK-5763) Make savepoints self-contained and relocatable

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878021#comment-15878021 ] ASF GitHub Bot commented on FLINK-5763: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-02-22 Thread clarkyzl
GitHub user clarkyzl opened a pull request: https://github.com/apache/flink/pull/3389 [FLINK-5881] [table] ScalarFunction(UDF) should support variable types and variable arguments Type: New Feature Priority: Major Components: table, udf, ScalarFunction Problem

[GitHub] flink issue #3346: [FLINK-5763] [checkpoints] Add CheckpointOptions for self...

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3346 This is a prerequisite for https://issues.apache.org/jira/browse/FLINK-5820 Reviewing this now... --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-5865) Throw original exception in states

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878022#comment-15878022 ] ASF GitHub Bot commented on FLINK-5865: --- Github user shixiaogang commented on the issue:

[GitHub] flink issue #3380: [FLINK-5865][state] Throw original exception in the state...

2017-02-22 Thread shixiaogang
Github user shixiaogang commented on the issue: https://github.com/apache/flink/pull/3380 I like the idea of find some more "specific" exceptions. Flink can define some specific Exceptions like `StateAccessException`. That may help better understand the code. I am also

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878020#comment-15878020 ] ASF GitHub Bot commented on FLINK-5881: --- GitHub user clarkyzl opened a pull request:

[jira] [Created] (FLINK-5879) ExecutionAttemptID should invoke super() in constructor

2017-02-22 Thread Biao Liu (JIRA)
Biao Liu created FLINK-5879: --- Summary: ExecutionAttemptID should invoke super() in constructor Key: FLINK-5879 URL: https://issues.apache.org/jira/browse/FLINK-5879 Project: Flink Issue Type: Bug

[GitHub] flink issue #3190: [FLINK-5546][build] java.io.tmpdir setted as project buil...

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3190 Hi! `mvn test` works from the command line. IntelliJ right-click on a test and run does often not work, it only works if a console build was done before and the `.../target/tmp/`

[jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877928#comment-15877928 ] ASF GitHub Bot commented on FLINK-5090: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r102427382 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java --- @@ -0,0 +1,167 @@ +/* + *

[GitHub] flink pull request #3384: [FLINK-4422] Convert all time interval measurement...

2017-02-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3384#discussion_r102427597 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientConnectionTest.java --- @@ -115,13 +115,13 @@ public void run() {

[GitHub] flink pull request #3336: [FLINK-4856][state] Add MapState in KeyedState

2017-02-22 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3336#discussion_r102426884 --- Diff: docs/dev/stream/state.md --- @@ -118,6 +118,11 @@ added to the state. Contrary to `ReducingState`, the aggregate type may be diffe of

[jira] [Commented] (FLINK-4856) Add MapState for keyed streams

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877932#comment-15877932 ] ASF GitHub Bot commented on FLINK-4856: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-4856) Add MapState for keyed streams

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877933#comment-15877933 ] ASF GitHub Bot commented on FLINK-4856: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-4422) Convert all time interval measurements to System.nanoTime()

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877931#comment-15877931 ] ASF GitHub Bot commented on FLINK-4422: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5826) UDF/UDTF should support variable types and variable arguments

2017-02-22 Thread Zhuoluo Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877953#comment-15877953 ] Zhuoluo Yang commented on FLINK-5826: - We would like to split the task into two sub-tasks. 1. support

[GitHub] flink issue #3368: [FLINK-5854] [core] Add base Flink Exception classes

2017-02-22 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3368 This looks good, but what is the reason behind the empty constructors that create an exception without message or cause? --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #3368: [FLINK-5854] [core] Add base Flink Exception classes

2017-02-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3368 Hey Stephan! The changes look very good. Thanks also for your explanations, I think this is something that we should focus on more during code reviews. Actually, a section in the Internals or

[jira] [Commented] (FLINK-5854) Introduce some Flink-specific base Exception types

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877992#comment-15877992 ] ASF GitHub Bot commented on FLINK-5854: --- Github user uce commented on the issue:

[jira] [Updated] (FLINK-5568) Introduce interface for catalog, and provide an in-memory implementation. Integrate external catalog with calcite catalog.

2017-02-22 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jingzhang updated FLINK-5568: - Summary: Introduce interface for catalog, and provide an in-memory implementation. Integrate external

[jira] [Commented] (FLINK-5763) Make savepoints self-contained and relocatable

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878068#comment-15878068 ] ASF GitHub Bot commented on FLINK-5763: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3345: [FLINK-5763] [checkpoints] Minor meta data refacto...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3383: [FLINK-5877] [docs] Fix Scala snippet in Async I/O...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (FLINK-5568) Introduce interface for catalog, and provide an in-memory implementation, and integrate with calcite schema

2017-02-22 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jingzhang updated FLINK-5568: - Description: The {TableEnvironment} now provides a mechanism to register temporary table. It registers

[jira] [Updated] (FLINK-5568) Introduce interface for catalog, and provide an in-memory implementation, and integrate with calcite schema

2017-02-22 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jingzhang updated FLINK-5568: - Description: The {{TableEnvironment}} now provides a mechanism to register temporary table. It registers

[jira] [Commented] (FLINK-5864) CEP: fix duplicate output patterns problem.

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878106#comment-15878106 ] ASF GitHub Bot commented on FLINK-5864: --- GitHub user dawidwys opened a pull request:

[GitHub] flink pull request #3390: [FLINK-5864] CEP: fix duplicate output patterns pr...

2017-02-22 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/3390 [FLINK-5864] CEP: fix duplicate output patterns problem. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If

[jira] [Commented] (FLINK-5767) New aggregate function interface and built-in aggregate functions

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878159#comment-15878159 ] ASF GitHub Bot commented on FLINK-5767: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5767) New aggregate function interface and built-in aggregate functions

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878158#comment-15878158 ] ASF GitHub Bot commented on FLINK-5767: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5767) New aggregate function interface and built-in aggregate functions

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878160#comment-15878160 ] ASF GitHub Bot commented on FLINK-5767: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3354: [FLINK-5767] [Table] New aggregate function interf...

2017-02-22 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3354#discussion_r102431548 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/builtInAggFuncs/CountAggFunction.scala --- @@ -0,0 +1,49 @@ +/*

[jira] [Commented] (FLINK-5767) New aggregate function interface and built-in aggregate functions

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878165#comment-15878165 ] ASF GitHub Bot commented on FLINK-5767: --- Github user fhueske commented on a diff in the pull

  1   2   3   4   >