[jira] [Created] (FLINK-7563) Fix watermark semantics in CEP operators

2017-08-31 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-7563: --- Summary: Fix watermark semantics in CEP operators Key: FLINK-7563 URL: https://issues.apache.org/jira/browse/FLINK-7563 Project: Flink Issue Type: Bug

[GitHub] flink pull request #4624: [FLINK-7410] [table] Use toString method to displa...

2017-08-31 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4624#discussion_r136308757 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala --- @@ -41,7 +41,7 @@ abstract class

[jira] [Commented] (FLINK-7410) Use toString method to display operator names for UserDefinedFunction

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148850#comment-16148850 ] ASF GitHub Bot commented on FLINK-7410: --- Github user wuchong commented on a diff in the pull

[jira] [Commented] (FLINK-7410) Use toString method to display operator names for UserDefinedFunction

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148851#comment-16148851 ] ASF GitHub Bot commented on FLINK-7410: --- Github user wuchong commented on a diff in the pull

[jira] [Closed] (FLINK-6787) Job-/StoppableException should extend FlinkException

2017-08-31 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-6787. --- Resolution: Fixed Fix Version/s: 1.4.0 Fixed on master in

[jira] [Reopened] (FLINK-6787) Job-/StoppableException should extend FlinkException

2017-08-31 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reopened FLINK-6787: - > Job-/StoppableException should extend FlinkException >

[jira] [Closed] (FLINK-6787) Job-/StoppableException should extend FlinkException

2017-08-31 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-6787. --- Resolution: Fixed > Job-/StoppableException should extend FlinkException >

[jira] [Commented] (FLINK-6787) Job-/StoppableException should extend FlinkException

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148735#comment-16148735 ] ASF GitHub Bot commented on FLINK-6787: --- Github user aljoscha commented on the issue:

[GitHub] flink pull request #4626: [FLINK-7561][streaming] Implement PreAggregationOp...

2017-08-31 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4626#discussion_r136293381 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/aggregation/PreAggregationOperator.java --- @@ -0,0 +1,249 @@

[jira] [Commented] (FLINK-7552) Extend SinkFunction interface with SinkContext

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148659#comment-16148659 ] ASF GitHub Bot commented on FLINK-7552: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / ...

2017-08-31 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4616#discussion_r136279356 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/SinkFunction.java --- @@ -35,6 +35,40 @@ * *

[GitHub] flink issue #4536: [FLINK-7439] [table] Support variable arguments for UDTF ...

2017-08-31 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4536 Hi @sunjincheng121 I have updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #4500: [FLINK-6787] Fix Job-/StoppingException extend FlinkExcep...

2017-08-31 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4500 Thanks for fixing this. 👍 I just merged, could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-7299) Write GenericRecord using AvroOutputFormat

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148778#comment-16148778 ] ASF GitHub Bot commented on FLINK-7299: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4422: [FLINK-7299][AVRO] Write GenericRecord using AvroOutputFo...

2017-08-31 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4422 Thanks for opening this PR! 😄 Could you please also verify that the records are correctly written in the test? I.e. read the file and compare against what was written. Otherwise the

[GitHub] flink pull request #4624: [FLINK-7410] [table] Use toString method to displa...

2017-08-31 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4624#discussion_r136308925 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -268,6 +269,7 @@ object

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-08-31 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r136287683 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala --- @@ -74,48 +75,102 @@ class

[jira] [Commented] (FLINK-7439) Support variable arguments for UDTF in SQL

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148715#comment-16148715 ] ASF GitHub Bot commented on FLINK-7439: --- Github user wuchong commented on a diff in the pull

[GitHub] flink issue #4626: [FLINK-7561][streaming] Implement PreAggregationOperator

2017-08-31 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4626 I have benchmarked this code and here are the results of using this operator for tumbling windows, with 1000 number of distinct values in the key and watermark once every 16000 elements:

[jira] [Commented] (FLINK-2267) Support multi-class scoring for binary classification scores

2017-08-31 Thread Mikhail Lipkovich (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148763#comment-16148763 ] Mikhail Lipkovich commented on FLINK-2267: -- Hi All, [~rohits134] are you still working on it? If

[jira] [Commented] (FLINK-7561) Add support for pre-aggregation in DataStream API

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148762#comment-16148762 ] ASF GitHub Bot commented on FLINK-7561: --- Github user aljoscha commented on a diff in the pull

[jira] [Created] (FLINK-7564) Fix Watermark semantics in Table API

2017-08-31 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-7564: --- Summary: Fix Watermark semantics in Table API Key: FLINK-7564 URL: https://issues.apache.org/jira/browse/FLINK-7564 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-7552) Extend SinkFunction interface with SinkContext

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148664#comment-16148664 ] ASF GitHub Bot commented on FLINK-7552: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-7552) Extend SinkFunction interface with SinkContext

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148662#comment-16148662 ] ASF GitHub Bot commented on FLINK-7552: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / ...

2017-08-31 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4616#discussion_r136279538 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSink.java --- @@ -31,14 +31,24 @@ private static

[GitHub] flink issue #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / Use in ...

2017-08-31 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4616 To be honest, I didn't look at the tests because I didn't think they would fail. Sorry for that. 😓 I'll fix the tests and let you know once this is ready again. --- If your project is set up

[jira] [Commented] (FLINK-7439) Support variable arguments for UDTF in SQL

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148724#comment-16148724 ] ASF GitHub Bot commented on FLINK-7439: --- Github user wuchong commented on the issue:

[jira] [Commented] (FLINK-7561) Add support for pre-aggregation in DataStream API

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148744#comment-16148744 ] ASF GitHub Bot commented on FLINK-7561: --- Github user pnowojski commented on the issue:

[jira] [Commented] (FLINK-2269) Add Receiver operating characteristic (ROC) curve evaluation

2017-08-31 Thread Mikhail Lipkovich (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148766#comment-16148766 ] Mikhail Lipkovich commented on FLINK-2269: -- Hi All, Is

[jira] [Commented] (FLINK-5944) Flink should support reading Snappy Files

2017-08-31 Thread Mikhail Lipkovich (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148863#comment-16148863 ] Mikhail Lipkovich commented on FLINK-5944: -- Hi, Can I assign this task to me? This task seems

[jira] [Assigned] (FLINK-7564) Fix Watermark semantics in Table API

2017-08-31 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui reassigned FLINK-7564: -- Assignee: Xingcan Cui > Fix Watermark semantics in Table API >

[GitHub] flink pull request #4629: [hotfix][table] Fix bug of testAggregateFunctionOp...

2017-08-31 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/4629 [hotfix][table] Fix bug of testAggregateFunctionOperandTypeCheck *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the

[jira] [Commented] (FLINK-7552) Extend SinkFunction interface with SinkContext

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148978#comment-16148978 ] ASF GitHub Bot commented on FLINK-7552: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / Use in ...

2017-08-31 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/4616 I see. It is a similar problem we've discussed with the SourceContext. Users only implement it, but don't call it. I believe in this case, it makes sense to add an exception to Japicmp to

[jira] [Updated] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-08-31 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-6988: -- Fix Version/s: 1.4.0 > Add Apache Kafka 0.11 connector > --- > >

[GitHub] flink issue #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / Use in ...

2017-08-31 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4616 @rmetzger the binary compatibility checker is acting up because it doesn't like the changes to `SinkFunction` and `RichSinkFunction`. It might be that we can't actually change this. What do you

[jira] [Commented] (FLINK-7552) Extend SinkFunction interface with SinkContext

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148990#comment-16148990 ] ASF GitHub Bot commented on FLINK-7552: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / Use in ...

2017-08-31 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4616 Can we add fine-grained exclusions, or would this exclude the whole file? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #4624: [FLINK-7410] [table] Use toString method to display opera...

2017-08-31 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4624 The CI failed but is not related to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-7410) Use toString method to display operator names for UserDefinedFunction

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148876#comment-16148876 ] ASF GitHub Bot commented on FLINK-7410: --- Github user wuchong commented on the issue:

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148914#comment-16148914 ] ASF GitHub Bot commented on FLINK-6442: --- Github user lincoln-lil commented on a diff in the pull

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-08-31 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r136321128 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -106,6 +106,43 @@ abstract class

[GitHub] flink issue #3829: [FLINK-6442] [table] Extend TableAPI Support Sink Table R...

2017-08-31 Thread lincoln-lil
Github user lincoln-lil commented on the issue: https://github.com/apache/flink/pull/3829 Thanks you for such a detailed review! @fhueske These comments help me a lot! I left some comment on the `queryConfig` and `registerTableSink` methods. I'd created another jira

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148949#comment-16148949 ] ASF GitHub Bot commented on FLINK-6442: --- Github user lincoln-lil commented on the issue:

[jira] [Commented] (FLINK-7561) Add support for pre-aggregation in DataStream API

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148964#comment-16148964 ] ASF GitHub Bot commented on FLINK-7561: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4626: [FLINK-7561][streaming] Implement PreAggregationOp...

2017-08-31 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4626#discussion_r136332646 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/aggregation/PreAggregationOperator.java --- @@ -0,0 +1,249 @@

[GitHub] flink issue #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / Use in ...

2017-08-31 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4616 The problem is that `RichSinkFunction` defines ``` public abstract void invoke(IN value) throws Exception; ``` even though it implements `SinkFunction`, which defines: ```

[jira] [Commented] (FLINK-7552) Extend SinkFunction interface with SinkContext

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148970#comment-16148970 ] ASF GitHub Bot commented on FLINK-7552: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / ...

2017-08-31 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4616#discussion_r136334346 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSink.java --- @@ -31,14 +31,24 @@ private

[jira] [Commented] (FLINK-7552) Extend SinkFunction interface with SinkContext

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148924#comment-16148924 ] ASF GitHub Bot commented on FLINK-7552: --- Github user aljoscha commented on the issue:

[jira] [Updated] (FLINK-7478) Update documentation for sql insert and api change in TableAPI & SQL

2017-08-31 Thread lincoln.lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln.lee updated FLINK-7478: --- Description: we need to add the new features and changes to the documentation: Add a section about

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148936#comment-16148936 ] ASF GitHub Bot commented on FLINK-6442: --- Github user lincoln-lil commented on a diff in the pull

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-08-31 Thread lincoln-lil
Github user lincoln-lil commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r136325581 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala --- @@ -19,9 +19,21 @@ package

[jira] [Updated] (FLINK-7478) Update documentation for sql insert and api change in TableAPI & SQL

2017-08-31 Thread lincoln.lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln.lee updated FLINK-7478: --- Description: we need to add the new features and changes to the documentation: Add a section about

[jira] [Commented] (FLINK-6016) Newlines should be valid in quoted strings in CSV

2017-08-31 Thread Mikhail Lipkovich (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148931#comment-16148931 ] Mikhail Lipkovich commented on FLINK-6016: -- Hi Luke, I've just started diving into Flink so maybe

[jira] [Comment Edited] (FLINK-6016) Newlines should be valid in quoted strings in CSV

2017-08-31 Thread Mikhail Lipkovich (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148931#comment-16148931 ] Mikhail Lipkovich edited comment on FLINK-6016 at 8/31/17 12:49 PM: Hi

[jira] [Updated] (FLINK-7478) Update documentation for sql insert and api change in TableAPI & SQL

2017-08-31 Thread lincoln.lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln.lee updated FLINK-7478: --- Description: we need to add the new features and changes to the documentation: Add a section about

[jira] [Commented] (FLINK-7552) Extend SinkFunction interface with SinkContext

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148966#comment-16148966 ] ASF GitHub Bot commented on FLINK-7552: --- Github user aljoscha commented on the issue:

[GitHub] flink pull request #4484: [FLINK-7376][Client] Cleanup options class and tes...

2017-08-31 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/4484 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #4614: [FLINK-7547] AsyncFunction.scala extends Function, serial...

2017-08-31 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4614 Hi @twalthr @zentol, Please helps to review, Thank you very much. :beers: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-31 Thread Peter Ertl (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149754#comment-16149754 ] Peter Ertl commented on FLINK-7430: --- Perhaps, but I know too little about the background of restricting

[jira] [Commented] (FLINK-7552) Extend SinkFunction interface with SinkContext

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149111#comment-16149111 ] ASF GitHub Bot commented on FLINK-7552: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #4422: [FLINK-7299][AVRO] Write GenericRecord using AvroOutputFo...

2017-08-31 Thread soniclavier
Github user soniclavier commented on the issue: https://github.com/apache/flink/pull/4422 @aljoscha Thanks for taking a look. I have modified the test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-7299) Write GenericRecord using AvroOutputFormat

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149117#comment-16149117 ] ASF GitHub Bot commented on FLINK-7299: --- Github user soniclavier commented on the issue:

[GitHub] flink issue #4575: [FLINK-7494][travis] Add license headers to '.travis.yml'...

2017-08-31 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4575 Hi @twalthr @zentol, Please helps to review, Thank you very much. :beers: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-7494) No license headers in ".travis.yml" file

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149014#comment-16149014 ] ASF GitHub Bot commented on FLINK-7494: --- Github user yew1eb commented on the issue:

[jira] [Updated] (FLINK-7565) Add support for HTTP 1.1 (Chunked transfer encoding) to Flink web UI

2017-08-31 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7565: -- Description: I tried sending some REST calls to Flink's web UI, using a HTTP 1.1 client

[GitHub] flink pull request #4630: [FLINK-6733] Remove commented out AvgAggregationFu...

2017-08-31 Thread mlipkovich
GitHub user mlipkovich opened a pull request: https://github.com/apache/flink/pull/4630 [FLINK-6733] Remove commented out AvgAggregationFunction.java *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-08-31 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r136362552 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -106,6 +106,43 @@ abstract class

[GitHub] flink pull request #4631: [hotfix][kafka][docs] Add warning regarding data l...

2017-08-31 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/4631 [hotfix][kafka][docs] Add warning regarding data losses when writing … This pull request add an alert in the documentation about possible data loses while writing to Kafka. CC

[GitHub] flink issue #4629: [hotfix][table] Fix bug of testAggregateFunctionOperandTy...

2017-08-31 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4629 Thanks for the hotfix, will merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #4629: [hotfix][table] Fix bug of testAggregateFunctionOp...

2017-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149107#comment-16149107 ] ASF GitHub Bot commented on FLINK-6442: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-08-31 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r136363886 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala --- @@ -19,9 +19,21 @@ package

[GitHub] flink issue #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / Use in ...

2017-08-31 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/4616 No, you can define fine-grained exclusions. Check the excludes in the example: http://siom79.github.io/japicmp/MavenPlugin.html --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149110#comment-16149110 ] ASF GitHub Bot commented on FLINK-6442: --- Github user wuchong commented on a diff in the pull

[jira] [Commented] (FLINK-7438) Some classes are eclipsed by classes in package scala

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149015#comment-16149015 ] ASF GitHub Bot commented on FLINK-7438: --- Github user yew1eb commented on the issue:

[jira] [Comment Edited] (FLINK-6733) Remove commented out AvgAggregationFunction.java

2017-08-31 Thread Mikhail Lipkovich (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149068#comment-16149068 ] Mikhail Lipkovich edited comment on FLINK-6733 at 8/31/17 2:36 PM: ---

[jira] [Created] (FLINK-7565) Add support for HTTP 1.1 (Chunked transfer encoding) to Flink web UI

2017-08-31 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-7565: - Summary: Add support for HTTP 1.1 (Chunked transfer encoding) to Flink web UI Key: FLINK-7565 URL: https://issues.apache.org/jira/browse/FLINK-7565 Project: Flink

[jira] [Commented] (FLINK-7376) Cleanup options class and test classes in flink-clients

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149011#comment-16149011 ] ASF GitHub Bot commented on FLINK-7376: --- Github user yew1eb closed the pull request at:

[jira] [Commented] (FLINK-7547) o.a.f.s.api.scala.async.AsyncFunction is not declared Serializable

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149013#comment-16149013 ] ASF GitHub Bot commented on FLINK-7547: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #4570: [FLINK-7438][DataStream API]Remove useless import, avoid ...

2017-08-31 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4570 Hi @twalthr @zentol, Please helps to review, Thank you very much. :beers: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-6733) Remove commented out AvgAggregationFunction.java

2017-08-31 Thread Mikhail Lipkovich (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149068#comment-16149068 ] Mikhail Lipkovich commented on FLINK-6733: -- Hello, If there are no objections I'm assigning this

[jira] [Commented] (FLINK-6733) Remove commented out AvgAggregationFunction.java

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149101#comment-16149101 ] ASF GitHub Bot commented on FLINK-6733: --- GitHub user mlipkovich opened a pull request:

[jira] [Assigned] (FLINK-7563) Fix watermark semantics in CEP operators

2017-08-31 Thread Yueting Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yueting Chen reassigned FLINK-7563: --- Assignee: Yueting Chen > Fix watermark semantics in CEP operators >

[jira] [Commented] (FLINK-6016) Newlines should be valid in quoted strings in CSV

2017-08-31 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149440#comment-16149440 ] Luke Hutchison commented on FLINK-6016: --- Mikhail: correct, this can't be fixed easily once the lines

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-08-31 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/3511 Actually, now I'm thinking we should defer implementing code generation for `FixedLengthRecordSorter` to after https://github.com/apache/flink/pull/2617 is merged. What do you think @greghogan ?

[jira] [Commented] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-31 Thread Mike Dias (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149283#comment-16149283 ] Mike Dias commented on FLINK-7430: -- Perhaps the solution is revert the code implemented in FLINK-6833

[jira] [Commented] (FLINK-7563) Fix watermark semantics in CEP operators

2017-08-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149615#comment-16149615 ] ASF GitHub Bot commented on FLINK-7563: --- GitHub user yestinchen opened a pull request:

[GitHub] flink pull request #4632: [FLINK-7563] [cep] Fix watermark semantics in cep ...

2017-08-31 Thread yestinchen
GitHub user yestinchen opened a pull request: https://github.com/apache/flink/pull/4632 [FLINK-7563] [cep] Fix watermark semantics in cep and related tests. ## What is the purpose of the change Correct the watermark semantics in cep. ## Brief change log -

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-08-31 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/3511 I pushed some more commits to [https://github.com/ggevay/flink/tree/sorter-codegen](https://github.com/ggevay/flink/tree/sorter-codegen). @heytitle , could you please push them here? (Or you could

[jira] [Created] (FLINK-7566) if there's only one checkpointing metadata file in , `flink run -s ` should resume from that metadata file

2017-08-31 Thread Bowen Li (JIRA)
Bowen Li created FLINK-7566: --- Summary: if there's only one checkpointing metadata file in , `flink run -s ` should resume from that metadata file Key: FLINK-7566 URL: https://issues.apache.org/jira/browse/FLINK-7566

[jira] [Updated] (FLINK-7566) if there's only one checkpointing metadata file in , `flink run -s ` should resume from that metadata file

2017-08-31 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-7566: Description: Currently, if we want to start a Flink job from a checkpointing file, we have to run `flink

[jira] [Assigned] (FLINK-7566) if there's only one checkpointing metadata file in , `flink run -s ` should resume from that metadata file

2017-08-31 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-7566: --- Assignee: Bowen Li > if there's only one checkpointing metadata file in , `flink run -s > ` should

[jira] [Updated] (FLINK-7566) if there's only one checkpointing metadata file in , `flink run -s ` should successfully resume from that metadata file

2017-08-31 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-7566: Summary: if there's only one checkpointing metadata file in , `flink run -s ` should successfully resume

[jira] [Updated] (FLINK-7566) if there's only one checkpointing metadata file in , `flink run -s ` should resume from that metadata file

2017-08-31 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-7566: Environment: (was: Currently, if we want to start a Flink job from a checkpointing file, we have to run

[jira] [Updated] (FLINK-7566) if there's only one checkpointing metadata file in , `flink run -s ` should successfully resume from that metadata file

2017-08-31 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-7566: Description: Currently, if we want to start a Flink job from a checkpointing file, we have to run `flink

[jira] [Updated] (FLINK-7566) if there's only one checkpointing metadata file in , `flink run -s ` should successfully resume from that metadata file

2017-08-31 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-7566: Component/s: (was: Startup Shell Scripts) State Backends, Checkpointing > if there's

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-08-31 Thread heytitle
Github user heytitle commented on the issue: https://github.com/apache/flink/pull/3511 @ggevay Thanks for the commits. They look good. I also added you to my repository. For `FixedLengthRecordSorter`, I agree with you that we should implement that when #2617 is merged.

[jira] [Commented] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-31 Thread Mike Dias (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149875#comment-16149875 ] Mike Dias commented on FLINK-7430: -- What I see about FLINK-6833 is solution for a corner-case that maybe

  1   2   >