[GitHub] satybald commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method

2018-09-21 Thread GitBox
satybald commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method URL: https://github.com/apache/flink/pull/6724#issuecomment-423427348 @StephanEwen agree, try expression doesn't incur any performance penalties. Another option that doesn't affect performance is

[GitHub] twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r219407109 ## File path:

[GitHub] twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r219407507 ## File path:

[jira] [Commented] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623207#comment-16623207 ] ASF GitHub Bot commented on FLINK-9567: --- asfgit closed pull request #6669:

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623198#comment-16623198 ] ASF GitHub Bot commented on FLINK-9713: --- twalthr commented on a change in pull request #6299:

[GitHub] asfgit closed pull request #6669: [FLINK-9567][runtime][yarn] Fix the yarn container over allocation in…

2018-09-21 Thread GitBox
asfgit closed pull request #6669: [FLINK-9567][runtime][yarn] Fix the yarn container over allocation in… URL: https://github.com/apache/flink/pull/6669 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623213#comment-16623213 ] ASF GitHub Bot commented on FLINK-9713: --- pnowojski commented on a change in pull request #6299:

[GitHub] tillrohrmann commented on issue #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread GitBox
tillrohrmann commented on issue #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration URL: https://github.com/apache/flink/pull/6727#issuecomment-423449469 Thanks for your contribution @kleingeist. The documentation needs to be updated in order

[jira] [Commented] (FLINK-10371) Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623236#comment-16623236 ] ASF GitHub Bot commented on FLINK-10371: tillrohrmann commented on issue #6727: [FLINK-10371]

[jira] [Commented] (FLINK-10380) Check if key is not nul before assign to group in KeyedStream

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623107#comment-16623107 ] ASF GitHub Bot commented on FLINK-10380: satybald removed a comment on issue #6724:

[jira] [Commented] (FLINK-10385) Implement a waitUntilCondition utils

2018-09-21 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623196#comment-16623196 ] 陈梓立 commented on FLINK-10385: - Maybe a waiting utils based on {{sleep}} and test would lose state changes

[jira] [Commented] (FLINK-10260) Confusing log during TaskManager registration

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623206#comment-16623206 ] ASF GitHub Bot commented on FLINK-10260: asfgit closed pull request #6720: [FLINK-10260] Change

[GitHub] asfgit closed pull request #6720: [FLINK-10260] Change log level to debug in ResourceManager in case of TaskExecutor reconnect

2018-09-21 Thread GitBox
asfgit closed pull request #6720: [FLINK-10260] Change log level to debug in ResourceManager in case of TaskExecutor reconnect URL: https://github.com/apache/flink/pull/6720 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[jira] [Commented] (FLINK-10375) ExceptionInChainedStubException hides wrapped exception in cause

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623205#comment-16623205 ] ASF GitHub Bot commented on FLINK-10375: asfgit closed pull request #6719: [FLINK-10375] Add

[GitHub] TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-09-21 Thread GitBox
TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-423436864 Travis fails on `TaskTest` because it is based on legacy code base. Temporarily hack to refine it. Note

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623190#comment-16623190 ] ASF GitHub Bot commented on FLINK-9713: --- twalthr commented on a change in pull request #6299:

[jira] [Commented] (FLINK-10263) User-defined function with LITERAL paramters yields CompileException

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623191#comment-16623191 ] ASF GitHub Bot commented on FLINK-10263: dawidwys commented on a change in pull request #6725:

[jira] [Comment Edited] (FLINK-10385) Implement a waitUntilCondition utils

2018-09-21 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623196#comment-16623196 ] 陈梓立 edited comment on FLINK-10385 at 9/21/18 7:36 AM: -- Maybe a waiting utils based

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623199#comment-16623199 ] ASF GitHub Bot commented on FLINK-9713: --- twalthr commented on a change in pull request #6299:

[GitHub] pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r219411672 ## File path:

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623216#comment-16623216 ] ASF GitHub Bot commented on FLINK-9713: --- pnowojski commented on a change in pull request #6299:

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623217#comment-16623217 ] ASF GitHub Bot commented on FLINK-9713: --- pnowojski commented on a change in pull request #6299:

[jira] [Commented] (FLINK-10380) Check if key is not nul before assign to group in KeyedStream

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623106#comment-16623106 ] ASF GitHub Bot commented on FLINK-10380: satybald commented on issue #6724: [FLINK-10380] Add

[GitHub] satybald commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method

2018-09-21 Thread GitBox
satybald commented on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method URL: https://github.com/apache/flink/pull/6724#issuecomment-423422608 another option would be to add try/catch statement for NPE. Try statement doesn't incur any performance issue unless an

[GitHub] satybald removed a comment on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method

2018-09-21 Thread GitBox
satybald removed a comment on issue #6724: [FLINK-10380] Add precondition for assignToKeyGroup method URL: https://github.com/apache/flink/pull/6724#issuecomment-423422608 another option would be to add try/catch statement for NPE. Try statement doesn't incur any performance issue unless

[jira] [Commented] (FLINK-10380) Check if key is not nul before assign to group in KeyedStream

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623132#comment-16623132 ] ASF GitHub Bot commented on FLINK-10380: satybald commented on issue #6724: [FLINK-10380] Add

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623203#comment-16623203 ] ASF GitHub Bot commented on FLINK-9713: --- twalthr commented on issue #6299: [FLINK-9713][table][sql]

[GitHub] twalthr commented on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
twalthr commented on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#issuecomment-423443446 Thank you @pnowojski. I added my last 4 comments. Feel free to merge this PR after you addressed them. +1 from my side.

[GitHub] pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r219410591 ## File path:

[jira] [Updated] (FLINK-10384) Add Sinh math function supported in Table API and SQL

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10384: --- Labels: pull-request-available (was: ) > Add Sinh math function supported in Table API and

[jira] [Commented] (FLINK-10384) Add Sinh math function supported in Table API and SQL

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623156#comment-16623156 ] ASF GitHub Bot commented on FLINK-10384: yanghua opened a new pull request #6730: [FLINK-10384]

[GitHub] yanghua opened a new pull request #6730: [FLINK-10384] Add Sinh math function supported in Table API and SQL

2018-09-21 Thread GitBox
yanghua opened a new pull request #6730: [FLINK-10384] Add Sinh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6730 ## What is the purpose of the change *This pull request adds Sinh math function supported in Table API and SQL* ##

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623173#comment-16623173 ] ASF GitHub Bot commented on FLINK-10386: TisonKun edited a comment on issue #6729: [FLINK-10386]

[GitHub] Clarkkkkk closed pull request #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool

2018-09-21 Thread GitBox
Clark closed pull request #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool URL: https://github.com/apache/flink/pull/6676 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623195#comment-16623195 ] ASF GitHub Bot commented on FLINK-10247: Clark closed pull request #6676:

[jira] [Commented] (FLINK-9235) Add Integration test for Flink-Yarn-Kerberos integration for flip-6

2018-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623209#comment-16623209 ] Till Rohrmann commented on FLINK-9235: -- What's the status of this issue [~suez1224] and [~aljoscha]?

[GitHub] pnowojski commented on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
pnowojski commented on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#issuecomment-423448194 Thanks for the review @twalthr :) I'm pushing latest update. Will merge it once it's green.

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623219#comment-16623219 ] ASF GitHub Bot commented on FLINK-9713: --- pnowojski edited a comment on issue #6299:

[GitHub] pnowojski edited a comment on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
pnowojski edited a comment on issue #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#issuecomment-423448194 Thanks for the review @twalthr :) I'm pushing latest update (already squashed). Will merge it once it's green.

[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623218#comment-16623218 ] ASF GitHub Bot commented on FLINK-9713: --- pnowojski commented on issue #6299:

[jira] [Commented] (FLINK-10339) SpillReadBufferPool cannot use off-heap memory

2018-09-21 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623153#comment-16623153 ] zhijiang commented on FLINK-10339: -- Hey [~NicoK]  [~pnowojski], do you think we should make

[jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623171#comment-16623171 ] ASF GitHub Bot commented on FLINK-10386: TisonKun commented on issue #6729: [FLINK-10386]

[GitHub] TisonKun edited a comment on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-09-21 Thread GitBox
TisonKun edited a comment on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-423436864 Travis fails on `TaskTest` because it is based on legacy code base. Temporarily hack to refine it.

[GitHub] twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r219405006 ## File path:

[GitHub] dawidwys commented on a change in pull request #6725: [FLINK-10263] [sql-client] Fix classloader issues in SQL Client

2018-09-21 Thread GitBox
dawidwys commented on a change in pull request #6725: [FLINK-10263] [sql-client] Fix classloader issues in SQL Client URL: https://github.com/apache/flink/pull/6725#discussion_r219405018 ## File path:

[GitHub] asfgit closed pull request #6719: [FLINK-10375] Add wrapped exception as cause in ExceptionInChainedStubException

2018-09-21 Thread GitBox
asfgit closed pull request #6719: [FLINK-10375] Add wrapped exception as cause in ExceptionInChainedStubException URL: https://github.com/apache/flink/pull/6719 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Reopened] (FLINK-7942) NPE when apply FilterJoinRule

2018-09-21 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reopened FLINK-7942: -- > NPE when apply FilterJoinRule > - > > Key:

[GitHub] pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins

2018-09-21 Thread GitBox
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r219411313 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread GitBox
tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration URL: https://github.com/apache/flink/pull/6727#discussion_r219416411 ## File path:

[jira] [Commented] (FLINK-10371) Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623257#comment-16623257 ] ASF GitHub Bot commented on FLINK-10371: tillrohrmann commented on a change in pull request

[GitHub] tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread GitBox
tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration URL: https://github.com/apache/flink/pull/6727#discussion_r219417270 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread GitBox
tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration URL: https://github.com/apache/flink/pull/6727#discussion_r219416570 ## File path:

[jira] [Commented] (FLINK-10371) Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623258#comment-16623258 ] ASF GitHub Bot commented on FLINK-10371: tillrohrmann commented on a change in pull request

[jira] [Commented] (FLINK-10371) Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623255#comment-16623255 ] ASF GitHub Bot commented on FLINK-10371: tillrohrmann commented on a change in pull request

[GitHub] tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread GitBox
tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration URL: https://github.com/apache/flink/pull/6727#discussion_r219416858 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread GitBox
tillrohrmann commented on a change in pull request #6727: [FLINK-10371] Allow to enable SSL mutual authentication on REST endpoints by configuration URL: https://github.com/apache/flink/pull/6727#discussion_r219417533 ## File path:

[jira] [Commented] (FLINK-10371) Allow to enable SSL mutual authentication on REST endpoints by configuration

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623254#comment-16623254 ] ASF GitHub Bot commented on FLINK-10371: tillrohrmann commented on a change in pull request

[jira] [Commented] (FLINK-10074) Allowable number of checkpoint failures

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623253#comment-16623253 ] ASF GitHub Bot commented on FLINK-10074: yanghua commented on issue #6567: [FLINK-10074]

[jira] [Updated] (FLINK-10344) Rethink SubmittedJobGraphListener

2018-09-21 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu updated FLINK-10344: - Attachment: (was: Tornado.pdf) > Rethink SubmittedJobGraphListener >

[jira] [Commented] (FLINK-9891) Flink cluster is not shutdown in YARN mode when Flink client is stopped

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623270#comment-16623270 ] ASF GitHub Bot commented on FLINK-9891: --- azagrebin commented on a change in pull request #6718:

[jira] [Commented] (FLINK-10344) Rethink SubmittedJobGraphListener

2018-09-21 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623273#comment-16623273 ] Biao Liu commented on FLINK-10344: -- [~dangdangdang] Oh that's my fault. I was reading a paper. Dragged

[jira] [Commented] (FLINK-9682) Add setDescription to execution environment and provide description field for the rest api

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623331#comment-16623331 ] ASF GitHub Bot commented on FLINK-9682: --- yanghua commented on issue #6266: [FLINK-9682] Add

[jira] [Updated] (FLINK-10312) Wrong / missing exception when submitting job

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10312: --- Labels: pull-request-available (was: ) > Wrong / missing exception when submitting job >

[GitHub] yanghua commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures

2018-09-21 Thread GitBox
yanghua commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures URL: https://github.com/apache/flink/pull/6567#issuecomment-423453821 hi @tillrohrmann what do you think about the latest implementation?

[GitHub] tillrohrmann commented on issue #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-21 Thread GitBox
tillrohrmann commented on issue #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#issuecomment-423455756 I think it should not be possible to have two async recovery operations ongoing since either of them will have

[jira] [Commented] (FLINK-10255) Standby Dispatcher locks submitted JobGraphs

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623264#comment-16623264 ] ASF GitHub Bot commented on FLINK-10255: tillrohrmann commented on issue #6678: [FLINK-10255]

[GitHub] twalthr commented on issue #6725: [FLINK-10263] [sql-client] Fix classloader issues in SQL Client

2018-09-21 Thread GitBox
twalthr commented on issue #6725: [FLINK-10263] [sql-client] Fix classloader issues in SQL Client URL: https://github.com/apache/flink/pull/6725#issuecomment-423486904 Thank you @dawidwys. I simplified the code there. This

[jira] [Commented] (FLINK-10354) Savepoints should be counted as retained checkpoints

2018-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623403#comment-16623403 ] Till Rohrmann commented on FLINK-10354: --- This looks like a duplicate of FLINK-9983? > Savepoints

[GitHub] TisonKun commented on issue #6721: [FLINK-10376] [tests] Replace mkdirTolerateExisting by thread safe Files#createDirectories

2018-09-21 Thread GitBox
TisonKun commented on issue #6721: [FLINK-10376] [tests] Replace mkdirTolerateExisting by thread safe Files#createDirectories URL: https://github.com/apache/flink/pull/6721#issuecomment-423456515 travis gives green and the unstable one is theoretically hardened. @tillrohrmann

[jira] [Updated] (FLINK-10344) Rethink SubmittedJobGraphListener

2018-09-21 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu updated FLINK-10344: - Attachment: (was: Tornado.pdf) > Rethink SubmittedJobGraphListener >

[jira] [Comment Edited] (FLINK-10312) Wrong / missing exception when submitting job

2018-09-21 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623266#comment-16623266 ] Andrey Zagrebin edited comment on FLINK-10312 at 9/21/18 8:42 AM: -- PR

[jira] [Commented] (FLINK-10363) S3 FileSystem factory prints secrets into logs

2018-09-21 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623330#comment-16623330 ] Steve Loughran commented on FLINK-10363: see WHIRR-642 for this same issue; it's easy to do. For

[jira] [Commented] (FLINK-10312) Wrong / missing exception when submitting job

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623261#comment-16623261 ] ASF GitHub Bot commented on FLINK-10312: azagrebin opened a new pull request #6731:

[GitHub] azagrebin opened a new pull request #6731: [FLINK-10312] Propagate exception from server to client in REST API

2018-09-21 Thread GitBox
azagrebin opened a new pull request #6731: [FLINK-10312] Propagate exception from server to client in REST API URL: https://github.com/apache/flink/pull/6731 ## What is the purpose of the change If exception currently happens on the server side in REST API handlers, the client side

[jira] [Commented] (FLINK-10312) Wrong / missing exception when submitting job

2018-09-21 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623266#comment-16623266 ] Andrey Zagrebin commented on FLINK-10312: - PR suggests the following embedding of server side

[jira] [Commented] (FLINK-10376) BlobCacheCleanupTest.testPermanentBlobCleanup failed on Travis

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623265#comment-16623265 ] ASF GitHub Bot commented on FLINK-10376: TisonKun commented on issue #6721: [FLINK-10376]

[jira] [Resolved] (FLINK-10260) Confusing log during TaskManager registration

2018-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-10260. --- Resolution: Fixed Fixed via 1.7.0: 542e8cc22290984b4b2e32577430ceb82dd82fde 1.6.2:

[jira] [Resolved] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

2018-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-9567. -- Resolution: Fixed Fix Version/s: (was: 1.5.1) (was: 1.6.0)

[jira] [Resolved] (FLINK-10375) ExceptionInChainedStubException hides wrapped exception in cause

2018-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-10375. --- Resolution: Fixed Fix Version/s: 1.5.5 1.6.2

[jira] [Created] (FLINK-10387) StateBackend create methods should return interface not abstract KeyedStateBackend classes

2018-09-21 Thread Gyula Fora (JIRA)
Gyula Fora created FLINK-10387: -- Summary: StateBackend create methods should return interface not abstract KeyedStateBackend classes Key: FLINK-10387 URL: https://issues.apache.org/jira/browse/FLINK-10387

[jira] [Updated] (FLINK-10310) Cassandra Sink - Handling failing requests

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10310: --- Labels: pull-request-available (was: ) > Cassandra Sink - Handling failing requests >

[jira] [Commented] (FLINK-10310) Cassandra Sink - Handling failing requests

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623422#comment-16623422 ] ASF GitHub Bot commented on FLINK-10310: wittyameta opened a new pull request #6732:

[jira] [Commented] (FLINK-8803) Mini Cluster Shutdown with HA unstable, causing test failures

2018-09-21 Thread tison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623459#comment-16623459 ] tison commented on FLINK-8803: -- is it "won't fix" since it's all about {{FlinkMiniCluster}} which based on

[jira] [Commented] (FLINK-10354) Savepoints should be counted as retained checkpoints

2018-09-21 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623465#comment-16623465 ] Dawid Wysakowicz commented on FLINK-10354: -- You're right, haven't seen the other one. Will

[jira] [Closed] (FLINK-9983) Savepoints should count as checkpoints when recovering

2018-09-21 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-9983. --- Resolution: Duplicate Will be fixed in [FLINK-10354] > Savepoints should count as

[jira] [Commented] (FLINK-10379) Can not use Table Functions in Java Table API

2018-09-21 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623471#comment-16623471 ] Piotr Nowojski commented on FLINK-10379: Thanks [~hequn8128] :) Probably we should first also

[GitHub] wittyameta opened a new pull request #6732: [FLINK-10310] Cassandra Sink - Handling failing requests.

2018-09-21 Thread GitBox
wittyameta opened a new pull request #6732: [FLINK-10310] Cassandra Sink - Handling failing requests. URL: https://github.com/apache/flink/pull/6732 ## What is the purpose of the change This pull request provides support to optionally handle cassandra sink errors. A user may choose

[jira] [Commented] (FLINK-10157) Allow `null` user values in map state with TTL

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623467#comment-16623467 ] ASF GitHub Bot commented on FLINK-10157: StefanRRichter commented on issue #6707: [FLINK-10157]

[jira] [Commented] (FLINK-10384) Add Sinh math function supported in Table API and SQL

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623521#comment-16623521 ] ASF GitHub Bot commented on FLINK-10384: yanghua commented on issue #6730: [FLINK-10384] Add

[GitHub] pnowojski commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter

2018-09-21 Thread GitBox
pnowojski commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter URL: https://github.com/apache/flink/pull/6417#issuecomment-423499421 @NicoK said to me his LGTM, so I'm merging this :) Thank you @zhijiangW for the contribution and the time

[GitHub] pnowojski closed pull request #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter

2018-09-21 Thread GitBox
pnowojski closed pull request #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter URL: https://github.com/apache/flink/pull/6417 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Commented] (FLINK-9913) Improve output serialization only once in RecordWriter

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623432#comment-16623432 ] ASF GitHub Bot commented on FLINK-9913: --- pnowojski closed pull request #6417: [FLINK-9913][runtime]

[jira] [Resolved] (FLINK-9913) Improve output serialization only once in RecordWriter

2018-09-21 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski resolved FLINK-9913. --- Resolution: Fixed merged commit 914dffb into apache:master > Improve output serialization

[jira] [Closed] (FLINK-9738) Provide a way to define Table Version Functions in Table API

2018-09-21 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-9738. - Resolution: Fixed Fix Version/s: 1.7.0 Merged as f2a67a1682249d83711030f4e55b824cb18336d7

[jira] [Assigned] (FLINK-9715) Support versioned joins with event time

2018-09-21 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-9715: - Assignee: Piotr Nowojski > Support versioned joins with event time >

[jira] [Commented] (FLINK-10377) Remove precondition in TwoPhaseCommitSinkFunction.notifyCheckpointComplete

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623461#comment-16623461 ] ASF GitHub Bot commented on FLINK-10377: pnowojski commented on a change in pull request #6723:

[GitHub] pnowojski commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif…

2018-09-21 Thread GitBox
pnowojski commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif… URL: https://github.com/apache/flink/pull/6723#discussion_r219471764 ## File path:

[GitHub] StefanRRichter commented on issue #6707: [FLINK-10157] [State TTL] Allow `null` user values in map state with TTL

2018-09-21 Thread GitBox
StefanRRichter commented on issue #6707: [FLINK-10157] [State TTL] Allow `null` user values in map state with TTL URL: https://github.com/apache/flink/pull/6707#issuecomment-423507977 Thanks @azagrebin ! Changes look good to me, merging. 

[jira] [Commented] (FLINK-10320) Introduce JobMaster schedule micro-benchmark

2018-09-21 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623481#comment-16623481 ] Piotr Nowojski commented on FLINK-10320: [~till.rohrmann] might have a good point. [~Tison]

[jira] [Commented] (FLINK-9913) Improve output serialization only once in RecordWriter

2018-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623429#comment-16623429 ] ASF GitHub Bot commented on FLINK-9913: --- pnowojski commented on issue #6417: [FLINK-9913][runtime]

  1   2   >