[GitHub] [flink] flinkbot edited a comment on pull request #13812: [FLINK-19674][docs-zh] Translate "Docker" of "Clusters & Depolyment" page into Chinese

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13812: URL: https://github.com/apache/flink/pull/13812#issuecomment-717687160 ## CI report: * 4f66617c4540a4987a5852cf0168f7e3a552c91a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13763: [FLINK-19779][avro] Remove the record_ field name prefix for Confluen…

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13763: URL: https://github.com/apache/flink/pull/13763#issuecomment-715195599 ## CI report: * ba752274c9926115f65f5ecbef55b71b0b71cfa2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13760: [FLINK-19627][table-runtime] Introduce multiple input operator for batch

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13760: URL: https://github.com/apache/flink/pull/13760#issuecomment-715078238 ## CI report: * b1353f7422a706cd50502d62b988b06154d33ffc Azure:

[GitHub] [flink] flinkbot commented on pull request #13814: [FLINK-19839][e2e] Properly forward test exit code to CI system

2020-10-28 Thread GitBox
flinkbot commented on pull request #13814: URL: https://github.com/apache/flink/pull/13814#issuecomment-717724545 ## CI report: * 4ff8c35475568fee2cd77ba6268e119ed805ec95 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #13805: [FLINK-19569][table] Upgrade ICU4J to 67.1

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13805: URL: https://github.com/apache/flink/pull/13805#issuecomment-717226449 ## CI report: * 6ee7fc39e8a9c85c8b45c3c5a3b89de8f84416c7 Azure:

[GitHub] [flink] JingsongLi commented on pull request #13605: [FLINK-19599][table] Introduce Filesystem format factories to integrate new FileSource to table

2020-10-28 Thread GitBox
JingsongLi commented on pull request #13605: URL: https://github.com/apache/flink/pull/13605#issuecomment-717723912 Thanks a lot for your review! @wuchong Try to wrap `SerializationSchema` and `DeserializationSchema` for csv and json, is a very interesting thing.

[GitHub] [flink] flinkbot edited a comment on pull request #13300: [FLINK-19077][table-runtime] Import process time temporal join operator.

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13300: URL: https://github.com/apache/flink/pull/13300#issuecomment-684957567 ## CI report: * Unknown: [CANCELED](TBD) * 6bf5dc2e71b14086d5f908cc300060595adc46ea Azure:

[GitHub] [flink] godfreyhe merged pull request #13760: [FLINK-19627][table-runtime] Introduce multiple input operator for batch

2020-10-28 Thread GitBox
godfreyhe merged pull request #13760: URL: https://github.com/apache/flink/pull/13760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] shuiqiangchen commented on pull request #13756: [FLINK-19770][python][test] Changed the PythonProgramOptionTest to be an ITCase.

2020-10-28 Thread GitBox
shuiqiangchen commented on pull request #13756: URL: https://github.com/apache/flink/pull/13756#issuecomment-717730700 @anonymouscodeholic Thank you for pointing out the mistake, I have revised them in the latest commit.

[GitHub] [flink] tzulitai commented on pull request #13773: [backport-1.11] [FLINK-19748] Iterating key groups in raw keyed stream on restore fails if some key groups weren't written

2020-10-28 Thread GitBox
tzulitai commented on pull request #13773: URL: https://github.com/apache/flink/pull/13773#issuecomment-717730004 @Antti-Kaikkonen thanks you for trying the branch out. I think the exceptions you encountered are expected in the experiments you've tried out. Can you adjust

[GitHub] [flink] flinkbot edited a comment on pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13458: URL: https://github.com/apache/flink/pull/13458#issuecomment-697041219 ## CI report: * 7311b0d12d19a645391ea0359a9aa6318806363b UNKNOWN * 3676c7e7a4729c494e12e82f4df4f2617ef29b5d Azure:

[GitHub] [flink] wangyang0918 commented on a change in pull request #13644: [FLINK-19542][k8s]Implement LeaderElectionService and LeaderRetrievalService based on Kubernetes API

2020-10-28 Thread GitBox
wangyang0918 commented on a change in pull request #13644: URL: https://github.com/apache/flink/pull/13644#discussion_r51326 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/LeaderRetrievalDriver.java ## @@ -0,0 +1,31 @@ +/* + * Licensed

[GitHub] [flink] tzulitai edited a comment on pull request #13773: [backport-1.11] [FLINK-19748] Iterating key groups in raw keyed stream on restore fails if some key groups weren't written

2020-10-28 Thread GitBox
tzulitai edited a comment on pull request #13773: URL: https://github.com/apache/flink/pull/13773#issuecomment-717730004 @Antti-Kaikkonen thanks you for trying the branch out. I think the exceptions you encountered are expected in the experiments you've tried out. Can you

[GitHub] [flink] flinkbot edited a comment on pull request #13744: [FLINK-19766][table-runtime] Introduce File streaming compaction operators

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13744: URL: https://github.com/apache/flink/pull/13744#issuecomment-714369975 ## CI report: * 164c8b5b7750ed567813d70f160ef9f064d0a3b0 Azure:

[jira] [Assigned] (FLINK-18811) if a disk is damaged, taskmanager should choose another disk for temp dir , rather than throw an IOException, which causes flink job restart over and over again

2020-10-28 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-18811: -- Assignee: Kai Chen > if a disk is damaged, taskmanager should choose another disk

[jira] [Closed] (FLINK-18811) if a disk is damaged, taskmanager should choose another disk for temp dir , rather than throw an IOException, which causes flink job restart over and over again

2020-10-28 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-18811. -- Fix Version/s: 1.12.0 Resolution: Fixed merged commit e38716f into apache:master > if

[GitHub] [flink] pnowojski merged pull request #13810: [FLINK-18811][network] Pick another tmpDir if an IOException occurs w…

2020-10-28 Thread GitBox
pnowojski merged pull request #13810: URL: https://github.com/apache/flink/pull/13810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] wangxlong opened a new pull request #13816: [BP-1.11][FLINK-19587][table-planner-blink] Fix error result when casting bina…

2020-10-28 Thread GitBox
wangxlong opened a new pull request #13816: URL: https://github.com/apache/flink/pull/13816 ## What is the purpose of the change This is a backport of FLINK-19587 cherry picked from commit d9b0ac97ee4675aebdab1592af663b95fdc5051b

[GitHub] [flink] yuchuanchen commented on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

2020-10-28 Thread GitBox
yuchuanchen commented on pull request #13718: URL: https://github.com/apache/flink/pull/13718#issuecomment-717758921 Thanks @pnowojski This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] rmetzger commented on pull request #13796: [FLINK-19810][CI] Automatically run a basic NOTICE file check on CI

2020-10-28 Thread GitBox
rmetzger commented on pull request #13796: URL: https://github.com/apache/flink/pull/13796#issuecomment-717761562 Thanks a lot for taking a look. I believe the statement by the tool is correct: The notice file contains the following dependency: `com.apache.commons:commons-compress:1.20`,

[jira] [Created] (FLINK-19846) Grammar mistakes in annotations and log

2020-10-28 Thread zhouchao (Jira)
zhouchao created FLINK-19846: Summary: Grammar mistakes in annotations and log Key: FLINK-19846 URL: https://issues.apache.org/jira/browse/FLINK-19846 Project: Flink Issue Type: Wish Affects

[GitHub] [flink] flinkbot edited a comment on pull request #13756: [FLINK-19770][python][test] Changed the PythonProgramOptionTest to be an ITCase.

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13756: URL: https://github.com/apache/flink/pull/13756#issuecomment-714895505 ## CI report: * 9c215d1339aebe0b7249dc6e06b5a5d5d74c25c5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13744: [FLINK-19766][table-runtime] Introduce File streaming compaction operators

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13744: URL: https://github.com/apache/flink/pull/13744#issuecomment-714369975 ## CI report: * 164c8b5b7750ed567813d70f160ef9f064d0a3b0 Azure:

[jira] [Comment Edited] (FLINK-19847) Can we create a fast support on the Nested table join?

2020-10-28 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222033#comment-17222033 ] xiaogang zhou edited comment on FLINK-19847 at 10/28/20, 8:20 AM: -- In

[jira] [Commented] (FLINK-19847) Can we create a fast support on the Nested table join?

2020-10-28 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222033#comment-17222033 ] xiaogang zhou commented on FLINK-19847: --- In our situation, we use a Asynclookup for the redis and

[GitHub] [flink] dawidwys commented on a change in pull request #13763: [FLINK-19779][avro] Remove the record_ field name prefix for Confluen…

2020-10-28 Thread GitBox
dawidwys commented on a change in pull request #13763: URL: https://github.com/apache/flink/pull/13763#discussion_r513252724 ## File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverter.java ## @@ -297,17 +299,22 @@ private

[GitHub] [flink] dawidwys commented on a change in pull request #13763: [FLINK-19779][avro] Remove the record_ field name prefix for Confluen…

2020-10-28 Thread GitBox
dawidwys commented on a change in pull request #13763: URL: https://github.com/apache/flink/pull/13763#discussion_r513253682 ## File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverter.java ## @@ -297,17 +299,22 @@ private

[GitHub] [flink] liuyongvs opened a new pull request #13818: [FLINK-19848][docs] fix docs bug of build flink.

2020-10-28 Thread GitBox
liuyongvs opened a new pull request #13818: URL: https://github.com/apache/flink/pull/13818 ## What is the purpose of the change *fix docs bug of build flink.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it

[jira] [Updated] (FLINK-19848) flink docs of Building Flink from Source bug

2020-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19848: --- Labels: pull-request-available (was: ) > flink docs of Building Flink from Source bug >

[jira] [Updated] (FLINK-19834) Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-19834: --- Component/s: Tests > Make the TestSink reusable in all the sink related tests. >

[jira] [Updated] (FLINK-19834) Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-19834: --- Affects Version/s: 1.12.0 > Make the TestSink reusable in all the sink related tests. >

[jira] [Updated] (FLINK-19834) Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-19834: --- Fix Version/s: 1.12.0 > Make the TestSink reusable in all the sink related tests. >

[jira] [Assigned] (FLINK-19834) Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-19834: -- Assignee: Guowei Ma > Make the TestSink reusable in all the sink related tests. >

[GitHub] [flink] gm7y8 commented on pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-28 Thread GitBox
gm7y8 commented on pull request #13458: URL: https://github.com/apache/flink/pull/13458#issuecomment-717796453 > Thanks @gm7y8 . Additionally, I verified manually that the changes result in the expected behavior. Let's wait for @vthinkxie to get back to us to review the code itself.

[GitHub] [flink] zhuxiaoshang opened a new pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink

2020-10-28 Thread GitBox
zhuxiaoshang opened a new pull request #13819: URL: https://github.com/apache/flink/pull/13819 ## What is the purpose of the change *fix some mistakes in StreamingFileSink* ## Brief change log - *fix some mistakes in StreamingFileSink* ## Verifying this

[GitHub] [flink] shouweikun commented on pull request #13789: [FLINK-19727][table-runtime] Implement ParallelismProvider for sink i…

2020-10-28 Thread GitBox
shouweikun commented on pull request #13789: URL: https://github.com/apache/flink/pull/13789#issuecomment-717800065 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (FLINK-19847) Can we create a fast support on the Nested table join?

2020-10-28 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-19847: - Component/s: (was: API / DataStream) Table SQL / Runtime

[jira] [Created] (FLINK-19851) flink sql client connector type jdbc exception

2020-10-28 Thread hulingchan (Jira)
hulingchan created FLINK-19851: -- Summary: flink sql client connector type jdbc exception Key: FLINK-19851 URL: https://issues.apache.org/jira/browse/FLINK-19851 Project: Flink Issue Type: Bug

[GitHub] [flink] flinkbot edited a comment on pull request #13744: [FLINK-19766][table-runtime] Introduce File streaming compaction operators

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13744: URL: https://github.com/apache/flink/pull/13744#issuecomment-714369975 ## CI report: * 164c8b5b7750ed567813d70f160ef9f064d0a3b0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13697: [FLINK-19357][FLINK-19357][fs-connector] Introduce createBucketWriter to BucketsBuilder & Introduce FileLifeCycleListener to Buckets

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13697: URL: https://github.com/apache/flink/pull/13697#issuecomment-712672697 ## CI report: * b45885955bfdee4d4288f9273171e1d52379773f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13789: [FLINK-19727][table-runtime] Implement ParallelismProvider for sink i…

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13789: URL: https://github.com/apache/flink/pull/13789#issuecomment-716299701 ## CI report: * 6329930d7acc5d2d4d84e777561e79bd25ac9367 Azure:

[jira] [Created] (FLINK-19852) Managed memory released check can block IterativeTask

2020-10-28 Thread shaomeng.wang (Jira)
shaomeng.wang created FLINK-19852: - Summary: Managed memory released check can block IterativeTask Key: FLINK-19852 URL: https://issues.apache.org/jira/browse/FLINK-19852 Project: Flink

[GitHub] [flink] becketqin commented on pull request #13574: [FLINK-18323] Add a Kafka source implementation based on FLIP-27.

2020-10-28 Thread GitBox
becketqin commented on pull request #13574: URL: https://github.com/apache/flink/pull/13574#issuecomment-717837286 @StephanEwen I am trying to address the blocking close() method issue. However, it is a little more complicated than I thought. I want to align some design principle with you

[jira] [Closed] (FLINK-19851) flink sql client connector type jdbc exception

2020-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-19851. --- Resolution: Not A Problem > flink sql client connector type jdbc exception >

[jira] [Commented] (FLINK-19851) flink sql client connector type jdbc exception

2020-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222081#comment-17222081 ] Jark Wu commented on FLINK-19851: - Hi [~hulingchan], the exception tells that there is no JDBC factory

[GitHub] [flink] flinkbot edited a comment on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13620: URL: https://github.com/apache/flink/pull/13620#issuecomment-707904494 ## CI report: * 16f95599c033e72ce486b06dd3d527abd656b1a9 Azure:

[GitHub] [flink] StephanEwen commented on a change in pull request #13784: [FLINK-19698][connectors/common] API improvements to the Sources.

2020-10-28 Thread GitBox
StephanEwen commented on a change in pull request #13784: URL: https://github.com/apache/flink/pull/13784#discussion_r513286480 ## File path: flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java ## @@ -565,6 +565,20 @@ else if (t instanceof Error) {

[GitHub] [flink] flinkbot edited a comment on pull request #13789: [FLINK-19727][table-runtime] Implement ParallelismProvider for sink i…

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13789: URL: https://github.com/apache/flink/pull/13789#issuecomment-716299701 ## CI report: * 6329930d7acc5d2d4d84e777561e79bd25ac9367 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13784: [FLINK-19698][connectors/common] API improvements to the Sources.

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13784: URL: https://github.com/apache/flink/pull/13784#issuecomment-716153889 ## CI report: * ca695f256a825fdebadf79f576b0875d4faea7cd Azure:

[jira] [Created] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Robert Metzger (Jira)
Robert Metzger created FLINK-19854: -- Summary: TableScanTest.testTemporalJoinOnUpsertSource fails Key: FLINK-19854 URL: https://issues.apache.org/jira/browse/FLINK-19854 Project: Flink Issue

[jira] [Updated] (FLINK-19833) Rename Sink API Writer interface to SinkWriter

2020-10-28 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-19833: --- Fix Version/s: 1.12.0 > Rename Sink API Writer interface to SinkWriter >

[jira] [Assigned] (FLINK-19833) Rename Sink API Writer interface to SinkWriter

2020-10-28 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-19833: -- Assignee: Guowei Ma (was: Kostas Kloudas) > Rename Sink API Writer interface to

[GitHub] [flink] flinkbot edited a comment on pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13819: URL: https://github.com/apache/flink/pull/13819#issuecomment-717834371 ## CI report: * e4cf3eb0b429e4ffe12a5053e0d8110c2eb50693 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13817: [HotFix][docs] Fix broken link of docker.md

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13817: URL: https://github.com/apache/flink/pull/13817#issuecomment-717771629 ## CI report: * f7fcad2291f072819e6576b291327abd16947445 Azure:

[jira] [Updated] (FLINK-19833) Rename Sink API Writer interface to SinkWriter

2020-10-28 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-19833: --- Affects Version/s: 1.12.0 > Rename Sink API Writer interface to SinkWriter >

[jira] [Assigned] (FLINK-19833) Rename Sink API Writer interface to SinkWriter

2020-10-28 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-19833: -- Assignee: Kostas Kloudas > Rename Sink API Writer interface to SinkWriter >

[GitHub] [flink] StephanEwen commented on pull request #13595: [FLINK-19582][network] Introduce sort-merge based blocking shuffle to Flink

2020-10-28 Thread GitBox
StephanEwen commented on pull request #13595: URL: https://github.com/apache/flink/pull/13595#issuecomment-717865867 @wsry Your suggestion sounds good to me! This is an automated message from the Apache Git Service. To

[jira] [Created] (FLINK-19856) Add EndOfChannelRecovery rescaling epoch

2020-10-28 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-19856: - Summary: Add EndOfChannelRecovery rescaling epoch Key: FLINK-19856 URL: https://issues.apache.org/jira/browse/FLINK-19856 Project: Flink Issue

[GitHub] [flink] pnowojski opened a new pull request #13820: [FLINK-19671][codestyle] Revert .editorconfig change violating our coding style

2020-10-28 Thread GitBox
pnowojski opened a new pull request #13820: URL: https://github.com/apache/flink/pull/13820 https://flink.apache.org/contributing/code-style-and-quality-formatting.html#breaking-the-lines-of-too-long-statements > Rules about breaking the long lines: > > Break the argument list

[jira] [Updated] (FLINK-19856) Add EndOfChannelRecovery rescaling epoch

2020-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19856: --- Labels: pull-request-available (was: ) > Add EndOfChannelRecovery rescaling epoch >

[GitHub] [flink] rkhachatryan opened a new pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent

2020-10-28 Thread GitBox
rkhachatryan opened a new pull request #13822: URL: https://github.com/apache/flink/pull/13822 ## What is the purpose of the change Depends on #13821. The emitted event would allow to tear down "virtual channels" used to read channel state on recovery with unaligned

[GitHub] [flink] danny0405 commented on a change in pull request #13763: [FLINK-19779][avro] Remove the record_ field name prefix for Confluen…

2020-10-28 Thread GitBox
danny0405 commented on a change in pull request #13763: URL: https://github.com/apache/flink/pull/13763#discussion_r513370899 ## File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverter.java ## @@ -297,17 +299,22 @@ private

[GitHub] [flink] vthinkxie commented on a change in pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-10-28 Thread GitBox
vthinkxie commented on a change in pull request #13458: URL: https://github.com/apache/flink/pull/13458#discussion_r513374506 ## File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.ts ## @@ -55,21 +59,38 @@ export

[GitHub] [flink-statefun] tzulitai commented on a change in pull request #168: [FLINK-19692] Write all assigned key groups into the keyed raw stream with a Header.

2020-10-28 Thread GitBox
tzulitai commented on a change in pull request #168: URL: https://github.com/apache/flink-statefun/pull/168#discussion_r513379873 ## File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/logger/UnboundedFeedbackLogger.java ## @@

[GitHub] [flink] flinkbot edited a comment on pull request #13744: [FLINK-19766][table-runtime] Introduce File streaming compaction operators

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13744: URL: https://github.com/apache/flink/pull/13744#issuecomment-714369975 ## CI report: * 322bc2c3c11a0f5735db4a475864f894f38866da Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13789: [FLINK-19727][table-runtime] Implement ParallelismProvider for sink i…

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13789: URL: https://github.com/apache/flink/pull/13789#issuecomment-716299701 ## CI report: * 934e4f0acf9044de5c6cb73ae25d094396bfc146 UNKNOWN * fd0aa012ed1a15803fe2ed75180d60e6c9fe8d6d Azure:

[jira] [Updated] (FLINK-19836) Use provided Serializer for Sink Committables between operators

2020-10-28 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-19836: - Summary: Use provided Serializer for Sink Committables between operators (was:

[GitHub] [flink] flinkbot commented on pull request #13824: [FLINK-19736] Add the SinkTransformation

2020-10-28 Thread GitBox
flinkbot commented on pull request #13824: URL: https://github.com/apache/flink/pull/13824#issuecomment-717883808 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222115#comment-17222115 ] Robert Metzger commented on FLINK-19854: Pull requests are not rebased to the latest master when

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222116#comment-17222116 ] Robert Metzger commented on FLINK-19854: Thanks a lot for fixing this so quickly! >

[jira] [Updated] (FLINK-18640) Fix PostgresDialect doesn't quote the identifiers

2020-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-18640: Summary: Fix PostgresDialect doesn't quote the identifiers (was: Flink jdbc not support postgresql with

[GitHub] [flink] flinkbot commented on pull request #13825: [FLINK-19836] Add SimpleVersionedSerializerTypeSerializerProxy

2020-10-28 Thread GitBox
flinkbot commented on pull request #13825: URL: https://github.com/apache/flink/pull/13825#issuecomment-717888135 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Closed] (FLINK-19829) should enclose column name in double quotes for PostgreSQL

2020-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-19829. --- Resolution: Duplicate > should enclose column name in double quotes for PostgreSQL >

[GitHub] [flink] aljoscha commented on pull request #13808: [FLINK-19834] Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread GitBox
aljoscha commented on pull request #13808: URL: https://github.com/apache/flink/pull/13808#issuecomment-717817391 I merged this, but I renamed all the builder methods to `setFoo()` instead of `addFoo()` because they are setting a thing and not adding to a list of things.

[jira] [Closed] (FLINK-19834) Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-19834. Resolution: Implemented master: 0a983188cdcde0c8a5f024e59a3fb5ddc65f16b8 > Make the

[GitHub] [flink] aljoscha closed pull request #13808: [FLINK-19834] Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread GitBox
aljoscha closed pull request #13808: URL: https://github.com/apache/flink/pull/13808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] zentol commented on pull request #13796: [FLINK-19810][CI] Automatically run a basic NOTICE file check on CI

2020-10-28 Thread GitBox
zentol commented on pull request #13796: URL: https://github.com/apache/flink/pull/13796#issuecomment-717821843 I'm still not a fan of automating the verification; people _will_ see the tool as the source of truth (which it isn't, as you pointed out), and any attempt at automating the

[GitHub] [flink] guoweiM commented on pull request #13808: [FLINK-19834] Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread GitBox
guoweiM commented on pull request #13808: URL: https://github.com/apache/flink/pull/13808#issuecomment-717821255 > +1 for merging from me as soon as AZP given green, but I think @aljoscha 's comments are not in the branch. > I merged this, but I renamed all the builder

[GitHub] [flink] flinkbot edited a comment on pull request #13605: [FLINK-19599][table] Introduce Filesystem format factories to integrate new FileSource to table

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13605: URL: https://github.com/apache/flink/pull/13605#issuecomment-707521684 ## CI report: * a9df8a1384eb6306656b4fd952edd4be5d7a857d UNKNOWN * fa0dc913f56aa2567c30073c044f688f9ed74fee Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13620: URL: https://github.com/apache/flink/pull/13620#issuecomment-707904494 ## CI report: * 16f95599c033e72ce486b06dd3d527abd656b1a9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13812: [FLINK-19674][docs-zh] Translate "Docker" of "Clusters & Depolyment" page into Chinese

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13812: URL: https://github.com/apache/flink/pull/13812#issuecomment-717687160 ## CI report: * 74a934ea4dd99e6bc44ac84a9f314468faf8376b Azure:

[GitHub] [flink] liuyongvs closed pull request #13818: [FLINK-19848][docs] fix docs bug of build flink.

2020-10-28 Thread GitBox
liuyongvs closed pull request #13818: URL: https://github.com/apache/flink/pull/13818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot commented on pull request #13818: [FLINK-19848][docs] fix docs bug of build flink.

2020-10-28 Thread GitBox
flinkbot commented on pull request #13818: URL: https://github.com/apache/flink/pull/13818#issuecomment-717833523 ## CI report: * 80c826228cfa96218b23bd087f4047673e91f734 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Assigned] (FLINK-19837) Don't emit intermediate watermarks from watermark operators in BATCH execution mode

2020-10-28 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-19837: Assignee: Nicholas Jiang > Don't emit intermediate watermarks from watermark

[jira] [Commented] (FLINK-19829) should enclose column name in double quotes for PostgreSQL

2020-10-28 Thread zl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222101#comment-17222101 ] zl commented on FLINK-19829: Hi [~jark], can you take a look at this issue ? > should enclose column name

[GitHub] [flink] flinkbot commented on pull request #13820: [FLINK-19671][codestyle] Revert .editorconfig change violating our coding style

2020-10-28 Thread GitBox
flinkbot commented on pull request #13820: URL: https://github.com/apache/flink/pull/13820#issuecomment-717870794 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] rkhachatryan opened a new pull request #13821: [FLINK-19855][network] Specify channel AND gate in resumeConsumption()

2020-10-28 Thread GitBox
rkhachatryan opened a new pull request #13821: URL: https://github.com/apache/flink/pull/13821 ## What is the purpose of the change Replace `channelIndex` with `ChannelInfo` in resumeConsumption methods of `InputGate` and `CheckpointableInput`. Given `channelIndex` only,

[jira] [Updated] (FLINK-19855) Incompatible semantics of channelIndex in UnionInputGate.resumeConsumption and its clients

2020-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19855: --- Labels: pull-request-available (was: ) > Incompatible semantics of channelIndex in

[GitHub] [flink] leonardBang commented on pull request #13823: [hot-fix][table-planner-blink] Fix TableScanTest which used temporal …

2020-10-28 Thread GitBox
leonardBang commented on pull request #13823: URL: https://github.com/apache/flink/pull/13823#issuecomment-717878191 cc @wuchong Could you have a quick look ? thanks This is an automated message from the Apache Git Service.

[GitHub] [flink] wuchong merged pull request #13823: [hot-fix][table-planner-blink] Fix TableScanTest which used temporal …

2020-10-28 Thread GitBox
wuchong merged pull request #13823: URL: https://github.com/apache/flink/pull/13823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (FLINK-19836) Use provided Serializer for Sink Committables sent between operators

2020-10-28 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-19836: - Summary: Use provided Serializer for Sink Committables sent between operators (was:

[jira] [Updated] (FLINK-19736) Implement the `SinkTransformation`

2020-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19736: --- Labels: pull-request-available (was: ) > Implement the `SinkTransformation` >

[jira] [Assigned] (FLINK-19836) Use provided Serializer for Sink Committables sent between operators

2020-10-28 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-19836: Assignee: Aljoscha Krettek > Use provided Serializer for Sink Committables sent

[jira] [Commented] (FLINK-19829) should enclose column name in double quotes for PostgreSQL

2020-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222117#comment-17222117 ] Jark Wu commented on FLINK-19829: - Hi [~Leo Zhou], thanks for reporting this issue. This is a known

[GitHub] [flink] flinkbot edited a comment on pull request #13817: [HotFix][docs] Fix broken link of docker.md

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13817: URL: https://github.com/apache/flink/pull/13817#issuecomment-717771629 ## CI report: * f7fcad2291f072819e6576b291327abd16947445 Azure:

[jira] [Commented] (FLINK-13598) frocksdb doesn't have arm release

2020-10-28 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222061#comment-17222061 ] Yun Tang commented on FLINK-13598: -- [~wangxiyuan] we're planing to upgrade RocksDB version in

[GitHub] [flink] flinkbot edited a comment on pull request #13813: [FLINK-19491][avro] AvroSerializerSnapshot cannot handle large schema

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13813: URL: https://github.com/apache/flink/pull/13813#issuecomment-717706259 ## CI report: * 61014eba30b67fc21a965f876d9484dd3873e14d Azure:

[GitHub] [flink] kl0u commented on a change in pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink

2020-10-28 Thread GitBox
kl0u commented on a change in pull request #13819: URL: https://github.com/apache/flink/pull/13819#discussion_r513331116 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java ## @@ -137,12 +137,12 @@

[jira] [Commented] (FLINK-19847) Can we create a fast support on the Nested table join?

2020-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222084#comment-17222084 ] Jark Wu commented on FLINK-19847: - Yes, it is recommended to specify multiple flat fields rather than

[GitHub] [flink] Sxnan commented on a change in pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed

2020-10-28 Thread GitBox
Sxnan commented on a change in pull request #13073: URL: https://github.com/apache/flink/pull/13073#discussion_r513334483 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java ## @@ -163,6 +164,7 @@ public void

  1   2   3   4   5   6   >