[GitHub] [flink] lsyldliu opened a new pull request, #19553: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table

2022-04-22 Thread GitBox
lsyldliu opened a new pull request, #19553: URL: https://github.com/apache/flink/pull/19553 ## What is the purpose of the change Support SHOW PARTITIONS statement for partitioned table ## Brief change log - *Support SHOW PARTITIONS statement for partitioned table*

[GitHub] [flink] alpreu commented on a diff in pull request #19377: [FLINK-27048][test] Add ArchUnit rule that connectors should only depend on public API

2022-04-22 Thread GitBox
alpreu commented on code in PR #19377: URL: https://github.com/apache/flink/pull/19377#discussion_r855846859 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java: ## @@ -0,0 +1,69 @@ +/* + *

[jira] [Updated] (FLINK-27243) Support SHOW PARTITIONS statement for partitioned table

2022-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27243: --- Labels: pull-request-available (was: ) > Support SHOW PARTITIONS statement for partitioned

[GitHub] [flink] flinkbot commented on pull request #19554: [FLINK-27351][tests] Use sane TM resource spec

2022-04-22 Thread GitBox
flinkbot commented on PR #19554: URL: https://github.com/apache/flink/pull/19554#issuecomment-1106108502 ## CI report: * 9b48269ad19f2534e29c719cf8ffdb8c6eb5f1e8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27351) TaskExecutorBuilder configures unreasonable amount of memory

2022-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27351: --- Labels: pull-request-available (was: ) > TaskExecutorBuilder configures unreasonable

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #177: [FLINK-27303][FLINK-27309] Introduce FlinkConfigManager for efficient config management

2022-04-22 Thread GitBox
gyfora commented on PR #177: URL: https://github.com/apache/flink-kubernetes-operator/pull/177#issuecomment-1106114156 > Just a quick note: instead of creating a watch on the ConfigMap, I prefer to simply use `ScheduledExecutorService#scheduleAtFixedRate` to detect default configuration

[jira] [Commented] (FLINK-24434) PyFlink YARN per-job on Docker test fails on Azure

2022-04-22 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526209#comment-17526209 ] Yun Gao commented on FLINK-24434: - 1.14:

[jira] [Commented] (FLINK-27155) Reduce multiple reads to the same Changelog file in the same taskmanager during restore

2022-04-22 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526218#comment-17526218 ] Feifan Wang commented on FLINK-27155: - I considered the reference count implementation, and one

[GitHub] [flink-kubernetes-operator] wangyang0918 merged pull request #168: [FLINK-27161] Support fetch user jar from different source

2022-04-22 Thread GitBox
wangyang0918 merged PR #168: URL: https://github.com/apache/flink-kubernetes-operator/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #177: [FLINK-27303][FLINK-27309] Introduce FlinkConfigManager for efficient config management

2022-04-22 Thread GitBox
wangyang0918 commented on PR #177: URL: https://github.com/apache/flink-kubernetes-operator/pull/177#issuecomment-1106075709 Just a quick note: instead of creating a watch on the ConfigMap, I prefer to simply use `ScheduledExecutorService#scheduleAtFixedRate` to detect default

[GitHub] [flink] alpreu opened a new pull request, #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-04-22 Thread GitBox
alpreu opened a new pull request, #19552: URL: https://github.com/apache/flink/pull/19552 This PR fixes and grandfathers #19425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-27155) Reduce multiple reads to the same Changelog file in the same taskmanager during restore

2022-04-22 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526258#comment-17526258 ] Yun Tang commented on FLINK-27155: -- >From my experiences, serializing the acesses to the same file coud

[jira] [Closed] (FLINK-27345) operator does not update related resource when flinkConfiguration, logConfiguration are updated.

2022-04-22 Thread 陳昌倬
[ https://issues.apache.org/jira/browse/FLINK-27345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChangZhuo Chen (陳昌倬) closed FLINK-27345. Resolution: Invalid > operator does not update related resource when

[jira] [Commented] (FLINK-27345) operator does not update related resource when flinkConfiguration, logConfiguration are updated.

2022-04-22 Thread 陳昌倬
[ https://issues.apache.org/jira/browse/FLINK-27345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526264#comment-17526264 ] ChangZhuo Chen (陳昌倬) commented on FLINK-27345: -- Looks like it can be updated now, thanks

[GitHub] [flink] adiaixin commented on pull request #18719: [FLINK-22781][table-planner-blink] Fix bug that when implements the LookupFunction In SQL that indirect extends (Async)TableFunction, throw

2022-04-22 Thread GitBox
adiaixin commented on PR #18719: URL: https://github.com/apache/flink/pull/18719#issuecomment-1106075545 @twalthr hi, could you review this pr when you are free ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] flinkbot commented on pull request #19553: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table

2022-04-22 Thread GitBox
flinkbot commented on PR #19553: URL: https://github.com/apache/flink/pull/19553#issuecomment-1106103994 ## CI report: * bdbe0ba06575e3b32e6b87ebe456f6cf0a57 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zentol commented on a diff in pull request #19445: [FLINK-27209][build] Half the memory and double forkCount for running unit tests

2022-04-22 Thread GitBox
zentol commented on code in PR #19445: URL: https://github.com/apache/flink/pull/19445#discussion_r855849054 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorRecoveryITCase.java: ## @@ -58,7 +58,7 @@ /** Recovery tests for {@link

[GitHub] [flink] flinkbot commented on pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-04-22 Thread GitBox
flinkbot commented on PR #19552: URL: https://github.com/apache/flink/pull/19552#issuecomment-1106103895 ## CI report: * 16349ae9b8c9293dbfbb6034abd58709145565d9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] JingGe commented on a diff in pull request #19377: [FLINK-27048][test] Add ArchUnit rule that connectors should only depend on public API

2022-04-22 Thread GitBox
JingGe commented on code in PR #19377: URL: https://github.com/apache/flink/pull/19377#discussion_r855893792 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java: ## @@ -0,0 +1,69 @@ +/* + *

[jira] [Created] (FLINK-27351) TaskExecutorBuilder configures unreasonable amount of memory

2022-04-22 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-27351: Summary: TaskExecutorBuilder configures unreasonable amount of memory Key: FLINK-27351 URL: https://issues.apache.org/jira/browse/FLINK-27351 Project: Flink

[jira] [Commented] (FLINK-27340) [JUnit5 Migration] Module: flink-python

2022-04-22 Thread EMing Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526234#comment-17526234 ] EMing Zhou commented on FLINK-27340: Hi [~Sergey Nuyanzin]      Can I get the ticket?   > [JUnit5

[jira] [Commented] (FLINK-27345) operator does not update related resource when flinkConfiguration, logConfiguration are updated.

2022-04-22 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526255#comment-17526255 ] Yang Wang commented on FLINK-27345: --- I think updating the flinkConfiguration or logConfiguration in CR

[jira] [Comment Edited] (FLINK-27345) operator does not update related resource when flinkConfiguration, logConfiguration are updated.

2022-04-22 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526255#comment-17526255 ] Yang Wang edited comment on FLINK-27345 at 4/22/22 8:05 AM: I think updating

[jira] [Updated] (FLINK-27352) [JUnit5 Migration] Module: flink-json

2022-04-22 Thread EMing Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] EMing Zhou updated FLINK-27352: --- Affects Version/s: (was: 1.16.0) > [JUnit5 Migration] Module: flink-json >

[GitHub] [flink] alpreu commented on a diff in pull request #19377: [FLINK-27048][test] Add ArchUnit rule that connectors should only depend on public API

2022-04-22 Thread GitBox
alpreu commented on code in PR #19377: URL: https://github.com/apache/flink/pull/19377#discussion_r855898749 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java: ## @@ -0,0 +1,69 @@ +/* + *

[jira] [Created] (FLINK-27352) [JUnit5 Migration] Module: flink-json

2022-04-22 Thread EMing Zhou (Jira)
EMing Zhou created FLINK-27352: -- Summary: [JUnit5 Migration] Module: flink-json Key: FLINK-27352 URL: https://issues.apache.org/jira/browse/FLINK-27352 Project: Flink Issue Type: Sub-task

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #178: [FLINK-27334] Support auto generate the doc for the `KubernetesOperatorConfigOptions`

2022-04-22 Thread GitBox
wangyang0918 commented on code in PR #178: URL: https://github.com/apache/flink-kubernetes-operator/pull/178#discussion_r855853330 ## Dockerfile: ## @@ -23,21 +23,23 @@ WORKDIR /app ENV SHADED_DIR=flink-kubernetes-shaded ENV OPERATOR_DIR=flink-kubernetes-operator ENV

[jira] [Closed] (FLINK-27161) Support user jar from different type of filesystems

2022-04-22 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang closed FLINK-27161. - Resolution: Fixed Fixed via: main: f7ee710e1b66885f57ab422ccb2293176df6c503 > Support user jar from

[GitHub] [flink] zentol commented on a diff in pull request #19445: [FLINK-27209][build] Half the memory and double forkCount for running unit tests

2022-04-22 Thread GitBox
zentol commented on code in PR #19445: URL: https://github.com/apache/flink/pull/19445#discussion_r855835204 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorRecoveryITCase.java: ## @@ -58,7 +58,7 @@ /** Recovery tests for {@link

[GitHub] [flink] masteryhx commented on a diff in pull request #19142: [FLINK-23252][changelog] Support recovery from checkpoint after disab…

2022-04-22 Thread GitBox
masteryhx commented on code in PR #19142: URL: https://github.com/apache/flink/pull/19142#discussion_r855863007 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java: ## @@ -155,6 +155,25 @@ public AbstractKeyedStateBackend(

[GitHub] [flink] masteryhx commented on a diff in pull request #19142: [FLINK-23252][changelog] Support recovery from checkpoint after disab…

2022-04-22 Thread GitBox
masteryhx commented on code in PR #19142: URL: https://github.com/apache/flink/pull/19142#discussion_r855863884 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChangelogStorageLoader.java: ## @@ -99,4 +101,24 @@ public static StateChangelogStorage

[GitHub] [flink] flinkbot commented on pull request #19555: [FLINK-23659][metrics][prometheus] Cleanup code

2022-04-22 Thread GitBox
flinkbot commented on PR #19555: URL: https://github.com/apache/flink/pull/19555#issuecomment-1106223761 ## CI report: * 81e659448db7c78ee65291996ada0fc9d48f4081 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Resolved] (FLINK-26382) Add Chinese documents for flink-training exercises

2022-04-22 Thread Nico Kruber (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber resolved FLINK-26382. - Fix Version/s: 1.15.0 1.14.5 (was: 1.14.3)

[GitHub] [flink-training] NicoK opened a new pull request, #48: [FLINK-27353] Update to Flink 1.15

2022-04-22 Thread GitBox
NicoK opened a new pull request, #48: URL: https://github.com/apache/flink-training/pull/48 This PR will only go through CI once 1.15.0 is released. Until then, you can apply the following change to `build.gradle` to see it in action: ``` flinkVersion = '1.15-SNAPSHOT' ``` --

[jira] [Created] (FLINK-27354) JobMaster still processes requests while terminating

2022-04-22 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-27354: - Summary: JobMaster still processes requests while terminating Key: FLINK-27354 URL: https://issues.apache.org/jira/browse/FLINK-27354 Project: Flink Issue

[GitHub] [flink] zoltar9264 commented on pull request #19441: [FLINK-27187][state/changelog] Add changelog storage metric totalAttemptsPerUpload

2022-04-22 Thread GitBox
zoltar9264 commented on PR #19441: URL: https://github.com/apache/flink/pull/19441#issuecomment-1106451265 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-table-store] JingsongLi commented on pull request #99: [FLINK-27307] Flink table store support append-only ingestion without primary keys.

2022-04-22 Thread GitBox
JingsongLi commented on PR #99: URL: https://github.com/apache/flink-table-store/pull/99#issuecomment-1106466192 > The different manifests design for both two kinds of tables. Can you clarify which parts of the design are different? > What's the read API abstraction for those

[jira] [Updated] (FLINK-26413) Hive dialect support "LOAD DATA INPATH"

2022-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26413: --- Labels: pull-request-available (was: ) > Hive dialect support "LOAD DATA INPATH" >

[GitHub] [flink] snuyanzin opened a new pull request, #19557: [hotfix][docs] Fix class name in docs for ExecutionEnvironment class

2022-04-22 Thread GitBox
snuyanzin opened a new pull request, #19557: URL: https://github.com/apache/flink/pull/19557 ## What is the purpose of the change Trivial misprint fix class name for `ExecutionEnvironment` class in docs/content.zh/docs/connectors/datastream/formats/hadoop.md

[jira] (FLINK-27340) [JUnit5 Migration] Module: flink-python

2022-04-22 Thread EMing Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27340 ] EMing Zhou deleted comment on FLINK-27340: was (Author: zsigner): Hi [~Sergey Nuyanzin]      Can I get the ticket?   > [JUnit5 Migration] Module: flink-python >

[GitHub] [flink] dawidwys commented on a diff in pull request #18539: [FLINK-25745] Support RocksDB incremental native savepoints

2022-04-22 Thread GitBox
dawidwys commented on code in PR #18539: URL: https://github.com/apache/flink/pull/18539#discussion_r856213164 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/Checkpoints.java: ## @@ -369,4 +373,37 @@ public static CheckpointStorage loadCheckpointStorage(

[GitHub] [flink] dawidwys commented on a diff in pull request #18539: [FLINK-25745] Support RocksDB incremental native savepoints

2022-04-22 Thread GitBox
dawidwys commented on code in PR #18539: URL: https://github.com/apache/flink/pull/18539#discussion_r856213164 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/Checkpoints.java: ## @@ -369,4 +373,37 @@ public static CheckpointStorage loadCheckpointStorage(

[jira] [Updated] (FLINK-23659) Cleanup Prometheus reporter

2022-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23659: --- Labels: pull-request-available (was: ) > Cleanup Prometheus reporter >

[GitHub] [flink] zentol opened a new pull request, #19555: [FLINK-23659][metrics][prometheus] Cleanup code

2022-04-22 Thread GitBox
zentol opened a new pull request, #19555: URL: https://github.com/apache/flink/pull/19555 General cleanup in the prometheus reporter code base. Removes various warnings, simplifies some tests and reduces dependencies on runtime-internals. -- This is an automated message from the Apache

[jira] [Updated] (FLINK-24144) Improve DataGenerator to prevent excessive creation of new Random objects

2022-04-22 Thread Nico Kruber (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-24144: Priority: Not a Priority (was: Major) > Improve DataGenerator to prevent excessive creation of

[jira] [Assigned] (FLINK-24144) Improve DataGenerator to prevent excessive creation of new Random objects

2022-04-22 Thread Nico Kruber (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber reassigned FLINK-24144: --- Assignee: (was: Nico Kruber) > Improve DataGenerator to prevent excessive creation of

[GitHub] [flink-ml] HuangXingBo closed pull request #88: [FLINK-26268][ml][python] Add classfication algorithm support for LogisticRegression, KNN and NaiveBayes in ML Python API

2022-04-22 Thread GitBox
HuangXingBo closed pull request #88: [FLINK-26268][ml][python] Add classfication algorithm support for LogisticRegression, KNN and NaiveBayes in ML Python API URL: https://github.com/apache/flink-ml/pull/88 -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Assigned] (FLINK-26268) Add classfication algorithm support for LogisticRegression, KNN and NaiveBayes in ML Python API

2022-04-22 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo reassigned FLINK-26268: Assignee: Huang Xingbo > Add classfication algorithm support for LogisticRegression, KNN

[jira] [Commented] (FLINK-27348) Flink KafkaSource doesn't set groupId

2022-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526291#comment-17526291 ] Ahmet Gürbüz commented on FLINK-27348: -- How will i do that with KafkaSource? [~Jiangang]  > Flink

[jira] [Closed] (FLINK-11694) Enforce space before left curly brace

2022-04-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-11694. Resolution: Fixed Should be covered by spotless. > Enforce space before left curly brace

[jira] [Created] (FLINK-27353) Update training exercises to use Flink 1.15

2022-04-22 Thread Nico Kruber (Jira)
Nico Kruber created FLINK-27353: --- Summary: Update training exercises to use Flink 1.15 Key: FLINK-27353 URL: https://issues.apache.org/jira/browse/FLINK-27353 Project: Flink Issue Type: New

[GitHub] [flink] afedulov commented on pull request #19405: [FLINK-27066] Reintroduce e2e tests in ES as Java tests.

2022-04-22 Thread GitBox
afedulov commented on PR #19405: URL: https://github.com/apache/flink/pull/19405#issuecomment-1106341694 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-26114) DefaultScheduler fails fatally in case of an error when shutting down the checkpoint-related resources

2022-04-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-26114: -- Description: In contrast to the {{AdaptiveScheduler}}, the {{DefaultScheduler}} fails

[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink

2022-04-22 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526331#comment-17526331 ] Fabian Paul commented on FLINK-27174: - I think that is a valid point. We introduced the 

[GitHub] [flink] rkhachatryan commented on a diff in pull request #18539: [FLINK-25745] Support RocksDB incremental native savepoints

2022-04-22 Thread GitBox
rkhachatryan commented on code in PR #18539: URL: https://github.com/apache/flink/pull/18539#discussion_r856196969 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/Checkpoints.java: ## @@ -369,4 +373,37 @@ public static CheckpointStorage loadCheckpointStorage(

[jira] [Commented] (FLINK-27215) JDBC sink transiently deleted a record because of -u message of that record

2022-04-22 Thread tim yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526283#comment-17526283 ] tim yu commented on FLINK-27215: Hi [~fsk119], I have seen some classes that like

[jira] [Created] (FLINK-27355) JobManagerRunnerRegistry.localCleanupAsync does not call the JobManagerRunner.close method repeatedly

2022-04-22 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-27355: - Summary: JobManagerRunnerRegistry.localCleanupAsync does not call the JobManagerRunner.close method repeatedly Key: FLINK-27355 URL:

[GitHub] [flink] snuyanzin commented on pull request #18109: [FLINK-25284][Table SQL / API] Add proportion of null values to generate with datagen

2022-04-22 Thread GitBox
snuyanzin commented on PR #18109: URL: https://github.com/apache/flink/pull/18109#issuecomment-1106425611 @JingsongLi sorry for the poke Since you are one of the committers dealing with datagen, could you please have a look here, once you have time? -- This is an automated message

[GitHub] [flink] fapaul commented on a diff in pull request #19405: [FLINK-27066] Reintroduce e2e tests in ES as Java tests.

2022-04-22 Thread GitBox
fapaul commented on code in PR #19405: URL: https://github.com/apache/flink/pull/19405#discussion_r856141131 ## flink-end-to-end-tests/flink-end-to-end-tests-elasticsearch7/pom.xml: ## @@ -30,10 +30,14 @@ under the License. .. -

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #176: [FLINK-27279] Extract common status interfaces

2022-04-22 Thread GitBox
gyfora commented on code in PR #176: URL: https://github.com/apache/flink-kubernetes-operator/pull/176#discussion_r856146587 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/status/ReconciliationStatus.java: ## @@ -54,19 +49,20 @@ public

[GitHub] [flink-table-store] JingsongLi commented on pull request #99: [FLINK-27307] Flink table store support append-only ingestion without primary keys.

2022-04-22 Thread GitBox
JingsongLi commented on PR #99: URL: https://github.com/apache/flink-table-store/pull/99#issuecomment-1106461636 Can we set the append-only write file to an empty key? This allows for a good integration of these two modes. Actually, `SstFileMeta` can be renamed to `DataFileMeta`. --

[GitHub] [flink] gaoyunhaii commented on pull request #19512: [FLINK-23902][connectors/hive] Make flink support Hive 3.1.3 version

2022-04-22 Thread GitBox
gaoyunhaii commented on PR #19512: URL: https://github.com/apache/flink/pull/19512#issuecomment-1106209669 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-27155) Reduce multiple reads to the same Changelog file in the same taskmanager during restore

2022-04-22 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526281#comment-17526281 ] Feifan Wang commented on FLINK-27155: - Thanks for your reply [~yunta] , I think we can serialize all

[GitHub] [flink-table-store] openinx opened a new pull request, #99: [FLINK-27307] Flink table store support append-only ingestion without primary keys.

2022-04-22 Thread GitBox
openinx opened a new pull request, #99: URL: https://github.com/apache/flink-table-store/pull/99 This PR is trying to provide table store the ability to accept append-only ingestion without any defined primary keys. The previous table store abstraction are built on top of primary

[jira] [Updated] (FLINK-27307) Flink table store support append-only ingestion without primary keys.

2022-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27307: --- Labels: pull-request-available (was: ) > Flink table store support append-only ingestion

[jira] [Comment Edited] (FLINK-27348) Flink KafkaSource doesn't set groupId

2022-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526291#comment-17526291 ] Ahmet Gürbüz edited comment on FLINK-27348 at 4/22/22 9:49 AM: --- Yes i

[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink

2022-04-22 Thread Zhengqi Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526313#comment-17526313 ] Zhengqi Zhang commented on FLINK-27174: --- [~fpaul] , please take a look > Non-null check for

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #178: [FLINK-27334] Support auto generate the doc for the `KubernetesOperatorConfigOptions`

2022-04-22 Thread GitBox
SteNicholas commented on code in PR #178: URL: https://github.com/apache/flink-kubernetes-operator/pull/178#discussion_r856126535 ## Dockerfile: ## @@ -23,21 +23,23 @@ WORKDIR /app ENV SHADED_DIR=flink-kubernetes-shaded ENV OPERATOR_DIR=flink-kubernetes-operator ENV

[jira] [Comment Edited] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink

2022-04-22 Thread Zhengqi Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526356#comment-17526356 ] Zhengqi Zhang edited comment on FLINK-27174 at 4/22/22 11:57 AM: - Yes.

[GitHub] [flink] luoyuxia opened a new pull request, #19556: [FLINK-26413][hive] Hive dialect supports "LOAD DATA INPATH"

2022-04-22 Thread GitBox
luoyuxia opened a new pull request, #19556: URL: https://github.com/apache/flink/pull/19556 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] flinkbot commented on pull request #19557: [hotfix][docs] Fix class name in docs for ExecutionEnvironment class

2022-04-22 Thread GitBox
flinkbot commented on PR #19557: URL: https://github.com/apache/flink/pull/19557#issuecomment-1106473407 ## CI report: * 1940799765d3b35c3e93f7bc6f78138f1e33fbbb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #19556: [FLINK-26413][hive] Hive dialect supports "LOAD DATA INPATH"

2022-04-22 Thread GitBox
flinkbot commented on PR #19556: URL: https://github.com/apache/flink/pull/19556#issuecomment-1106473307 ## CI report: * 4d99ef8a1ea72740067fb5838d9c854a622be5d5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-27215) JDBC sink transiently deleted a record because of -u message of that record

2022-04-22 Thread tim yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tim yu closed FLINK-27215. -- Resolution: Not A Problem > JDBC sink transiently deleted a record because of -u message of that record >

[jira] [Comment Edited] (FLINK-27155) Reduce multiple reads to the same Changelog file in the same taskmanager during restore

2022-04-22 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526281#comment-17526281 ] Feifan Wang edited comment on FLINK-27155 at 4/22/22 9:08 AM: -- Thanks for

[jira] [Closed] (FLINK-26268) Add classfication algorithm support for LogisticRegression, KNN and NaiveBayes in ML Python API

2022-04-22 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo closed FLINK-26268. Resolution: Done Merged into master via aedf66335ff3475e449ebeee795d43372c9fa703 > Add

[jira] [Updated] (FLINK-26268) Add classfication algorithm support for LogisticRegression, KNN and NaiveBayes in ML Python API

2022-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26268: --- Labels: pull-request-available (was: ) > Add classfication algorithm support for

[jira] [Updated] (FLINK-27353) Update training exercises to use Flink 1.15

2022-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27353: --- Labels: pull-request-available (was: ) > Update training exercises to use Flink 1.15 >

[jira] [Closed] (FLINK-27348) Flink KafkaSource doesn't set groupId

2022-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmet Gürbüz closed FLINK-27348. Resolution: Done > Flink KafkaSource doesn't set groupId > -

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #176: [FLINK-27279] Extract common status interfaces

2022-04-22 Thread GitBox
gyfora commented on PR #176: URL: https://github.com/apache/flink-kubernetes-operator/pull/176#issuecomment-1106387142 Thank you, I will check this later today :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-web] NicoK commented on a diff in pull request #526: Announcement blogpost for the 1.15 release

2022-04-22 Thread GitBox
NicoK commented on code in PR #526: URL: https://github.com/apache/flink-web/pull/526#discussion_r856088102 ## _posts/2022-04-11-1.15-announcement.md: ## @@ -0,0 +1,431 @@ +--- +layout: post +title: "Announcing the Release of Apache Flink 1.15" +subtitle: "" +date:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #176: [FLINK-27279] Extract common status interfaces

2022-04-22 Thread GitBox
gyfora commented on code in PR #176: URL: https://github.com/apache/flink-kubernetes-operator/pull/176#discussion_r856142721 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconcileTarget.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink

2022-04-22 Thread Zhengqi Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526356#comment-17526356 ] Zhengqi Zhang commented on FLINK-27174: --- In the current code, if the user does not use the

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #99: [FLINK-27307] Flink table store support append-only ingestion without primary keys.

2022-04-22 Thread GitBox
JingsongLi commented on code in PR #99: URL: https://github.com/apache/flink-table-store/pull/99#discussion_r856178226 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/WriteMode.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] JulioPerezGitHub commented on pull request #17020: ---

2022-04-22 Thread GitBox
JulioPerezGitHub commented on PR #17020: URL: https://github.com/apache/flink/pull/17020#issuecomment-1106481367 https://discord.gg/ccZe2WMd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-training] NicoK merged pull request #46: [FLINK-26382]Add Chinese documents for flink-training exercises

2022-04-22 Thread GitBox
NicoK merged PR #46: URL: https://github.com/apache/flink-training/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-27155) Reduce multiple reads to the same Changelog file in the same taskmanager during restore

2022-04-22 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526298#comment-17526298 ] Roman Khachatryan commented on FLINK-27155: --- I think Yun Tang means waiting for all task of a

[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #176: [FLINK-27279] Extract common status interfaces

2022-04-22 Thread GitBox
Aitozi commented on PR #176: URL: https://github.com/apache/flink-kubernetes-operator/pull/176#issuecomment-1106331702 Due to the java type erasure, I can't not completly eliminate the `FlinkDeploymentReconciliationStatus` and `FlinkSessionJobReconciliationStatus` because I can't get the

[jira] [Assigned] (FLINK-26114) DefaultScheduler fails fatally in case of an error when shutting down the checkpoint-related resources

2022-04-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-26114: - Assignee: (was: Niklas Semmler) > DefaultScheduler fails fatally in case of an

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #176: [FLINK-27279] Extract common status interfaces

2022-04-22 Thread GitBox
gyfora commented on code in PR #176: URL: https://github.com/apache/flink-kubernetes-operator/pull/176#discussion_r856144200 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconcileTarget.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to

[GitHub] [flink] rkhachatryan commented on a diff in pull request #19441: [FLINK-27187][state/changelog] Add changelog storage metric totalAttemptsPerUpload

2022-04-22 Thread GitBox
rkhachatryan commented on code in PR #19441: URL: https://github.com/apache/flink/pull/19441#discussion_r856152839 ## flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/ChangelogStorageMetricsTest.java: ## @@ -295,6 +346,55 @@ public void close() { }

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #177: [FLINK-27303][FLINK-27309] Introduce FlinkConfigManager for efficient config management

2022-04-22 Thread GitBox
gyfora commented on PR #177: URL: https://github.com/apache/flink-kubernetes-operator/pull/177#issuecomment-1106522084 Reworked the watcher logic and added some more tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] rkhachatryan commented on a diff in pull request #18539: [FLINK-25745] Support RocksDB incremental native savepoints

2022-04-22 Thread GitBox
rkhachatryan commented on code in PR #18539: URL: https://github.com/apache/flink/pull/18539#discussion_r856290060 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/Checkpoints.java: ## @@ -369,4 +373,37 @@ public static CheckpointStorage loadCheckpointStorage(

[GitHub] [flink] rkhachatryan merged pull request #19508: [FLINK-27218] fix the problem that the internal Serializer in Operato…

2022-04-22 Thread GitBox
rkhachatryan merged PR #19508: URL: https://github.com/apache/flink/pull/19508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-26052) Update chinese documentation regarding FLIP-203

2022-04-22 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526480#comment-17526480 ] Dawid Wysakowicz commented on FLINK-26052: -- Sure, I've assigned it to you. Thank you for your

[jira] [Assigned] (FLINK-26052) Update chinese documentation regarding FLIP-203

2022-04-22 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-26052: Assignee: Feifan Wang > Update chinese documentation regarding FLIP-203 >

[GitHub] [flink-kubernetes-operator] SteNicholas commented on pull request #178: [FLINK-27334] Support auto generate the doc for the `KubernetesOperatorConfigOptions`

2022-04-22 Thread GitBox
SteNicholas commented on PR #178: URL: https://github.com/apache/flink-kubernetes-operator/pull/178#issuecomment-1106611797 @wangyang0918, thanks for your review. I have addressed above comments and verified the configuration html manually. PTAL. cc @gyfora . -- This is an automated

[jira] [Commented] (FLINK-27352) [JUnit5 Migration] Module: flink-json

2022-04-22 Thread EMing Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526450#comment-17526450 ] EMing Zhou commented on FLINK-27352: Hi, Can you assigne to me?Thank you. > [JUnit5 Migration]

[jira] [Commented] (FLINK-26052) Update chinese documentation regarding FLIP-203

2022-04-22 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526478#comment-17526478 ] Feifan Wang commented on FLINK-26052: - Hi [~pnowojski] and [~dwysakowicz] , I'm a Chinese speaker,

[jira] [Updated] (FLINK-27343) flink jdbc sink will lead to unordered result, because the sink buffer records execute unorder

2022-04-22 Thread pengyusong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] pengyusong updated FLINK-27343: --- Priority: Minor (was: Critical) > flink jdbc sink will lead to unordered result, because the sink

[jira] [Resolved] (FLINK-27187) The attemptsPerUpload metric may be lower than it actually is

2022-04-22 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan resolved FLINK-27187. --- Resolution: Fixed Thanks for adding this metric [~Feifan Wang], merged as

  1   2   >