[GitHub] [flink] zhuzhurk commented on a diff in pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-21 Thread via GitHub
zhuzhurk commented on code in PR #21970: URL: https://github.com/apache/flink/pull/21970#discussion_r1112513443 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java: ## @@ -377,6 +377,10 @@ private void restartTasks( final Set

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113910042 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/DataFrame.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Created] (FLINK-31180) Fail early when installing minikube and check whether we can retry

2023-02-21 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-31180: - Summary: Fail early when installing minikube and check whether we can retry Key: FLINK-31180 URL: https://issues.apache.org/jira/browse/FLINK-31180 Project: Flink

[GitHub] [flink-table-store] JingsongLi commented on pull request #547: [FLINK-31128] Add Create Table As for flink table store

2023-02-21 Thread via GitHub
JingsongLi commented on PR #547: URL: https://github.com/apache/flink-table-store/pull/547#issuecomment-1439554535 > Thanks @zhangjun0x01 , at present, the biggest problem with CTAS is that it cannot specify the primary key and partition column, which makes it almost unavailable for

[GitHub] [flink] flinkbot commented on pull request #21992: [BP-1.17][FLINK-31132] Let hive compact operator without setting parallelism subject to sink operator's configured parallelism.

2023-02-21 Thread via GitHub
flinkbot commented on PR #21992: URL: https://github.com/apache/flink/pull/21992#issuecomment-1439566892 ## CI report: * 2da857058638b87b37c50be1cc402022fdc3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] liuyongvs opened a new pull request, #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-21 Thread via GitHub
liuyongvs opened a new pull request, #21993: URL: https://github.com/apache/flink/pull/21993 ## What is the purpose of the change *Fix array_contains does not support null argument when the array element type is not null.* ## Brief change log *(for example:)* -

[GitHub] [flink] dannycranmer merged pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-21 Thread via GitHub
dannycranmer merged PR #21970: URL: https://github.com/apache/flink/pull/21970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] dannycranmer commented on pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-21 Thread via GitHub
dannycranmer commented on PR #21970: URL: https://github.com/apache/flink/pull/21970#issuecomment-1439572097 Thanks @huwh, seems like all open questions are resolved and CI passes. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
jiangxin369 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113903069 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/ModelServable.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (FLINK-31061) Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-02-21 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691961#comment-17691961 ] Yunhong Zheng commented on FLINK-31061: --- Thanks, [~JunRuiLi]  for your careful testing. no

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-21 Thread via GitHub
zhuzhurk commented on code in PR #21970: URL: https://github.com/apache/flink/pull/21970#discussion_r1113903871 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java: ## @@ -377,6 +377,10 @@ private void restartTasks( final Set

[jira] [Closed] (FLINK-31061) Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-02-21 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng closed FLINK-31061. - Resolution: Fixed > Release Testing: Verify FLINK-30376 Introduce a new flink bushy join

[GitHub] [flink-ml] lindong28 commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1439531423 @zhipeng93 Can you help review this PR? If this PR looks good to you, I will need to send an email to the FLIP-289 voting thread to discuss the proposed API change (e.g. let

[GitHub] [flink] reswqa opened a new pull request, #21992: [BP-1.17][FLINK-31132] Let hive compact operator without setting parallelism subject to sink operator's configured parallelism.

2023-02-21 Thread via GitHub
reswqa opened a new pull request, #21992: URL: https://github.com/apache/flink/pull/21992 Backport FLINK-31132 to release-1.17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] ChenZhongPu commented on a diff in pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-21 Thread via GitHub
ChenZhongPu commented on code in PR #21989: URL: https://github.com/apache/flink/pull/21989#discussion_r1113906467 ## docs/content.zh/docs/learn-flink/etl.md: ## @@ -223,11 +215,11 @@ minutesByStartCell 在 Flink 不参与管理状态的情况下,你的应用也可以使用状态,但 Flink 为其管理状态提供了一些引人注目的特性: -*

[GitHub] [flink] shuiqiangchen commented on pull request #21962: [FLINK-31124][Connectors/Hive] Add IT sase for HiveTableSink speculative execution

2023-02-21 Thread via GitHub
shuiqiangchen commented on PR #21962: URL: https://github.com/apache/flink/pull/21962#issuecomment-1439524626 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-31177) To introduce a formatter for Markdown files

2023-02-21 Thread CHEN Zhongpu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] CHEN Zhongpu updated FLINK-31177: - Description: Currently, markdown files in *docs* are maintained and updated by many

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113911222 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/ModelServable.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (FLINK-31166) array_contains element type error

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31166: --- Labels: pull-request-available (was: ) > array_contains element type error >

[GitHub] [flink] flinkbot commented on pull request #21990: [Flink 31170] [docs]The spelling error of the document word causes sql to fail to execute

2023-02-21 Thread via GitHub
flinkbot commented on PR #21990: URL: https://github.com/apache/flink/pull/21990#issuecomment-1439515422 ## CI report: * 9dd7ee22fcd390e9a32e54fe914640ef2d7b888f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #551: [FLINK-31179] Make data structures serializable

2023-02-21 Thread via GitHub
JingsongLi opened a new pull request, #551: URL: https://github.com/apache/flink-table-store/pull/551 This can make our internal data structures easy to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-31179) Make data structures serializable

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31179: --- Labels: pull-request-available (was: ) > Make data structures serializable >

[jira] [Created] (FLINK-31179) Make data structures serializable

2023-02-21 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-31179: Summary: Make data structures serializable Key: FLINK-31179 URL: https://issues.apache.org/jira/browse/FLINK-31179 Project: Flink Issue Type: Improvement

[GitHub] [flink] flinkbot commented on pull request #21991: [BP-1.17][FLINK-31091][sql-gateway] Add Ser/de for Interval types (#21945)

2023-02-21 Thread via GitHub
flinkbot commented on PR #21991: URL: https://github.com/apache/flink/pull/21991#issuecomment-1439549889 ## CI report: * f2a617eb6560c48e85f0dbff2cc1d550194bf67b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-31177) To introduce a formatter for Markdown files

2023-02-21 Thread CHEN Zhongpu (Jira)
CHEN Zhongpu created FLINK-31177: Summary: To introduce a formatter for Markdown files Key: FLINK-31177 URL: https://issues.apache.org/jira/browse/FLINK-31177 Project: Flink Issue Type:

[jira] [Commented] (FLINK-31169) KubernetesResourceManagerDriverTest.testOnPodDeleted fails fatally due to 239 exit code

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691994#comment-17691994 ] Matthias Pohl commented on FLINK-31169: ---

[GitHub] [flink] snuyanzin opened a new pull request, #21991: [BP-1.17][FLINK-31091][sql-gateway] Add Ser/de for Interval types (#21945)

2023-02-21 Thread via GitHub
snuyanzin opened a new pull request, #21991: URL: https://github.com/apache/flink/pull/21991 This is a backport of 14adc1679fb3d025a2808af91f23f14e7c6f6e24 to 1.17.0 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #546: [FLINK-31009] Add recordCount to snapshot meta

2023-02-21 Thread via GitHub
JingsongLi commented on code in PR #546: URL: https://github.com/apache/flink-table-store/pull/546#discussion_r1113926517 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java: ## @@ -477,12 +477,20 @@ private boolean

[jira] [Created] (FLINK-31178) Public Writer API

2023-02-21 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-31178: Summary: Public Writer API Key: FLINK-31178 URL: https://issues.apache.org/jira/browse/FLINK-31178 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-31041) Race condition in DefaultScheduler results in memory leak and busy loop

2023-02-21 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691998#comment-17691998 ] Danny Cranmer commented on FLINK-31041: --- Merged commit

[GitHub] [flink] liuyongvs commented on pull request #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-21 Thread via GitHub
liuyongvs commented on PR #21993: URL: https://github.com/apache/flink/pull/21993#issuecomment-1439574746 hi @snuyanzin after dig into the code, i fix it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Closed] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-31079. -- Resolution: Done > Release Testing: Verify FLINK-29663 Further improvements of adaptive batch >

[jira] [Comment Edited] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691969#comment-17691969 ] Lijie Wang edited comment on FLINK-31079 at 2/22/23 7:14 AM: - Thanks [~lsy].

[jira] [Commented] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691969#comment-17691969 ] Lijie Wang commented on FLINK-31079: Thanks [~lsy]. Currently, the

[jira] [Comment Edited] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691969#comment-17691969 ] Lijie Wang edited comment on FLINK-31079 at 2/22/23 7:14 AM: - Thanks [~lsy].

[jira] [Commented] (FLINK-31167) Verify that no exclusions were erroneously added to the japicmp plugin

2023-02-21 Thread Biao Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691970#comment-17691970 ] Biao Liu commented on FLINK-31167: -- Hi [~mapohl] , As you mentioned, the new method with context were

[jira] [Updated] (FLINK-30129) Push projection through ChangelogNormalize

2023-02-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-30129: Fix Version/s: 1.18.0 > Push projection through ChangelogNormalize >

[GitHub] [flink] MartijnVisser commented on pull request #21985: [FLINK-31162][yarn] Use currUsr.getCredentials.getTokens instead of currUsr.getTokens

2023-02-21 Thread via GitHub
MartijnVisser commented on PR #21985: URL: https://github.com/apache/flink/pull/21985#issuecomment-1439560715 > The issue here is different and is only specific to `1.16` So this issue only occurs in 1.16 and not in 1.17 and later? Then we're good yes :) -- This is an automated

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-02-21 Thread via GitHub
Fanoid commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1113947913 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/gbt/GBTModelParams.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (FLINK-31166) array_contains element type error

2023-02-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692003#comment-17692003 ] Martijn Visser commented on FLINK-31166: [~jackylau] So this is specifically about the behaviour

[GitHub] [flink] MartijnVisser merged pull request #21964: [FLINK-30948][Formats/AWS] Remove GlueSchemaRegistry Avro and JSON fo…

2023-02-21 Thread via GitHub
MartijnVisser merged PR #21964: URL: https://github.com/apache/flink/pull/21964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-30948) Remove flink-avro-glue-schema-registry and flink-json-glue-schema-registry from Flink main repo

2023-02-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30948: --- Fix Version/s: 1.17.0 > Remove flink-avro-glue-schema-registry and

[jira] [Updated] (FLINK-31153) Create a release branch

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31153: -- Description: If you are doing a new minor release, you need to update Flink version in the

[jira] [Commented] (FLINK-31059) Release Testing: Verify FLINK-29717 Supports hive udaf such as sum/count by native implementation

2023-02-21 Thread miamiaoxyz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691464#comment-17691464 ] miamiaoxyz commented on FLINK-31059: I first use sql client to test the feature, but the

[GitHub] [flink] FangYongs commented on a diff in pull request #21901: [FLINK-30968][sql-client] Sql client supports dynamic config to open session

2023-02-21 Thread via GitHub
FangYongs commented on code in PR #21901: URL: https://github.com/apache/flink/pull/21901#discussion_r1112748189 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/DefaultContextUtils.java: ## @@ -51,12 +52,17 @@ public static DefaultContext

[GitHub] [flink] MartijnVisser merged pull request #21969: [FLINK-30948][Formats/AWS] Remove GlueSchemaRegistry Avro and JSON fo…

2023-02-21 Thread via GitHub
MartijnVisser merged PR #21969: URL: https://github.com/apache/flink/pull/21969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-31150) Cross team testing

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-31150: - Assignee: Qingsheng Ren > Cross team testing > -- > >

[jira] [Created] (FLINK-31165) Over Agg: The window rank function without order by error in top N query

2023-02-21 Thread P Rohan Kumar (Jira)
P Rohan Kumar created FLINK-31165: - Summary: Over Agg: The window rank function without order by error in top N query Key: FLINK-31165 URL: https://issues.apache.org/jira/browse/FLINK-31165 Project:

[jira] [Assigned] (FLINK-31153) Create a release branch

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-31153: - Assignee: Leonard Xu > Create a release branch > --- > >

[jira] [Commented] (FLINK-31150) Cross team testing

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691465#comment-17691465 ] Matthias Pohl commented on FLINK-31150: --- [~renqs] created FLINK-30926 as an umbrella ticket for

[jira] [Commented] (FLINK-30948) Remove flink-avro-glue-schema-registry and flink-json-glue-schema-registry from Flink main repo

2023-02-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691466#comment-17691466 ] Martijn Visser commented on FLINK-30948: Fixed in: master:

[jira] [Closed] (FLINK-30948) Remove flink-avro-glue-schema-registry and flink-json-glue-schema-registry from Flink main repo

2023-02-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30948. -- Resolution: Fixed > Remove flink-avro-glue-schema-registry and

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-21 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1112754334 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -794,7 +802,23 @@ public void goToWaitingForResources() {

[jira] [Updated] (FLINK-31153) Create a release branch

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31153: -- Description: If you are doing a new minor release, you need to update Flink version in the

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #213: [FLINK-31126] Move classes not depending on Flink runtime from flink-ml-core to flink-ml-servable-core

2023-02-21 Thread via GitHub
Fanoid commented on code in PR #213: URL: https://github.com/apache/flink-ml/pull/213#discussion_r1112756657 ## flink-ml-servable-core/pom.xml: ## @@ -0,0 +1,127 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +

[jira] [Assigned] (FLINK-31092) Hive ITCases fail with OutOfMemoryError

2023-02-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-31092: -- Assignee: luoyuxia > Hive ITCases fail with OutOfMemoryError >

[jira] [Closed] (FLINK-30951) Release Testing: Verify FLINK-29635 Hive sink should support merge files in batch mode

2023-02-21 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-30951. - Resolution: Fixed > Release Testing: Verify FLINK-29635 Hive sink should support merge files in

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #213: [FLINK-31126] Move classes not depending on Flink runtime from flink-ml-core to flink-ml-servable-core

2023-02-21 Thread via GitHub
zhipeng93 commented on code in PR #213: URL: https://github.com/apache/flink-ml/pull/213#discussion_r1112772912 ## flink-ml-servable-core/pom.xml: ## @@ -0,0 +1,127 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +

[jira] [Commented] (FLINK-31059) Release Testing: Verify FLINK-29717 Supports hive udaf such as sum/count by native implementation

2023-02-21 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691472#comment-17691472 ] dalongliu commented on FLINK-31059: --- [~miamiaoxyz] Thanks for your verify, for the problem, I will see

[jira] [Closed] (FLINK-31059) Release Testing: Verify FLINK-29717 Supports hive udaf such as sum/count by native implementation

2023-02-21 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu closed FLINK-31059. - Resolution: Fixed > Release Testing: Verify FLINK-29717 Supports hive udaf such as sum/count by >

[GitHub] [flink-ml] zhipeng93 commented on pull request #213: [FLINK-31126] Move classes not depending on Flink runtime from flink-ml-core to flink-ml-servable-core

2023-02-21 Thread via GitHub
zhipeng93 commented on PR #213: URL: https://github.com/apache/flink-ml/pull/213#issuecomment-1438119732 Thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] zhipeng93 merged pull request #213: [FLINK-31126] Move classes not depending on Flink runtime from flink-ml-core to flink-ml-servable-core

2023-02-21 Thread via GitHub
zhipeng93 merged PR #213: URL: https://github.com/apache/flink-ml/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] lindong28 commented on pull request #213: [FLINK-31126] Move classes not depending on Flink runtime from flink-ml-core to flink-ml-servable-core

2023-02-21 Thread via GitHub
lindong28 commented on PR #213: URL: https://github.com/apache/flink-ml/pull/213#issuecomment-1438122258 Thank you both for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-31153) Create a release branch

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31153: -- Description: If you are doing a new minor release, you need to update Flink version in the

[jira] [Updated] (FLINK-31147) Create a new version in JIRA

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31147: -- Description: When contributors resolve an issue in JIRA, they are tagging it with a release

[jira] [Updated] (FLINK-31149) Review and update documentation

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31149: -- Description: There are a few pages in the documentation that need to be reviewed and updated

[GitHub] [flink] reswqa commented on a diff in pull request #21977: [FLINK-31132] Compact without setting parallelism does not follow the configured sink parallelism for HiveTableSink

2023-02-21 Thread via GitHub
reswqa commented on code in PR #21977: URL: https://github.com/apache/flink/pull/21977#discussion_r1112641083 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkITCase.java: ## @@ -42,17 +44,18 @@ import static

[GitHub] [flink-ml] lindong28 commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1438134181 @jiangxin369 Can you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] FangYongs commented on pull request #21956: [FLINK-31113] Support AND filter push down in orc

2023-02-21 Thread via GitHub
FangYongs commented on PR #21956: URL: https://github.com/apache/flink/pull/21956#issuecomment-1438133167 Thanks @libenchao , I have updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-31152) Setup for the executing release manager

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31152: -- Description: h4. GPG Key You need to have a GPG key to sign the release artifacts. Please be

[jira] [Updated] (FLINK-31144) Slow scheduling on large-scale batch jobs

2023-02-21 Thread Julien Tournay (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Tournay updated FLINK-31144: --- Attachment: image-2023-02-21-10-29-49-388.png > Slow scheduling on large-scale batch jobs

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-21 Thread via GitHub
zhipeng93 commented on code in PR #212: URL: https://github.com/apache/flink-ml/pull/212#discussion_r1112795550 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java: ## @@ -42,7 +42,7 @@ protected RowGenerator[]

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-21 Thread via GitHub
zhipeng93 commented on code in PR #212: URL: https://github.com/apache/flink-ml/pull/212#discussion_r1112795550 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java: ## @@ -42,7 +42,7 @@ protected RowGenerator[]

[jira] [Commented] (FLINK-31144) Slow scheduling on large-scale batch jobs

2023-02-21 Thread Julien Tournay (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691474#comment-17691474 ] Julien Tournay commented on FLINK-31144: Hi [~huwh], Thank you for the quick reply :)

[jira] [Updated] (FLINK-31153) Create a release branch

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31153: -- Description: If you are doing a new minor release, you need to update Flink version in the

[GitHub] [flink-ml] zhipeng93 closed pull request #176: Bump jackson-databind from 2.12.6.1 to 2.12.7.1

2023-02-21 Thread via GitHub
zhipeng93 closed pull request #176: Bump jackson-databind from 2.12.6.1 to 2.12.7.1 URL: https://github.com/apache/flink-ml/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] dependabot[bot] commented on pull request #176: Bump jackson-databind from 2.12.6.1 to 2.12.7.1

2023-02-21 Thread via GitHub
dependabot[bot] commented on PR #176: URL: https://github.com/apache/flink-ml/pull/176#issuecomment-1438157269 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-21 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1112810683 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-21 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1112815613 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotSharingSlotAllocator.java: ## @@ -121,16 +133,13 @@ public Optional

[jira] [Updated] (FLINK-31142) Some queries lead to abrupt sql client close

2023-02-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-31142: Priority: Blocker (was: Major) > Some queries lead to abrupt sql client close >

[jira] [Updated] (FLINK-31142) Some queries lead to abrupt sql client close

2023-02-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-31142: Description: Although the behavior has been changed in 1.17.0, I'm not sure whether it is

[jira] [Updated] (FLINK-31168) JobManagerHAProcessFailureRecoveryITCase failed due to job not being found

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31168: -- Description:

[jira] [Updated] (FLINK-31133) PartiallyFinishedSourcesITCase hangs if a checkpoint fails

2023-02-21 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-31133: -- Summary: PartiallyFinishedSourcesITCase hangs if a checkpoint fails (was:

[GitHub] [flink] Mulavar commented on pull request #21545: [FLINK-30396][table]make alias hint take effect in correlate

2023-02-21 Thread via GitHub
Mulavar commented on PR #21545: URL: https://github.com/apache/flink/pull/21545#issuecomment-1438817485 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-31138) Either StreamCheckpointingITCase/StreamFaultToleranceTestBase or EventTimeWindowCheckpointingITCase are timinng out

2023-02-21 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691725#comment-17691725 ] Roman Khachatryan commented on FLINK-31138: --- Thanks [~mapohl] and [~fanrui] ,  In the

[jira] [Updated] (FLINK-31162) Avoid setting private tokens to AM container context when kerberos delegation token fetch is disabled

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31162: --- Labels: pull-request-available (was: ) > Avoid setting private tokens to AM container

[jira] [Commented] (FLINK-31133) AdaptiveSchedulerITCase took extraordinary long to finish

2023-02-21 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691693#comment-17691693 ] Roman Khachatryan commented on FLINK-31133: --- I think the issue is actually

[jira] [Updated] (FLINK-31133) AdaptiveSchedulerITCase took extraordinary long to finish

2023-02-21 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-31133: -- Priority: Major (was: Critical) > AdaptiveSchedulerITCase took extraordinary long to

[jira] [Commented] (FLINK-31168) JobManagerHAProcessFailureRecoveryITCase failed due to job not being found

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691710#comment-17691710 ] Matthias Pohl commented on FLINK-31168: --- Based on the stacktrace listed in the description, the

[GitHub] [flink] venkata91 opened a new pull request, #21985: [FLINK-31162][yarn] Use currUsr.getTokens instead of currUsr.getCrede…

2023-02-21 Thread via GitHub
venkata91 opened a new pull request, #21985: URL: https://github.com/apache/flink/pull/21985 …ntials to avoid including private tokens in AM container context ## What is the purpose of the change Avoid setting private tokens to AM container context when kerberos

[jira] [Assigned] (FLINK-31133) AdaptiveSchedulerITCase took extraordinary long to finish

2023-02-21 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan reassigned FLINK-31133: - Assignee: Roman Khachatryan > AdaptiveSchedulerITCase took extraordinary long

[jira] [Commented] (FLINK-31143) Invalid request: offset doesn't match when restarting from a savepoint

2023-02-21 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691714#comment-17691714 ] Weijie Guo commented on FLINK-31143: I'm a little suspicious that the current logic can't handle

[GitHub] [flink] akalash commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-02-21 Thread via GitHub
akalash commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1113358376 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -949,7 +952,9 @@ public final void cleanUp(Throwable throwable)

[jira] [Updated] (FLINK-31138) Either StreamCheckpointingITCase/StreamFaultToleranceTestBase or EventTimeWindowCheckpointingITCase are timinng out

2023-02-21 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-31138: -- Priority: Major (was: Critical) > Either

[jira] [Comment Edited] (FLINK-31133) AdaptiveSchedulerITCase took extraordinary long to finish

2023-02-21 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691693#comment-17691693 ] Roman Khachatryan edited comment on FLINK-31133 at 2/21/23 4:26 PM:

[GitHub] [flink] flinkbot commented on pull request #21985: [FLINK-31162][yarn] Use currUsr.getTokens instead of currUsr.getCrede…

2023-02-21 Thread via GitHub
flinkbot commented on PR #21985: URL: https://github.com/apache/flink/pull/21985#issuecomment-1438893837 ## CI report: * bf60278b45ba5c499da3755d50c70aaf546f8bfa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31109) Fails with proxy user not supported even when security.kerberos.fetch.delegation-token is set to false

2023-02-21 Thread Venkata krishnan Sowrirajan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691740#comment-17691740 ] Venkata krishnan Sowrirajan commented on FLINK-31109: - [~martijnvisser] I'm still

[GitHub] [flink] venkata91 commented on pull request #21985: [FLINK-31162][yarn] Use currUsr.getCredentials.getTokens instead of currUsr.getTokens

2023-02-21 Thread via GitHub
venkata91 commented on PR #21985: URL: https://github.com/apache/flink/pull/21985#issuecomment-1438988558 > Re title: You mean 'Use currUsr.getCredentials().getAllTokens() instead of currUsr.getTokens() to avoid including private tokens' ? Oh. Yes. Thanks for pointing out. -- This

[GitHub] [flink] venkata91 commented on pull request #21985: [FLINK-31162][yarn] Use currUsr.getCredentials.getTokens instead of currUsr.getTokens

2023-02-21 Thread via GitHub
venkata91 commented on PR #21985: URL: https://github.com/apache/flink/pull/21985#issuecomment-1438989508 > Change looks good to me. Not sure how testable this is ... Yeah not sure how we can add either unit tests or integration tests. -- This is an automated message from the

[GitHub] [flink] venkata91 commented on pull request #21985: [FLINK-31162][yarn] Use currUsr.getTokens instead of currUsr.getCrede…

2023-02-21 Thread via GitHub
venkata91 commented on PR #21985: URL: https://github.com/apache/flink/pull/21985#issuecomment-1438936505 Please take a look. cc @gaborgsomogyi @MartijnVisser @becketqin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

  1   2   3   4   >