Re: [PR] [FLINK-33935][checkpoint] Improve the default value logic related to `execution.checkpointing.tolerable-failed-checkpoints` and `state.backend.type` [flink]

2023-12-25 Thread via GitHub
flinkbot commented on PR #23987: URL: https://github.com/apache/flink/pull/23987#issuecomment-1868837454 ## CI report: * dd1f509ca1feb399f4e7e05b7c3127a0c76c1361 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-33932) Support retry mechanism for rocksdb uploader

2023-12-25 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800258#comment-17800258 ] xiangyu feng edited comment on FLINK-33932 at 12/25/23 8:55 AM: Hi

Re: [PR] [FLINK-33921][table] Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig [flink]

2023-12-25 Thread via GitHub
liyubin117 commented on PR #23980: URL: https://github.com/apache/flink/pull/23980#issuecomment-1868876743 @LadyForest Hi, CI has passed, PTAL, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (FLINK-33921) Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig

2023-12-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33921: --- Labels: pull-request-available (was: ) > Cleanup usage of deprecated

[jira] [Commented] (FLINK-33934) Flink SQL Source use raw format maybe lead to data lost

2023-12-25 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800273#comment-17800273 ] Cai Liuyang commented on FLINK-33934: - [~hackergin] Yeah,  turn off Object Reuse for all

Re: [PR] [doc-fix] - changed preference to settings for setting pycharm for pyflink ide setting section [flink]

2023-12-25 Thread via GitHub
Myasuka closed pull request #23903: [doc-fix] - changed preference to settings for setting pycharm for pyflink ide setting section URL: https://github.com/apache/flink/pull/23903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-32880) Redundant taskManagers should always be fulfilled in FineGrainedSlotManager

2023-12-25 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800294#comment-17800294 ] Weihua Hu commented on FLINK-32880: --- [~mapohl]  Sorry for missing the merge information. I will

Re: [PR] [FLINK-33879] Avoids the potential hang of Hybrid Shuffle during redistribution [flink]

2023-12-25 Thread via GitHub
jiangxin369 commented on code in PR #23957: URL: https://github.com/apache/flink/pull/23957#discussion_r1436042917 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemorySpec.java: ## @@ -30,9 +30,21 @@ public class

Re: [PR] [FLINK-33935][checkpoint] Improve the default value logic related to `execution.checkpointing.tolerable-failed-checkpoints` and `state.backend.type` [flink]

2023-12-25 Thread via GitHub
1996fanrui commented on PR #23987: URL: https://github.com/apache/flink/pull/23987#issuecomment-1868918339 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (FLINK-33891) Remove the obsolete SingleJobGraphStore

2023-12-25 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu reassigned FLINK-33891: - Assignee: Zhanghao Chen > Remove the obsolete SingleJobGraphStore >

Re: [PR] [FLINK-33891] Remove the obsolete SingleJobGraphStore [flink]

2023-12-25 Thread via GitHub
huwh merged PR #23958: URL: https://github.com/apache/flink/pull/23958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (FLINK-33891) Remove the obsolete SingleJobGraphStore

2023-12-25 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu resolved FLINK-33891. --- Fix Version/s: 1.19.0 Resolution: Fixed resolved in master:

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2023-12-25 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800303#comment-17800303 ] Benchao Li commented on FLINK-33611: [~dsaisharath] Sure, I'll review the PR. I may respond slow

[jira] [Commented] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2023-12-25 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800304#comment-17800304 ] Benchao Li commented on FLINK-33817: [~maosuhan] What do you think of this? I have an impression

[jira] [Updated] (FLINK-33935) Improve the default value doc and logic for some state backend and checkpoint related options

2023-12-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33935: Description: Some state backend and checkpoint related options don't set the default value directly, but

[jira] [Commented] (FLINK-33934) Flink SQL Source use raw format maybe lead to data lost

2023-12-25 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800267#comment-17800267 ] Feng Jin commented on FLINK-33934: -- [~cailiuyang] Does this mean that we should turn off Object Reuse

Re: [PR] [FLINK-33792] Generate the same code for the same logic [flink]

2023-12-25 Thread via GitHub
libenchao commented on PR #23984: URL: https://github.com/apache/flink/pull/23984#issuecomment-1868890131 @zoudan The PR looks good to me, except that the CI is failing, could you fix that? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-33879] Avoids the potential hang of Hybrid Shuffle during redistribution [flink]

2023-12-25 Thread via GitHub
jiangxin369 commented on code in PR #23957: URL: https://github.com/apache/flink/pull/23957#discussion_r1436041141 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java: ## @@ -244,6 +282,39 @@

[jira] [Comment Edited] (FLINK-33934) Flink SQL Source use raw format maybe lead to data lost

2023-12-25 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800273#comment-17800273 ] Cai Liuyang edited comment on FLINK-33934 at 12/25/23 11:41 AM:

[jira] [Updated] (FLINK-33934) Flink SQL Source use raw format maybe lead to data lost

2023-12-25 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33934: Description: In our product we encounter a case that lead to data lost, the job info:     1.

Re: [PR] [FLINK-30535][Test] Customize TtlTimeProvider in state benchmarks [flink]

2023-12-25 Thread via GitHub
Myasuka commented on code in PR #23985: URL: https://github.com/apache/flink/pull/23985#discussion_r1436070483 ## flink-test-utils-parent/flink-test-utils/src/test/java/org/apache/flink/state/benchmark/StateBackendBenchmarkUtils.java: ## @@ -216,7 +225,7 @@ private static

[jira] [Created] (FLINK-33939) Make husky in runtime-web no longer affect git global hooks

2023-12-25 Thread Jason TANG (Jira)
Jason TANG created FLINK-33939: -- Summary: Make husky in runtime-web no longer affect git global hooks Key: FLINK-33939 URL: https://issues.apache.org/jira/browse/FLINK-33939 Project: Flink

[jira] [Commented] (FLINK-33939) Make husky in runtime-web no longer affect git global hooks

2023-12-25 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800411#comment-17800411 ] Wencong Liu commented on FLINK-33939: - Thanks for raising this issue!  I completely agree with your

Re: [PR] [FLINK-23633][FLIP-150][connector/common] HybridSource: Support dynamic stop position in FileSource [flink]

2023-12-25 Thread via GitHub
waywtdcc commented on PR #20289: URL: https://github.com/apache/flink/pull/20289#issuecomment-1869298738 How is this going? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-22793) HybridSource Table Implementation

2023-12-25 Thread waywtdcc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800414#comment-17800414 ] waywtdcc commented on FLINK-22793: -- How is this going? > HybridSource Table Implementation >

[jira] [Updated] (FLINK-33941) Use field index instead of field name about window time column

2023-12-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33941: --- Labels: pull-request-available (was: ) > Use field index instead of field name about

[PR] [FLINK-33941][table-planner] use field index instead of field name about window time column [flink]

2023-12-25 Thread via GitHub
xuyangzhong opened a new pull request, #23991: URL: https://github.com/apache/flink/pull/23991 ## What is the purpose of the change In some exec nodes like StreamExecGroupWindowAggregate and some rules like BatchPhysicalWindowAggregateRule, planner uses "AggregateUtil#timeFieldIndex"

[PR] [FLINK-33939][runtime-web] Remove the husky dependency to make sure the global hooks work as expected [flink]

2023-12-25 Thread via GitHub
simplejason opened a new pull request, #23992: URL: https://github.com/apache/flink/pull/23992 **_WIP: IN DISCUSSION_** ## What is the purpose of the change Remove husky dependencies to ensure global hooks work as expected ## Brief change log - remove

[jira] [Created] (FLINK-33937) Translate "Stateful Stream Processing" page into Chinese

2023-12-25 Thread Yongping Li (Jira)
Yongping Li created FLINK-33937: --- Summary: Translate "Stateful Stream Processing" page into Chinese Key: FLINK-33937 URL: https://issues.apache.org/jira/browse/FLINK-33937 Project: Flink Issue

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-25 Thread via GitHub
TanYuxin-tyx commented on PR #23927: URL: https://github.com/apache/flink/pull/23927#issuecomment-1869187119 @yunfengzhou-hub Thanks for the update. I have no more comments on the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi… [flink]

2023-12-25 Thread via GitHub
xuzhiwen1255 commented on PR #22010: URL: https://github.com/apache/flink/pull/22010#issuecomment-1869194665 @XComp I'm sorry that I haven't had time to deal with this problem recently due to some things. Now I plan to continue to deal with this issue. Do you have time to take a look? --

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-25 Thread via GitHub
xintongsong commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1436062729 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexRange.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2023-12-25 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-33940: -- Description: *Background* The choice of the max parallelism of an stateful operator is

[jira] [Commented] (FLINK-33941) Use field index instead of field name about window time column

2023-12-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800427#comment-17800427 ] Jane Chan commented on FLINK-33941: --- Thanks, [~xuyangzhong] reporting this issue. You're right that we

[jira] [Assigned] (FLINK-33941) Use field index instead of field name about window time column

2023-12-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-33941: - Assignee: xuyang > Use field index instead of field name about window time column >

[jira] [Commented] (FLINK-31650) Incorrect busyMsTimePerSecond metric value for FINISHED task

2023-12-25 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800398#comment-17800398 ] Lijie Wang commented on FLINK-31650: Fixed via: master(1.19) : 

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2023-12-25 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800412#comment-17800412 ] Jufang He commented on FLINK-33856: --- [~masteryhx] [~Weijie Guo]  I have created a PR for this issue, 

[jira] [Created] (FLINK-33940) Update Update the auto-derivation rule of max parallelism for enlarged upscaling space

2023-12-25 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-33940: - Summary: Update Update the auto-derivation rule of max parallelism for enlarged upscaling space Key: FLINK-33940 URL: https://issues.apache.org/jira/browse/FLINK-33940

[jira] [Updated] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2023-12-25 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-33940: -- Summary: Update the auto-derivation rule of max parallelism for enlarged upscaling space

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2023-12-25 Thread via GitHub
AlexYinHan commented on PR #23514: URL: https://github.com/apache/flink/pull/23514#issuecomment-1869314576 @curcur The CI failure has been addressed. (The file-merging checkpoint was unexpectedly enabled.) Would you please take another look? -- This is an automated message from the

Re: [PR] [FLINK-33736][Scheduler] Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier [flink]

2023-12-25 Thread via GitHub
1996fanrui commented on PR #23911: URL: https://github.com/apache/flink/pull/23911#issuecomment-1869214268 Thanks @RocMarshal for the quick review! Merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33736][Scheduler] Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier [flink]

2023-12-25 Thread via GitHub
1996fanrui merged PR #23911: URL: https://github.com/apache/flink/pull/23911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33939) Make husky in runtime-web no longer affect git global hooks

2023-12-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33939: --- Labels: pull-request-available (was: ) > Make husky in runtime-web no longer affect git

[jira] [Created] (FLINK-33938) Update Web UI to adopt typescript 5.x

2023-12-25 Thread Ao Yuchen (Jira)
Ao Yuchen created FLINK-33938: - Summary: Update Web UI to adopt typescript 5.x Key: FLINK-33938 URL: https://issues.apache.org/jira/browse/FLINK-33938 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core package api-common [flink]

2023-12-25 Thread via GitHub
GOODBOY008 commented on PR #23960: URL: https://github.com/apache/flink/pull/23960#issuecomment-1869278941 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-33941) Use field index instead of field name about window time column

2023-12-25 Thread xuyang (Jira)
xuyang created FLINK-33941: -- Summary: Use field index instead of field name about window time column Key: FLINK-33941 URL: https://issues.apache.org/jira/browse/FLINK-33941 Project: Flink Issue

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2023-12-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800433#comment-17800433 ] Gyula Fora commented on FLINK-33940: Consider 840 in instead of 1024, 840 has 32 divisors compared

Re: [PR] Draft [flink]

2023-12-25 Thread via GitHub
flinkbot commented on PR #23993: URL: https://github.com/apache/flink/pull/23993#issuecomment-1869336037 ## CI report: * f4137f701ba8790ef75aefdca3c0d54e4fb7e61a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Draft [flink]

2023-12-25 Thread via GitHub
JunRuiLee commented on PR #23993: URL: https://github.com/apache/flink/pull/23993#issuecomment-1869335533 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-31650) Incorrect busyMsTimePerSecond metric value for FINISHED task

2023-12-25 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-31650. -- Fix Version/s: 1.19.0 1.18.1 1.17.3 Resolution: Fixed >

Re: [PR] [FLINK-31650][metrics][rest] Remove transient metrics for subtasks in terminal state [flink]

2023-12-25 Thread via GitHub
wanglijie95 commented on PR #23447: URL: https://github.com/apache/flink/pull/23447#issuecomment-1869194011 Thanks @X-czh , and thanks for the review of @JunRuiLee. I will close this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (FLINK-33938) Correct implicit coercions in relational operators to adopt typescript 5.0

2023-12-25 Thread Ao Yuchen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ao Yuchen updated FLINK-33938: -- Description: Since TypeScript 5.0, implicit coercions in relational operators are forbidden

[jira] [Updated] (FLINK-33938) Correct implicit coercions in relational operators to adopt typescript 5.0

2023-12-25 Thread Ao Yuchen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ao Yuchen updated FLINK-33938: -- Summary: Correct implicit coercions in relational operators to adopt typescript 5.0 (was: Update Web

[jira] [Commented] (FLINK-30535) Introduce TTL state based benchmarks

2023-12-25 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800407#comment-17800407 ] Yun Tang commented on FLINK-30535: -- Some work done on Flink side: master:

Re: [PR] [FLINK-30535][Test] Customize TtlTimeProvider in state benchmarks [flink]

2023-12-25 Thread via GitHub
Myasuka merged PR #23985: URL: https://github.com/apache/flink/pull/23985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2023-12-25 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800420#comment-17800420 ] Zhanghao Chen commented on FLINK-33940: --- Here I'm proposing to

[jira] [Updated] (FLINK-33938) Update Web UI to adopt typescript 5.0

2023-12-25 Thread Ao Yuchen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ao Yuchen updated FLINK-33938: -- Summary: Update Web UI to adopt typescript 5.0 (was: Update Web UI to adopt typescript 5.x ) >

[jira] [Updated] (FLINK-33938) Update Web UI to adopt typescript 5.0

2023-12-25 Thread Ao Yuchen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ao Yuchen updated FLINK-33938: -- Description: Since TypeScript 5.0, implicit coercions in relations operators are forbidden

[jira] [Commented] (FLINK-33939) Make husky in runtime-web no longer affect git global hooks

2023-12-25 Thread Jason TANG (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800409#comment-17800409 ] Jason TANG commented on FLINK-33939: Feedback is welcome, I can submit a PR to remove the husky

[jira] [Updated] (FLINK-33938) Correct implicit coercions in relational operators to adopt typescript 5.0

2023-12-25 Thread Ao Yuchen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ao Yuchen updated FLINK-33938: -- Description: Since TypeScript 5.0, there is a break change that implicit coercions in relational

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2023-12-25 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800413#comment-17800413 ] Zhanghao Chen commented on FLINK-33940: --- cc [~mxm] [~fanrui] Looking forward to the opinions from

[jira] [Assigned] (FLINK-33939) Make husky in runtime-web no longer affect git global hooks

2023-12-25 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-33939: Assignee: Jason TANG > Make husky in runtime-web no longer affect git global hooks >

[PR] Draft [flink]

2023-12-25 Thread via GitHub
JunRuiLee opened a new pull request, #23993: URL: https://github.com/apache/flink/pull/23993 Draft. Do not review this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (FLINK-33736) Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier

2023-12-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33736. - Resolution: Fixed > Update default value of exponential-delay.max-backoff and >

[jira] [Commented] (FLINK-33736) Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier

2023-12-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800403#comment-17800403 ] Rui Fan commented on FLINK-33736: - Merged to master(1.19) via : d9e8b2a7be9c516bf497d4a68c39ac7f12e3b293

[jira] [Updated] (FLINK-33736) Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier

2023-12-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33736: Description: Update default value of exponential-delay.max-backoff from 5min to 1min. Update default

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2023-12-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800416#comment-17800416 ] Gyula Fora commented on FLINK-33940: If we are going to change this, powers of 2 are not really good

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2023-12-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800435#comment-17800435 ] Rui Fan commented on FLINK-33940: - Thanks [~gyfora] for the reminder! Too many divisors is useful for

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-25 Thread via GitHub
flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1436178955 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -72,6 +72,21 @@ private static

Re: [PR] [FLINK-31650][metrics][rest][BP-1.17] Remove transient metrics for subtasks in terminal state [flink]

2023-12-25 Thread via GitHub
wanglijie95 merged PR #23988: URL: https://github.com/apache/flink/pull/23988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33938) Correct implicit coercions in relational operators to adopt typescript 5.0

2023-12-25 Thread Ao Yuchen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ao Yuchen updated FLINK-33938: -- Description: Since TypeScript 5.0, there is a break change that implicit coercions in relational

[jira] [Commented] (FLINK-33939) Make husky in runtime-web no longer affect git global hooks

2023-12-25 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800423#comment-17800423 ] Xintong Song commented on FLINK-33939: -- Sounds good to me. Thanks for reporting and volunteering on

Re: [PR] [FLINK-33941][table-planner] use field index instead of field name about window time column [flink]

2023-12-25 Thread via GitHub
flinkbot commented on PR #23991: URL: https://github.com/apache/flink/pull/23991#issuecomment-1869311476 ## CI report: * 35919f76384f970d54fd6a19f7f7e8cc90fa891d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33939][runtime-web] Remove the husky dependency to make sure the global hooks work as expected [flink]

2023-12-25 Thread via GitHub
flinkbot commented on PR #23992: URL: https://github.com/apache/flink/pull/23992#issuecomment-1869325717 ## CI report: * 3f87d0950bae646a728bcd5b9c3e95dbda68 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2023-12-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33940: --- Assignee: Zhanghao Chen > Update the auto-derivation rule of max parallelism for enlarged

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2023-12-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800430#comment-17800430 ] Rui Fan commented on FLINK-33940: - Thanks [~Zhanghao Chen] for driving this improvement and for the

[PR] [FLINK-33784][table] Support Configuring CatalogStoreFactory via StreamExecutionEnvironment [flink]

2023-12-25 Thread via GitHub
hackergin opened a new pull request, #23990: URL: https://github.com/apache/flink/pull/23990 ## What is the purpose of the change The initialization of CatalogStore is currently before flink-conf.yaml and StreamTableEnvironment, which causes the configuration in flink-conf.yaml to

[jira] [Updated] (FLINK-33784) CatalogStoreFactory can not be configured via StreamExecutionEnvironment

2023-12-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33784: --- Labels: pull-request-available (was: ) > CatalogStoreFactory can not be configured via

Re: [PR] [FLINK-33784][table] Support Configuring CatalogStoreFactory via StreamExecutionEnvironment [flink]

2023-12-25 Thread via GitHub
flinkbot commented on PR #23990: URL: https://github.com/apache/flink/pull/23990#issuecomment-1869049218 ## CI report: * da80787fb7b6e345b94278cbd74ce53a0bc6df6b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-33936) Mini-batch should output the result when the result is same as last if TTL is setted.

2023-12-25 Thread Feng Jin (Jira)
Feng Jin created FLINK-33936: Summary: Mini-batch should output the result when the result is same as last if TTL is setted. Key: FLINK-33936 URL: https://issues.apache.org/jira/browse/FLINK-33936

[jira] [Updated] (FLINK-33936) Mini-batch should output the result when the result is same as last if TTL is setted.

2023-12-25 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-33936: - Description: If mini-batch is enabled currently, and if the aggregated result is the same as the

[jira] [Updated] (FLINK-33936) Mini-batch should output the result when the result is same as last if TTL is setted.

2023-12-25 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-33936: - Description: If mini-batch is enabled currently, and if the aggregated result is the same as the

[jira] [Updated] (FLINK-33936) The aggregation of mini-batches should output the result even if the result is the same as before when TTL is configured.

2023-12-25 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-33936: - Description: If mini-batch is enabled currently, and if the aggregated result is the same as the

[jira] [Updated] (FLINK-33936) The aggregation of mini-batches should output the result even if the result is the same as before when TTL is configured.

2023-12-25 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-33936: - Summary: The aggregation of mini-batches should output the result even if the result is the same as

[jira] [Updated] (FLINK-33936) Mini-batch agg should output the result when the result is same as last if TTL is setted.

2023-12-25 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-33936: - Summary: Mini-batch agg should output the result when the result is same as last if TTL is setted.

Re: [PR] [FLINK-31650][metrics][rest] Remove transient metrics for subtasks in terminal state [flink]

2023-12-25 Thread via GitHub
wanglijie95 commented on PR #23447: URL: https://github.com/apache/flink/pull/23447#issuecomment-1868951155 Hi @X-czh, kindly remind again, we need a PR for release-1.17 ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (FLINK-33921) Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig

2023-12-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800307#comment-17800307 ] Jane Chan commented on FLINK-33921: --- [~liyubin117] Assigned to you. > Cleanup usage of deprecated

[jira] [Assigned] (FLINK-33921) Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig

2023-12-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-33921: - Assignee: Yubin Li > Cleanup usage of deprecated IdleStateRetentionTime related method in >

[jira] [Commented] (FLINK-33927) Cleanup usage of deprecated ExecutionConfigOptions#(TABLE_EXEC_SHUFFLE_MODE, TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS)

2023-12-25 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800308#comment-17800308 ] Yubin Li commented on FLINK-33927: -- [~qingyue] Looking forward your review :) > Cleanup usage of

Re: [PR] [FLINK-31650][metrics][rest] Remove transient metrics for subtasks in terminal state [flink]

2023-12-25 Thread via GitHub
X-czh commented on PR #23447: URL: https://github.com/apache/flink/pull/23447#issuecomment-1868963641 OK, I'll prepare it tonight -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [FLINK-31650][metrics][rest] Remove transient metrics for subtasks in terminal state [flink]

2023-12-25 Thread via GitHub
X-czh opened a new pull request, #23988: URL: https://github.com/apache/flink/pull/23988 ## What is the purpose of the change Cherry picked from commit dd028282e8ab19c0d1cd05fad02b63bbda6c1358 (MR: https://github.com/apache/flink/pull/23447) ## Brief change log

Re: [PR] [FLINK-33856][checkpointing] Add metrics for interaction performance with external storage system in the process of checkpoint making [flink]

2023-12-25 Thread via GitHub
flinkbot commented on PR #23989: URL: https://github.com/apache/flink/pull/23989#issuecomment-1868979605 ## CI report: * 1e679c2a9834caa0dc21a99a96c5f121d987ff67 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33935][checkpoint] Improve the default value logic related to `execution.checkpointing.tolerable-failed-checkpoints` and `state.backend.type` [flink]

2023-12-25 Thread via GitHub
1996fanrui commented on PR #23987: URL: https://github.com/apache/flink/pull/23987#issuecomment-1868981257 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2023-12-25 Thread via GitHub
AlexYinHan commented on PR #23514: URL: https://github.com/apache/flink/pull/23514#issuecomment-1868986046 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-25 Thread via GitHub
1996fanrui commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1436102422 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -72,6 +72,21 @@ private static

Re: [PR] [FLINK-31650][metrics][rest][BP-1.17] Remove transient metrics for subtasks in terminal state [flink]

2023-12-25 Thread via GitHub
flinkbot commented on PR #23988: URL: https://github.com/apache/flink/pull/23988#issuecomment-1868970696 ## CI report: * 4b320c2f3649172236331fa5ba4bef3650e8fe2c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32738][formats] PROTOBUF format supports projection push down [flink]

2023-12-25 Thread via GitHub
zhougit86 commented on PR #23323: URL: https://github.com/apache/flink/pull/23323#issuecomment-1868970682 > @zhougit86 Thank you for your patience and contribution. I will complete the review within the next two weeks and provide comments. @ljw-hit just a reminder to review, thx 

Re: [PR] [FLINK-30535][Test] Customize TtlTimeProvider in state benchmarks [flink]

2023-12-25 Thread via GitHub
Zakelly commented on code in PR #23985: URL: https://github.com/apache/flink/pull/23985#discussion_r1436084300 ## flink-test-utils-parent/flink-test-utils/src/test/java/org/apache/flink/state/benchmark/StateBackendBenchmarkUtils.java: ## @@ -216,7 +225,7 @@ private static

[PR] [FLINK-33856][checkpointing] Add metrics for interaction performance with external storage system in the process of checkpoint making [flink]

2023-12-25 Thread via GitHub
hejufang opened a new pull request, #23989: URL: https://github.com/apache/flink/pull/23989 …with external storage system in the process of checkpoint making ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob

[jira] [Updated] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2023-12-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33856: --- Labels: pull-request-available (was: ) > Add metrics to monitor the interaction

  1   2   >