[GitHub] flink pull request #3570: [FLINK-6122] add TravisCI build status to README.m...

2017-03-20 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3570 [FLINK-6122] add TravisCI build status to README.md Add TravisCI build status image to FLINK's github repo homepage https://cloud.githubusercontent.com/assets/1892692/24091460/6b6

[GitHub] flink pull request #3577: [FLINK-6133] fix build status in README.md

2017-03-20 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3577 [FLINK-6133] fix build status in README.md So sorry, I think I made a mistake when committing code for https://issues.apache.org/jira/browse/FLINK-6122. I tried to copy what's i

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-18 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3736 [Flink-6013][metrics] Add Datadog HTTP metrics reporter I'm adding a DatadogHttpReporter for Flink metrics system. The implementation, including making parameters in Flink's

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-18 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Great advice. Thanks, @zentol ! My questions to your suggestions: 1. If I make DatadogHttpReport implement MetricReporter interface, shall I just ignore Histogram and Meter which are

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-18 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112083224 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/metric/DGauge.java --- @@ -0,0 +1,30

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-18 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112115925 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,38 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-18 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112115930 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,85 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmln

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-18 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Addressed @zentol 's comments. Ready for another round. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112279814 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112280185 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,216

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112281086 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/metric/MetricType.java --- @@ -0,0 +1,26

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112282965 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,85 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmln

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112283099 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/metric/DGauge.java --- @@ -0,0 +1,30

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-19 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Addressed @zentol and @StephanEwen 's comments. Ready for another round! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112338938 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112339291 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112339524 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMeter.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340046 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340221 --- Diff: flink-metrics/flink-metrics-datadog/src/test/java/org/apache/flink/metrics/datadog/DatadogHttpReporterTests.java --- @@ -0,0 +1,40

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340350 --- Diff: flink-metrics/flink-metrics-datadog/src/test/java/org/apache/flink/metrics/datadog/DatadogHttpReporterTests.java --- @@ -0,0 +1,40

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340440 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340582 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,35 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340825 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,35 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341238 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341399 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341697 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341874 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmln

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112342781 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344276 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/utils/TimestampUtils.java --- @@ -0,0 +1,27

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344296 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/utils/SerializationUtils.java --- @@ -0,0 +1,30

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344359 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344522 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344622 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344921 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmln

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-19 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @zentol ready for another round. The build fails because there are a few unrelated flake tests timing out in travis build --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112496785 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112496915 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112498342 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmln

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112499012 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112520676 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,29 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112521836 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,200

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112522071 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,78 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmln

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Where is the title that you're referring to? This PR's title at the very top is already "[FLINK-6013][metrics] Add Datadog HTTP metrics reporter" (without double quote) --

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Aha! Updated! Apparently Chrome search is case insensitive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Green build! @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112727098 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,97

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112727145 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,197

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112727162 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,197

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112728271 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112729036 --- Diff: flink-dist/src/main/assemblies/opt.xml --- @@ -95,5 +95,12 @@ flink-metrics-statsd-${project.version}.jar

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112729232 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,97

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-24 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112985930 --- Diff: flink-dist/src/main/assemblies/opt.xml --- @@ -95,5 +95,12 @@ flink-metrics-statsd-${project.version}.jar

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @zentol any further details and suggestions on the maven-jar-plugin part? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-25 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113259225 --- Diff: flink-dist/src/main/assemblies/opt.xml --- @@ -95,5 +95,12 @@ flink-metrics-statsd-${project.version}.jar

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-25 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @StephanEwen @zentol I shaded okhttp3 and okio from flink-metrics-datadog. I didn't use 'shade-flink' because I found it somehow prevents me from building a uber jar. Let me kno

[GitHub] flink pull request #3775: [FLINK-6386] Missing bracket in 'Compiler Limitati...

2017-04-25 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3775 [FLINK-6386] Missing bracket in 'Compiler Limitation' section Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into con

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-26 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113510125 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,109 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmln

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-26 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113512176 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,199

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-27 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @StephanEwen @zentol Hi guys, I just tested it on my machine and it works as expected. What's your plan on this PR? I found on email thread that there'll be a feature freeze of rele

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-28 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @StephanEwen @zentol I've made the following changes: 1) Datadog (DD) itself has a bug of being unstable when users filter metrics by 'host' in dashboards if 'h

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-05-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r114595396 --- Diff: flink-metrics/flink-metrics-datadog/src/test/java/org/apache/flink/metrics/datadog/DatadogHttpClientTest.java --- @@ -0,0 +1,194

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-05-04 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @zentol do you have any other concerns? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-05-07 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @zentol cool! Let me know how to get this into 1.3 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-05-08 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 I see - by looking at the code, I saw Flink has switched to version 1.4-SNAPSHOT 12h ago. Getting it into 1.4 is fine, our company has a open ticket for getting this code into Flink, and I want to

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-05-08 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Sure. BTW, that reminds me of one thing - I need to update the project version in my code from 1.3-SNAPSHOT to 1.4-SNAPSHOT. --- If your project is set up for it, you can reply to this

[GitHub] flink issue #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

2017-05-12 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Cool! 1.3 here we go! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #4665: [Flink-7611]add metrics to measure the num of data...

2017-09-12 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4665#discussion_r138513684 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -132,6 +133,13

[GitHub] flink issue #4657: [FLINK-7600][kinesis] shorten delay of KinesisProducerCon...

2017-09-13 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4657 @tzulitai Hi Gordon, can you please take a look at this PR? ---

[GitHub] flink issue #4656: [FLINK-7508][kinesis] switch FlinkKinesisProducer to use ...

2017-09-13 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4656 @tzulitai Hi Gordon, can you please take a look at this PR? ---

[GitHub] flink issue #4662: [FLINK-7609][examples] WindowWordCount example doesn't pr...

2017-09-13 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4662 @zentol Done ---

[GitHub] flink pull request #4656: [FLINK-7508][kinesis] switch FlinkKinesisProducer ...

2017-09-14 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4656#discussion_r138965647 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -171,8

[GitHub] flink issue #4656: [FLINK-7508][kinesis] switch FlinkKinesisProducer to use ...

2017-09-14 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4656 @tzulitai Thanks, Gordon! I watched your presentation on "managing state of Flink", and you did a great job explaining all details. I added an option for PER_REQUEST model since

[GitHub] flink issue #4663: [FLINK-6549] [DataStream API] Improve error message for t...

2017-09-17 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4663 Hi @zentol , let me know if you can help merge this in :) ---

[GitHub] flink issue #4662: [FLINK-7609][examples] WindowWordCount example doesn't pr...

2017-09-18 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4662 @zentol and this one. Thanks! ---

[GitHub] flink pull request #4684: [FLINK-7603][savepoint/doc] Document how to take a...

2017-09-19 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4684 [FLINK-7603][savepoint/doc] Document how to take a savepoint on YARN ## What is the purpose of the change The documentation should have a separate entry for savepoint related CLI

[GitHub] flink issue #4684: [FLINK-7603][savepoint/doc] Document how to take a savepo...

2017-09-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4684 cc @zentol ---

[GitHub] flink pull request #4684: [FLINK-7603][savepoint/doc] Document how to take a...

2017-09-20 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4684#discussion_r140050554 --- Diff: docs/ops/cli.md --- @@ -138,17 +138,30 @@ This allows the job to finish processing all inflight data. [Savepoints]({{site.baseurl

[GitHub] flink issue #4656: [FLINK-7508][kinesis] switch FlinkKinesisProducer to use ...

2017-09-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4656 @tzulitai Thank you! ---

[GitHub] flink issue #4657: [FLINK-7600][kinesis] shorten delay of KinesisProducerCon...

2017-09-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4657 @tzulitai Thank you, Gordon! ---

[GitHub] flink pull request #4702: [FLINK-7635][DataStream API][Scala API] Support si...

2017-09-21 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4702 [FLINK-7635][DataStream API][Scala API] Support sideOutput in ProcessWindowFunciton ## What is the purpose of the change Add support for sideOutput in ProcessWindowFunciton

[GitHub] flink issue #4702: [FLINK-7635][DataStream API][Scala API] Support sideOutpu...

2017-09-21 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4702 @aljoscha @chenqin Hi guys, can you please take a look? I'll write doc about this feature with [FLINK-7660](https://issues.apache.org/jira/browse/FLINK-7660). BTW, this is my first time wr

[GitHub] flink pull request #4703: [FLINK-7659][REST] Unprotected access to inProgres...

2017-09-21 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4703 [FLINK-7659][REST] Unprotected access to inProgress in JobCancellationWithSavepointHandlers#handleNewRequest ## What is the purpose of the change There's a thread accessing `inPro

[GitHub] flink pull request #4665: [Flink-7611]add metrics to measure the num of data...

2017-09-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4665#discussion_r140564281 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -405,6 +411,8 @@ public

[GitHub] flink pull request #4665: [Flink-7611]add metrics to measure the num of data...

2017-09-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4665#discussion_r140564400 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java --- @@ -231,6 +231,8

[GitHub] flink issue #4665: [Flink-7611]add metrics to measure the num of data droppe...

2017-09-22 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4665 @aljoscha sorry for being late the this CR. I left a couple comments ---

[GitHub] flink pull request #4707: [hotfix] Add doc for window operators, fix typos a...

2017-09-22 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4707 [hotfix] Add doc for window operators, fix typos and format code ## What is the purpose of the change Add doc for window operators, fix typos and format code. This is separated from

[GitHub] flink pull request #4702: [FLINK-7635][DataStream API][Scala API] Support si...

2017-09-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4702#discussion_r140571380 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -774,6 +774,14 @@ public

[GitHub] flink issue #4702: [FLINK-7635][DataStream API][Scala API] Support sideOutpu...

2017-09-22 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4702 Thank you @aljoscha ! I moved unrelated code changes to PR https://github.com/apache/flink/pull/4707 Just curious that why Flink's Scala API has its own `OutputTag`

[GitHub] flink pull request #4708: [FLINK-7393][kinesis connector] Move unit tests th...

2017-09-22 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4708 [FLINK-7393][kinesis connector] Move unit tests that should belong to KinesisConfigUtil from FlinkKinesisConsumerTest to KinesisConfigUtilTest ## What is the purpose of the change Right

[GitHub] flink pull request #4701: [FLINK-7664] Replace FlinkFutureException by java....

2017-09-22 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4701#discussion_r140614369 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarPlanHandler.java --- @@ -65,7 +65,7 @@ public JarPlanHandler

[GitHub] flink issue #4701: [FLINK-7664] Replace FlinkFutureException by java.util.co...

2017-09-22 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4701 LGTM ---

[GitHub] flink pull request #4711: [FLINK-7674][Streaming Connectors] NullPointerExce...

2017-09-23 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4711 [FLINK-7674][Streaming Connectors] NullPointerException in ContinuousFileMonitoringFunction close ## What is the purpose of the change If the ContinuousFileMonitoringFunction is closed

[GitHub] flink pull request #4665: [Flink-7611]add metrics to measure the num of data...

2017-09-23 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4665#discussion_r140645413 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java --- @@ -231,6 +231,8

[GitHub] flink issue #4708: [FLINK-7393][kinesis connector] Move unit tests that shou...

2017-09-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4708 cc @tzulitai ---

[GitHub] flink pull request #4721: [FLINK-6703][savepoint/doc] Document how to take a...

2017-09-24 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4721 [FLINK-6703][savepoint/doc] Document how to take a savepoint on YARN ## What is the purpose of the change The documentation should have a separate entry for savepoint related CLI

[GitHub] flink pull request #4684: [FLINK-6703][savepoint/doc] Document how to take a...

2017-09-24 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4684 ---

[GitHub] flink issue #4684: [FLINK-6703][savepoint/doc] Document how to take a savepo...

2017-09-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4684 Sorry, I realized I used the wrong jira ticket number. I'm closing this one, and the new PR is at https://github.com/apache/flink/pull/4721 ---

[GitHub] flink pull request #4707: [hotfix] Add doc for window operators, fix typos a...

2017-09-25 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4707 ---

[GitHub] flink pull request #4702: [FLINK-7635][DataStream API][Scala API] Support si...

2017-09-25 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4702 ---

[GitHub] flink issue #4702: [FLINK-7635][DataStream API][Scala API] Support sideOutpu...

2017-09-25 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4702 Thank you, guys @aljoscha @chenqin ! ---

  1   2   3   4   5   >