[GitHub] flink pull request #5908: [FLINK-9182]async checkpoints for timer service

2018-05-10 Thread makeyang
Github user makeyang commented on a diff in the pull request: https://github.com/apache/flink/pull/5908#discussion_r187296892 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java --- @@ -97,6 +105,32 @@ public String toString

[GitHub] flink pull request #5908: [FLINK-9182]async checkpoints for timer service

2018-05-10 Thread makeyang
Github user makeyang commented on a diff in the pull request: https://github.com/apache/flink/pull/5908#discussion_r187297365 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java --- @@ -395,36 +402,102 @@ public final

[GitHub] flink pull request #5908: [FLINK-9182]async checkpoints for timer service

2018-05-10 Thread makeyang
Github user makeyang commented on a diff in the pull request: https://github.com/apache/flink/pull/5908#discussion_r187294295 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java --- @@ -39,11 +40,18 @@ private final

[GitHub] flink pull request #5908: [FLINK-9182]async checkpoints for timer service

2018-05-10 Thread makeyang
Github user makeyang commented on a diff in the pull request: https://github.com/apache/flink/pull/5908#discussion_r187294255 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -49,13 +50,13

[GitHub] flink issue #5908: [FLINK-9182]async checkpoints for timer service

2018-05-10 Thread makeyang
Github user makeyang commented on the issue: https://github.com/apache/flink/pull/5908 @StefanRRichter sorry for the late answer. just take a surgery few days ago and come back now. I'll take close look at you comments and then answer back. ---

[GitHub] flink issue #5908: [FLINK-9182]async checkpoints for timer service

2018-05-10 Thread makeyang
Github user makeyang commented on the issue: https://github.com/apache/flink/pull/5908 @StefanRRichter I definitely like u ideas about flat copy priority queue in sync and then handler key-group thing in async. so I'll get rid of my solution and try to implement u solution

[GitHub] flink pull request #5908: [FLINK-9182]async checkpoints for timer service

2018-05-17 Thread makeyang
Github user makeyang closed the pull request at: https://github.com/apache/flink/pull/5908 ---

[GitHub] flink issue #5908: [FLINK-9182]async checkpoints for timer service

2018-05-17 Thread makeyang
Github user makeyang commented on the issue: https://github.com/apache/flink/pull/5908 @StefanRRichter should jira be close too? ---

[GitHub] flink pull request #6019: [FLINK-9182]async checkpoints for timer service

2018-05-16 Thread makeyang
Github user makeyang closed the pull request at: https://github.com/apache/flink/pull/6019 ---

[GitHub] flink issue #6019: [FLINK-9182]async checkpoints for timer service

2018-05-16 Thread makeyang
Github user makeyang commented on the issue: https://github.com/apache/flink/pull/6019 @StefanRRichter & @sihuazhou thanks u guys ---

[GitHub] flink pull request #6019: [FLINK-9182]async checkpoints for timer service

2018-05-15 Thread makeyang
GitHub user makeyang opened a pull request: https://github.com/apache/flink/pull/6019 [FLINK-9182]async checkpoints for timer service ## What is the purpose of the change it is for async checkpoints for timer service the whole idea is based on discussion in previous PR

[GitHub] flink pull request #6110: [hotfix] fix EXECUTION_FAILOVER_STRATEGY's comment...

2018-06-01 Thread makeyang
GitHub user makeyang opened a pull request: https://github.com/apache/flink/pull/6110 [hotfix] fix EXECUTION_FAILOVER_STRATEGY's comments error and its inf… ## What is the purpose of the change fix EXECUTION_FAILOVER_STRATEGY's comments error and its info message error

[GitHub] flink issue #6110: [hotfix] fix EXECUTION_FAILOVER_STRATEGY's comments error...

2018-06-05 Thread makeyang
Github user makeyang commented on the issue: https://github.com/apache/flink/pull/6110 can anybody take a look at it? it's pretty straightforward ---

[GitHub] flink pull request #5908: [FLINK-9182]async checkpoints for timer service

2018-04-25 Thread makeyang
GitHub user makeyang opened a pull request: https://github.com/apache/flink/pull/5908 [FLINK-9182]async checkpoints for timer service ## What is the purpose of the change This PR is WIP, and is need finish unit tests which are marked as TODO. It is opened to collect feedback

[jira] [Created] (FLINK-9631) use Files.createDirectories instead of directory.mkdirs

2018-06-20 Thread makeyang (JIRA)
makeyang created FLINK-9631: --- Summary: use Files.createDirectories instead of directory.mkdirs Key: FLINK-9631 URL: https://issues.apache.org/jira/browse/FLINK-9631 Project: Flink Issue Type

[jira] [Created] (FLINK-9182) async checkpoints for timer service

2018-04-16 Thread makeyang (JIRA)
makeyang created FLINK-9182: --- Summary: async checkpoints for timer service Key: FLINK-9182 URL: https://issues.apache.org/jira/browse/FLINK-9182 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-9228) log details about task fail/task manager is shutting down

2018-04-20 Thread makeyang (JIRA)
makeyang created FLINK-9228: --- Summary: log details about task fail/task manager is shutting down Key: FLINK-9228 URL: https://issues.apache.org/jira/browse/FLINK-9228 Project: Flink Issue Type