Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/3284
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/3768
[FLINK-6368][table] Grouping keys in stream aggregations have wrong order
âFLINK-5768 removed the `AggregateUtil.createPrepareMapFunction` stage,
who maps all grouping keys to the first n fields of
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3284#discussion_r100455274
--- Diff: docs/dev/libs/gelly/library_methods.md ---
@@ -242,6 +242,28 @@ The algorithm takes a directed, vertex (and possibly
edge) attributed graph as i
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/3284
With the present situation (for gelly), shall I close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/3284
[FLINK-1526] [Gelly] Add Minimum Spanning Tree library method
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4625
Hi @fhueske, the PR has been updated. However, there are still some
unfinished tasks, e.g., optimise the data caching and cleaning up policies and
distinguish the `<` and `<=`signs. I want to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139585456
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,74
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139591493
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/RowTimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,83
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139611419
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -131,340 +116,308 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139628583
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -131,340 +116,308 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139631978
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/RowTimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,83
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139633281
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -131,340 +116,308 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139849018
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/RowTimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,83
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139983961
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -131,340 +116,308 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139986193
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala
---
@@ -383,13 +384,158 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r140251765
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -131,340 +116,308 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r140255052
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,442
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r140266297
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -131,340 +116,308 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r140645274
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -131,340 +116,308 @@ class
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4625
Hi @fhueske, the PR has been updated. Temporarily, I keep the logic for
dealing with the late data, as well as the fine-grained cache.
For the late data semantics problem, I think we need to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r141993041
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -131,340 +116,308 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r142891284
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,410
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r143208392
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,410
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r143211000
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,410
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r143222605
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
@@ -184,4 +229,50 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r143231150
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/JoinITCase.scala
---
@@ -102,5 +117,154 @@ class JoinITCase
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r143357544
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/JoinITCase.scala
---
@@ -102,5 +117,154 @@ class JoinITCase
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r143412087
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,410
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r143445293
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,410
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r143448956
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,410
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r143487841
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,410
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4625
Hi @fhueske, I really appreciate for your guidance with great care.
Hopefully this prolonged work do not affect the schedule.
I'll keep working on the follow-up issues.
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4790
[FLINK-7764] [kafka] Enable the operator settings for FlinkKafkaProducer010
## What is the purpose of the change
This PR fixes the operator setting (name, uid, parallelism, etc.) problem
of
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4790
Thanks for the review @StephanEwen and @aljoscha. I'd like to fix this
thoroughly. However, I don't have much experience working on other branches.
Shall I checkout the `release-1.3` branc
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4804
[hotfix] [kafka] Fix the config parameter names in KafkaTestBase
## What is the purpose of the change
Fix the erroneous config parameter names in KafkaTestBase.
## Brief change
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/4804
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4819
[FLINK-7764] [kafka] Fix the operator setting problem of
FlinkKafkaProducer010(1.3)
## What is the purpose of the change
This PR fixes the operator setting (name, uid, parallelism, etc
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4790
Hi @aljoscha, I've created another PR #4819 for the `release-1.3` branch.
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4825
[FLINK-7798] [table] Add support for stream windowed inner joins to Table
API
## What is the purpose of the change
The PR enables the time-windowed inner join for
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4825#discussion_r144688279
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/JoinITCase.scala
---
@@ -0,0 +1,114
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4825#discussion_r144688874
--- Diff: docs/dev/table/tableApi.md ---
@@ -498,6 +499,23 @@ Table left = tableEnv.fromDataSet(ds1, "a, b, c");
Table right = tableEnv.fromD
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4830
[FLINK-7730] [table] Restrict the predicates of table function left outer
join
## What is the purpose of the change
The PR aims to temporarily cover up the table function left outer join
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4830#discussion_r144815350
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/CorrelateTest.scala
---
@@ -98,4 +103,17 @@ class CorrelateTest
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/4830
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4830
@fhueske, I'll separate this PR into sub ones.
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4842
[FLINK-7853] [table] Reject table function outer joins with predicates in
table API
# What is the purpose of the change
Due to CALCITE-2004, this PR aims to temporarily restrict the
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4846
[FLINK-7854] [table] Reject lateral table outer joins with predicates in SQL
## What is the purpose of the change
Due to CALCITE-2004, this PR aims to temporarily restrict the predicates
for
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4842#discussion_r145298482
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CorrelateITCase.scala
---
@@ -82,6 +82,42 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4842#discussion_r145299001
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CorrelateITCase.scala
---
@@ -82,6 +82,45 @@ class
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4842
Thanks for the review, @fhueske. I've updated the code and create a JIRA
FLINK-7865 to track the resolving process of CALCITE-2004.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4846
Hi @fhueske. I am working on it now.
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4846#discussion_r145650965
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkCalciteSqlValidator.scala
---
@@ -48,4 +49,19 @@ class
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4846
Hi @fhueske, the PR has been updated.
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4858#discussion_r145863708
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetJoinRule.scala
---
@@ -41,8 +41,7 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4858#discussion_r145938918
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetJoin.scala
---
@@ -156,65 +163,394 @@ class DataSetJoin
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4858#discussion_r145938669
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetJoin.scala
---
@@ -156,65 +163,394 @@ class DataSetJoin
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4858#discussion_r145863086
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalJoin.scala
---
@@ -97,8 +97,7 @@ private class
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4874
[hotfix] [docs] Update the description of time-windowed join for SQL doc
## What is the purpose of the change
This PR updates the description of time-windowed join in the SQL doc page
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4874
Thanks for reviewing this @fhueske. I've updated the doc.
Thanks, Xingcan
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r146104726
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/UpdatingPlanChecker.scala
---
@@ -56,16 +58,20 @@ object
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r146104539
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamJoinRule.scala
---
@@ -0,0 +1,112
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4530
[FLINK-7245] [stream] Support holding back watermarks with static delays
## What is the purpose of the change
*This pull request aims to allow the operators to support holding back
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132817252
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132820853
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132833668
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/OutputRowtimeProcessFunction.scala
---
@@ -0,0 +1,62
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132842811
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -719,33 +715,47 @@ abstract class
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4530
Thanks for the suggestion, @aljoscha. Do you think it's appropriate to add
a new package `org.apache.flink.table.runtime.operator`?
---
If your project is set up for it, you can reply to this
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4530
@fhueske Yes, the plural is better. I should have noticed that before.
This PR is updated with the new package name and an extra delay parameter
added to the co-operator.
---
If your project is
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4530
Thanks for the comments @fhueske. I will pay more attention to the coding
style.
Actually, there are many ways to implement this feature. At first, I planed
to override the `processWatermark
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4530
Thanks for the comment, @aljoscha. IMO, making the `timeServiceManager`
protected indeed will minimise the impact on `AbstractStreamOperator`, while
that may introduce duplicated codes in the
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4530
I totally understand the choice, @fhueske ð
Thanks for the refactoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4625
[FLINK-6233] [table] Support time-bounded stream inner join in the SQL API
## What is the purpose of the change
This PR aims add an implementation of the time-bounded stream inner join
for
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4633
[FLINK-7564] [table] Fix Watermark semantics in RowTimeUnboundedOver
## What is the purpose of the change
This PR aims to fix the watermark boundary check problem (mentioned in
[this
thread
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4633
Thanks for the review, @fhueske. I tried to consolidate the logics for
proctime and rowtime watermark processing, but failed. That's because when
using proctime, the "watermark" (n
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4633
I see. Thanks :-)
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4625
Thanks for the review, @fhueske. This PR is a little rough when I
committed. I'll address your comments and submit a refined version as soon as
possible.
Best, Xingcan
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137137915
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowJoinRule.scala
---
@@ -55,8 +55,10 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137144634
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
@@ -184,4 +195,54 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137146303
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
@@ -184,4 +195,54 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137150128
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala
---
@@ -115,10 +118,15 @@ object WindowJoinUtil
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137158818
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,533
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137163327
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,533
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137168799
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,533
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137201317
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,533
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137205581
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,533
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r137272749
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,533
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r146105104
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/DataStreamInnerJoin.scala
---
@@ -0,0 +1,287
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r146105359
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/DataStreamInnerJoin.scala
---
@@ -0,0 +1,287
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r146105512
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/DataStreamInnerJoin.scala
---
@@ -0,0 +1,287
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r146104323
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
---
@@ -0,0 +1,211
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r146104452
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
---
@@ -0,0 +1,211
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r146105266
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/DataStreamInnerJoin.scala
---
@@ -0,0 +1,287
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r146105057
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CRowWrappingMultiOuputCollector.scala
---
@@ -0,0 +1,48
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r146104524
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamJoinRule.scala
---
@@ -0,0 +1,112
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146424180
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146423916
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146423953
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146423134
--- Diff: docs/dev/table/tableApi.md ---
@@ -1031,19 +1034,22 @@ val result = in.orderBy('a.asc);
-
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146423039
--- Diff: docs/dev/table/tableApi.md ---
@@ -985,19 +985,22 @@ Table result = in.orderBy("a.asc");
-
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146426403
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table
1 - 100 of 250 matches
Mail list logo
