Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/3835
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/3836
[FLINK-6448] Web UI TaskManager view: Rename 'Free Memory' to 'JVM Heap'
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/3835
[FLINK-6448] Web UI TaskManager view: Rename 'Free Memory' to 'JVM Heap'
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/3836
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/3840
[FLINK-6448] Web UI TaskManager view: Rename 'Free Memory' to 'JVM Heap'
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/3840
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5933#discussion_r186347318
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -59,6 +60,8
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5933
@zentol please review again, if you have time.
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5933#discussion_r186346559
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -59,6 +60,8
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5834
@zentol this PR also reviewed by you, and takes a long time, can you review
this? thanks~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5954
cc @StephanEwen refactored code base on your suggestion, please review
again, thanks.
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5954
[FLINK-9276] Improve error message when TaskManager fails
## What is the purpose of the change
*This pull request improves error message when TaskManager fails*
## Brief
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5799
cc @zentol @GJL this PR takes a long time and the travis build error seems
uncorrelated. can you review it? thanks.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5777
cc @zentol @GJL @tzulitai this PR takes a long time, please review it
thanks.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @zentol @GJL @tzulitai this PR takes a long time, please review thanks~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
cc @zentol would you like to have a look?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5773
cc @zentol @GJL @tzulitai please review thanks~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
cc @fhueske changed and fixed a remained error before
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6002
cc @tzulitai
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6014
[FLINK-8933] Avoid calling Class#newInstance
## What is the purpose of the change
*This pull request refactored the usage of `Class#newInstance`*
## Brief change log
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6014
cc @StephanEwen & @zentol just one commit~
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6016
[FLINK-8933] Avoid calling Class#newInstance(part 2)
## What is the purpose of the change
*This pull request avoid calling Class#newInstance*
## Brief change log
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5970
cc @tillrohrmann this can be merged thanks!
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6014
OK now closing this and create two new PRs...
---
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6014
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6015
[FLINK-8933] Avoid calling Class#newInstance(part 1)
## What is the purpose of the change
*This pull request avoid calling Class#newInstance*
## Brief change log
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5970
[FLINK-9292] [core] Remove TypeInfoParser (part 2)
## What is the purpose of the change
*This pull request removed class `TypeInfoParser` and refactored specific
test case
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5970
hi @StephanEwen this issues part 2, please review it
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5971
cc @zentol
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5834
cc @zentol
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5936
cc @StephanEwen , here is the dependency tree :
```
[INFO] org.apache.flink:flink-metrics-prometheus:jar:1.6-SNAPSHOT
[INFO] +- io.prometheus:simpleclient:jar:0.3.0:compile
[INFO
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5971
[FLINK-9321] Rename SubtasksAllAccumulatorsHandlers
## What is the purpose of the change
*This pull request renamed SubtasksAllAccumulatorsHandlers to
SubtasksAllAccumulatorsHeaders
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5976
cc @fhueske @zentol
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5976
[FLINK-9309] Recommend HA setup on Production Readiness Checklist
## What is the purpose of the change
*This pull request adds HA setup on Production Readiness Checklist
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5976
@alpinegizmo good suggestion, will accept it and change it soon.
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5978
[FLINK-8554] Upgrade AWS SDK
## What is the purpose of the change
*This pull request upgrades AWS SDK*
## Brief change log
- *Upgrades AWS SDK*
## Verifying
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5834
cc @zentol refactored based on your suggestion, please review it again
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5933
cc @zentol
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5935
[FLINK-9119] example code error in Concepts & Common API
## What is the purpose of the change
*This pull request fixed example code error in Concepts & Common API*
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5936
[FLINK-9265] Upgrade Prometheus version
## What is the purpose of the change
*This pull request upgrades the prometheus's version to the latest version*
## Brief change log
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5933
[FLINK-9125] MiniClusterResource should set CoreOptions.TMP_DIRS
## What is the purpose of the change
*This pull request sets the `CoreOptions.TMP_DIRS` for MiniClusterResource
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5935
cc @fhueske
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5970
cc @StephanEwen fixed a incompatibility error
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
cc @tillrohrmann
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5834
@zentol this PR also reviewed by you, and takes a long time, can you review
this? thanks~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5976
cc @alpinegizmo @fhueske
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5997
[FLINK-9339] Accumulators are not UI accessible running in FLIP-6 mode
## What is the purpose of the change
*This pull request fixed a issue : accumulators are not UI accessible
running
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5834
cc @zentol
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5997
cc @zentol
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5997
@zentol you mean change all places in this PR? current change can fix the
issue, for others, I think in a new issue we could do the refactor. what's your
idea?
if you agree this suggestion, I
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5997
cc @zentol
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
@StephanEwen does this has any problem need to change? it seems @medcv try
to fixed this issue before asking me.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5834
hi @StephanEwen why the committers do not review those old PRs? I have
serval PRs which take so long time.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
cc @zentol @tillrohrmann
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5970
cc @StephanEwen refactored base on your suggestion.
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6001
[FLINK-9299] ProcessWindowFunction documentation Java examples have errors
## What is the purpose of the change
*This pull request fixed some document demo code error
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5954
cc @StephanEwen
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5970
cc @StephanEwen
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5834
@zentol thanks for your clarification. Actually, when I start join Flink
community, most of the PRs were reviewed by you and till. Both of you gave me a
lot of suggestion and technical opinion
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6002
[FLINK-9350] Parameter baseInterval has wrong check message in
CheckpointCoordinator constructor
## What is the purpose of the change
*This pull request fixed wrong check message
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5970
cc @StephanEwen refactored based on your suggestion, the travis build
failed because of yarn test, seems not about this PR's change.
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5970#discussion_r187601380
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java ---
@@ -268,8 +274,8 @@ public void
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5970#discussion_r187600843
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/typeinfo/TypeInformationTest.java
---
@@ -61,7 +61,7 @@ public void
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5970#discussion_r187601082
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java ---
@@ -109,7 +112,7 @@ public String map(MyPojo value) throws
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5799
hi @tzulitai can you review this PR, it takes a long time, thanks~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
cc @zentol @GJL
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5954
cc @StephanEwen @zentol
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6041
[FLINK-9326] TaskManagerOptions.NUM_TASK_SLOTS does not work for
local/embedded mode
## What is the purpose of the change
*This pull request fixed the num slot config value override error
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6041
cc @tillrohrmann
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5978
@StephanEwen here is test error in the [build
job](https://travis-ci.org/apache/flink/jobs/380523257), and it seems the aws
sdk is under license "Apache 2.0", so should I do the secon
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5978
version: 1.11.319:
```
[INFO] org.apache.flink:flink-connector-kinesis_2.11:jar:1.6-SNAPSHOT
[INFO] +- com.amazonaws:aws-java-sdk-kinesis:jar:1.11.319:compile
[INFO
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @kl0u
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6028
cc @tillrohrmann ,
[here](https://travis-ci.org/apache/flink/jobs/380067997) is a local recovery
rocksdb full test error .
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6028
[FLINK-9356] Improve error message for when queryable state not ready /
reachable
## What is the purpose of the change
*This pull request improve error message for when queryable state
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6029
[FLINK-9387] Several log message errors in queryable-state module
## What is the purpose of the change
*This pull request fixed several log message errors in queryable-state
module
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
cc @tzulitai @fhueske
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5970
cc @tzulitai
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6001#discussion_r188530473
--- Diff: docs/dev/stream/operators/windows.md ---
@@ -797,7 +797,7 @@ DataStream input = ...;
input
.keyBy()
- .timeWindow
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
@StephanEwen fixed based on your suggestion
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6029
cc @tzulitai
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6028
hi @kl0u , there is another PR about queryable state, would you like to
have a look? thanks~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6016
I mean the issue was thrown before the review, that may be considered it
was not a principal problem, deprecating `Class.newInstance` most reason is
used to fix undeclared checked exceptions (even
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6015
cc @zentol splitted it into two PRs please review and apologize to you again
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6016
hi @zentol I find this pattern has been defined as a
[BugPattern](https://github.com/google/error-prone/issues/407) in google's
[error-prone](https://github.com/google/error-prone) which is a lib
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6016
OK, I agree @StephanEwen , let's give it a low priority. Actually, I know
this big change can bring nondeterminacy to the codebase. So when I assigned
this issue to myself, I asked your opinion
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6029#discussion_r189858273
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6041#discussion_r189856924
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/LocalStreamEnvironment.java
---
@@ -103,9 +103,16 @@ public
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6028#discussion_r189943667
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5954
cc @StephanEwen
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6041#discussion_r190187802
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/LocalStreamEnvironment.java
---
@@ -103,9 +103,16 @@ public
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
so I just remove the close method from `disassociateFromJobManager `?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
@zentol normally, it seems you are right. But I don't know if there is any
exception could cause any remained information, at the jm switching moment.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
@zentol if we just remove it from `disassociateFromJobManager ` and do not
clear and reinitialize it, when a new job manager reconnect to the task manager
, it would remain some tasks' information
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6060
[FLINK-8946] TaskManager stop sending metrics after JobManager failover
## What is the purpose of the change
*This pull request improve error message for when queryable state not ready
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6028
cc @kl0u
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6060
cc @zentol I recreate a new PR base on your suggestion #5869 , the travis
build failed because of flink-statebackend-rocksdb
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
@zentol please see new PR #6060 , closing this PR...
---
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/5869
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6081
[FLINK-8067] User code ClassLoader not set before calling
ProcessingTimeCallback
## What is the purpose of the change
*This pull request sets the user code class loader for the thread
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5448
cc @dawidwys and @StephanEwen , I have fixed the conflicts and some issues
in new files, please review it.
---
1 - 100 of 473 matches
Mail list logo
