[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2652 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83842005 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,128 @@ public void

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83841451 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1299,124 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83840872 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,128 @@ public void testOnPartitionStateUpdate()

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83840545 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,128 @@ public void

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83839720 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1299,124 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83824898 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,50 @@ public void testOnPartitionStateUpdate()

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83824787 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83824750 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83824704 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83800757 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83801277 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,50 @@ public void

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83803660 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java --- @@ -565,6 +568,50 @@ public void

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83800396 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1183,47 +1220,48 @@ public String toString() { */

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83800845 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83800506 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -1251,33 +1289,113 @@ public void run() {

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2652#discussion_r83800264 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -289,6 +294,10 @@ public Task(

[GitHub] flink pull request #2652: [FLINK-4715] Fail TaskManager with fatal error if ...

2016-10-17 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2652 [FLINK-4715] Fail TaskManager with fatal error if task cancellation is stuck - Splits the cancellation up into two threads: * The `TaskCanceler` calls `cancel` on the invokable and `interrupt`