Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058545
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058073
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058480
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058404
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058523
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r129663595
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaCommitCallback.java
---
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r129663181
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaCommitCallback.java
---
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r129663458
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaCommitCallback.java
---
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r128078950
--- Diff: docs/monitoring/metrics.md ---
@@ -896,6 +896,28 @@ Thus, in order to infer the metric identifier:
+ Connector:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127966695
--- Diff: docs/monitoring/metrics.md ---
@@ -896,6 +896,28 @@ Thus, in order to infer the metric identifier:
+ Connector:
---
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127842765
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127838984
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127636481
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127636725
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -505,6
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127636859
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaCommitCallback.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127636523
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -185,6
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127560857
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127560753
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaCommitCallback.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127400942
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaCommitCallback.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127400689
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -505,6
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127400527
--- Diff: docs/monitoring/metrics.md ---
@@ -896,6 +896,28 @@ Thus, in order to infer the metric identifier:
+ Connector:
+
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r126283335
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -184,6
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r126283316
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -104,7
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r124413737
--- Diff: docs/monitoring/metrics.md ---
@@ -867,6 +867,28 @@ Thus, in order to infer the metric identifier:
+ Connector:
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r124413756
--- Diff: docs/monitoring/metrics.md ---
@@ -867,6 +867,28 @@ Thus, in order to infer the metric identifier:
+ Connector:
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r124284709
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r124235516
--- Diff: docs/monitoring/metrics.md ---
@@ -867,6 +867,28 @@ Thus, in order to infer the metric identifier:
+ Connector:
+
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r124235539
--- Diff: docs/monitoring/metrics.md ---
@@ -867,6 +867,28 @@ Thus, in order to infer the metric identifier:
+ Connector:
+
GitHub user zhenzhongxu opened a pull request:
https://github.com/apache/flink/pull/4187
[FLINK-6998][Kafka Connector] Add kafka offset commit metrics in consâ¦
add "kafkaCommitsSucceeded" and "kafkaCommitsFailed" metrics in
KafkaConsumerThread class.
You can merge this pull
30 matches
Mail list logo
