[GitHub] flink pull request #5782: [FLINK-6567] [tests] Harden ExecutionGraphMetricsT...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5782


---

[GitHub] flink pull request #5782: [FLINK-6567] [tests] Harden ExecutionGraphMetricsT...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

https://github.com/apache/flink/pull/5782#discussion_r178017403
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphMetricsTest.java
 ---
@@ -140,6 +140,9 @@ public void testExecutionGraphRestartTimeMetric() 
throws JobException, IOExcepti
 
assertTrue(currentRestartingTime >= 
previousRestartingTime);
previousRestartingTime = currentRestartingTime;
+
+   // add some pause to let the 
currentRestartingTime increase
+   Thread.sleep(1L);
--- End diff --

Yes can do.


---

[GitHub] flink pull request #5782: [FLINK-6567] [tests] Harden ExecutionGraphMetricsT...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

https://github.com/apache/flink/pull/5782#discussion_r178017114
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphMetricsTest.java
 ---
@@ -140,6 +140,9 @@ public void testExecutionGraphRestartTimeMetric() 
throws JobException, IOExcepti
 
assertTrue(currentRestartingTime >= 
previousRestartingTime);
previousRestartingTime = currentRestartingTime;
+
+   // add some pause to let the 
currentRestartingTime increase
+   Thread.sleep(1L);
--- End diff --

I think we have to keep it here, because otherwise the loop might finish so 
fast that we don't see an increase in `previousRestartingTime` because this 
value is effectively `System.currentTimeMillis - timestamps[RESTARTING]`.


---

[GitHub] flink pull request #5782: [FLINK-6567] [tests] Harden ExecutionGraphMetricsT...

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/5782#discussion_r177804309
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphMetricsTest.java
 ---
@@ -193,6 +197,8 @@ public void testExecutionGraphRestartTimeMetric() 
throws JobException, IOExcepti
 
assertTrue(currentRestartingTime >= 
previousRestartingTime);
previousRestartingTime = currentRestartingTime;
+   // add some pause to the let 
currentRestartingTime increase
+   Thread.sleep(1L);
--- End diff --

same as above


---

[GitHub] flink pull request #5782: [FLINK-6567] [tests] Harden ExecutionGraphMetricsT...

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/5782#discussion_r177803798
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphMetricsTest.java
 ---
@@ -140,6 +140,9 @@ public void testExecutionGraphRestartTimeMetric() 
throws JobException, IOExcepti
 
assertTrue(currentRestartingTime >= 
previousRestartingTime);
previousRestartingTime = currentRestartingTime;
+
+   // add some pause to let the 
currentRestartingTime increase
+   Thread.sleep(1L);
--- End diff --

move this to the start of the loop instead? (since you call 
`restartingTime.getValue()` right before the loop and at the start of the loop)


---

[GitHub] flink pull request #5782: [FLINK-6567] [tests] Harden ExecutionGraphMetricsT...

[tillrohrmann]

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/5782

[FLINK-6567] [tests] Harden ExecutionGraphMetricsTest

## What is the purpose of the change

The problem was that in some cases the currentRestartingTime would not 
increase
because the iteration in the loop were too fast.

cc @zentol 

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink 
hardenExecutionGraphMetricsTest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5782


commit 91b5db420f7e9079e9da364529fe125f157b9533
Author: Till Rohrmann 
Date:   2018-03-28T13:35:11Z

[FLINK-6567] [tests] Harden ExecutionGraphMetricsTest

The problem was that in some cases the currentRestartingTime would not 
increase
because the iteration in the loop were too fast.




---