[jira] [Commented] (FLINK-4560) enforcer java version as 1.7
[ https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526904#comment-15526904 ] ASF GitHub Bot commented on FLINK-4560: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2458 > enforcer java version as 1.7 > > > Key: FLINK-4560 > URL: https://issues.apache.org/jira/browse/FLINK-4560 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > Fix For: 1.2.0 > > > 1. maven-enforcer-plugin add java version enforce > 2. maven-enforcer-plugin version upgrade to 1.4.1 > explicit require java version -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4560) enforcer java version as 1.7
[ https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15518662#comment-15518662 ] ASF GitHub Bot commented on FLINK-4560: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2458 @StephanEwen OK. > enforcer java version as 1.7 > > > Key: FLINK-4560 > URL: https://issues.apache.org/jira/browse/FLINK-4560 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > 1. maven-enforcer-plugin add java version enforce > 2. maven-enforcer-plugin version upgrade to 1.4.1 > explicit require java version -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4560) enforcer java version as 1.7
[ https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512936#comment-15512936 ] ASF GitHub Bot commented on FLINK-4560: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2458 From my side, this is good to merge. Unless someone objects, I will merge this later today... > enforcer java version as 1.7 > > > Key: FLINK-4560 > URL: https://issues.apache.org/jira/browse/FLINK-4560 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > 1. maven-enforcer-plugin add java version enforce > 2. maven-enforcer-plugin version upgrade to 1.4.1 > explicit require java version -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4560) enforcer java version as 1.7
[ https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509137#comment-15509137 ] ASF GitHub Bot commented on FLINK-4560: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2458 enforce java 7 before compile. There is no conflict between source/target and enforcer java version. > enforcer java version as 1.7 > > > Key: FLINK-4560 > URL: https://issues.apache.org/jira/browse/FLINK-4560 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > 1. maven-enforcer-plugin add java version enforce > 2. maven-enforcer-plugin version upgrade to 1.4.1 > explicit require java version -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4560) enforcer java version as 1.7
[ https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507137#comment-15507137 ] ASF GitHub Bot commented on FLINK-4560: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2458 We already gave up Java 6, and setting the source and target version in the Maven compiler plugin already prevents Java 6 usage. That is why I am wondering... > enforcer java version as 1.7 > > > Key: FLINK-4560 > URL: https://issues.apache.org/jira/browse/FLINK-4560 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > 1. maven-enforcer-plugin add java version enforce > 2. maven-enforcer-plugin version upgrade to 1.4.1 > explicit require java version -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4560) enforcer java version as 1.7
[ https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506901#comment-15506901 ] ASF GitHub Bot commented on FLINK-4560: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2458 @greghogan exactly 3.0.3 will be OK. This limit is some module require, I forget where it is, I am sorry.. > enforcer java version as 1.7 > > > Key: FLINK-4560 > URL: https://issues.apache.org/jira/browse/FLINK-4560 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > 1. maven-enforcer-plugin add java version enforce > 2. maven-enforcer-plugin version upgrade to 1.4.1 > explicit require java version -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4560) enforcer java version as 1.7
[ https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506858#comment-15506858 ] ASF GitHub Bot commented on FLINK-4560: --- Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2458 Would this be useful to prevent building Flink with Maven 3.3.x? https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html https://maven.apache.org/enforcer/enforcer-rules/ > enforcer java version as 1.7 > > > Key: FLINK-4560 > URL: https://issues.apache.org/jira/browse/FLINK-4560 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > 1. maven-enforcer-plugin add java version enforce > 2. maven-enforcer-plugin version upgrade to 1.4.1 > explicit require java version -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4560) enforcer java version as 1.7
[ https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506752#comment-15506752 ] ASF GitHub Bot commented on FLINK-4560: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2458 hi, @StephanEwen There are much difference between JDK 6 and JDK 7+. It's better for compatible low version JDK，but there are better performance for Scala with Lambda support, and JDK 7 and 8 are enhanced on many features. Now JDK7 is wide used. Give up JDK 6 compatible. It's clearly for developer: use JDK 7+ features relieved > enforcer java version as 1.7 > > > Key: FLINK-4560 > URL: https://issues.apache.org/jira/browse/FLINK-4560 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > 1. maven-enforcer-plugin add java version enforce > 2. maven-enforcer-plugin version upgrade to 1.4.1 > explicit require java version -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4560) enforcer java version as 1.7
[ https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504538#comment-15504538 ] ASF GitHub Bot commented on FLINK-4560: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2458 Hi! Can you explain a bit what this pull request fixes? I think Maven complains by itself if the JDK is of a lower version than the compiler target version. So what changes here? Thanks! > enforcer java version as 1.7 > > > Key: FLINK-4560 > URL: https://issues.apache.org/jira/browse/FLINK-4560 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > 1. maven-enforcer-plugin add java version enforce > 2. maven-enforcer-plugin version upgrade to 1.4.1 > explicit require java version -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4560) enforcer java version as 1.7
[
https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457312#comment-15457312
]
ASF GitHub Bot commented on FLINK-4560:
---
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2458
[FLINK-4560] enforcer java version as 1.7
[FLINK-4560](https://issues.apache.org/jira/browse/FLINK-4560) enforcer
java version as 1.7
1. maven-enforcer-plugin add java version enforce
2. maven-enforcer-plugin version upgrade to 1.4.1
explicit require java version
Only modify the root pom file.
The pull request references the related JIRA issue ("[FLINK-4560] enforcer
java version as 1.7")
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shijinkui/flink enforcer_java_version_7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2458
commit d4fe8b21ea6680832328cc93b620973bee57ab03
Author: shijinkui
Date: 2016-09-02T02:46:45Z
\
[FLINK-4560] enforcer java version as 1.7
1. maven-enforcer-plugin add java version enforce
2. maven-enforcer-plugin version upgrade to 1.4.1
explicit require java version
> enforcer java version as 1.7
>
>
> Key: FLINK-4560
> URL: https://issues.apache.org/jira/browse/FLINK-4560
> Project: Flink
> Issue Type: Improvement
>Reporter: shijinkui
>
> 1. maven-enforcer-plugin add java version enforce
> 2. maven-enforcer-plugin version upgrade to 1.4.1
> explicit require java version
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
