[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979683#comment-15979683 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 @fhueske Thanks : ) > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Sub-task > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.3.0 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979374#comment-15979374 ] ASF GitHub Bot commented on FLINK-4562: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2460 > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Sub-task > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979264#comment-15979264 ] ASF GitHub Bot commented on FLINK-4562: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2460 Merging > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Sub-task > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978262#comment-15978262 ] ASF GitHub Bot commented on FLINK-4562: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2460 Thanks, @shijinkui I think this PR is good to merge. I was waiting for you to add the examples jar file to the `./opt` folder, but we can also do this as a follow up task. I'll rename the resulting file to `flink-table-examples-with-dependencies.jar` and merge this PR. Thanks, Fabian > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Sub-task > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978173#comment-15978173 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 > Hi @shijinkui, yes that sounds good to me. Thanks. When will we merge this? > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Sub-task > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972406#comment-15972406 ] ASF GitHub Bot commented on FLINK-4562: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2460 Hi @shijinkui, yes that sounds good to me. > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Sub-task > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941619#comment-15941619 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 > I agree with @wuchong , that we should follow the example of Gelly and add the flink-table-examples JAR file to the opt folder. @fhueske Thanks for your review. IMO, directory style below is reasonable: * `examples` directory only contain example jars * `opt` directory only contain optional library jars * `lib` directory only contain library jar that must be load in runtime The `opt` directory is noisy, that contains lib jar and example jar: ``` flink-cep-scala_2.11-1.3.0.jar flink-gelly_2.11-1.3.0.jar flink-metrics-statsd-1.3.0.jar flink-cep_2.11-1.3.0.jar flink-metrics-dropwizard-1.3.0.jar flink-ml_2.11-1.3.0.jar flink-gelly-examples_2.11-1.3.0.jar flink-metrics-ganglia-1.3.0.jar flink-gelly-scala_2.11-1.3.0.jar flink-metrics-graphite-1.3.0.jar ``` > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[
https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939397#comment-15939397
]
ASF GitHub Bot commented on FLINK-4562:
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2460#discussion_r107792137
--- Diff:
flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/scala/StreamTableExample.scala
---
@@ -18,18 +18,18 @@
package org.apache.flink.table.examples.scala
import org.apache.flink.api.scala._
-import org.apache.flink.table.api.scala._
import org.apache.flink.streaming.api.scala.{DataStream,
StreamExecutionEnvironment}
import org.apache.flink.table.api.TableEnvironment
+import org.apache.flink.table.api.scala._
/**
- * Simple example for demonstrating the use of Table API on a Stream
Table.
- *
- * This example shows how to:
- * - Convert DataStreams to Tables
- * - Apply union, select, and filter operations
- *
- */
+ * Simple example for demonstrating the use of Table API on a Stream Table.
--- End diff --
Can you fix the Scaladoc comment style of the other Scala classes as well?
Thanks
> table examples make an divided module in flink-examples
> ---
>
> Key: FLINK-4562
> URL: https://issues.apache.org/jira/browse/FLINK-4562
> Project: Flink
> Issue Type: Improvement
> Components: Examples, Table API & SQL
>Reporter: shijinkui
>Assignee: shijinkui
> Fix For: 1.2.1
>
>
> example code should't packaged in table module.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[
https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939396#comment-15939396
]
ASF GitHub Bot commented on FLINK-4562:
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2460#discussion_r107804086
--- Diff: flink-examples/flink-examples-table/pom.xml ---
@@ -0,0 +1,108 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+
+ org.apache.flink
+ flink-examples_2.10
+ 1.3-SNAPSHOT
+ ..
+
+
+ flink-examples-table
+ flink-examples-table_2.10
+ jar
+
+
+
+ org.apache.flink
+ flink-table_2.10
+ ${project.version}
+
+
+
+
+
+
+ net.alchim31.maven
+ scala-maven-plugin
+
+
+ scala-compile-first
+ process-resources
+
+ add-source
+ compile
+
+
+
+ scala-test-compile
+
process-test-resources
+
+ testCompile
+
+
+
+
+
+ org.apache.maven.plugins
+ maven-shade-plugin
+
+
+ fat-jar-table-examples
+ package
+
+ shade
+
+
+
false
+
false
+
false
+
TableExamples
--- End diff --
I think we should keep the name of the generated artifact as
`flink-table-examples_2.10`
> table examples make an divided module in flink-examples
> ---
>
> Key: FLINK-4562
> URL: https://issues.apache.org/jira/browse/FLINK-4562
> Project: Flink
> Issue Type: Improvement
> Components: Examples, Table API & SQL
>Reporter: shijinkui
>Assignee: shijinkui
> Fix For: 1.2.1
>
>
> example code should't packaged in table module.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928973#comment-15928973 ] ASF GitHub Bot commented on FLINK-4562: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2460 Thanks for the reminder @shijinkui! I'll put this one on my list for next week. Thanks, Fabian > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925836#comment-15925836 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 ping @wuchong @fhueske @twalthr > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877486#comment-15877486 ] ASF GitHub Bot commented on FLINK-4562: --- Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2460 Hi @shijinkui , sorry for the delay, the change looks very good to me. Regarding to your questions, >1. all the example code moved in flink-examples module, as a sub-module. Yes or No? Yes, it's fine to me. >2. optionally generate runnable example jar in flink distribution. Yes or No? I think we can generate the runnable table example jar in the distribution. And I think we can put it under `/examples/`. But I find that the gelly example is put into `/opt/`. Maybe we can start a discussion in mailing list to keep consistent with gelly. > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877294#comment-15877294 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 @wuchong @StephanEwen can you review this pull request. Generating independent example runnable jar will increase the size of flink distribution. This table example jar is 13Mb or so. We can make a agreement of example here: 1. all the example code moved in flink-examples module, as a sub-module. Yes or No? 2. optionally generate runnable example jar in flink distribution. Yes or No? > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861120#comment-15861120 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 > The repackaging is good. > Unfortunately this breaks the Table API tests, because they use one of the examples. > > The Table API IT cases probably need to use their own programs, rather than relying on the examples. Table test dependency the `WC` case class of WordCountExample. I have divided them. the flink-examples-table module have support building the fat jar like `flink-examples-streaming` and `flink-examples-batch`. IMO, all the example module should move to the `flink-examples` module as a sub-module :) > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement > Components: Examples, Table API & SQL >Reporter: shijinkui >Assignee: shijinkui > Fix For: 1.2.1 > > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611141#comment-15611141 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 fixed it. > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608887#comment-15608887 ] ASF GitHub Bot commented on FLINK-4562: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2460 The repackaging is good. Unfortunately this breaks the Table API tests, because they use one of the examples. The Table API IT cases probably need to use their own programs, rather than relying on the examples. > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530097#comment-15530097 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 @wuchong you are right. Different package of scala/java can avoid same class conflict > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[
https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530093#comment-15530093
]
ASF GitHub Bot commented on FLINK-4562:
---
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/2460#discussion_r80955533
--- Diff: flink-examples/flink-examples-table/pom.xml ---
@@ -0,0 +1,24 @@
+
+http://maven.apache.org/POM/4.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+
+ org.apache.flink
+ flink-examples_2.10
+ 1.2-SNAPSHOT
+
+
+ flink-examples-table_2.10
+ flink-examples-table
+
+
+
+ org.apache.flink
+ flink-table_2.10
+ ${project.version}
+
+
--- End diff --
I lost jar
> table examples make an divided module in flink-examples
> ---
>
> Key: FLINK-4562
> URL: https://issues.apache.org/jira/browse/FLINK-4562
> Project: Flink
> Issue Type: Improvement
>Reporter: shijinkui
>
> example code should't packaged in table module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530092#comment-15530092 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80955413 --- Diff: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/StreamSQLExample.scala --- @@ -15,7 +15,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.flink.examples.scala +package org.apache.flink.table.examples --- End diff -- OK > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[
https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529637#comment-15529637
]
ASF GitHub Bot commented on FLINK-4562:
---
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2460#discussion_r80916077
--- Diff: flink-examples/flink-examples-table/pom.xml ---
@@ -0,0 +1,24 @@
+
+http://maven.apache.org/POM/4.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+
+ org.apache.flink
+ flink-examples_2.10
+ 1.2-SNAPSHOT
+
+
+ flink-examples-table_2.10
+ flink-examples-table
+
+
+
+ org.apache.flink
+ flink-table_2.10
+ ${project.version}
+
+
--- End diff --
My IDE (IntelliJ) does not recognize `src/scala` as source folder. It might
be necessary to add additional Maven configuration. I would use
`flink-gelly-examples` as a reference for the plugin configuration.
> table examples make an divided module in flink-examples
> ---
>
> Key: FLINK-4562
> URL: https://issues.apache.org/jira/browse/FLINK-4562
> Project: Flink
> Issue Type: Improvement
>Reporter: shijinkui
>
> example code should't packaged in table module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529636#comment-15529636 ] ASF GitHub Bot commented on FLINK-4562: --- Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80910964 --- Diff: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/StreamSQLExample.scala --- @@ -15,7 +15,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.flink.examples.scala +package org.apache.flink.table.examples --- End diff -- This should be called `org.apache.flink.table.examples.scala` to be consistent with `org.apache.flink.table.examples.java`. IMHO the language should be right after the `table`: `org.apache.flink.table.java.examples` > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529611#comment-15529611 ] ASF GitHub Bot commented on FLINK-4562: --- Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2460 Could we move the Scala examples to a separate package , such as: `org.apache.flink.table.scala.examples`, to avoid potential class conflicts. > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529490#comment-15529490 ] ASF GitHub Bot commented on FLINK-4562: --- Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2460 +1 I will shepherd this PR. > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504585#comment-15504585 ] ASF GitHub Bot commented on FLINK-4562: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2460 I agree. +1 for moving the examples. > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504575#comment-15504575 ] ASF GitHub Bot commented on FLINK-4562: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2460 I think this is actually a good idea. The Table API module should not contain the examples. @fhueske @twalthr What do you think about this? > table examples make an divided module in flink-examples > --- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement >Reporter: shijinkui > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples
[
https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457733#comment-15457733
]
ASF GitHub Bot commented on FLINK-4562:
---
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2460
[FLINK-4562] table examples make an divided module in flink-examples
only move table examle code to a divided module in flink-examples.
Table API module should't contain example code.
[issue](https://issues.apache.org/jira/browse/FLINK-4562)
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-4562] table
examples make an divided module in flink-examples")
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shijinkui/flink table-example-module
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2460.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2460
commit 4fb919b7bc31a269bfa82e32ae67fb43065ba6ac
Author: shijinkui
Date: 2016-09-02T06:50:11Z
[FLINK-4562] table examples make an divided module in flink-examples
> table examples make an divided module in flink-examples
> ---
>
> Key: FLINK-4562
> URL: https://issues.apache.org/jira/browse/FLINK-4562
> Project: Flink
> Issue Type: Improvement
>Reporter: shijinkui
>
> example code should't packaged in table module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
