[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470269#comment-16470269
]
ASF GitHub Bot commented on FLINK-9179:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5856
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462088#comment-16462088
]
Aljoscha Krettek commented on FLINK-9179:
-
[~Zentol] Ok, let's deprecate it then.
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458425#comment-16458425
]
Chesnay Schepler commented on FLINK-9179:
-
It's _probably_ possible to do, but I'm wondering whether users actually gain
anything.
The server-side is doable; move the StaticFileServerHandler into a separate
RestEndpoint and add a bit of plumbing to support 2 endpoints in the dispatcher.
The client-side however is problematic as IIRC the rest calls implicitly go
against the same port that the UI is running on. I don't know how we could
dynamically set this to a different port, outside of injecting it into
{{index.js}} on the fly.
The only use-case I could see is to make it easier to restrict access to the
REST API while retaining a functioning WebUI. This will become more important
as we extend the REST API with more control functions.
But I don't know enough about how one would implement this to make a definitive
statement as to whether this is actually the case. The problem I see is that
one would have to enumerate all paths to allow/restrict which is error-prone
and hard to maintain, whereas a separate port is easy to detect. But then how
is the WebUI still allowed to access everything it needs?
We are in bad spot here; if we don't change the keys the transition to 1.5 will
be bumpy, but if we change them we can't reverse it easily.
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458394#comment-16458394
]
Aljoscha Krettek commented on FLINK-9179:
-
Does is maybe sometimes make sense to have a separate Web UI running on a
different port from the JobManager/Dispatcher?
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451825#comment-16451825
]
ASF GitHub Bot commented on FLINK-9179:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5856
merging.
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450021#comment-16450021
]
ASF GitHub Bot commented on FLINK-9179:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5856
Thanks for @zentol having an awesome review! Will have a update soon.
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449779#comment-16449779
]
ASF GitHub Bot commented on FLINK-9179:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5856
there are also other references:
classes:
* StreamExecutionEnvironment#createLocalEnvironmentWithWebUI
* (scala) StreamExecutionEnvironment#createLocalEnvironmentWithWebUI
* ExecutionEnvironment#createLocalEnvironmentWithWebUI
docs:
* rest_api.md
* mesos.md
scripts:
* common.sh
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449772#comment-16449772
]
ASF GitHub Bot commented on FLINK-9179:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5856
we should also update `flink-conf-yaml` which by default contains
`web.port`.
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443706#comment-16443706
]
ASF GitHub Bot commented on FLINK-9179:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5856
Hi @zentol This patch is ready for having a review.
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439443#comment-16439443
]
ASF GitHub Bot commented on FLINK-9179:
---
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5856#discussion_r181733675
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/WebOptions.java ---
@@ -38,7 +38,10 @@
/**
* The port for the runtime monitor web-frontend server.
+*
+* @deprecated Use {@link RestOptions#PORT} instead
*/
--- End diff --
FLINK-9180 rename it to RestOptions#PORT.
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439442#comment-16439442
]
ASF GitHub Bot commented on FLINK-9179:
---
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5856
[FLINK-9179] [conf] Fix deduplicate WebOptions.PORT and RestOptions.PORT
## What is the purpose of the change
There are deduplicate WebOptions.PORT and RestOptions.REST_PORT. Should be
solved.
## Brief change log
Deprecate WebOptions.PORT, and add a deprecated key to
RestOptions.REST_PORT.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-9179
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5856
commit 8eb6c87cb735eaae18892ec2542076509b741690
Author: zhangminglei
Date: 2018-04-16T13:24:14Z
[FLINK-9179] [conf] Fix deduplicate WebOptions.PORT and RestOptions.PORT
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439438#comment-16439438
]
ASF GitHub Bot commented on FLINK-9179:
---
Github user lamber-ken closed the pull request at:
https://github.com/apache/flink/pull/5855
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT
[
https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439432#comment-16439432
]
ASF GitHub Bot commented on FLINK-9179:
---
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/5855
[FLINK-9179] add prometheus pushgateway reporter
## What is the purpose of the change
This pull request makes flink system can send metrics to prometheus via
pushgateway. when using `yarn-cluster` model, it's useful.
## Brief change log
- Add prometheus pushgateway repoter
- Restructure the code of the promethues reporter part
## Verifying this change
This change is already covered by existing tests. [prometheus
test](https://github.com/apache/flink/tree/master/flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lamber-ken/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5855.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5855
commit 7332c6df905f3f9d56615618fb000d2449109f3f
Author: xl38154
Date: 2018-04-16T12:58:44Z
add prometheus pushgateway reporter
> Deduplicate WebOptions.PORT and RestOptions.REST_PORT
> -
>
> Key: FLINK-9179
> URL: https://issues.apache.org/jira/browse/FLINK-9179
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, REST, Webfrontend
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: mingleizhang
>Priority: Blocker
> Fix For: 1.5.0
>
>
> In the past {{WebOptions.PORT}} was used to configure the port on which the
> WebUI listens on. With the rework of the REST API we added a new
> configuration key {{RestOptions.REST_PORT}} to specify on which port the REST
> API listens on.
> Effectively these 2 options control the same thing, with the rest option
> being broader and also applicable to components with a REST API but no WebUI.
> I suggest to deprecate WebOptions.PORT, and add a deprecated key to
> {{RestOptions.REST_PORT}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
