[GitHub] incubator-hawq pull request #928: HAWQ-1051. Failing in reverse DNS lookup c...
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/928 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #928: HAWQ-1051. Failing in reverse DNS lookup c...
Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/928#discussion_r80054816
--- Diff: src/backend/resourcemanager/requesthandler.c ---
@@ -627,7 +627,11 @@ bool handleRMSEGRequestIMAlive(void **arg)
fts_client_ip_len = strlen(fts_client_ip);
inet_aton(fts_client_ip, &fts_client_addr);
fts_client_host = gethostbyaddr(&fts_client_addr, 4, AF_INET);
- Assert(fts_client_host != NULL);
+ if (fts_client_host == NULL)
+ {
+ elog(WARNING, "Failed to reverse DNS lookup for ip %s.",
fts_client_ip);
+ return true;
+ }
--- End diff --
Not quit after "reverse dns lookup" failure. This function handles the
IMAlive message from segment resource manager process. "return true" just
ignore this message and do not continue the followup work after a lookup
failure. IP address is not enough since followup work needs the hostname.
For replace gethostbyaddr(), @jiny2 could you give some comments ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #928: HAWQ-1051. Failing in reverse DNS lookup c...
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/928#discussion_r80015438
--- Diff: src/backend/resourcemanager/requesthandler.c ---
@@ -627,7 +627,11 @@ bool handleRMSEGRequestIMAlive(void **arg)
fts_client_ip_len = strlen(fts_client_ip);
inet_aton(fts_client_ip, &fts_client_addr);
fts_client_host = gethostbyaddr(&fts_client_addr, 4, AF_INET);
- Assert(fts_client_host != NULL);
+ if (fts_client_host == NULL)
+ {
+ elog(WARNING, "Failed to reverse DNS lookup for ip %s.",
fts_client_ip);
+ return true;
+ }
--- End diff --
If it is easy to modify we could use the replacement of gethostbyaddr().
By the way, why need to quit after "reverse dns lookup" failure. Should not
an IP address work also?
DESCRIPTION
The gethostbyname*() and gethostbyaddr*() functions are obsolete.
Applications
should use getaddrinfo(3) and getnameinfo(3) instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #928: HAWQ-1051. Failing in reverse DNS lookup c...
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/928 HAWQ-1051. Failing in reverse DNS lookup causes resource manager core⦠⦠dump You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyxiang/incubator-hawq reversefail Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/928.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #928 commit 0f5cec04203304c22558e89f4ce29266f4643f33 Author: stanlyxiang Date: 2016-09-21T15:57:27Z HAWQ-1051. Failing in reverse DNS lookup causes resource manager core dump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
