[GitHub] [hbase] Apache-HBase commented on pull request #2592: HBASE-25223 Use try-with-resources statement

Apache-HBase commented on pull request #2592: URL: https://github.com/apache/hbase/pull/2592#issuecomment-717729462 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2581: HBASE-25201 YouAreDeadException should be moved to hbase-server module

Apache-HBase commented on pull request #2581: URL: https://github.com/apache/hbase/pull/2581#issuecomment-717734279 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 merged pull request #2581: HBASE-25201 YouAreDeadException should be moved to hbase-server module

Apache9 merged pull request #2581: URL: https://github.com/apache/hbase/pull/2581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

Apache-HBase commented on pull request #2591: URL: https://github.com/apache/hbase/pull/2591#issuecomment-717775168 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2592: HBASE-25223 Use try-with-resources statement

Apache-HBase commented on pull request #2592: URL: https://github.com/apache/hbase/pull/2592#issuecomment-717790345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2580: HBASE-25210 RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

Apache-HBase commented on pull request #2580: URL: https://github.com/apache/hbase/pull/2580#issuecomment-717816131 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] nkalmar commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

nkalmar commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-717826088 Different test failed than before, restarting build This is an automated message from the Apache Git Service. To

[jira] [Created] (HBASE-25225) Create table very slowly if there are multi regions

Guanghao Zhang created HBASE-25225: -- Summary: Create table very slowly if there are multi regions Key: HBASE-25225 URL: https://issues.apache.org/jira/browse/HBASE-25225 Project: HBase

[GitHub] [hbase] petersomogyi opened a new pull request #2593: HBASE-25224 Maximize sleep for checking meta and namespace regions availability

petersomogyi opened a new pull request #2593: URL: https://github.com/apache/hbase/pull/2593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-717841767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] infraio commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

infraio commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-717856156 > @ddupg Need to fix the spotbugs warnings:

[GitHub] [hbase] infraio merged pull request #2579: HBASE-24999 Master manages ReplicationServers

infraio merged pull request #2579: URL: https://github.com/apache/hbase/pull/2579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2580: HBASE-25210 RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

Apache-HBase commented on pull request #2580: URL: https://github.com/apache/hbase/pull/2580#issuecomment-717827233 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Updated] (HBASE-25225) Create table very slowly if there are multi regions

[ https://issues.apache.org/jira/browse/HBASE-25225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-25225: --- Description: Run the same UT TestRegionReplicaFailover on my local PC, mvn clean test

[jira] [Resolved] (HBASE-24999) Master manages ReplicationServers

[ https://issues.apache.org/jira/browse/HBASE-24999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24999. Resolution: Fixed Merged. Thanks [~Ddupg] for contributing. > Master manages

[GitHub] [hbase] Apache-HBase commented on pull request #2592: HBASE-25223 Use try-with-resources statement

Apache-HBase commented on pull request #2592: URL: https://github.com/apache/hbase/pull/2592#issuecomment-717813068 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

Apache-HBase commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-717869410 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

Apache-HBase commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-717872510 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 merged pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

Apache9 merged pull request #2538: URL: https://github.com/apache/hbase/pull/2538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2581: HBASE-25201 YouAreDeadException should be moved to hbase-server module

Apache-HBase commented on pull request #2581: URL: https://github.com/apache/hbase/pull/2581#issuecomment-717749806 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25224) Maximize sleep for checking meta and namespace regions availability

Peter Somogyi created HBASE-25224: - Summary: Maximize sleep for checking meta and namespace regions availability Key: HBASE-25224 URL: https://issues.apache.org/jira/browse/HBASE-25224 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2580: HBASE-25210 RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

Apache-HBase commented on pull request #2580: URL: https://github.com/apache/hbase/pull/2580#issuecomment-717815090 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2593: HBASE-25224 Maximize sleep for checking meta and namespace regions availability

Apache-HBase commented on pull request #2593: URL: https://github.com/apache/hbase/pull/2593#issuecomment-717859344 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2593: HBASE-25224 Maximize sleep for checking meta and namespace regions availability

Apache-HBase commented on pull request #2593: URL: https://github.com/apache/hbase/pull/2593#issuecomment-717921237 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25173) Remove owner related methods in TableDescriptor/TableDescriptorBuilder

[ https://issues.apache.org/jira/browse/HBASE-25173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222162#comment-17222162 ] Hudson commented on HBASE-25173: Results for branch master [build #108 on

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-717978701 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25173) Remove owner related methods in TableDescriptor/TableDescriptorBuilder

[ https://issues.apache.org/jira/browse/HBASE-25173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222119#comment-17222119 ] wenfeiyi666 commented on HBASE-25173: - [~zhangduo], filled, help see if it works. > Remove owner

[jira] [Updated] (HBASE-25173) Remove owner related methods in TableDescriptor/TableDescriptorBuilder

[ https://issues.apache.org/jira/browse/HBASE-25173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 updated HBASE-25173: Release Note: Remove the OWNER field in the table creation statement, the relevant permissions

[GitHub] [hbase] Apache-HBase commented on pull request #2593: HBASE-25224 Maximize sleep for checking meta and namespace regions availability

Apache-HBase commented on pull request #2593: URL: https://github.com/apache/hbase/pull/2593#issuecomment-717922186 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

Apache-HBase commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-717803769 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2538: HBASE-25176 MasterStoppedException should be moved to hbase-client module

Apache-HBase commented on pull request #2538: URL: https://github.com/apache/hbase/pull/2538#issuecomment-717739141 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25176) MasterStoppedException should be moved to hbase-client module

[ https://issues.apache.org/jira/browse/HBASE-25176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25176: -- Fix Version/s: 2.4.0 3.0.0-alpha-1 > MasterStoppedException should be moved to

[jira] [Resolved] (HBASE-25176) MasterStoppedException should be moved to hbase-client module

[ https://issues.apache.org/jira/browse/HBASE-25176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25176. --- Hadoop Flags: Incompatible change,Reviewed Resolution: Fixed Pushed to master and branch-2.

[jira] [Resolved] (HBASE-25201) YouAreDeadException should be moved to hbase-server module

[ https://issues.apache.org/jira/browse/HBASE-25201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25201. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~niuyulin]

[jira] [Updated] (HBASE-25201) YouAreDeadException should be moved to hbase-server module

[ https://issues.apache.org/jira/browse/HBASE-25201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25201: -- Fix Version/s: 2.4.0 3.0.0-alpha-1 > YouAreDeadException should be moved to

[GitHub] [hbase] brfrn169 commented on a change in pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

brfrn169 commented on a change in pull request #2498: URL: https://github.com/apache/hbase/pull/2498#discussion_r513236879 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -3069,27 +3073,33 @@ private RegionScannerImpl

[GitHub] [hbase] saintstack commented on a change in pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

saintstack commented on a change in pull request #2591: URL: https://github.com/apache/hbase/pull/2591#discussion_r513179886 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java ## @@ -323,7 +323,7 @@ public boolean

[GitHub] [hbase] saintstack merged pull request #2592: HBASE-25223 Use try-with-resources statement

saintstack merged pull request #2592: URL: https://github.com/apache/hbase/pull/2592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] petersomogyi commented on a change in pull request #2590: HBASE-25221 Backport HBASE-24368 Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null

petersomogyi commented on a change in pull request #2590: URL: https://github.com/apache/hbase/pull/2590#discussion_r513578511 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/HBCKServerCrashProcedure.java ## @@ -169,4 +170,16 @@ public

[jira] [Resolved] (HBASE-25224) Maximize sleep for checking meta and namespace regions availability

[ https://issues.apache.org/jira/browse/HBASE-25224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-25224. --- Fix Version/s: 2.3.4 2.2.7 2.4.0

[GitHub] [hbase] bharathv commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

bharathv commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r513623950 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -688,14 +689,17 @@ void sawNoSuchFamily() { // Last

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-718032396 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] petersomogyi merged pull request #2590: HBASE-25221 Backport HBASE-24368 Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null

petersomogyi merged pull request #2590: URL: https://github.com/apache/hbase/pull/2590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] petersomogyi merged pull request #2593: HBASE-25224 Maximize sleep for checking meta and namespace regions availability

petersomogyi merged pull request #2593: URL: https://github.com/apache/hbase/pull/2593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] bharathv commented on a change in pull request #2585: HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

bharathv commented on a change in pull request #2585: URL: https://github.com/apache/hbase/pull/2585#discussion_r513584165 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java ## @@ -91,6 +91,10 @@ String

[jira] [Updated] (HBASE-25221) Backport HBASE-24368 "Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null"

[ https://issues.apache.org/jira/browse/HBASE-25221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-25221: -- Fix Version/s: 2.2.7 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Resolved] (HBASE-25223) Use try-with-resources statement in snapshot package

[ https://issues.apache.org/jira/browse/HBASE-25223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25223. --- Fix Version/s: 2.4.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

sandeepvinayak commented on a change in pull request #2591: URL: https://github.com/apache/hbase/pull/2591#discussion_r513599178 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java ## @@ -323,7 +323,7 @@ public boolean

[jira] [Commented] (HBASE-25221) Backport HBASE-24368 "Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null"

[ https://issues.apache.org/jira/browse/HBASE-25221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222440#comment-17222440 ] Hudson commented on HBASE-25221: Results for branch branch-2.2 [build #109 on

[jira] [Commented] (HBASE-24368) Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null

[ https://issues.apache.org/jira/browse/HBASE-24368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222441#comment-17222441 ] Hudson commented on HBASE-24368: Results for branch branch-2.2 [build #109 on

[jira] [Commented] (HBASE-25224) Maximize sleep for checking meta and namespace regions availability

[ https://issues.apache.org/jira/browse/HBASE-25224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222442#comment-17222442 ] Hudson commented on HBASE-25224: Results for branch branch-2.2 [build #109 on

[GitHub] [hbase] apurtell opened a new pull request #2594: HBASE-25227 [branch-1] Cast in UnsafeAccess to avoid Java 11 runtime issue

apurtell opened a new pull request #2594: URL: https://github.com/apache/hbase/pull/2594 UnsafeAccess is observed to throw NoSuchMethodErrors running on Java 11. Some of our methods accept 'int' parameters and use them as parameters to Unsafe methods expecting 'long'. The Java 8

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513805156 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSimpleSelector.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513780611 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSimpleSelector.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513780263 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSimpleSelector.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718255715 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

Apache-HBase commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-718289982 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m

[GitHub] [hbase] Reidddddd commented on a change in pull request #2585: HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

Reidd commented on a change in pull request #2585: URL: https://github.com/apache/hbase/pull/2585#discussion_r513916033 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ## @@ -1254,8 +1255,10 @@ private boolean processAllResponses(final

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513809104 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSimpleSelector.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] [hbase] brfrn169 commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

brfrn169 commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-718287389 The failed UT is not related to the patch. It was successful locally. I removed the new additional Scanner things from the patch and add the following document to the

[GitHub] [hbase] apurtell commented on pull request #2594: HBASE-25227 [branch-1] Cast in UnsafeAccess to avoid Java 11 runtime issue

apurtell commented on pull request #2594: URL: https://github.com/apache/hbase/pull/2594#issuecomment-718304414 Fix checkstyle issues This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-718312486 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718372812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513778939 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSimpleSelector.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718269087 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

sandeepvinayak commented on a change in pull request #2591: URL: https://github.com/apache/hbase/pull/2591#discussion_r513830335 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScanBase.java ## @@ -271,6 +272,11 @@ public void

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513782880 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -89,7 +90,10 @@ private final int

[GitHub] [hbase] huaxiangsun commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718273513 @saintstack @Apache9 I pushed updates based on your comments, could you take a look to see if all comments are addressed? Thanks.

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-718294308 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718305100 Unit tests passed, but there was a VM crash during test execution. Environmental? [ERROR] ExecutionException The forked VM terminated without properly saying goodbye.

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718305014 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25227) [branch-1] Cast in UnsafeAccess to avoid Java 11 runtime issue

[ https://issues.apache.org/jira/browse/HBASE-25227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25227: Status: Patch Available (was: Open) > [branch-1] Cast in UnsafeAccess to avoid

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718312524 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718325176 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Reidddddd commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

Reidd commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r513897937 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8730,12 +8868,22 @@ public void startRegionOperation()

[GitHub] [hbase] Reidddddd commented on pull request #2585: HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

Reidd commented on pull request #2585: URL: https://github.com/apache/hbase/pull/2585#issuecomment-718341999 > Curious whats the context for this change? Noticed something fishy there in the call queue? The main purpose is to gain better insight of the whole rpc process

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-718251587 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718257620 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

Apache-HBase commented on pull request #2591: URL: https://github.com/apache/hbase/pull/2591#issuecomment-718324114 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718332088 I had a run for the failed test case TestRSGroupsAdmin2, it passed. I assume this test is flakey. This is an

[GitHub] [hbase] HorizonNet commented on a change in pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

HorizonNet commented on a change in pull request #2542: URL: https://github.com/apache/hbase/pull/2542#discussion_r513798278 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java ## @@ -35,13 +35,21 @@ // the specification of server hostname is

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513784019 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -196,8 +200,33 @@ private boolean

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513808484 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSelectorFactory.java ## @@ -0,0 +1,49 @@ +/**

[GitHub] [hbase] Apache-HBase commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

Apache-HBase commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-718336891 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Reidddddd commented on a change in pull request #2585: HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

Reidd commented on a change in pull request #2585: URL: https://github.com/apache/hbase/pull/2585#discussion_r513920031 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ## @@ -1254,8 +1255,10 @@ private boolean processAllResponses(final

[GitHub] [hbase] Apache-HBase commented on pull request #2594: HBASE-25227 [branch-1] Cast in UnsafeAccess to avoid Java 11 runtime issue

Apache-HBase commented on pull request #2594: URL: https://github.com/apache/hbase/pull/2594#issuecomment-718315003 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-718338924 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2594: HBASE-25227 [branch-1] Cast in UnsafeAccess to avoid Java 11 runtime issue

Apache-HBase commented on pull request #2594: URL: https://github.com/apache/hbase/pull/2594#issuecomment-718259256 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

Apache-HBase commented on pull request #2591: URL: https://github.com/apache/hbase/pull/2591#issuecomment-718374329 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

sandeepvinayak commented on a change in pull request #2591: URL: https://github.com/apache/hbase/pull/2591#discussion_r513795763 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSplit.java ## @@ -184,9 +184,24 @@ public TableSplit(final byte []

[jira] [Created] (HBASE-25227) [branch-1] Cast in UnsafeAccess to avoid Java 11 runtime issue

Andrew Kyle Purtell created HBASE-25227: --- Summary: [branch-1] Cast in UnsafeAccess to avoid Java 11 runtime issue Key: HBASE-25227 URL: https://issues.apache.org/jira/browse/HBASE-25227

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513785364 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/CatalogReplicaLoadBalanceReplicaSimpleSelector.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

apurtell commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-718239306 Rebase and address review feedback This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-718239085 Rebase and address review feedback This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513794164 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -196,8 +200,33 @@ private boolean

[GitHub] [hbase] apurtell commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

apurtell commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-718239273 Rebase and address review feedback This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513793981 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ## @@ -577,6 +624,15 @@ private void

[GitHub] [hbase] bharathv commented on a change in pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

bharathv commented on a change in pull request #2591: URL: https://github.com/apache/hbase/pull/2591#discussion_r513757980 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSplit.java ## @@ -184,9 +184,24 @@ public TableSplit(final byte []

[jira] [Commented] (HBASE-25221) Backport HBASE-24368 "Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null"

[ https://issues.apache.org/jira/browse/HBASE-25221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222506#comment-17222506 ] Michael Stack commented on HBASE-25221: --- One question [~psomogyi] ... There is some nice text

[GitHub] [hbase] bharathv commented on pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

bharathv commented on pull request #2591: URL: https://github.com/apache/hbase/pull/2591#issuecomment-718092878 @saintstack I can sign-off on this change, I have some context on the bug, will take a look. This is an

  1   2   >