wchevreuil commented on pull request #86:
URL:
https://github.com/apache/hbase-operator-tools/pull/86#issuecomment-837185929
> I think my main worry is about relying on log file parsing for this.
That's not to say this is flawed -- it just is what it is.
Yeah, it's fragile indeed,
[
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-25875 started by Pankaj Kumar.
> RegionServer failed to start due to IllegalThreadStateException in
>
Apache-HBase commented on pull request #3242:
URL: https://github.com/apache/hbase/pull/3242#issuecomment-837244127
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
pankaj72981 opened a new pull request #3250:
URL: https://github.com/apache/hbase/pull/3250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
shahrs87 commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629708006
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##
@@ -256,6 +278,26 @@ public void write(Cell cell)
saintstack commented on a change in pull request #3246:
URL: https://github.com/apache/hbase/pull/3246#discussion_r629730178
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
##
@@ -295,6 +295,11 @@ public void
[
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342086#comment-17342086
]
Huaxiang Sun edited comment on HBASE-25032 at 5/10/21, 6:58 PM:
joshelser commented on pull request #86:
URL:
https://github.com/apache/hbase-operator-tools/pull/86#issuecomment-837194494
> Although meta is already online, master has not completed initialisation
(because of namespace table region stuck on a unknown server), so it pushes
back any
shahrs87 commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629711573
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##
@@ -256,6 +278,26 @@ public void write(Cell cell)
[
https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342201#comment-17342201
]
Sean Busbey commented on HBASE-25855:
-
ah I see. 3.5.0 was the htrace replacement module. that's
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629757222
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##
@@ -241,10 +246,27 @@ public void write(Cell cell)
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629757734
##
File path: hbase-protocol-shaded/src/main/protobuf/server/region/WAL.proto
##
@@ -32,6 +32,7 @@ message WALHeader {
optional bool
bharathv commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629772178
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##
@@ -302,14 +343,28 @@ protected Cell parseCell()
Apache-HBase commented on pull request #3236:
URL: https://github.com/apache/hbase/pull/3236#issuecomment-837164125
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
saintstack merged pull request #3236:
URL: https://github.com/apache/hbase/pull/3236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ndimiduk commented on pull request #51:
URL: https://github.com/apache/hbase-thirdparty/pull/51#issuecomment-837239785
> Since the relocated jaxrs provider is intimately tied to our use of
jersey, can we fold this into our packaged relocation of jersey in the
`hbase-shaded-jersey` module?
[
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342130#comment-17342130
]
Andrew Kyle Purtell commented on HBASE-25032:
-
Good, so no release is affected and we can
[
https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-25855:
-
Fix Version/s: (was: thirdparty-3.5.1)
thirdparty-4.0.0
> Fix typo in
[
https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-25855:
-
Summary: [hbase-thirdparty] Fix typo in jersey relocation path (was: Fix
typo in jersey
Apache-HBase commented on pull request #51:
URL: https://github.com/apache/hbase-thirdparty/pull/51#issuecomment-837377636
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec |
bharathv commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629760196
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
##
@@ -34,21 +36,49 @@
[
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342205#comment-17342205
]
Bharath Vissapragada commented on HBASE-25032:
--
Oops, this patch was committed on 25th
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629763436
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
##
@@ -34,21 +36,49 @@
[
https://issues.apache.org/jira/browse/HBASE-25862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342088#comment-17342088
]
Nick Dimiduk commented on HBASE-25862:
--
Hi [~impself]. The project policy is to have unrelated
Apache-HBase commented on pull request #3242:
URL: https://github.com/apache/hbase/pull/3242#issuecomment-837157621
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m
[
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342081#comment-17342081
]
Huaxiang Sun edited comment on HBASE-25032 at 5/10/21, 7:01 PM:
Just saw
wchevreuil commented on a change in pull request #86:
URL:
https://github.com/apache/hbase-operator-tools/pull/86#discussion_r629626179
##
File path:
hbase-tools/src/main/java/org/apache/hbase/RegionsOnUnknownServersRecoverer.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342162#comment-17342162
]
Huaxiang Sun commented on HBASE-25032:
--
Yeah, no new release is needed for 2.3.*.
> Wait for
ndimiduk commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629712475
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
##
@@ -230,6 +230,11 @@ public static long getKeyDataStructureSize(int
saintstack commented on a change in pull request #3249:
URL: https://github.com/apache/hbase/pull/3249#discussion_r629734904
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##
@@ -1601,6 +1601,89 @@
*/
public static final int
Apache-HBase commented on pull request #3250:
URL: https://github.com/apache/hbase/pull/3250#issuecomment-837463452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
busbey commented on a change in pull request #51:
URL: https://github.com/apache/hbase-thirdparty/pull/51#discussion_r629751088
##
File path: hbase-shaded-jackson-jaxrs-json-provider/pom.xml
##
@@ -0,0 +1,110 @@
+
+http://maven.apache.org/POM/4.0.0;
apurtell edited a comment on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837518016
> Is it reasonable to always use the same compressor all the time for WALs?
It strikes me that operators make an explicit choice about the compression used
in their
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629761476
##
File path: hbase-protocol-shaded/src/main/protobuf/server/region/WAL.proto
##
@@ -32,6 +32,7 @@ message WALHeader {
optional bool
Michael Stack created HBASE-25876:
-
Summary: Add retry if we fail to read all bytes of the protobuf
magic marker
Key: HBASE-25876
URL: https://issues.apache.org/jira/browse/HBASE-25876
Project: HBase
ndimiduk commented on a change in pull request #51:
URL: https://github.com/apache/hbase-thirdparty/pull/51#discussion_r629642048
##
File path: hbase-shaded-jackson-jaxrs-json-provider/pom.xml
##
@@ -0,0 +1,110 @@
+
+http://maven.apache.org/POM/4.0.0;
busbey commented on pull request #51:
URL: https://github.com/apache/hbase-thirdparty/pull/51#issuecomment-837242913
> > Since the relocated jaxrs provider is intimately tied to our use of
jersey, can we fold this into our packaged relocation of jersey in the
`hbase-shaded-jersey` module?
[
https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342148#comment-17342148
]
Nick Dimiduk commented on HBASE-25855:
--
It appears to me that hbase-core has not moved onto 3.5.x
saintstack commented on a change in pull request #3248:
URL: https://github.com/apache/hbase/pull/3248#discussion_r629719036
##
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java
##
@@ -59,10 +59,11 @@
*/
@Deprecated
String
ndimiduk commented on pull request #3063:
URL: https://github.com/apache/hbase/pull/3063#issuecomment-837478253
Hi @rahulLiving , I noticed you closed this PR. Are you planning to take
this one in a different direction?
--
This is an automated message from the Apache Git Service.
To
ndimiduk commented on a change in pull request #51:
URL: https://github.com/apache/hbase-thirdparty/pull/51#discussion_r629746479
##
File path: hbase-shaded-jackson-jaxrs-json-provider/pom.xml
##
@@ -0,0 +1,110 @@
+
+http://maven.apache.org/POM/4.0.0;
apurtell edited a comment on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837512098
> There is a potential performance improvement here. We could create a
Deflater/Inflater pair per column family.
This idea didn't pan out. It makes compression in
apurtell commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837512098
bq. There is a potential performance improvement here. We could create a
Deflater/Inflater pair per column family.
This idea didn't pan out. It makes compression in my
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629763212
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##
@@ -302,14 +343,28 @@ protected Cell parseCell()
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629763436
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
##
@@ -34,21 +36,49 @@
Apache-HBase commented on pull request #3251:
URL: https://github.com/apache/hbase/pull/3251#issuecomment-837558899
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on pull request #3236:
URL: https://github.com/apache/hbase/pull/3236#issuecomment-837185063
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 7m
[
https://issues.apache.org/jira/browse/HBASE-25876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-25876:
--
Priority: Trivial (was: Major)
> Add retry if we fail to read all bytes of the protobuf
[
https://issues.apache.org/jira/browse/HBASE-25876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342125#comment-17342125
]
Michael Stack commented on HBASE-25876:
---
Just two places (thought there were more). Trivial.
[
https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342127#comment-17342127
]
Michael Stack commented on HBASE-25774:
---
Thanks for figuring the race [~zhangduo] (My bad too for
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629759791
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##
@@ -256,6 +278,26 @@ public void write(Cell cell)
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629759981
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##
@@ -256,6 +278,26 @@ public void write(Cell cell)
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629763436
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
##
@@ -34,21 +36,49 @@
[
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342086#comment-17342086
]
Huaxiang Sun commented on HBASE-25032:
--
[~ndimiduk] I think the metadata is not changed. When the
[
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342111#comment-17342111
]
Pankaj Kumar commented on HBASE-25875:
--
This is a race condition problem, where LeaderElector is
[
https://issues.apache.org/jira/browse/HBASE-25859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-25859.
---
Fix Version/s: 2.4.4
2.5.0
3.0.0-alpha-1
Hadoop
[
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342113#comment-17342113
]
Pankaj Kumar commented on HBASE-25875:
--
NettyRpcServer should start the secret manager in
Apache-HBase commented on pull request #3250:
URL: https://github.com/apache/hbase/pull/3250#issuecomment-837331291
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629759791
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##
@@ -256,6 +278,26 @@ public void write(Cell cell)
[
https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-25855:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> [hbase-thirdparty] Fix
Apache-HBase commented on pull request #3251:
URL: https://github.com/apache/hbase/pull/3251#issuecomment-837357330
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
ndimiduk commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837437980
Oh, one other comment I forgot to mention before hitting submit. Is it
reasonable to always use the same compressor all the time for WALs? It strikes
me that operators make an
Apache-HBase commented on pull request #3242:
URL: https://github.com/apache/hbase/pull/3242#issuecomment-837454813
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629757734
##
File path: hbase-protocol-shaded/src/main/protobuf/server/region/WAL.proto
##
@@ -32,6 +32,7 @@ message WALHeader {
optional bool
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629757734
##
File path: hbase-protocol-shaded/src/main/protobuf/server/region/WAL.proto
##
@@ -32,6 +32,7 @@ message WALHeader {
optional bool
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629763436
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
##
@@ -34,21 +36,49 @@
joshelser commented on a change in pull request #86:
URL:
https://github.com/apache/hbase-operator-tools/pull/86#discussion_r629631126
##
File path:
hbase-tools/src/main/java/org/apache/hbase/RegionsOnUnknownServersRecoverer.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pankaj Kumar updated HBASE-25875:
-
Fix Version/s: 3.0.0-alpha-1
Status: Patch Available (was: In Progress)
>
ndimiduk commented on a change in pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#discussion_r629645403
##
File path:
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java
##
@@ -18,22 +17,19 @@
*/
package
busbey commented on a change in pull request #51:
URL: https://github.com/apache/hbase-thirdparty/pull/51#discussion_r629645813
##
File path: hbase-shaded-jackson-jaxrs-json-provider/pom.xml
##
@@ -0,0 +1,110 @@
+
+http://maven.apache.org/POM/4.0.0;
ndimiduk commented on a change in pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#discussion_r629644198
##
File path: hbase-rest/pom.xml
##
@@ -160,7 +151,6 @@
org.apache.hbase
hbase-protocol-shaded
- jar
Review comment:
Yes,
ndimiduk commented on a change in pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#discussion_r629645829
##
File path:
hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/RowResourceBase.java
##
@@ -18,22 +18,16 @@
package org.apache.hadoop.hbase.rest;
saintstack opened a new pull request #3251:
URL: https://github.com/apache/hbase/pull/3251
…gic marker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
Apache-HBase commented on pull request #3242:
URL: https://github.com/apache/hbase/pull/3242#issuecomment-837320433
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey reassigned HBASE-25855:
---
Assignee: Nick Dimiduk (was: Sean Busbey)
> [hbase-thirdparty] Fix typo in jersey
[
https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey reassigned HBASE-25855:
---
Assignee: Sean Busbey (was: Nick Dimiduk)
> [hbase-thirdparty] Fix typo in jersey
Apache-HBase commented on pull request #3242:
URL: https://github.com/apache/hbase/pull/3242#issuecomment-837517120
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
apurtell commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837518016
> Is it reasonable to always use the same compressor all the time for WALs?
It strikes me that operators make an explicit choice about the compression used
in their tables, so
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629760897
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
##
@@ -230,6 +230,11 @@ public static long getKeyDataStructureSize(int
rda3mon commented on a change in pull request #3246:
URL: https://github.com/apache/hbase/pull/3246#discussion_r629784728
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
##
@@ -295,6 +295,11 @@ public void
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629801863
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
##
@@ -241,10 +246,27 @@ public void write(Cell cell)
apurtell commented on a change in pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#discussion_r629802049
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
##
@@ -230,6 +230,11 @@ public static long getKeyDataStructureSize(int
Apache-HBase commented on pull request #3246:
URL: https://github.com/apache/hbase/pull/3246#issuecomment-837677173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
Apache-HBase commented on pull request #3246:
URL: https://github.com/apache/hbase/pull/3246#issuecomment-837636720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
Apache-HBase commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837655575
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3246:
URL: https://github.com/apache/hbase/pull/3246#issuecomment-837684227
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837776421
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837823204
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837831402
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m
Apache-HBase commented on pull request #3246:
URL: https://github.com/apache/hbase/pull/3246#issuecomment-837638994
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
apurtell commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837688241
Rolled up the first round of review feedback into d4d707d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Apache-HBase commented on pull request #3202:
URL: https://github.com/apache/hbase/pull/3202#issuecomment-837872302
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
apurtell edited a comment on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837666043
I have some changes coming soon. Accepted @bharathv 's argument that
unconditionally compressing values if value compression is enabled is fine even
if some value cases
apurtell commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837666043
I have some changes coming soon. Accepted @bharathv 's argument that
unconditionally compressing values if value compression is enabled is fine even
if some value cases may not
rahulLiving commented on pull request #3063:
URL: https://github.com/apache/hbase/pull/3063#issuecomment-837813571
Hi @ndimiduk I need to test out this change once, after addressing some
comments. I was out for sometime, hence couldn't do it and thus closed for time
being. I'll get it to
Apache9 commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837580362
> > So we will only compress value?
>
> This is an enhancement to existing WAL compression. As you know the
existing WAL compression already compresses other aspects of WAL
[
https://issues.apache.org/jira/browse/HBASE-25858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342273#comment-17342273
]
Reid Chan commented on HBASE-25858:
---
Try merging, FYI [~apurtell]
> [branch-1] make hbase-thrift
Apache-HBase commented on pull request #3202:
URL: https://github.com/apache/hbase/pull/3202#issuecomment-837765986
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3202:
URL: https://github.com/apache/hbase/pull/3202#issuecomment-837775180
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m
Apache-HBase commented on pull request #3244:
URL: https://github.com/apache/hbase/pull/3244#issuecomment-837847210
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
1 - 100 of 168 matches
Mail list logo
