[GitHub] [hbase] sunhelly opened a new pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread GitBox
sunhelly opened a new pull request #3280: URL: https://github.com/apache/hbase/pull/3280 More details in [HBASE-25899](https://issues.apache.org/jira/browse/HBASE-25899) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] virajjasani commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-19 Thread GitBox
virajjasani commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-843969438 > > meanwhile, does this apply to other branches? > > @bharathv This patch doesn't apply to other branches. master branch doesn't have appendExecutor at all. I am still

[jira] [Commented] (HBASE-25888) Backup tests are categorically flakey

2021-05-19 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347587#comment-17347587 ] Mallikarjun commented on HBASE-25888: - [~ndimiduk] You can have a look at PR whenever you have time. 

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-844015025 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-844018165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-844046400 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-19 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347628#comment-17347628 ] Rushabh Shah commented on HBASE-25890: -- Sure [~reidchan] Let me know if I could of any help. Will

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-844050301 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] shahrs87 commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-19 Thread GitBox
shahrs87 commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-844050812 @bharathv @virajjasani Please don't merge until @Reidd gives a green light. He asked me to [wait

[GitHub] [hbase] shahrs87 edited a comment on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-19 Thread GitBox
shahrs87 edited a comment on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-844050812 @bharathv @virajjasani Thank you for your reviews. Please don't merge until @Reidd gives a green light. He asked me to [wait

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-844053246 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-25898) RS getting aborted due to NPE in Replication WALEntryStream

2021-05-19 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347635#comment-17347635 ] Rushabh Shah commented on HBASE-25898: -- [~anoop.hbase] which hbase version did you see this error ?

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347682#comment-17347682 ] Anoop Sam John commented on HBASE-24623: So this is not the case of early release of BB (which

[jira] [Commented] (HBASE-25898) RS getting aborted due to NPE in Replication WALEntryStream

2021-05-19 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347683#comment-17347683 ] Anoop Sam John commented on HBASE-25898: Am on 2.1.6 still. But I think in branch-2 also same

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-844115617 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-844119212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] shahrs87 commented on a change in pull request #3277: HBASE-25893 First draft

2021-05-19 Thread GitBox
shahrs87 commented on a change in pull request #3277: URL: https://github.com/apache/hbase/pull/3277#discussion_r635258171 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -1565,49 +1569,23 @@ Path closeWriter(String

[jira] [Created] (HBASE-25900) HBoss tests compile/failure against Hadoop 3.3.1

2021-05-19 Thread Steve Loughran (Jira)
Steve Loughran created HBASE-25900: -- Summary: HBoss tests compile/failure against Hadoop 3.3.1 Key: HBASE-25900 URL: https://issues.apache.org/jira/browse/HBASE-25900 Project: HBase Issue

[GitHub] [hbase] shahrs87 commented on a change in pull request #3277: HBASE-25893 First draft

2021-05-19 Thread GitBox
shahrs87 commented on a change in pull request #3277: URL: https://github.com/apache/hbase/pull/3277#discussion_r635260123 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -1369,13 +1369,17 @@ public

[GitHub] [hbase] shahrs87 commented on pull request #3277: HBASE-25893 First draft

2021-05-19 Thread GitBox
shahrs87 commented on pull request #3277: URL: https://github.com/apache/hbase/pull/3277#issuecomment-844127971 ``` [INFO] [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ hbase-server --- [INFO] [INFO] ---

[GitHub] [hbase] Apache9 opened a new pull request #3281: HBASE-25897 TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-19 Thread GitBox
Apache9 opened a new pull request #3281: URL: https://github.com/apache/hbase/pull/3281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] rda3mon opened a new pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-19 Thread GitBox
rda3mon opened a new pull request #3279: URL: https://github.com/apache/hbase/pull/3279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-843877053 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25898) RS getting aborted due to NPE in Replication WALEntryStream

2021-05-19 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347414#comment-17347414 ] ramkrishna.s.vasudevan commented on HBASE-25898: Good one. > RS getting aborted due to

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-843880018 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-843880153 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25899) Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25899: --- Attachment: 78631.jstack > Improve efficiency of SnapshotHFileCleaner >

[jira] [Created] (HBASE-25899) Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread Xiaolin Ha (Jira)
Xiaolin Ha created HBASE-25899: -- Summary: Improve efficiency of SnapshotHFileCleaner Key: HBASE-25899 URL: https://issues.apache.org/jira/browse/HBASE-25899 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-844713121 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635778623 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/BoundedDelegatingInputStream.java ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[jira] [Updated] (HBASE-25899) Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25899: --- Attachment: cleaner-result.png > Improve efficiency of SnapshotHFileCleaner >

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-844723701 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844683025 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844690212 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844698814 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-843790688 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25897) TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-19 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25897: - Summary: TestRetainAssignmentOnRestart is flaky after HBASE-25032 Key: HBASE-25897 URL: https://issues.apache.org/jira/browse/HBASE-25897 Project: HBase Issue

[GitHub] [hbase] Apache-HBase commented on pull request #3278: HBASE-25791 UI of master-status to show a recent history of that why …

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3278: URL: https://github.com/apache/hbase/pull/3278#issuecomment-843826578 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25898) RS getting aborted due to NPE in Replication WALEntryStream

2021-05-19 Thread Anoop Sam John (Jira)
Anoop Sam John created HBASE-25898: -- Summary: RS getting aborted due to NPE in Replication WALEntryStream Key: HBASE-25898 URL: https://issues.apache.org/jira/browse/HBASE-25898 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-843781271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3278: HBASE-25791 UI of master-status to show a recent history of that why …

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3278: URL: https://github.com/apache/hbase/pull/3278#issuecomment-843793359 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-843805844 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25898) RS getting aborted due to NPE in Replication WALEntryStream

2021-05-19 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-25898: --- Description: Below sequence of events happened in a customer cluster An empty WAL file got

[GitHub] [hbase] Apache-HBase commented on pull request #3282: Rebasing against master

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3282: URL: https://github.com/apache/hbase/pull/3282#issuecomment-844150234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844624849 SNAPPY or ZSTD are recommended, all other options provided for comparison. (LZMA is included as a sanity check that indeed an expensive algorithm really is expensive.)

[GitHub] [hbase] bharathv commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
bharathv commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844625565 > SNAPPY+copy had a 10x loss, now SNAPPY+no-copy has a 10x gain. I double checked these findings and it seems correct. I will re-run the benchmark when measuring for the other

[jira] [Comment Edited] (HBASE-25869) WAL value compression

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342054#comment-17342054 ] Andrew Kyle Purtell edited comment on HBASE-25869 at 5/20/21, 2:06 AM:

[GitHub] [hbase] bharathv edited a comment on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
bharathv edited a comment on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844625565 > SNAPPY+copy had a 10x loss, now SNAPPY+no-copy has a 10x gain. I double checked these findings and it seems correct. I will re-run the benchmark when measuring for the

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844628225 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] bharathv commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
bharathv commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635699848 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/BoundedDelegatingInputStream.java ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844641501 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348027#comment-17348027 ] Anoop Sam John commented on HBASE-24623: Oh.. Thanks for those details Andy. Now I remember ur

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844648566 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348028#comment-17348028 ] Anoop Sam John commented on HBASE-24623: So ur jira was never committed Andy? > SIGSEGV v

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-844658762 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348030#comment-17348030 ] Andrew Kyle Purtell commented on HBASE-24623: - Not sure. The idea didn’t pan out, so if it

[jira] [Commented] (HBASE-25841) Add basic jshell support

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348031#comment-17348031 ] Andrew Kyle Purtell commented on HBASE-25841: - I don’t have a strong opinion either way

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-19 Thread GitBox
nyl3532016 commented on a change in pull request #3266: URL: https://github.com/apache/hbase/pull/3266#discussion_r635089665 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java ## @@ -253,6 +256,12 @@ private void init(final int

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-843966389 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani edited a comment on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-19 Thread GitBox
virajjasani edited a comment on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-843969438 > > meanwhile, does this apply to other branches? > > @bharathv This patch doesn't apply to other branches. master branch doesn't have appendExecutor at all. I

[GitHub] [hbase] shahrs87 commented on pull request #3277: HBASE-25893 Corruption in recovered WAL in WALSplitter

2021-05-19 Thread GitBox
shahrs87 commented on pull request #3277: URL: https://github.com/apache/hbase/pull/3277#issuecomment-844130006 @bharathv @virajjasani @apurtell could you guys please help review this change ? Thank you ! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] wchevreuil opened a new pull request #3282: Rebasing against master

2021-05-19 Thread GitBox
wchevreuil opened a new pull request #3282: URL: https://github.com/apache/hbase/pull/3282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Commented] (HBASE-25898) RS getting aborted due to NPE in Replication WALEntryStream

2021-05-19 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347713#comment-17347713 ] Rushabh Shah commented on HBASE-25898: -- [~anoop.hbase] Your analysis makes sense to me. Thank you

[GitHub] [hbase] Apache9 commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-19 Thread GitBox
Apache9 commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-844165059 #3281 is for fixing the failed UT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #3281: HBASE-25897 TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3281: URL: https://github.com/apache/hbase/pull/3281#issuecomment-844171361 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3276: HBASE-25894 Improve the performance for region load and region count related cost functions

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3276: URL: https://github.com/apache/hbase/pull/3276#issuecomment-844232266 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3281: HBASE-25897 TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3281: URL: https://github.com/apache/hbase/pull/3281#issuecomment-844287379 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3277: HBASE-25893 Corruption in recovered WAL in WALSplitter

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3277: URL: https://github.com/apache/hbase/pull/3277#issuecomment-844287571 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25032: Fix Version/s: (was: 2.4.4) 2.4.3 > Do not assign regions

[jira] [Updated] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25875: Fix Version/s: (was: 2.4.4) 2.4.3 > RegionServer failed to

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844301569 Unit test failure is not related. TestJMXListener.setupBeforeClass:68 » IO Shutting down Going to merge today unless objection. -- This is an automated

[GitHub] [hbase] bharathv commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-19 Thread GitBox
bharathv commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-844307527 I'm reading the disruptor shutdown code and now I'm a bit confused, lets hold off on merging this until I get back (by EOD). -- This is an automated message from the Apache

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347793#comment-17347793 ] Andrew Kyle Purtell commented on HBASE-24623: - {quote}There was a jira that

[jira] [Comment Edited] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347793#comment-17347793 ] Andrew Kyle Purtell edited comment on HBASE-24623 at 5/19/21, 5:23 PM:

[GitHub] [hbase] sandeepvinayak opened a new pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak opened a new pull request #3283: URL: https://github.com/apache/hbase/pull/3283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] bharathv commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
bharathv commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635463483 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/DelegatingInputStream.java ## @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3281: HBASE-25897 TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3281: URL: https://github.com/apache/hbase/pull/3281#issuecomment-844335051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] bharathv commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
bharathv commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635463483 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/DelegatingInputStream.java ## @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3276: HBASE-25894 Improve the performance for region load and region count related cost functions

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3276: URL: https://github.com/apache/hbase/pull/3276#issuecomment-844336972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-operator-tools] wchevreuil merged pull request #87: HBASE-25885 [hbase-operator-tools] Extra checks on RegionsMerger to a…

2021-05-19 Thread GitBox
wchevreuil merged pull request #87: URL: https://github.com/apache/hbase-operator-tools/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Updated] (HBASE-25885) [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers

2021-05-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25885: - Component/s: hbase-operator-tools > [hbase-operator-tools] Extra checks on

[jira] [Resolved] (HBASE-25885) [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers

2021-05-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25885. -- Resolution: Fixed > [hbase-operator-tools] Extra checks on RegionsMerger to

[jira] [Updated] (HBASE-25885) [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers

2021-05-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25885: - Affects Version/s: hbase-operator-tools-1.1.0 > [hbase-operator-tools] Extra

[jira] [Updated] (HBASE-25885) [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers

2021-05-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25885: - Fix Version/s: hbase-operator-tools-1.2.0 > [hbase-operator-tools] Extra checks

[jira] [Commented] (HBASE-25885) [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers

2021-05-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347810#comment-17347810 ] Wellington Chevreuil commented on HBASE-25885: -- Thanks for reviewing it, [~psomogyi]! >

[GitHub] [hbase] shahrs87 commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
shahrs87 commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635472479 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryFilterRetryableException.java ## @@ -0,0 +1,36 @@ +/**

[jira] [Commented] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347811#comment-17347811 ] Hudson commented on HBASE-25861: Results for branch branch-2 [build #254 on

[GitHub] [hbase] shahrs87 commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
shahrs87 commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635476647 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryFilterRetryableException.java ## @@ -0,0 +1,36 @@ +/**

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635481243 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -165,6 +165,12 @@

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844355147 > just extend FIS and add setDelegate (that makes it small). Oh, I misunderstood. Sure, I can do that. -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635482369 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/DelegatingInputStream.java ## @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635482591 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryFilterRetryableException.java ## @@ -0,0 +1,36 @@

[GitHub] [hbase] shahrs87 commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
shahrs87 commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635483682 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -165,6 +165,12 @@ public

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635489204 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -165,6 +165,12 @@

[GitHub] [hbase] ndimiduk merged pull request #3224: HBASE-25841 Add basic jshell support

2021-05-19 Thread GitBox
ndimiduk merged pull request #3224: URL: https://github.com/apache/hbase/pull/3224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (HBASE-25841) Add basic jshell support

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25841: - Fix Version/s: 3.0.0-alpha-1 > Add basic jshell support > > >

[GitHub] [hbase] Apache-HBase commented on pull request #3224: HBASE-25841 Add basic jshell support

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3224: URL: https://github.com/apache/hbase/pull/3224#issuecomment-844368393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] Apache-HBase commented on pull request #3224: HBASE-25841 Add basic jshell support

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3224: URL: https://github.com/apache/hbase/pull/3224#issuecomment-844368639 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk opened a new pull request #3284: Backport "HBASE-25841 Add basic jshell support" to branch-2

2021-05-19 Thread GitBox
ndimiduk opened a new pull request #3284: URL: https://github.com/apache/hbase/pull/3284 Signed-off-by: Bharath Vissapragada Signed-off-by: Pankaj Kumar Signed-off-by: Duo Zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] Apache-HBase commented on pull request #3284: Backport "HBASE-25841 Add basic jshell support" to branch-2

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3284: URL: https://github.com/apache/hbase/pull/3284#issuecomment-844374432 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

  1   2   >