[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176255#comment-14176255 ] Matteo Bertozzi commented on HBASE-12161: - thanks for the patch, committed to 98 too Add support for grant/revoke on namespaces in AccessControlClient - Key: HBASE-12161 URL: https://issues.apache.org/jira/browse/HBASE-12161 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: HBASE-12161_0.98.patch, HBASE-12161_98_v5.patch, HBASE-12161_master.patch, HBASE-12161_master_v2.patch, HBASE-12161_master_v4.patch, HBASE-12161_master_v5.patch, HBASE-12161_v3.patch As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176278#comment-14176278 ] Hudson commented on HBASE-12161: FAILURE: Integrated in HBase-0.98 #611 (See [https://builds.apache.org/job/HBase-0.98/611/]) HBASE-12161 Add support for grant/revoke on namespaces in AccessControlClient (Srikanth Srungarapu) (matteo.bertozzi: rev 2383c293b0fff1b881f99b107fc48a1cd387fdf9) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedListWithVisibility.java Add support for grant/revoke on namespaces in AccessControlClient - Key: HBASE-12161 URL: https://issues.apache.org/jira/browse/HBASE-12161 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: HBASE-12161_0.98.patch, HBASE-12161_98_v5.patch, HBASE-12161_master.patch, HBASE-12161_master_v2.patch, HBASE-12161_master_v4.patch, HBASE-12161_master_v5.patch, HBASE-12161_v3.patch As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176289#comment-14176289 ] Hudson commented on HBASE-12161: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #581 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/581/]) HBASE-12161 Add support for grant/revoke on namespaces in AccessControlClient (Srikanth Srungarapu) (matteo.bertozzi: rev 2383c293b0fff1b881f99b107fc48a1cd387fdf9) * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedListWithVisibility.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java Add support for grant/revoke on namespaces in AccessControlClient - Key: HBASE-12161 URL: https://issues.apache.org/jira/browse/HBASE-12161 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: HBASE-12161_0.98.patch, HBASE-12161_98_v5.patch, HBASE-12161_master.patch, HBASE-12161_master_v2.patch, HBASE-12161_master_v4.patch, HBASE-12161_master_v5.patch, HBASE-12161_v3.patch As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176137#comment-14176137 ] Hudson commented on HBASE-12161: FAILURE: Integrated in HBase-1.0 #328 (See [https://builds.apache.org/job/HBase-1.0/328/]) HBASE-12161 Add support for grant/revoke on namespaces in AccessControlClient (Srikanth Srungarapu) (matteo.bertozzi: rev 0dee72466d5152bae6e60fe2230bef1464a83ff2) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedListWithVisibility.java * hbase-shell/src/main/ruby/hbase/admin.rb * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java Add support for grant/revoke on namespaces in AccessControlClient - Key: HBASE-12161 URL: https://issues.apache.org/jira/browse/HBASE-12161 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch, HBASE-12161_master_v2.patch, HBASE-12161_master_v4.patch, HBASE-12161_master_v5.patch, HBASE-12161_v3.patch As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176146#comment-14176146 ] Hudson commented on HBASE-12161: FAILURE: Integrated in HBase-TRUNK #5673 (See [https://builds.apache.org/job/HBase-TRUNK/5673/]) HBASE-12161 Add support for grant/revoke on namespaces in AccessControlClient (Srikanth Srungarapu) (matteo.bertozzi: rev 49056295ef7763745876c05ae8c04b5a7317d323) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * hbase-shell/src/main/ruby/hbase/admin.rb * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedListWithVisibility.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Add support for grant/revoke on namespaces in AccessControlClient - Key: HBASE-12161 URL: https://issues.apache.org/jira/browse/HBASE-12161 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch, HBASE-12161_master_v2.patch, HBASE-12161_master_v4.patch, HBASE-12161_master_v5.patch, HBASE-12161_v3.patch As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175564#comment-14175564
]
Hadoop QA commented on HBASE-12161:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675579/HBASE-12161_master_v4.patch
against trunk revision .
ATTACHMENT ID: 12675579
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11392//console
This message is automatically generated.
Add support for grant/revoke on namespaces in AccessControlClient
-
Key: HBASE-12161
URL: https://issues.apache.org/jira/browse/HBASE-12161
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch,
HBASE-12161_master_v2.patch, HBASE-12161_master_v4.patch, HBASE-12161_v3.patch
As per the description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175697#comment-14175697
]
Hadoop QA commented on HBASE-12161:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675588/HBASE-12161_master_v4.patch
against trunk revision .
ATTACHMENT ID: 12675588
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11393//console
This message is automatically generated.
Add support for grant/revoke on namespaces in AccessControlClient
-
Key: HBASE-12161
URL: https://issues.apache.org/jira/browse/HBASE-12161
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch,
HBASE-12161_master_v2.patch, HBASE-12161_master_v4.patch, HBASE-12161_v3.patch
As per the description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175706#comment-14175706 ] Matteo Bertozzi commented on HBASE-12161: - ok, that looks better to me. let me try it and commit Add support for grant/revoke on namespaces in AccessControlClient - Key: HBASE-12161 URL: https://issues.apache.org/jira/browse/HBASE-12161 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch, HBASE-12161_master_v2.patch, HBASE-12161_master_v4.patch, HBASE-12161_v3.patch As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175710#comment-14175710
]
Ted Yu commented on HBASE-12161:
This seems related:
{code}
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java:77:
warning - @return tag cannot be used in method with void return type.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java:139:
warning - @return tag cannot be used in method with void return type.
{code}
Add support for grant/revoke on namespaces in AccessControlClient
-
Key: HBASE-12161
URL: https://issues.apache.org/jira/browse/HBASE-12161
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch,
HBASE-12161_master_v2.patch, HBASE-12161_master_v4.patch, HBASE-12161_v3.patch
As per the description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175794#comment-14175794
]
Hadoop QA commented on HBASE-12161:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675623/HBASE-12161_master_v5.patch
against trunk revision .
ATTACHMENT ID: 12675623
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11394//console
This message is automatically generated.
Add support for grant/revoke on namespaces in AccessControlClient
-
Key: HBASE-12161
URL: https://issues.apache.org/jira/browse/HBASE-12161
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch,
HBASE-12161_master_v2.patch, HBASE-12161_master_v4.patch,
HBASE-12161_master_v5.patch, HBASE-12161_v3.patch
As per the description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173627#comment-14173627
]
Matteo Bertozzi commented on HBASE-12161:
-
I was testing the patch before committing it, but sometimes fails with:
{noformat}
testAccessControlClientGrantRevokeOnNamespace(org.apache.hadoop.hbase.security.access.TestAccessController)
Time elapsed: 1.544 sec FAILURE!
java.lang.AssertionError: Expected action to pass for user 'testNS' but was
denied
at org.junit.Assert.fail(Assert.java:88)
at
org.apache.hadoop.hbase.security.access.SecureTestUtil.verifyAllowed(SecureTestUtil.java:158)
at
org.apache.hadoop.hbase.security.access.SecureTestUtil.verifyAllowed(SecureTestUtil.java:165)
at
org.apache.hadoop.hbase.security.access.TestAccessController.testAccessControlClientGrantRevokeOnNamespace(TestAccessController.java:2135)
{noformat}
the problem is that the grant/revoke was not applied yet. a simple
Thread.sleep() minimize the problem, but maybe you can add a better check
Add support for grant/revoke on namespaces in AccessControlClient
-
Key: HBASE-12161
URL: https://issues.apache.org/jira/browse/HBASE-12161
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch,
HBASE-12161_master_v2.patch, HBASE-12161_v3.patch
As per the description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170706#comment-14170706
]
Matteo Bertozzi commented on HBASE-12161:
-
something like that would be nice also for the existing grant/revoke, since
they are not using the ProtobufUtil.grant/revoke but reimplementing the logic.
but this thing doesn't work.
{code}
BlockingInterface getAccessControlServiceStub (HTable ht) {
...
ht = new HTable(...)
ht...
...
}
...
HTable ht = null;
stub = getAccessControlServiceStub(ht);
if (ht != null)
...
...
{code}
Add support for grant/revoke on namespaces in AccessControlClient
-
Key: HBASE-12161
URL: https://issues.apache.org/jira/browse/HBASE-12161
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch
As per the description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171589#comment-14171589
]
Ted Yu commented on HBASE-12161:
lgtm
{code}
TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, acl);
{code}
Referring to AccessControlConstants#OP_ATTRIBUTE_ACL would be better.
{code}
public void testAccessControlClientGrantRevokeOnNameSpace() throws
Exception {
{code}
nit: 'Namespace' (lower case s) should suffice.
Add support for grant/revoke on namespaces in AccessControlClient
-
Key: HBASE-12161
URL: https://issues.apache.org/jira/browse/HBASE-12161
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch,
HBASE-12161_master_v2.patch
As per the description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171609#comment-14171609 ] Matteo Bertozzi commented on HBASE-12161: - v3 looks good to me Add support for grant/revoke on namespaces in AccessControlClient - Key: HBASE-12161 URL: https://issues.apache.org/jira/browse/HBASE-12161 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch, HBASE-12161_master_v2.patch, HBASE-12161_v3.patch As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171688#comment-14171688
]
Hadoop QA commented on HBASE-12161:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12674859/HBASE-12161_v3.patch
against trunk revision .
ATTACHMENT ID: 12674859
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11345//console
This message is automatically generated.
Add support for grant/revoke on namespaces in AccessControlClient
-
Key: HBASE-12161
URL: https://issues.apache.org/jira/browse/HBASE-12161
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Fix For: 2.0.0, 0.99.2
Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch,
HBASE-12161_master_v2.patch, HBASE-12161_v3.patch
As per the description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161230#comment-14161230
]
Srikanth Srungarapu commented on HBASE-12161:
-
Thanks for the detailed feedback Dima :). My responses inline
bq. Your method declaration for getAccessControlServiceStub should be split
over two lines. Same for the AccessControlClient.grant in
#testAccessControlClientGrantOnNameSpace.
Addressed.
bq. The AccessControlClient#grant and #revoke methods have nearly identical
logic that might as well be factored into a common private method to avoid a
bit of code duplication.
{code}
+} finally {
+ if (ht != null) {
+ht.close();
+ }
{code}
Agreed that this part of the code is common to both methods. But, is it worth
trying to refactor to special method?
bq. Similarly (as you explained to me), your
#testAccessControlClientGrantOnNameSpace is very similar to the existing
#testNamespaceUserGrant. It might be worth factoring out the common bits and
only leaving the different grant methods used by each test.
I found it a bit hard to refactor the commonalities into a method as the two
statements AccessTestAction and verifyX method calls are divided by
AccessControlClient.grant and grantOnNamespace methods respectively in each
test. So, instead I combined #testAccessControlClientGrantOnNameSpace and
#testAccessControlClientRevokOnNameSpace to reduce code duplication.
bq. In #testAccessControlClientGrantOnNameSpace, you handle a Throwable by just
logging it which swallow any exception that might break things. Is this
intentional or might you want the test to fail at this point if such a general
exception is thrown?
Yeah, this is deliberate as primary intention is to test functional correctness
of the methods (inline with the other defined tests in this class).
Add support for grant/revoke on namespaces in AccessControlClient
-
Key: HBASE-12161
URL: https://issues.apache.org/jira/browse/HBASE-12161
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch
As per the description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161336#comment-14161336
]
Hadoop QA commented on HBASE-12161:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12673241/HBASE-12161_master.patch
against trunk revision .
ATTACHMENT ID: 12673241
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at org.apache.oozie.test.MiniHCatServer$1.run(MiniHCatServer.java:137)
at
org.apache.oozie.test.XTestCase$MiniClusterShutdownMonitor.run(XTestCase.java:1071)
at org.apache.oozie.test.XTestCase.waitFor(XTestCase.java:692)
at
org.apache.oozie.command.wf.TestReRunXCommand.testRerunWithExistingCoodConf(TestReRunXCommand.java:375)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11229//console
This message is automatically generated.
Add support for grant/revoke on namespaces in AccessControlClient
-
Key: HBASE-12161
URL: https://issues.apache.org/jira/browse/HBASE-12161
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch
As per the description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12161) Add support for grant/revoke on namespaces in AccessControlClient
[ https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159816#comment-14159816 ] Dima Spivak commented on HBASE-12161: - Thanks for taking this on, Srikanth. Some minor suggestions: - Your method declaration for getAccessControlServiceStub should be split over two lines. Same for the AccessControlClient.grant in #testAccessControlClientGrantOnNameSpace. - The AccessControlClient#grant and #revoke methods have nearly identical logic that might as well be factored into a common private method to avoid a bit of code duplication. - Similarly (as you explained to me), your #testAccessControlClientGrantOnNameSpace is very similar to the existing #testNamespaceUserGrant. It might be worth factoring out the common bits and only leaving the different grant methods used by each test. - In #testAccessControlClientGrantOnNameSpace, you handle a Throwable by just logging it which swallow any exception that might break things. Is this intentional or might you want the test to fail at this point if such a general exception is thrown? Add support for grant/revoke on namespaces in AccessControlClient - Key: HBASE-12161 URL: https://issues.apache.org/jira/browse/HBASE-12161 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Attachments: HBASE-12161_0.98.patch As per the description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
