[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815908#comment-16815908
]
Zheng Hu commented on HBASE-20151:
--
Assigned to me firstly, I'll think about this issu
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815603#comment-16815603
]
Andrew Purtell commented on HBASE-20151:
Any progress here? Or unschedule it? Or
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766721#comment-16766721
]
Guanghao Zhang commented on HBASE-20151:
Any updates here?
> Bug with SingleCol
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758620#comment-16758620
]
Hadoop QA commented on HBASE-20151:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555107#comment-16555107
]
Reid Chan commented on HBASE-20151:
---
bq. filterRow is related to the cells in entire
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554349#comment-16554349
]
Zheng Hu commented on HBASE-20151:
--
Now I am worried that if the implementation of filt
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554328#comment-16554328
]
Zheng Hu commented on HBASE-20151:
--
[~reidchan], Thanks for your issue. So you tried t
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554268#comment-16554268
]
Duo Zhang commented on HBASE-20151:
---
To be clear, -1 on introducing setFilterListType,
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554262#comment-16554262
]
Ted Yu commented on HBASE-20151:
Since SingleColumnValueFilter is singled out in Zheng's
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554112#comment-16554112
]
Reid Chan commented on HBASE-20151:
---
Tried once in HBASE-19824 (though not relate to t
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554084#comment-16554084
]
Zheng Hu commented on HBASE-20151:
--
Reconsider the bug again, I think the cause is not
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553741#comment-16553741
]
Reid Chan commented on HBASE-20151:
---
Then we should find a good way to deal with this
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553735#comment-16553735
]
Ted Yu commented on HBASE-20151:
bq. is it acceptable to sacrifice some performance degr
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553729#comment-16553729
]
Reid Chan commented on HBASE-20151:
---
So is it acceptable to sacrifice some performance
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553728#comment-16553728
]
Duo Zhang commented on HBASE-20151:
---
And to me, it is a bit confusing that a Filter's
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553724#comment-16553724
]
Zheng Hu commented on HBASE-20151:
--
The problem is: we abstract a new concept named Fil
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553714#comment-16553714
]
Reid Chan commented on HBASE-20151:
---
Then FF can use the {{FilterListType}} to determi
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553708#comment-16553708
]
Duo Zhang commented on HBASE-20151:
---
So what if we put a FilterListAll into a FilterLi
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553699#comment-16553699
]
Ted Yu commented on HBASE-20151:
bq. can just create an new filter named FamilyAloneFil
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553689#comment-16553689
]
Zheng Hu commented on HBASE-20151:
--
[~yuzhih...@gmail.com] Skimmed the patch, so the pa
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553466#comment-16553466
]
Andrew Purtell commented on HBASE-20151:
Changes to public APIs are not allowed
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553113#comment-16553113
]
Hadoop QA commented on HBASE-20151:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| V
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553060#comment-16553060
]
Ted Yu commented on HBASE-20151:
Looks like we want to let FamilyFilter know whether it
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552756#comment-16552756
]
Zheng Hu commented on HBASE-20151:
--
We have to make choice between correctness and perf
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552534#comment-16552534
]
Reid Chan commented on HBASE-20151:
---
Yea~...Ted, i think there is...
> Bug with Singl
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552532#comment-16552532
]
Ted Yu commented on HBASE-20151:
By using ReturnCode.SKIP, is there performance degradat
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552394#comment-16552394
]
Hadoop QA commented on HBASE-20151:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552299#comment-16552299
]
Zheng Hu commented on HBASE-20151:
--
+1 if Hadoop QA says OK.
> Bug with SingleColumnVa
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552258#comment-16552258
]
Zheng Hu commented on HBASE-20151:
--
Oh, you've uploaded the latest patch ... Let me hav
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552255#comment-16552255
]
Zheng Hu commented on HBASE-20151:
--
If no objection until tomorrow, [~reidchan] , I thi
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552248#comment-16552248
]
Reid Chan commented on HBASE-20151:
---
ping [~openinx] for review if you have free cycle
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549151#comment-16549151
]
Reid Chan commented on HBASE-20151:
---
Let's wait if any other comments about this rever
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549137#comment-16549137
]
Zheng Hu commented on HBASE-20151:
--
[~reidchan], Mind you update your patch ? I think
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549108#comment-16549108
]
Reid Chan commented on HBASE-20151:
---
+1 for keeping it simple.
{{Filter}} code is quit
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549100#comment-16549100
]
Zheng Hu commented on HBASE-20151:
--
bq. Does the revert break your fix in HBASE-18368?
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549087#comment-16549087
]
Reid Chan commented on HBASE-20151:
---
Does the revert break your fix in HBASE-18368? [~
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549072#comment-16549072
]
Ted Yu commented on HBASE-20151:
[~zhoushuaifeng2]
What do you think of the suggestion a
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549057#comment-16549057
]
Zheng Hu commented on HBASE-20151:
--
So this bug is still caused by NEXT_ROW of FamilyFi
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512633#comment-16512633
]
Reid Chan commented on HBASE-20151:
---
please ping me, if any one has bandwidth to revis
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483804#comment-16483804
]
Reid Chan commented on HBASE-20151:
---
ping @watchers, if time allows, could anyone take
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483615#comment-16483615
]
Reid Chan commented on HBASE-20151:
---
Unrelated failed UT.
> Bug with SingleColumnValue
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483592#comment-16483592
]
Hadoop QA commented on HBASE-20151:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483476#comment-16483476
]
Reid Chan commented on HBASE-20151:
---
Move method {{transformReturnCode}} default impl f
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463702#comment-16463702
]
Reid Chan commented on HBASE-20151:
---
Got it, i will upload a new patch after you fully
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463677#comment-16463677
]
Chia-Ping Tsai commented on HBASE-20151:
{quote}Does this count as default impl?
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463671#comment-16463671
]
Reid Chan commented on HBASE-20151:
---
{code:title=In FilterBase}
@Override
public Return
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463658#comment-16463658
]
Chia-Ping Tsai commented on HBASE-20151:
I'm trying to catch this issue...Will ad
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447467#comment-16447467
]
Reid Chan commented on HBASE-20151:
---
ping [~chia7712], would you mind taking a look at
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441724#comment-16441724
]
Hadoop QA commented on HBASE-20151:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440919#comment-16440919
]
Reid Chan commented on HBASE-20151:
---
Unrelated UT failure
> Bug with SingleColumnValue
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440907#comment-16440907
]
Hadoop QA commented on HBASE-20151:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440720#comment-16440720
]
Reid Chan commented on HBASE-20151:
---
Thanks for review Ted.
bq. Can you add test corres
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434102#comment-16434102
]
Ted Yu commented on HBASE-20151:
{code}
+if (logic == FilterListBase.LOGIG.AND &&
{co
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433912#comment-16433912
]
Hadoop QA commented on HBASE-20151:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433689#comment-16433689
]
Reid Chan commented on HBASE-20151:
---
HBase-20068 is fixed, thanks Sean for reminder.
Tr
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432320#comment-16432320
]
Sean Busbey commented on HBASE-20151:
-
that error is HBASE-20068, which I have a patc
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432198#comment-16432198
]
Reid Chan commented on HBASE-20151:
---
bq. Failed to execute goal
org.apache.maven.plugi
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432175#comment-16432175
]
Hadoop QA commented on HBASE-20151:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431996#comment-16431996
]
Reid Chan commented on HBASE-20151:
---
Added an UT, and fixed {{hadoopcheck}}.
> Bug wit
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427351#comment-16427351
]
Hadoop QA commented on HBASE-20151:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427256#comment-16427256
]
Reid Chan commented on HBASE-20151:
---
Come up an idea.
With FilterList, we can 'slow dow
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426950#comment-16426950
]
Reid Chan commented on HBASE-20151:
---
> If false it will check any version for the condi
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404791#comment-16404791
]
Reid Chan commented on HBASE-20151:
---
Got your point.
Thanks for pointing out, let me t
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404603#comment-16404603
]
Anoop Sam John commented on HBASE-20151:
Yes that was mentioned in my first comm
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404088#comment-16404088
]
Hadoop QA commented on HBASE-20151:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404061#comment-16404061
]
Reid Chan commented on HBASE-20151:
---
After patch,
{code}
hbase(main):006:0> scan 'test'
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403853#comment-16403853
]
Appy commented on HBASE-20151:
--
That sounds coherent to kinds of issues i saw with filter la
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403467#comment-16403467
]
Reid Chan commented on HBASE-20151:
---
Because SCVF returns {{INCLUDE}} and FF returns {{
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401586#comment-16401586
]
Reid Chan commented on HBASE-20151:
---
Got the reason.
*1*. I checked those cells passed
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398078#comment-16398078
]
Appy commented on HBASE-20151:
--
Thanks sir!
> Bug with SingleColumnValueFilter and FamilyFi
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398066#comment-16398066
]
Reid Chan commented on HBASE-20151:
---
Teams are busy on 2.0.0 G.A, i can take this.
> B
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397079#comment-16397079
]
Appy commented on HBASE-20151:
--
Trying to understand the nature of bug morehere's more d
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391689#comment-16391689
]
Reid Chan commented on HBASE-20151:
---
master branch still has these bugs i'm afraid...
b
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391662#comment-16391662
]
Anoop Sam John commented on HBASE-20151:
All these are bugs with FilterList.. Ma
[
https://issues.apache.org/jira/browse/HBASE-20151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390676#comment-16390676
]
Reid Chan commented on HBASE-20151:
---
Confirmed, reproducible.
> Bug with SingleColumnV
75 matches
Mail list logo
