[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231009#comment-13231009
]
Lars Francke commented on HBASE-4608:
-
This seems to be missing documentation, no?
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230360#comment-13230360
]
Zhihong Yu commented on HBASE-4608:
---
w.r.t. Lars' comment:
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230449#comment-13230449
]
stack commented on HBASE-4608:
--
I'll commit v30 then.
Thanks all for reviews, etc.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230456#comment-13230456
]
stack commented on HBASE-4608:
--
Now this is in, does that mean we can cut a 0.94RC0?
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230490#comment-13230490
]
Lars Hofhansl commented on HBASE-4608:
--
Yeah! And, yes, time for an RC.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230493#comment-13230493
]
Hudson commented on HBASE-4608:
---
Integrated in HBase-0.94 #32 (See
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230500#comment-13230500
]
Li Pi commented on HBASE-4608:
--
Woohoo! It's in!
HLog Compression
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230538#comment-13230538
]
Hudson commented on HBASE-4608:
---
Integrated in HBase-TRUNK #2683 (See
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230914#comment-13230914
]
Hudson commented on HBASE-4608:
---
Integrated in HBase-TRUNK-security #139 (See
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229022#comment-13229022
]
stack commented on HBASE-4608:
--
@Lars Generalizing the compression done here is out of scope
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229024#comment-13229024
]
stack commented on HBASE-4608:
--
Lars, I can't upload a patch to someone else's issue. Made a
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229027#comment-13229027
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229032#comment-13229032
]
Lars Hofhansl commented on HBASE-4608:
--
@Stack: fair enough. Let's get this one done.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229051#comment-13229051
]
Todd Lipcon commented on HBASE-4608:
btw, +1 on this new patch after you've
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229054#comment-13229054
]
stack commented on HBASE-4608:
--
I like your changes Todd. Nice fixup. Lars, let me post v28
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229055#comment-13229055
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229064#comment-13229064
]
stack commented on HBASE-4608:
--
I reran compress, decompress, compress cycle over my 40 odd
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229069#comment-13229069
]
Hadoop QA commented on HBASE-4608:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229080#comment-13229080
]
Li Pi commented on HBASE-4608:
--
@Stack nvm, just read upwards. That's inline with the other
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229137#comment-13229137
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229248#comment-13229248
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229263#comment-13229263
]
Li Pi commented on HBASE-4608:
--
+1 from here.
Agree w/ Stack. Compression can be generalized
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229277#comment-13229277
]
Zhihong Yu commented on HBASE-4608:
---
bq. HLogKey does not need to know about 'type' of
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229281#comment-13229281
]
Li Pi commented on HBASE-4608:
--
That code is just writing the output for the regionname,
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229292#comment-13229292
]
Li Pi commented on HBASE-4608:
--
Not that we'd compress a random value well at all anyways.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229291#comment-13229291
]
Li Pi commented on HBASE-4608:
--
Also, figured out why Ted's benchmarks differed from the rest
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229294#comment-13229294
]
Zhihong Yu commented on HBASE-4608:
---
bq. we don't compress values yet.
Looks like we
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229420#comment-13229420
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229432#comment-13229432
]
Zhihong Yu commented on HBASE-4608:
---
I just thought we should encapsulate LRUDictionary
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229448#comment-13229448
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229454#comment-13229454
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229453#comment-13229453
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229663#comment-13229663
]
stack commented on HBASE-4608:
--
Li asked me lzma some of my logs from the wild. I did. W/
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229678#comment-13229678
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229771#comment-13229771
]
stack commented on HBASE-4608:
--
Here's some WALs to compared compressed w/ patch v29 vs lzma
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229773#comment-13229773
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229776#comment-13229776
]
Lars Hofhansl commented on HBASE-4608:
--
I'm still +1 :)
The lzma number are
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229826#comment-13229826
]
Hadoop QA commented on HBASE-4608:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229871#comment-13229871
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229877#comment-13229877
]
stack commented on HBASE-4608:
--
@Ted Would suggest that in future you not piecemeal in your
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229878#comment-13229878
]
jirapos...@reviews.apache.org commented on HBASE-4608:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229884#comment-13229884
]
Zhihong Yu commented on HBASE-4608:
---
w.r.t. adding javadoc for offset and length of
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229890#comment-13229890
]
Hadoop QA commented on HBASE-4608:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229893#comment-13229893
]
Lars Hofhansl commented on HBASE-4608:
--
bq. I'm not wondering if this patch is worth
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229913#comment-13229913
]
Li Pi commented on HBASE-4608:
--
If a dictionary file gets cut up, you'll be able to read all
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229914#comment-13229914
]
Li Pi commented on HBASE-4608:
--
If a dictionary file gets cut up, you'll be able to read all
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229921#comment-13229921
]
Li Pi commented on HBASE-4608:
--
On other compression things. I looked into those.
plugging
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228842#comment-13228842
]
Zhihong Yu commented on HBASE-4608:
---
In isWALCompressionEnabled():
{code}
+if (txt
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228931#comment-13228931
]
Hadoop QA commented on HBASE-4608:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228946#comment-13228946
]
stack commented on HBASE-4608:
--
Here's my compressing, decompressing, compressing again,
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228947#comment-13228947
]
stack commented on HBASE-4608:
--
Here's my compressing, decompressing, compressing again,
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228948#comment-13228948
]
Zhihong Yu commented on HBASE-4608:
---
The sentence involving COMPRESSION_VERSION was in
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228950#comment-13228950
]
Zhihong Yu commented on HBASE-4608:
---
I noticed the size of
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228954#comment-13228954
]
Zhihong Yu commented on HBASE-4608:
---
Please wrap long line:
{code}
+ public static
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228957#comment-13228957
]
stack commented on HBASE-4608:
--
bq. I noticed the size of
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228965#comment-13228965
]
stack commented on HBASE-4608:
--
bq. It implies that WAL_VERSION is the same as
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228970#comment-13228970
]
Zhihong Yu commented on HBASE-4608:
---
bq. and if all else is equal – same API, etc. –
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228971#comment-13228971
]
Zhihong Yu commented on HBASE-4608:
---
In HLogKey.java:
{code}
+ * Enables compression.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228972#comment-13228972
]
Hadoop QA commented on HBASE-4608:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228976#comment-13228976
]
stack commented on HBASE-4608:
--
bq. But we don't know if the current dictionary compression
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228979#comment-13228979
]
stack commented on HBASE-4608:
--
I took a random set of 40 logs off our front end and did a
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228981#comment-13228981
]
stack commented on HBASE-4608:
--
We need facility in wal like we have in hfile for printing
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228983#comment-13228983
]
Zhihong Yu commented on HBASE-4608:
---
I feel the dictionary compression implementation is
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228985#comment-13228985
]
stack commented on HBASE-4608:
--
bq. This would make developing a new compression scheme hard.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228986#comment-13228986
]
stack commented on HBASE-4608:
--
bq. This would make developing a new compression scheme hard.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228991#comment-13228991
]
Zhihong Yu commented on HBASE-4608:
---
bq. Out of scope for this issue.
This reminds me of
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228996#comment-13228996
]
stack commented on HBASE-4608:
--
Can I get a +1 from someone else. Its not a big patch.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227869#comment-13227869
]
stack commented on HBASE-4608:
--
Is HLog versioned? If not, perhaps instead of a
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227892#comment-13227892
]
Ted Yu commented on HBASE-4608:
---
Introducing WAL_VERSION would imply that we may change HLog
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227898#comment-13227898
]
stack commented on HBASE-4608:
--
In TestLRUDictionary, we test a single entry in essence. We
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227901#comment-13227901
]
Ted Yu commented on HBASE-4608:
---
bq. try a paragraph of text going in and out
LRUDictionary
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227908#comment-13227908
]
stack commented on HBASE-4608:
--
Its the test of a single entry only which is not really
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227929#comment-13227929
]
stack commented on HBASE-4608:
--
Its a regular pattern only. Perhaps this does some decent
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227934#comment-13227934
]
stack commented on HBASE-4608:
--
The tests do not have variety. I think we should add it here
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227946#comment-13227946
]
Ted Yu commented on HBASE-4608:
---
I think WAL_VERSION metadata is orthogonal to compression
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227954#comment-13227954
]
Ted Yu commented on HBASE-4608:
---
bq. Should the Compression class in wal package ...
I only
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227961#comment-13227961
]
Ted Yu commented on HBASE-4608:
---
Uploaded v23 onto review board.
After WAL version metadata
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227969#comment-13227969
]
stack commented on HBASE-4608:
--
bq. I think WAL_VERSION metadata is orthogonal to compression
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227984#comment-13227984
]
Ted Yu commented on HBASE-4608:
---
For code specific review, please use
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228033#comment-13228033
]
stack commented on HBASE-4608:
--
bq. I can add WAL_VERSION as v2 in the metadata.
Why not as
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228042#comment-13228042
]
Zhihong Yu commented on HBASE-4608:
---
Since WAL compression may be off for the new HLog
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228051#comment-13228051
]
Lars Hofhansl commented on HBASE-4608:
--
bq. My question is: would HLog v2 be allowed
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228056#comment-13228056
]
Zhihong Yu commented on HBASE-4608:
---
I think we may enhance WAL compression using
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228097#comment-13228097
]
Zhihong Yu commented on HBASE-4608:
---
HLog version decision aside, my feeling about the
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228108#comment-13228108
]
Todd Lipcon commented on HBASE-4608:
bq. First, compression ratio is not good - at
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228122#comment-13228122
]
Zhihong Yu commented on HBASE-4608:
---
We're looking at several metadata fields for
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228157#comment-13228157
]
stack commented on HBASE-4608:
--
Stop making this more complicated than it need be Ted.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228158#comment-13228158
]
stack commented on HBASE-4608:
--
Stop making this more complicated than it need be Ted.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228164#comment-13228164
]
Zhihong Yu commented on HBASE-4608:
---
Having PREFIX_COMPRESSION_V2 in the future is
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228166#comment-13228166
]
stack commented on HBASE-4608:
--
@Ted I think you should resign ownership of this issue. You
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228165#comment-13228165
]
Zhihong Yu commented on HBASE-4608:
---
bq. Stop making this more complicated than it need
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228173#comment-13228173
]
Zhihong Yu commented on HBASE-4608:
---
From what can one conclude who owns the issue ?
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228175#comment-13228175
]
stack commented on HBASE-4608:
--
Let me have a go at it since Li Pi can't finish it just yet.
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228181#comment-13228181
]
Lars Hofhansl commented on HBASE-4608:
--
Just my $0.02 here... I think having a
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228185#comment-13228185
]
stack commented on HBASE-4608:
--
bq. It is rare that I saw review comments in such tone:
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228193#comment-13228193
]
Li Pi commented on HBASE-4608:
--
Yo, sorry I can't quite work on this. Finals are finished
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228194#comment-13228194
]
Li Pi commented on HBASE-4608:
--
Yo, sorry I can't quite work on this. Finals are finished
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228196#comment-13228196
]
Zhihong Yu commented on HBASE-4608:
---
From HFileBlock:
{code}
int getMinorVersion() {
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228202#comment-13228202
]
stack commented on HBASE-4608:
--
bq. PREFIX_COMPRESSION_V2, first cited by Stack, is a
[
https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228216#comment-13228216
]
Zhihong Yu commented on HBASE-4608:
---
Since Li Pi has done 90% of coding, I think this
1 - 100 of 232 matches
Mail list logo
