[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570977#comment-13570977 ] Hudson commented on HBASE-7369: --- Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/11/]) HBASE-7369 HConnectionManager should remove aborted connections (Bryan Baugher) (Revision 1430533) Result = FAILURE tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Assignee: Bryan Baugher Priority: Minor Fix For: 0.96.0 Attachments: 7369-0.94.txt, 7369-v5.txt, HBASE-7369_HCM-remove-aborted-cnxs-2.txt, HBASE-7369_HCM-remove-aborted-cnxs-3.txt, HBASE-7369_HCM-remove-aborted-cnxs-4.txt, HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554226#comment-13554226 ] Hudson commented on HBASE-7369: --- Integrated in HBase-0.94-security #95 (See [https://builds.apache.org/job/HBase-0.94-security/95/]) HBASE-7369 HConnectionManager should remove aborted connections (Bryan Baugher) (Revision 1430533) Result = SUCCESS tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Assignee: Bryan Baugher Priority: Minor Fix For: 0.96.0 Attachments: 7369-0.94.txt, 7369-v5.txt, HBASE-7369_HCM-remove-aborted-cnxs-2.txt, HBASE-7369_HCM-remove-aborted-cnxs-3.txt, HBASE-7369_HCM-remove-aborted-cnxs-4.txt, HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547184#comment-13547184 ] Lars Hofhansl commented on HBASE-7369: -- I think this should be in 0.94 (Thanks [~te...@apache.org] for reminding me offline) HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Assignee: Bryan Baugher Priority: Minor Fix For: 0.96.0 Attachments: 7369-v5.txt, HBASE-7369_HCM-remove-aborted-cnxs-2.txt, HBASE-7369_HCM-remove-aborted-cnxs-3.txt, HBASE-7369_HCM-remove-aborted-cnxs-4.txt, HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547258#comment-13547258
]
Ted Yu commented on HBASE-7369:
---
I ran the following tests for 0.94 branch and they passed:
{code}
368 mt -Dtest=TestHCM
369 mt -Dtest=TestAdmin
371 mt -Dtest=TestMultiRowResource,TestTableMapReduce
{code}
Integrated to 0.94 branch
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Assignee: Bryan Baugher
Priority: Minor
Fix For: 0.96.0
Attachments: 7369-0.94.txt, 7369-v5.txt,
HBASE-7369_HCM-remove-aborted-cnxs-2.txt,
HBASE-7369_HCM-remove-aborted-cnxs-3.txt,
HBASE-7369_HCM-remove-aborted-cnxs-4.txt,
HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547262#comment-13547262 ] Lars Hofhansl commented on HBASE-7369: -- Thanks Ted! HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Assignee: Bryan Baugher Priority: Minor Fix For: 0.96.0 Attachments: 7369-0.94.txt, 7369-v5.txt, HBASE-7369_HCM-remove-aborted-cnxs-2.txt, HBASE-7369_HCM-remove-aborted-cnxs-3.txt, HBASE-7369_HCM-remove-aborted-cnxs-4.txt, HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547366#comment-13547366 ] Hudson commented on HBASE-7369: --- Integrated in HBase-0.94 #714 (See [https://builds.apache.org/job/HBase-0.94/714/]) HBASE-7369 HConnectionManager should remove aborted connections (Bryan Baugher) (Revision 1430533) Result = SUCCESS tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Assignee: Bryan Baugher Priority: Minor Fix For: 0.96.0 Attachments: 7369-0.94.txt, 7369-v5.txt, HBASE-7369_HCM-remove-aborted-cnxs-2.txt, HBASE-7369_HCM-remove-aborted-cnxs-3.txt, HBASE-7369_HCM-remove-aborted-cnxs-4.txt, HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545440#comment-13545440
]
Hadoop QA commented on HBASE-7369:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12563489/7369-v5.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3881//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3881//console
This message is automatically generated.
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Fix For: 0.96.0
Attachments: 7369-v5.txt, HBASE-7369_HCM-remove-aborted-cnxs-2.txt,
HBASE-7369_HCM-remove-aborted-cnxs-3.txt,
HBASE-7369_HCM-remove-aborted-cnxs-4.txt,
HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545443#comment-13545443
]
Ted Yu commented on HBASE-7369:
---
From QA report:
{code}
pool-1-thread-1 prio=10 tid=0x77002400 nid=0x6844 in Object.wait()
[0x771fe000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on 0xd0c0c6d0 (a
org.apache.hadoop.hbase.util.JVMClusterUtil$RegionServerThread)
at java.lang.Thread.join(Thread.java:1194)
- locked 0xd0c0c6d0 (a
org.apache.hadoop.hbase.util.JVMClusterUtil$RegionServerThread)
at
org.apache.hadoop.hbase.util.JVMClusterUtil.shutdown(JVMClusterUtil.java:249)
at
org.apache.hadoop.hbase.LocalHBaseCluster.shutdown(LocalHBaseCluster.java:430)
at
org.apache.hadoop.hbase.MiniHBaseCluster.shutdown(MiniHBaseCluster.java:501)
at
org.apache.hadoop.hbase.HBaseTestingUtility.shutdownMiniHBaseCluster(HBaseTestingUtility.java:856)
at
org.apache.hadoop.hbase.HBaseTestingUtility.shutdownMiniCluster(HBaseTestingUtility.java:826)
at
org.apache.hadoop.hbase.TestRegionRebalancing.after(TestRegionRebalancing.java:77)
{code}
I looped TestRegionRebalancing locally 4 times and they passed.
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Fix For: 0.96.0
Attachments: 7369-v5.txt, HBASE-7369_HCM-remove-aborted-cnxs-2.txt,
HBASE-7369_HCM-remove-aborted-cnxs-3.txt,
HBASE-7369_HCM-remove-aborted-cnxs-4.txt,
HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545444#comment-13545444 ] Ted Yu commented on HBASE-7369: --- Integrated to trunk. Thanks for the patch, Bryan. Thanks for the review, Chunhui. HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Priority: Minor Fix For: 0.96.0 Attachments: 7369-v5.txt, HBASE-7369_HCM-remove-aborted-cnxs-2.txt, HBASE-7369_HCM-remove-aborted-cnxs-3.txt, HBASE-7369_HCM-remove-aborted-cnxs-4.txt, HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545455#comment-13545455 ] Hudson commented on HBASE-7369: --- Integrated in HBase-TRUNK #3703 (See [https://builds.apache.org/job/HBase-TRUNK/3703/]) HBASE-7369 HConnectionManager should remove aborted connections (Bryan Baugher) (Revision 1429556) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Assignee: Bryan Baugher Priority: Minor Fix For: 0.96.0 Attachments: 7369-v5.txt, HBASE-7369_HCM-remove-aborted-cnxs-2.txt, HBASE-7369_HCM-remove-aborted-cnxs-3.txt, HBASE-7369_HCM-remove-aborted-cnxs-4.txt, HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545527#comment-13545527 ] Hudson commented on HBASE-7369: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #333 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/333/]) HBASE-7369 HConnectionManager should remove aborted connections (Bryan Baugher) (Revision 1429556) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Assignee: Bryan Baugher Priority: Minor Fix For: 0.96.0 Attachments: 7369-v5.txt, HBASE-7369_HCM-remove-aborted-cnxs-2.txt, HBASE-7369_HCM-remove-aborted-cnxs-3.txt, HBASE-7369_HCM-remove-aborted-cnxs-4.txt, HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545213#comment-13545213
]
Ted Yu commented on HBASE-7369:
---
The above test failures seem to tell us something.
e.g. I got the following based on patch v4:
{code}
org.apache.hadoop.hbase.security.access.TestTablePermissions Time elapsed:
217,171.39 sec ERROR!
org.apache.hadoop.hbase.MasterNotRunningException: Connection was closed while
trying to get master
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.createMasterWithRetries(HConnectionManager.java:793)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getKeepAliveMasterProtocol(HConnectionManager.java:1622)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getKeepAliveMasterAdmin(HConnectionManager.java:1648)
at org.apache.hadoop.hbase.client.HBaseAdmin.execute(HBaseAdmin.java:2107)
at
org.apache.hadoop.hbase.client.HBaseAdmin.createTableAsync(HBaseAdmin.java:498)
at org.apache.hadoop.hbase.client.HBaseAdmin.createTable(HBaseAdmin.java:391)
at org.apache.hadoop.hbase.client.HBaseAdmin.createTable(HBaseAdmin.java:327)
at
org.apache.hadoop.hbase.HBaseTestingUtility.createTable(HBaseTestingUtility.java:977)
at
org.apache.hadoop.hbase.HBaseTestingUtility.createTable(HBaseTestingUtility.java:945)
at
org.apache.hadoop.hbase.HBaseTestingUtility.createTable(HBaseTestingUtility.java:933)
at
org.apache.hadoop.hbase.security.access.TestTablePermissions.beforeClass(TestTablePermissions.java:101)
{code}
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Attachments: HBASE-7369_HCM-remove-aborted-cnxs-2.txt,
HBASE-7369_HCM-remove-aborted-cnxs-3.txt,
HBASE-7369_HCM-remove-aborted-cnxs-4.txt,
HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543709#comment-13543709
]
chunhui shen commented on HBASE-7369:
-
Removing
{code}this.closed = true;{code}
from abort() is better, I think..
Others are ok for me after addressing Ted's comment
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Attachments: HBASE-7369_HCM-remove-aborted-cnxs-2.txt,
HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544007#comment-13544007
]
Hadoop QA commented on HBASE-7369:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12563315/HBASE-7369_HCM-remove-aborted-cnxs-3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3857//console
This message is automatically generated.
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Attachments: HBASE-7369_HCM-remove-aborted-cnxs-2.txt,
HBASE-7369_HCM-remove-aborted-cnxs-3.txt,
HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544014#comment-13544014 ] Ted Yu commented on HBASE-7369: --- HBASE-7488 was recently integrated. Please rebase patch. Thanks HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Priority: Minor Attachments: HBASE-7369_HCM-remove-aborted-cnxs-2.txt, HBASE-7369_HCM-remove-aborted-cnxs-3.txt, HBASE-7369_HCM-remove-aborted-cnxs-4.txt, HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544102#comment-13544102
]
Hadoop QA commented on HBASE-7369:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12563316/HBASE-7369_HCM-remove-aborted-cnxs-4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout
org.apache.hadoop.hbase.filter.TestColumnRangeFilter
org.apache.hadoop.hbase.client.TestMultipleTimestamps
org.apache.hadoop.hbase.mapred.TestTableInputFormat
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.constraint.TestConstraint
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
org.apache.hadoop.hbase.rest.TestMultiRowResource
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
org.apache.hadoop.hbase.client.TestScannerTimeout
org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.security.access.TestAccessController
org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
org.apache.hadoop.hbase.rest.TestScannerResource
org.apache.hadoop.hbase.regionserver.TestStoreFileBlockCacheSummary
org.apache.hadoop.hbase.TestFullLogReconstruction
org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort
org.apache.hadoop.hbase.master.TestMasterTransitions
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
org.apache.hadoop.hbase.rest.TestGzipFilter
org.apache.hadoop.hbase.fs.TestBlockReorder
org.apache.hadoop.hbase.backup.TestHFileArchiving
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster
org.apache.hadoop.hbase.TestMultiVersions
org.apache.hadoop.hbase.trace.TestHTraceHooks
org.apache.hadoop.hbase.master.handler.TestTableDeleteFamilyHandler
org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding
org.apache.hadoop.hbase.catalog.TestMetaMigrationConvertingToPB
org.apache.hadoop.hbase.regionserver.TestRSKilledWhenMasterInitializing
org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
org.apache.hadoop.hbase.regionserver.TestHRegion
org.apache.hadoop.hbase.client.TestTimestampsFilter
org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
org.apache.hadoop.hbase.regionserver.TestCompactionState
org.apache.hadoop.hbase.client.TestShell
org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.regionserver.wal.TestHLogFiltering
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.rest.TestTableResource
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544118#comment-13544118 ] Ted Yu commented on HBASE-7369: --- The above test failures were due to environment issue. I triggered another build: https://builds.apache.org/job/PreCommit-HBASE-Build/3859/consoleFull HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Priority: Minor Attachments: HBASE-7369_HCM-remove-aborted-cnxs-2.txt, HBASE-7369_HCM-remove-aborted-cnxs-3.txt, HBASE-7369_HCM-remove-aborted-cnxs-4.txt, HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544251#comment-13544251
]
Hadoop QA commented on HBASE-7369:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12563316/HBASE-7369_HCM-remove-aborted-cnxs-4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout
org.apache.hadoop.hbase.filter.TestColumnRangeFilter
org.apache.hadoop.hbase.client.TestMultipleTimestamps
org.apache.hadoop.hbase.mapred.TestTableInputFormat
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.constraint.TestConstraint
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
org.apache.hadoop.hbase.rest.TestMultiRowResource
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
org.apache.hadoop.hbase.client.TestScannerTimeout
org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.security.access.TestAccessController
org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
org.apache.hadoop.hbase.rest.TestScannerResource
org.apache.hadoop.hbase.regionserver.TestStoreFileBlockCacheSummary
org.apache.hadoop.hbase.TestFullLogReconstruction
org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort
org.apache.hadoop.hbase.master.TestMasterTransitions
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
org.apache.hadoop.hbase.rest.TestGzipFilter
org.apache.hadoop.hbase.fs.TestBlockReorder
org.apache.hadoop.hbase.backup.TestHFileArchiving
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster
org.apache.hadoop.hbase.TestMultiVersions
org.apache.hadoop.hbase.trace.TestHTraceHooks
org.apache.hadoop.hbase.master.handler.TestTableDeleteFamilyHandler
org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding
org.apache.hadoop.hbase.catalog.TestMetaMigrationConvertingToPB
org.apache.hadoop.hbase.regionserver.TestRSKilledWhenMasterInitializing
org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
org.apache.hadoop.hbase.regionserver.TestHRegion
org.apache.hadoop.hbase.client.TestTimestampsFilter
org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
org.apache.hadoop.hbase.regionserver.TestCompactionState
org.apache.hadoop.hbase.client.TestShell
org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.regionserver.wal.TestHLogFiltering
org.apache.hadoop.hbase.client.TestAdmin
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543001#comment-13543001 ] Bryan Baugher commented on HBASE-7369: -- [~zjushch] I like the idea of moving the logic into close() and will do that shortly. The reason I created this issue and patch is because I was fighting an issue where our HConnection would become aborted and no matter how many times we closed and retrieved new HTables the connection was still aborted (because of the caching mechanism). With this patch that should no longer be true. My thought is that HTables should be short lived or it should be understandable that if an HTable throws an exception one should close it and retrieve a new one, which would fix the issue. HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Priority: Minor Attachments: patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543003#comment-13543003 ] Bryan Baugher commented on HBASE-7369: -- I had forgot what the code looked like, abort actually never calls close() but sets closed=true. HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Priority: Minor Attachments: patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543136#comment-13543136 ] ramkrishna.s.vasudevan commented on HBASE-7369: --- @Bryan Baugher So HCM.locateRegion() would have thrown exception after this. Its better to remove or while doing getConnection every time check if isClosed == true and if so return a new connection. bq.if an HTable throws an exception one should close it and retrieve a new one Ya this should solve the problem if application takes care of it. As Chunhui suggested we can move the code to close(). +1 from me. Also may be we can improve the javadoc saying if your connection is closed then application should handle it by creating a new one. HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Priority: Minor Attachments: patch2.diff, patch3.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543213#comment-13543213
]
Hadoop QA commented on HBASE-7369:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12563119/HBASE-7369_HCM-remove-aborted-cnxs.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestLocalHBaseCluster
{color:red}-1 core zombie tests{color}. There are 4 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3828//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3828//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3828//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3828//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3828//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3828//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3828//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3828//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3828//console
This message is automatically generated.
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Attachments: HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff,
patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543223#comment-13543223
]
Ted Yu commented on HBASE-7369:
---
{code}
}
+ else if (connection.isClosed()) {
{code}
Move the 'else' line to the end of previous line.
{code}
+close();
this.closed = true;
{code}
When we call close(), this.closed = true would be taken care of inside close(),
right ?
{code}
+ if(aborted){
+ HConnectionManager.deleteStaleConnection(this);
{code}
Please use two spaces for indentation. You can use
dev-support/hbase_eclipse_formatter.xml from trunk.
{code}
+ public void abortingHConnectionRemovesItFromHCM() throws Exception{
{code}
abortingHConnectionRemovesItFromHCM - abortingHConnectionRemovesItselfFromHCM
{code}
+ MapHConnectionKey, HConnectionImplementation oldHBaseInstances = new
HashMapHConnectionKey, HConnectionImplementation();
+ for (EntryHConnectionKey, HConnectionImplementation entry :
HConnectionManager.HBASE_INSTANCES.entrySet()){
{code}
Wrap long line: 100 characters per line max
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Attachments: HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff,
patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543419#comment-13543419
]
Ted Yu commented on HBASE-7369:
---
{code}
-HConnectionManager.deleteConnection(this, stopProxy, false);
+ if(aborted){
{code}
nit: shift the if block left by two spaces (to align with the original position
of 'H').
{code}
+ }
+ else {
+ HConnectionManager.deleteConnection(this, stopProxy, false);
{code}
Move 'else {' to the end of previous line.
{code}
+for (EntryHConnectionKey, HConnectionImplementation entry :
+ HConnectionManager.HBASE_INSTANCES.entrySet()) {
+ oldHBaseInstances.put(entry.getKey(), entry.getValue());
+}
{code}
Utilize
http://docs.oracle.com/javase/6/docs/api/java/util/Map.html#putAll%28java.util.Map%29
for the two copy actions.
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Attachments: HBASE-7369_HCM-remove-aborted-cnxs-2.txt,
HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543435#comment-13543435
]
Hadoop QA commented on HBASE-7369:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12563183/HBASE-7369_HCM-remove-aborted-cnxs-2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestZooKeeper
org.apache.hadoop.hbase.replication.TestReplication
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3841//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3841//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3841//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3841//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3841//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3841//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3841//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3841//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3841//console
This message is automatically generated.
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Attachments: HBASE-7369_HCM-remove-aborted-cnxs-2.txt,
HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542423#comment-13542423 ] Bryan Baugher commented on HBASE-7369: -- Anything I can do to help this along? HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Priority: Minor Attachments: patch2.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542434#comment-13542434 ] Ted Yu commented on HBASE-7369: --- @Bryan: There has been effort to bring findbugs warning down to 0. If you look at https://builds.apache.org/job/PreCommit-HBASE-Build/, there were two green builds. Can you re-attach patch so that we know where your patch stands nowadays ? I am waiting for one more +1. Thanks HConnectionManager should remove aborted connections Key: HBASE-7369 URL: https://issues.apache.org/jira/browse/HBASE-7369 Project: HBase Issue Type: Improvement Components: Client Affects Versions: 0.94.3 Reporter: Bryan Baugher Priority: Minor Attachments: patch2.diff, patch.diff When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection becomes unusable. HConnectionManager cache of HConnections currently does not have any logic around removing aborted connections automatically. Currently it is up to the consumer to do so using HConnectionManager.deleteStaleConnection(HConnection). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542703#comment-13542703
]
chunhui shen commented on HBASE-7369:
-
Once closed is set true, we won't reuse the HConnection again now.
Therefore, like
HConnectionImplementation#locateRegion,HConnectionImplementation#createMasterWithRetries,
will throw exception directly because closed=true.
[~bbaugher]
what about calling close() instead of
{code}if (managed) HConnectionManager.deleteStaleConnection(this);{code}
and change a little in close()
{code}
@Override
public void close() {
if (managed) {
if(abortRequested){
HConnectionManager.deleteStaleConnection(this);
}
else{
HConnectionManager.deleteConnection(this, stopProxy, false);
}
} else {
close(true);
}
}
{code}
By the way, there's another problem. Although a stale connecion is removed,
the existed HTable whose hconnection refers to this stale connection couldn't
work any more until we restart the client or application handle this case. I
think it's better reset the hconnection in HTable if it is already closed. e.g.
check whether connection is closed when using connection in HTable
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Attachments: patch2.diff, patch3.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534202#comment-13534202
]
Ted Yu commented on HBASE-7369:
---
{code}
+if(managed)
+HConnectionManager.deleteStaleConnection(this);
{code}
nit: insert space between if and (.
Call to HConnectionManager.deleteStaleConnection() can be placed on the same
line as if statement.
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Attachments: patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
[
https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534320#comment-13534320
]
Hadoop QA commented on HBASE-7369:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12561341/patch2.diff
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
additional warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 26 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
{color:red}-1 core zombie tests{color}. There are zombie tests. See build
logs for details.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3572//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3572//console
This message is automatically generated.
HConnectionManager should remove aborted connections
Key: HBASE-7369
URL: https://issues.apache.org/jira/browse/HBASE-7369
Project: HBase
Issue Type: Improvement
Components: Client
Affects Versions: 0.94.3
Reporter: Bryan Baugher
Priority: Minor
Attachments: patch2.diff, patch.diff
When an HConnection is abort()'ed (i.e. if numerous services are lost) the
connection becomes unusable. HConnectionManager cache of HConnections
currently does not have any logic around removing aborted connections
automatically. Currently it is up to the consumer to do so using
HConnectionManager.deleteStaleConnection(HConnection).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
