[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585137#comment-13585137 ] Ted Yu commented on HBASE-7899: --- I went through patch v3 briefly. Good job. +1 Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt, 7899v2.txt, 7899v3.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585218#comment-13585218 ] stack commented on HBASE-7899: -- Committed to trunk. Thanks for the helpful reviews all. Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt, 7899v2.txt, 7899v3.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585220#comment-13585220 ] stack commented on HBASE-7899: -- Attached to wrong issue. Deleted 7900 patch. Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt, 7899v2.txt, 7899v3.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585248#comment-13585248 ] Hudson commented on HBASE-7899: --- Integrated in HBase-TRUNK #3894 (See [https://builds.apache.org/job/HBase-TRUNK/3894/]) HBASE-7899 Cell block building tools: Cell codec and means of iterating an objects Cells (Revision 1449420) Result = FAILURE stack : Files : * /hbase/trunk/hbase-common/pom.xml * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTestUtil.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTool.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/Compression.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/LoadTestKVGenerator.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/RedundantKVGenerator.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/Cell.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/CellComparator.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/CellScannable.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/CellScanner.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/CellUtil.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/cell * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/BaseDecoder.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/BaseEncoder.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/CellCodec.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/Codec.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/CodecException.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/KeyValueCodec.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/io * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/io/CellOutputStream.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hbase * /hbase/trunk/hbase-common/src/test/java/org/apache/hbase/TestCellUtil.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hbase/codec * /hbase/trunk/hbase-common/src/test/java/org/apache/hbase/codec/TestCellCodec.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hbase/codec/TestKeyValueCodec.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/PrefixTreeCodec.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/PrefixTreeSeeker.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/decode/PrefixTreeArrayScanner.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/decode/PrefixTreeArraySearcher.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/decode/PrefixTreeCell.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/encode/PrefixTreeEncoder.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/scanner/CellScanner.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/scanner/CellScannerPosition.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/scanner/CellSearcher.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/scanner/ReversibleCellScanner.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/BaseTestRowData.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/TestRowEncoder.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/data/TestRowDataDeeper.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/data/TestRowDataNumberStrings.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/data/TestRowDataSearcherRowMiss.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/data/TestRowDataSimple.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/data/TestRowDataTrivial.java *
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585249#comment-13585249 ] Ted Yu commented on HBASE-7899: --- Looks like the empty file caused RAT check to fail: -rw-r--r-- 1 tyu staff 0 Feb 23 16:28 hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/scanner/CellScanner.java Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt, 7899v2.txt, 7899v3.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585254#comment-13585254 ] Hudson commented on HBASE-7899: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #418 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/418/]) HBASE-7899 Cell block building tools: Cell codec and means of iterating an objects Cells (Revision 1449420) Result = FAILURE stack : Files : * /hbase/trunk/hbase-common/pom.xml * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTestUtil.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTool.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/Compression.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/LoadTestKVGenerator.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/RedundantKVGenerator.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/Cell.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/CellComparator.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/CellScannable.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/CellScanner.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/CellUtil.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/cell * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/BaseDecoder.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/BaseEncoder.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/CellCodec.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/Codec.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/CodecException.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/codec/KeyValueCodec.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/io * /hbase/trunk/hbase-common/src/main/java/org/apache/hbase/io/CellOutputStream.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hbase * /hbase/trunk/hbase-common/src/test/java/org/apache/hbase/TestCellUtil.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hbase/codec * /hbase/trunk/hbase-common/src/test/java/org/apache/hbase/codec/TestCellCodec.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hbase/codec/TestKeyValueCodec.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/PrefixTreeCodec.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/PrefixTreeSeeker.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/decode/PrefixTreeArrayScanner.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/decode/PrefixTreeArraySearcher.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/decode/PrefixTreeCell.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/encode/PrefixTreeEncoder.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/scanner/CellScanner.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/scanner/CellScannerPosition.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/scanner/CellSearcher.java * /hbase/trunk/hbase-prefix-tree/src/main/java/org/apache/hbase/codec/prefixtree/scanner/ReversibleCellScanner.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/BaseTestRowData.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/TestRowEncoder.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/data/TestRowDataDeeper.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/data/TestRowDataNumberStrings.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/data/TestRowDataSearcherRowMiss.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/data/TestRowDataSimple.java * /hbase/trunk/hbase-prefix-tree/src/test/java/org/apache/hbase/codec/prefixtree/row/data/TestRowDataTrivial.java *
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584869#comment-13584869 ] stack commented on HBASE-7899: -- Updated rb w/ v2. Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt, 7899v2.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[
https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584919#comment-13584919
]
Hadoop QA commented on HBASE-7899:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570561/7899v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 48 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4505//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4505//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4505//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4505//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4505//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4505//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4505//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4505//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4505//console
This message is automatically generated.
Cell block building tools: Cell codec and means of iterating an objects Cells
-
Key: HBASE-7899
URL: https://issues.apache.org/jira/browse/HBASE-7899
Project: HBase
Issue Type: Sub-task
Components: IPC/RPC
Reporter: stack
Assignee: stack
Priority: Blocker
Fix For: 0.96.0
Attachments: 7899.txt, 7899v2.txt
In our rpc specification,
https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#,
we talk of passing lots of Cells outside of protobuf. We do it using Cell
blocks. There are blobs filled with Cells that are encoded variously and
optionally compressed.
This issue is about adding to hbase-common basic facility for building Cell
blocks. It includes a codec Interface for encoding/decoding Cell blocks as
well as a means of iterating an objects Cell content (prefix-tree's
CellScanner).
This is a subtask of HBASE-7898 Serializing Cells over RPC
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[
https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585042#comment-13585042
]
Hadoop QA commented on HBASE-7899:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570606/7899v3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 51 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestTablePermissions
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4511//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4511//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4511//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4511//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4511//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4511//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4511//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4511//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4511//console
This message is automatically generated.
Cell block building tools: Cell codec and means of iterating an objects Cells
-
Key: HBASE-7899
URL: https://issues.apache.org/jira/browse/HBASE-7899
Project: HBase
Issue Type: Sub-task
Components: IPC/RPC
Reporter: stack
Assignee: stack
Priority: Blocker
Fix For: 0.96.0
Attachments: 7899.txt, 7899v2.txt, 7899v3.txt
In our rpc specification,
https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#,
we talk of passing lots of Cells outside of protobuf. We do it using Cell
blocks. There are blobs filled with Cells that are encoded variously and
optionally compressed.
This issue is about adding to hbase-common basic facility for building Cell
blocks. It includes a codec Interface for encoding/decoding Cell blocks as
well as a means of iterating an objects Cell content (prefix-tree's
CellScanner).
This is a subtask of HBASE-7898 Serializing Cells over RPC
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585052#comment-13585052 ] stack commented on HBASE-7899: -- Ok. Test passes locally for me. Any +1s so I can get this in? Thanks lads. Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt, 7899v2.txt, 7899v3.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583482#comment-13583482 ] stack commented on HBASE-7899: -- It is on rb here: https://reviews.apache.org/r/9546/ Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Task Components: IPC/RPC Reporter: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583535#comment-13583535 ] Ted Yu commented on HBASE-7899: --- Maybe rename CellScannerable as CellScannable ? Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583539#comment-13583539 ] Ted Yu commented on HBASE-7899: --- I tried to access https://reviews.apache.org/r/9546/ but found that it is private. Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[
https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583541#comment-13583541
]
Hadoop QA commented on HBASE-7899:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570346/7899.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 51 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 5
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4485//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4485//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4485//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4485//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4485//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4485//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4485//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4485//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4485//console
This message is automatically generated.
Cell block building tools: Cell codec and means of iterating an objects Cells
-
Key: HBASE-7899
URL: https://issues.apache.org/jira/browse/HBASE-7899
Project: HBase
Issue Type: Task
Components: IPC/RPC
Reporter: stack
Assignee: stack
Priority: Blocker
Fix For: 0.96.0
Attachments: 7899.txt
In our rpc specification,
https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#,
we talk of passing lots of Cells outside of protobuf. We do it using Cell
blocks. There are blobs filled with Cells that are encoded variously and
optionally compressed.
This issue is about adding to hbase-common basic facility for building Cell
blocks. It includes a codec Interface for encoding/decoding Cell blocks as
well as a means of iterating an objects Cell content (prefix-tree's
CellScanner).
This is a subtask of HBASE-7898 Serializing Cells over RPC
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583546#comment-13583546 ] stack commented on HBASE-7899: -- bq. Maybe rename CellScannerable as CellScannable ? Could do that. rb seems to be still loading. will look at it. Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583550#comment-13583550 ] stack commented on HBASE-7899: -- Try now. It seems done finally. Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583553#comment-13583553 ] Ted Yu commented on HBASE-7899: --- I was able to access the review. But there're only two buttons: Review and ShipIt - I couldn't see the diff Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[
https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583568#comment-13583568
]
Ted Yu commented on HBASE-7899:
---
{code}
+ * backing bytes copied from the steam.
{code}
Typo: steam
For CellTool:
{code}
+ public static CellScanner createCellScanner(final IteratorCell cells) {
...
+ public boolean next() {
+return this.iterator.hasNext();
+ }
{code}
Is the implementation for next() correct ?
{code}
+ public Cell getDeepCopy() {
+// TODO: Fix to do a deep copy. Does the CellIterable passed have to
be against deep copies?
+return get();
+ }
{code}
Do you plan to address the above in a follow-on issue ?
Cell block building tools: Cell codec and means of iterating an objects Cells
-
Key: HBASE-7899
URL: https://issues.apache.org/jira/browse/HBASE-7899
Project: HBase
Issue Type: Task
Components: IPC/RPC
Reporter: stack
Assignee: stack
Priority: Blocker
Fix For: 0.96.0
Attachments: 7899.txt
In our rpc specification,
https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#,
we talk of passing lots of Cells outside of protobuf. We do it using Cell
blocks. There are blobs filled with Cells that are encoded variously and
optionally compressed.
This issue is about adding to hbase-common basic facility for building Cell
blocks. It includes a codec Interface for encoding/decoding Cell blocks as
well as a means of iterating an objects Cell content (prefix-tree's
CellScanner).
This is a subtask of HBASE-7898 Serializing Cells over RPC
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[
https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583575#comment-13583575
]
Ted Yu commented on HBASE-7899:
---
CellScannerable, Codec, BaseEncoder and BaseDecoder miss audience annotation.
{code}
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
+public final class CellTool {
{code}
I thought a Tool should be for public audience.
{code}
+ * @return Byte array read from the stream.
+ * @throws IOException
+ */
+private byte [] readByteArray(final InputStream in) throws IOException {
{code}
Please add javadoc for parameter in.
Cell block building tools: Cell codec and means of iterating an objects Cells
-
Key: HBASE-7899
URL: https://issues.apache.org/jira/browse/HBASE-7899
Project: HBase
Issue Type: Task
Components: IPC/RPC
Reporter: stack
Assignee: stack
Priority: Blocker
Fix For: 0.96.0
Attachments: 7899.txt
In our rpc specification,
https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#,
we talk of passing lots of Cells outside of protobuf. We do it using Cell
blocks. There are blobs filled with Cells that are encoded variously and
optionally compressed.
This issue is about adding to hbase-common basic facility for building Cell
blocks. It includes a codec Interface for encoding/decoding Cell blocks as
well as a means of iterating an objects Cell content (prefix-tree's
CellScanner).
This is a subtask of HBASE-7898 Serializing Cells over RPC
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7899) Cell block building tools: Cell codec and means of iterating an objects Cells
[ https://issues.apache.org/jira/browse/HBASE-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583579#comment-13583579 ] stack commented on HBASE-7899: -- Try rb again. On comments so far, I just moved CellTool. I think it fine being private for now. Will not address the deep copy issue in encoders until we have more than one KV implementation going on in hbase. Keep coming w/ the comments. Cell block building tools: Cell codec and means of iterating an objects Cells - Key: HBASE-7899 URL: https://issues.apache.org/jira/browse/HBASE-7899 Project: HBase Issue Type: Task Components: IPC/RPC Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.0 Attachments: 7899.txt In our rpc specification, https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit#, we talk of passing lots of Cells outside of protobuf. We do it using Cell blocks. There are blobs filled with Cells that are encoded variously and optionally compressed. This issue is about adding to hbase-common basic facility for building Cell blocks. It includes a codec Interface for encoding/decoding Cell blocks as well as a means of iterating an objects Cell content (prefix-tree's CellScanner). This is a subtask of HBASE-7898 Serializing Cells over RPC -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
