[GitHub] [incubator-iceberg] prodeezy commented on issue #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on issue #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#issuecomment-535369666 cc @rominparekh @rdblue @xabriel

[GitHub] [incubator-iceberg] prodeezy commented on issue #495: Add back ability to set custom name on transformed field

prodeezy commented on issue #495: Add back ability to set custom name on transformed field URL: https://github.com/apache/incubator-iceberg/issues/495#issuecomment-535369565 cc @rominparekh @rdblue @xabriel please review : https://github.com/apache/incubator-iceberg/pull/498

[GitHub] [incubator-iceberg] prodeezy opened a new pull request #498: Adding partition transform builder methods to set custom target field names

prodeezy opened a new pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498 https://github.com/apache/incubator-iceberg/issues/495 Reports as issue where we currently don't have a way to

[GitHub] [incubator-iceberg] prodeezy closed pull request #496: Adding back public access to Builder add method

prodeezy closed pull request #496: Adding back public access to Builder add method URL: https://github.com/apache/incubator-iceberg/pull/496 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

xabriel commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328702664 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

xabriel commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328702507 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #497: Support retaining last N snapshots

aokolnychyi commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r328728064 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -310,6 +323,19 @@

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #497: Support retaining last N snapshots

aokolnychyi commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r328718655 ## File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java ## @@ -55,6 +55,14 @@ */

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #497: Support retaining last N snapshots

xabriel commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r328713783 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -310,6 +323,19 @@ private

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

rdblue commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328716596 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

rdblue commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328717472 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r328755892 ## File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java ## @@ -55,6 +55,14 @@

[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328751043 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328753229 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328753324 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] prodeezy commented on issue #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on issue #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#issuecomment-535622330 Added unit test to check target names that already exists

[GitHub] [incubator-iceberg] yathindranath commented on a change in pull request #497: Support retaining last N snapshots

yathindranath commented on a change in pull request #497: Support retaining last N snapshots URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r328769072 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -310,6 +323,19 @@

[GitHub] [incubator-iceberg] rdsr commented on issue #207: Add external schema mappings for files written with name-based schemas #40

rdsr commented on issue #207: Add external schema mappings for files written with name-based schemas #40 URL: https://github.com/apache/incubator-iceberg/pull/207#issuecomment-535752509 @rdblue . I updated the code and made the changes in `PruneColumns` api.

[GitHub] [incubator-iceberg] rdblue commented on issue #498: Adding partition transform builder methods to set custom target field names

rdblue commented on issue #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#issuecomment-535700392 @prodeezy, just one minor thing to fix that your test case caught.

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

rdblue commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328840798 ## File path:

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #207: Add external schema mappings for files written with name-based schemas #40

rdsr commented on a change in pull request #207: Add external schema mappings for files written with name-based schemas #40 URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r32086 ## File path:

[GitHub] [incubator-iceberg] manishmalhotrawork opened a new pull request #499: Add persistent IDs to partition fields (WIP)

manishmalhotrawork opened a new pull request #499: Add persistent IDs to partition fields (WIP) URL: https://github.com/apache/incubator-iceberg/pull/499 for #280. @rdblue can you please review. Raising as WIP PR, as this might need some changes. Summary: parsing

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #207: Add external schema mappings for files written with name-based schemas #40

rdsr commented on a change in pull request #207: Add external schema mappings for files written with name-based schemas #40 URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r328890017 ## File path: core/src/main/java/org/apache/iceberg/avro/PruneColumns.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

rdblue commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328842041 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

rdblue commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328842041 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] rdsr opened a new issue #500: Support External name mapping in Iceberg generic single message encoder

rdsr opened a new issue #500: Support External name mapping in Iceberg generic single message encoder URL: https://github.com/apache/incubator-iceberg/issues/500 #207 adds external schema mapping support in Avro file reader. this issue tracks adding support for name mapping for Iceberg

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #207: Add external schema mappings for files written with name-based schemas #40

rdsr commented on a change in pull request #207: Add external schema mappings for files written with name-based schemas #40 URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r328890580 ## File path:

[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328903596 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328903596 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] rdsr edited a comment on issue #207: Add external schema mappings for files written with name-based schemas #40

rdsr edited a comment on issue #207: Add external schema mappings for files written with name-based schemas #40 URL: https://github.com/apache/incubator-iceberg/pull/207#issuecomment-535752509 @rdblue . I updated the code and made the changes in `PruneColumns` class.

[GitHub] [incubator-iceberg] prodeezy removed a comment on issue #498: Adding partition transform builder methods to set custom target field names

prodeezy removed a comment on issue #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#issuecomment-535785220 retest This is an

[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328903596 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] prodeezy commented on issue #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on issue #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#issuecomment-535773972 @rdblue addressed pending comments. Please let me know if this looks good.

[GitHub] [incubator-iceberg] prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on a change in pull request #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328903596 ## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java

[GitHub] [incubator-iceberg] prodeezy commented on issue #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on issue #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#issuecomment-535785220 retest This is an automated

[GitHub] [incubator-iceberg] prodeezy commented on issue #498: Adding partition transform builder methods to set custom target field names

prodeezy commented on issue #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#issuecomment-535784805 Test failures are around `TestIcebergSourceHiveTables` with a `SocketException` so seems

[GitHub] [incubator-iceberg] prodeezy edited a comment on issue #498: Adding partition transform builder methods to set custom target field names

prodeezy edited a comment on issue #498: Adding partition transform builder methods to set custom target field names URL: https://github.com/apache/incubator-iceberg/pull/498#issuecomment-535784805 Test failures are around `TestIcebergSourceHiveTables` with a `SocketException` so seems