[GitHub] [metron] nickwallen commented on a change in pull request #1441: METRON-2156: Remove Storm dependency from metron-hbase

2019-06-12 Thread GitBox 
nickwallen commented on a change in pull request #1441: METRON-2156: Remove 
Storm dependency from metron-hbase
URL: https://github.com/apache/metron/pull/1441#discussion_r293050481
 
 

 ##
 File path: 
metron-platform/metron-hbase/metron-hbase-common/src/test/java/org/apache/metron/hbase/client/HBaseClientTest.java
 ##
 @@ -149,7 +128,7 @@ public void testWrite() throws Exception {
 client.mutate();
 
 HBaseProjectionCriteria criteria = new HBaseProjectionCriteria();
-criteria.addColumnFamily(WidgetMapper.CF_STRING);
+criteria.addColumnFamily(Bytes.toString(cf));
 
 Review comment:
   In the comments and test names in this class there are still references to 
"widgets".  With this refactor, nothing in here uses the Widgets or 
WidgetMapper any longer.  Would you be able to clean our those old references 
to "widget" so as to not confuse anyone?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [metron] nickwallen commented on a change in pull request #1441: METRON-2156: Remove Storm dependency from metron-hbase

2019-06-12 Thread GitBox 
nickwallen commented on a change in pull request #1441: METRON-2156: Remove 
Storm dependency from metron-hbase
URL: https://github.com/apache/metron/pull/1441#discussion_r293055162
 
 

 ##
 File path: metron-analytics/metron-profiler-storm/pom.xml
 ##
 @@ -130,7 +130,7 @@
 
 
 org.apache.metron
-metron-hbase
+metron-hbase-storm
 
 Review comment:
   All of the classes in `metron-hbase-storm` like `HBaseBolt`, `HBaseMapper`, 
`BatchHelper` are **only** used by the Profiler.  These classes will never be 
reused by anything else at this point.  Would it make sense to just move these 
to `metron-profiler-storm` and remove the new `metron-hbase-storm` project?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [metron] nickwallen commented on a change in pull request #1441: METRON-2156: Remove Storm dependency from metron-hbase

2019-06-12 Thread GitBox 
nickwallen commented on a change in pull request #1441: METRON-2156: Remove 
Storm dependency from metron-hbase
URL: https://github.com/apache/metron/pull/1441#discussion_r293052546
 
 

 ##
 File path: 
metron-platform/metron-hbase/metron-hbase-common/src/main/java/org/apache/metron/hbase/ColumnList.java
 ##
 @@ -18,7 +18,7 @@
  *
  */
 
-package org.apache.metron.hbase.bolt.mapper;
+package org.apache.metron.hbase;
 
 Review comment:
   I don't see `org.apache.metron.hbase.Connector` used anywhere.  Am I missing 
it?  If not, we should delete this too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [metron] nickwallen commented on a change in pull request #1441: METRON-2156: Remove Storm dependency from metron-hbase

2019-06-12 Thread GitBox 
nickwallen commented on a change in pull request #1441: METRON-2156: Remove 
Storm dependency from metron-hbase
URL: https://github.com/apache/metron/pull/1441#discussion_r293050481
 
 

 ##
 File path: 
metron-platform/metron-hbase/metron-hbase-common/src/test/java/org/apache/metron/hbase/client/HBaseClientTest.java
 ##
 @@ -149,7 +128,7 @@ public void testWrite() throws Exception {
 client.mutate();
 
 HBaseProjectionCriteria criteria = new HBaseProjectionCriteria();
-criteria.addColumnFamily(WidgetMapper.CF_STRING);
+criteria.addColumnFamily(Bytes.toString(cf));
 
 Review comment:
   In the comments and test names in this class there are still references to 
"widgets".  Since the refactor this no longer makes sense. Would you be able to 
clean those out?  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services