[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393343#comment-16393343 ] ASF GitHub Bot commented on MXNET-42: - marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173531188 ## File path: python/mxnet/gluon/data/dataloader.py ## @@ -214,6 +214,7 @@ def __iter__(self): worker.start() workers.append(worker) +idx = 0 Review comment: Good question, I don't really know :/ pylint just complained about a few things and I fixed them to get the tests to pass This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393308#comment-16393308 ] ASF GitHub Bot commented on MXNET-42: - szha commented on a change in pull request #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173525209 ## File path: python/mxnet/gluon/data/dataloader.py ## @@ -214,6 +214,7 @@ def __iter__(self): worker.start() workers.append(worker) +idx = 0 Review comment: This is in a path where pylint check is enforced. Why now? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392880#comment-16392880 ] ASF GitHub Bot commented on MXNET-42: - marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173447787 ## File path: ci/docker/install/arm64_openblas.sh ## @@ -0,0 +1,35 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# build and install are separated so changes to build don't invalidate +# the whole docker cache for the image + +set -ex +pushd . +wget -nv https://api.github.com/repos/xianyi/OpenBLAS/git/refs/heads/master -O openblas_version.json +echo "Using openblas:" +cat openblas_version.json +git clone https://github.com/xianyi/OpenBLAS.git +cd OpenBLAS +make -j$(nproc) TARGET=ARMV8 +make install +ln -s /opt/OpenBLAS/lib/libopenblas.so /usr/lib/libopenblas.so +ln -s /opt/OpenBLAS/lib/libopenblas.a /usr/lib/libopenblas.a +ln -s /opt/OpenBLAS/lib/libopenblas.a /usr/lib/liblapack.a Review comment: Problem is that we need these libraries "present" in both locations for cross compilation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392875#comment-16392875 ] ASF GitHub Bot commented on MXNET-42: - marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173447072 ## File path: python/mxnet/gluon/data/dataloader.py ## @@ -214,6 +214,7 @@ def __iter__(self): worker.start() workers.append(worker) +idx = 0 Review comment: This is a lint fix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392876#comment-16392876
]
ASF GitHub Bot commented on MXNET-42:
-
marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp;
Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173447091
##
File path: ci/build.py
##
@@ -0,0 +1,182 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Multi arch dockerized build tool.
+
+"""
+
+__author__ = 'Marco de Abreu, Kellen Sunderland, Anton Chernov, Pedro Larroy'
+__version__ = '0.1'
+
+import os
+import sys
+import subprocess
+import logging
+import argparse
+from subprocess import check_call, call
+import glob
+import re
+from typing import *
+from itertools import chain
+from copy import deepcopy
+
+
+def get_platforms(path: Optional[str]="docker"):
+"""Get a list of architectures given our dockerfiles"""
+dockerfiles = glob.glob(os.path.join(path, "Dockerfile.build.*"))
+dockerfiles = list(filter(lambda x: x[-1] != '~', dockerfiles))
+files = list(map(lambda x: re.sub(r"Dockerfile.build.(.*)", r"\1", x),
dockerfiles))
+files.sort()
+platforms = list(map(lambda x: os.path.split(x)[1], files))
+return platforms
+
+
+def get_docker_tag(platform: str) -> None:
+return "mxnet/build.{0}".format(platform)
+
+
+def get_dockerfile(platform: str, path="docker"):
+return os.path.join(path, "Dockerfile.build.{0}".format(platform))
+
+def get_docker_binary(use_nvidia_docker: bool):
+if use_nvidia_docker:
+return "nvidia-docker"
+else:
+return "docker"
+
+def build_docker(platform: str, docker_binary: str) -> None:
+"""Build a container for the given platform"""
+tag = get_docker_tag(platform)
+logging.info("Building container tagged '%s' with %s", tag, docker_binary)
+cmd = [docker_binary, "build",
+"-f", get_dockerfile(platform),
+"--build-arg", "USER_ID={}".format(os.getuid()),
+"-t", tag,
+"docker"]
+logging.info("Running command: '%s'", ' '.join(cmd))
+check_call(cmd)
+
+def get_mxnet_root() -> str:
+curpath = os.path.abspath(os.path.dirname(__file__))
+def is_mxnet_root(path: str) -> bool:
+return os.path.exists(os.path.join(path, ".mxnet_root"))
+while not is_mxnet_root(curpath):
+parent = os.path.abspath(os.path.join(curpath, os.pardir))
+if parent == curpath:
+raise RuntimeError("Got to the root and couldn't find a parent
folder with .mxnet_root")
+curpath = parent
+return curpath
+
+
+def container_run(platform: str, docker_binary: str, command: List[str]) ->
None:
+tag = get_docker_tag(platform)
+mx_root = get_mxnet_root()
+#local_build_folder = '{}/build_{}'.format(mx_root, platform)
+local_build_folder = '{}/build'.format(mx_root)
+# We need to create it first, otherwise it will be created by the docker
daemon with root only permissions
+os.makedirs(local_build_folder, exist_ok=True)
+logging.info("Running %s in container %s", command, tag)
+runlist = [docker_binary, 'run', '--rm',
+#'-v', "{}:/work/mxnet:ro".format(mx_root), # mount mxnet root
+'-v', "{}:/work/mxnet".format(mx_root), # mount mxnet root
+'-v', "{}:/work/build".format(local_build_folder), # mount mxnet/build
for storing build artifacts
+#'-w', '/work/build',
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improv
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392877#comment-16392877 ] ASF GitHub Bot commented on MXNET-42: - marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173447110 ## File path: ci/docker/Dockerfile.build.centos7_cpu ## @@ -0,0 +1,17 @@ +FROM centos:7 Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392463#comment-16392463 ] ASF GitHub Bot commented on MXNET-42: - szha commented on a change in pull request #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173371249 ## File path: python/mxnet/gluon/data/dataloader.py ## @@ -214,6 +214,7 @@ def __iter__(self): worker.start() workers.append(worker) +idx = 0 Review comment: ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392461#comment-16392461 ] ASF GitHub Bot commented on MXNET-42: - szha commented on a change in pull request #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173370939 ## File path: ci/docker/install/arm64_openblas.sh ## @@ -0,0 +1,35 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# build and install are separated so changes to build don't invalidate +# the whole docker cache for the image + +set -ex +pushd . +wget -nv https://api.github.com/repos/xianyi/OpenBLAS/git/refs/heads/master -O openblas_version.json +echo "Using openblas:" +cat openblas_version.json +git clone https://github.com/xianyi/OpenBLAS.git +cd OpenBLAS +make -j$(nproc) TARGET=ARMV8 +make install +ln -s /opt/OpenBLAS/lib/libopenblas.so /usr/lib/libopenblas.so +ln -s /opt/OpenBLAS/lib/libopenblas.a /usr/lib/libopenblas.a +ln -s /opt/OpenBLAS/lib/libopenblas.a /usr/lib/liblapack.a Review comment: `make PREFIX=path install` can help specify the place to put these files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392436#comment-16392436 ] ASF GitHub Bot commented on MXNET-42: - szha commented on a change in pull request #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173367898 ## File path: ci/docker/Dockerfile.build.centos7_cpu ## @@ -0,0 +1,17 @@ +FROM centos:7 Review comment: Add similar comment as other docker files? ``` # -*- mode: dockerfile -*- # dockerfile to build libmxnet.so for centos7 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392435#comment-16392435
]
ASF GitHub Bot commented on MXNET-42:
-
szha commented on a change in pull request #9995: [WIP] CI docker revamp; Add
Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173367713
##
File path: ci/build.py
##
@@ -0,0 +1,182 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Multi arch dockerized build tool.
+
+"""
+
+__author__ = 'Marco de Abreu, Kellen Sunderland, Anton Chernov, Pedro Larroy'
+__version__ = '0.1'
+
+import os
+import sys
+import subprocess
+import logging
+import argparse
+from subprocess import check_call, call
+import glob
+import re
+from typing import *
+from itertools import chain
+from copy import deepcopy
+
+
+def get_platforms(path: Optional[str]="docker"):
+"""Get a list of architectures given our dockerfiles"""
+dockerfiles = glob.glob(os.path.join(path, "Dockerfile.build.*"))
+dockerfiles = list(filter(lambda x: x[-1] != '~', dockerfiles))
+files = list(map(lambda x: re.sub(r"Dockerfile.build.(.*)", r"\1", x),
dockerfiles))
+files.sort()
+platforms = list(map(lambda x: os.path.split(x)[1], files))
+return platforms
+
+
+def get_docker_tag(platform: str) -> None:
+return "mxnet/build.{0}".format(platform)
+
+
+def get_dockerfile(platform: str, path="docker"):
+return os.path.join(path, "Dockerfile.build.{0}".format(platform))
+
+def get_docker_binary(use_nvidia_docker: bool):
+if use_nvidia_docker:
+return "nvidia-docker"
+else:
+return "docker"
+
+def build_docker(platform: str, docker_binary: str) -> None:
+"""Build a container for the given platform"""
+tag = get_docker_tag(platform)
+logging.info("Building container tagged '%s' with %s", tag, docker_binary)
+cmd = [docker_binary, "build",
+"-f", get_dockerfile(platform),
+"--build-arg", "USER_ID={}".format(os.getuid()),
+"-t", tag,
+"docker"]
+logging.info("Running command: '%s'", ' '.join(cmd))
+check_call(cmd)
+
+def get_mxnet_root() -> str:
+curpath = os.path.abspath(os.path.dirname(__file__))
+def is_mxnet_root(path: str) -> bool:
+return os.path.exists(os.path.join(path, ".mxnet_root"))
+while not is_mxnet_root(curpath):
+parent = os.path.abspath(os.path.join(curpath, os.pardir))
+if parent == curpath:
+raise RuntimeError("Got to the root and couldn't find a parent
folder with .mxnet_root")
+curpath = parent
+return curpath
+
+
+def container_run(platform: str, docker_binary: str, command: List[str]) ->
None:
+tag = get_docker_tag(platform)
+mx_root = get_mxnet_root()
+#local_build_folder = '{}/build_{}'.format(mx_root, platform)
+local_build_folder = '{}/build'.format(mx_root)
+# We need to create it first, otherwise it will be created by the docker
daemon with root only permissions
+os.makedirs(local_build_folder, exist_ok=True)
+logging.info("Running %s in container %s", command, tag)
+runlist = [docker_binary, 'run', '--rm',
+#'-v', "{}:/work/mxnet:ro".format(mx_root), # mount mxnet root
+'-v', "{}:/work/mxnet".format(mx_root), # mount mxnet root
+'-v', "{}:/work/build".format(local_build_folder), # mount mxnet/build
for storing build artifacts
+#'-w', '/work/build',
Review comment:
Clean up commented code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392150#comment-16392150
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173332947
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392152#comment-16392152
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173332972
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
thanks for checking
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392144#comment-16392144
]
ASF GitHub Bot commented on MXNET-42:
-
marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp;
Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173332212
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
No it won't. I just double checked.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392143#comment-16392143
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173331575
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
I understand, however I think the following code will take the if branch,
which it shouldn't:
```python
lib_from_env = ""
if lib_from_env:
print(lib_from_env)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392137#comment-16392137
]
ASF GitHub Bot commented on MXNET-42:
-
marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp;
Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173330602
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
Just open the code and look below the introduced if-block :D
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392141#comment-16392141
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173331575
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
I understand, however I think the following code will take the if branch,
which it shouldn't:
```python
lib_from_env = "
if lib_from_env:
print(lib_from_env)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392138#comment-16392138
]
ASF GitHub Bot commented on MXNET-42:
-
marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp;
Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173330808
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
it continue in line 32/44 as before - we just inserted special handling in
case that variable is set
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392119#comment-16392119 ] ASF GitHub Bot commented on MXNET-42: - cjolivier01 commented on issue #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#issuecomment-371663585 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392118#comment-16392118
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173327315
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
I don't see any evidence to support that claim, but whatever -- I don't care
all that much.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392103#comment-16392103
]
ASF GitHub Bot commented on MXNET-42:
-
marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp;
Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173325670
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
The default one below (starting with ``curr_path =
os.path.dirname(os.path.abspath(os.path.expanduser(__file__)))``)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391925#comment-16391925
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173294247
##
File path: CMakeLists.txt
##
@@ -94,7 +95,13 @@ else(MSVC)
endif()
check_cxx_compiler_flag("-std=c++11" SUPPORT_CXX11)
check_cxx_compiler_flag("-std=c++0x" SUPPORT_CXX0X)
- check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
+ # For cross compilation, we can't rely on the compiler which accepts the
flag, but mshadow will
+ # add platform specific includes not available in other arches
+ if(USE_SSE STREQUAL "AUTO")
+check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
+ else()
+set(SUPPORT_MSSE2 "OFF")
Review comment:
Please use unset(SUPPORT_MSSE) or set to FALSE (no quotes)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391923#comment-16391923
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173294029
##
File path: CMakeLists.txt
##
@@ -94,7 +95,13 @@ else(MSVC)
endif()
check_cxx_compiler_flag("-std=c++11" SUPPORT_CXX11)
check_cxx_compiler_flag("-std=c++0x" SUPPORT_CXX0X)
- check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
+ # For cross compilation, we can't rely on the compiler which accepts the
flag, but mshadow will
+ # add platform specific includes not available in other arches
+ if(USE_SSE STREQUAL "AUTO")
+check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
Review comment:
nit: the spacing before SUPPORT_MSSE2 becomes kind of pointless if the
check_cxx_compiler_flag(...) line isn;t still aligned with the rest of them
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391875#comment-16391875
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173279612
##
File path: CMakeLists.txt
##
@@ -94,7 +95,13 @@ else(MSVC)
endif()
check_cxx_compiler_flag("-std=c++11" SUPPORT_CXX11)
check_cxx_compiler_flag("-std=c++0x" SUPPORT_CXX0X)
- check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
+ # For cross compilation, we can't rely on the compiler which accepts the
flag, but mshadow will
+ # add platform specific includes not available in other arches
+ if(USE_SSE STREQUAL "AUTO")
+check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391874#comment-16391874
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173279526
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
so which code path will be taken for an empty string?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391857#comment-16391857
]
ASF GitHub Bot commented on MXNET-42:
-
marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp;
Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173275487
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
Yes it does
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391855#comment-16391855
]
ASF GitHub Bot commented on MXNET-42:
-
marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp;
Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173274949
##
File path: CMakeLists.txt
##
@@ -94,7 +95,13 @@ else(MSVC)
endif()
check_cxx_compiler_flag("-std=c++11" SUPPORT_CXX11)
check_cxx_compiler_flag("-std=c++0x" SUPPORT_CXX0X)
- check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
+ # For cross compilation, we can't rely on the compiler which accepts the
flag, but mshadow will
+ # add platform specific includes not available in other arches
+ if(USE_SSE STREQUAL "AUTO")
+check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
Review comment:
When we cross compile, the compiler supports the option, but the target
platform actually does not support it. This means that the cmake auto detects
it wrong.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391821#comment-16391821
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173268948
##
File path: python/mxnet/libinfo.py
##
@@ -29,6 +30,17 @@ def find_lib_path():
lib_path : list(string)
List of all found path to the libraries.
"""
+lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+if lib_from_env:
Review comment:
Does this also check for an empty string? Some OS's, at least in C, will
return a valid pointer from getenv() for an empty, yet defined, string
ie
export MXNET_LIBRARY_PATH=
will return "" on some OS's, even though the intent is clearly to not be
defined.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391822#comment-16391822
]
ASF GitHub Bot commented on MXNET-42:
-
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173266753
##
File path: CMakeLists.txt
##
@@ -94,7 +95,13 @@ else(MSVC)
endif()
check_cxx_compiler_flag("-std=c++11" SUPPORT_CXX11)
check_cxx_compiler_flag("-std=c++0x" SUPPORT_CXX0X)
- check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
+ # For cross compilation, we can't rely on the compiler which accepts the
flag, but mshadow will
+ # add platform specific includes not available in other arches
+ if(USE_SSE STREQUAL "AUTO")
+check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
Review comment:
Why would you ever turn it off on a platform that supported it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391220#comment-16391220 ] ASF GitHub Bot commented on MXNET-42: - marcoabreu commented on issue #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#issuecomment-37148 Yes, all jobs have been migrated. I'm just waiting for Anton to fix the Android builds. Yes, great teamwork! Thanks everybody :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391219#comment-16391219 ] ASF GitHub Bot commented on MXNET-42: - marcoabreu commented on a change in pull request #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173150116 ## File path: ci/docker/Dockerfile.build.amzn_linux_cpu ## @@ -0,0 +1,24 @@ +FROM amazonlinux + +WORKDIR /work/deps +COPY install/amzn_linux_core.sh /work/ +RUN /work/amzn_linux_core.sh +COPY install/amzn_linux_opencv.sh /work/ +RUN /work/amzn_linux_opencv.sh +COPY install/amzn_linux_openblas.sh /work/ +RUN /work/amzn_linux_openblas.sh +COPY install/amzn_linux_python2.sh /work/ +RUN /work/amzn_linux_python2.sh +COPY install/amzn_linux_python3.sh /work/ +RUN /work/amzn_linux_python3.sh +COPY install/amzn_linux_testdeps.sh /work/ +RUN /work/amzn_linux_testdeps.sh +COPY install/amzn_linux_julia.sh /work/ +RUN /work/amzn_linux_julia.sh +COPY install/amzn_linux_maven.sh /work/ +RUN /work/amzn_linux_maven.sh +COPY install/amzn_linux_library.sh /work/ +RUN /work/amzn_linux_library.sh +WORKDIR /work/mxnet + +COPY runtime_functions.sh /work/ Review comment: I think either way is okay. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391192#comment-16391192 ] ASF GitHub Bot commented on MXNET-42: - larroy commented on issue #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#issuecomment-371475948 BTW great job Marco and good teamwork! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391089#comment-16391089 ] ASF GitHub Bot commented on MXNET-42: - larroy commented on a change in pull request #9995: [WIP] CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173128735 ## File path: ci/docker/Dockerfile.build.amzn_linux_cpu ## @@ -0,0 +1,24 @@ +FROM amazonlinux + +WORKDIR /work/deps +COPY install/amzn_linux_core.sh /work/ +RUN /work/amzn_linux_core.sh +COPY install/amzn_linux_opencv.sh /work/ +RUN /work/amzn_linux_opencv.sh +COPY install/amzn_linux_openblas.sh /work/ +RUN /work/amzn_linux_openblas.sh +COPY install/amzn_linux_python2.sh /work/ +RUN /work/amzn_linux_python2.sh +COPY install/amzn_linux_python3.sh /work/ +RUN /work/amzn_linux_python3.sh +COPY install/amzn_linux_testdeps.sh /work/ +RUN /work/amzn_linux_testdeps.sh +COPY install/amzn_linux_julia.sh /work/ +RUN /work/amzn_linux_julia.sh +COPY install/amzn_linux_maven.sh /work/ +RUN /work/amzn_linux_maven.sh +COPY install/amzn_linux_library.sh /work/ +RUN /work/amzn_linux_library.sh +WORKDIR /work/mxnet + +COPY runtime_functions.sh /work/ Review comment: Shall we copy this file like that or access directly from the mounted volume? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391088#comment-16391088
]
ASF GitHub Bot commented on MXNET-42:
-
larroy commented on a change in pull request #9995: [WIP] CI docker revamp; Add
Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173128408
##
File path: Jenkinsfile
##
@@ -419,6 +339,22 @@ try {
}
}
}
+},
+'NVidia Jetson / ARMv8':{
Review comment:
\o/
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391086#comment-16391086
]
ASF GitHub Bot commented on MXNET-42:
-
larroy commented on a change in pull request #9995: [WIP] CI docker revamp; Add
Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173128239
##
File path: Jenkinsfile
##
@@ -129,17 +129,14 @@ echo ${libs} | sed -e 's/,/ /g' | xargs md5sum
// Python 2
def python2_ut(docker_type) {
timeout(time: max_time, unit: 'MINUTES') {
-sh "${docker_run} ${docker_type} --dockerbinary docker find . -name
'*.pyc' -type f -delete"
-sh "${docker_run} ${docker_type} --dockerbinary docker
PYTHONPATH=./python/ nosetests-2.7 --with-timer --verbose tests/python/unittest"
-sh "${docker_run} ${docker_type} --dockerbinary docker
PYTHONPATH=./python/ nosetests-2.7 --with-timer --verbose tests/python/train"
+sh "ci/build.py --build -p ${docker_type} /work/runtime_functions.sh
unittest_ubuntu_python2_cpu"
Review comment:
we can also call build.py with -bp why one option long and the other short?
otherwise for consistency both long? --build --platform x
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391085#comment-16391085
]
ASF GitHub Bot commented on MXNET-42:
-
larroy commented on a change in pull request #9995: [WIP] CI docker revamp; Add
Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173128055
##
File path: Jenkinsfile
##
@@ -129,17 +129,14 @@ echo ${libs} | sed -e 's/,/ /g' | xargs md5sum
// Python 2
def python2_ut(docker_type) {
timeout(time: max_time, unit: 'MINUTES') {
-sh "${docker_run} ${docker_type} --dockerbinary docker find . -name
'*.pyc' -type f -delete"
-sh "${docker_run} ${docker_type} --dockerbinary docker
PYTHONPATH=./python/ nosetests-2.7 --with-timer --verbose tests/python/unittest"
-sh "${docker_run} ${docker_type} --dockerbinary docker
PYTHONPATH=./python/ nosetests-2.7 --with-timer --verbose tests/python/train"
+sh "ci/build.py --build -p ${docker_type} /work/runtime_functions.sh
unittest_ubuntu_python2_cpu"
Review comment:
I like it, it's shorter, less noisy, reproducible locally
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make CI failures locally reproducible
> -
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
>Reporter: Marco de Abreu
>Assignee: Marco de Abreu
>Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org
[jira] [Commented] (MXNET-42) Make CI failures locally reproducible
[ https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390408#comment-16390408 ] ASF GitHub Bot commented on MXNET-42: - marcoabreu commented on issue #9995: CI docker revamp; Add Jetson, Raspberry and CentOS 7 build [MXNET-42][MXNET-43][MXNET-44][MXNET-57] URL: https://github.com/apache/incubator-mxnet/pull/9995#issuecomment-371318315 @szha @sergeykolychev @tqchen @cjolivier01 @eric-haibin-lin can you please review? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make CI failures locally reproducible > - > > Key: MXNET-42 > URL: https://issues.apache.org/jira/browse/MXNET-42 > Project: Apache MXNet > Issue Type: Improvement >Reporter: Marco de Abreu >Assignee: Marco de Abreu >Priority: Major > > At the moment, it's hard to reproduce CI failures. Ideally, every failure > could be reproduced by executing a single command. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
