[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1071202236 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -137,49 +148,317 @@ void AbstractMQTTProcessor::onSchedule(const

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1071202236 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -137,49 +148,317 @@ void AbstractMQTTProcessor::onSchedule(const

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1042215060 ## extensions/mqtt/processors/AbstractMQTTProcessor.h: ## @@ -46,150 +44,178 @@ class AbstractMQTTProcessor : public core::Processor {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1042214797 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -137,19 +148,45 @@ void AbstractMQTTProcessor::onSchedule(const

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1042144555 ## PROCESSORS.md: ## @@ -337,28 +337,34 @@ This Processor gets the contents of a FlowFile from a MQTT broker for a specifie In the list below, the

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1042119988 ## extensions/mqtt/processors/PublishMQTT.cpp: ## @@ -34,76 +34,229 @@ void PublishMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041328112 ## extensions/mqtt/processors/PublishMQTT.cpp: ## @@ -34,76 +34,229 @@ void PublishMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041315835 ## extensions/mqtt/processors/PublishMQTT.cpp: ## @@ -34,76 +34,229 @@ void PublishMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041313305 ## extensions/mqtt/processors/PublishMQTT.cpp: ## @@ -34,76 +34,229 @@ void PublishMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041290532 ## extensions/mqtt/processors/PublishMQTT.cpp: ## @@ -34,76 +34,229 @@ void PublishMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041288113 ## extensions/mqtt/processors/PublishMQTT.cpp: ## @@ -34,76 +34,229 @@ void PublishMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041281537 ## extensions/mqtt/processors/ConsumeMQTT.cpp: ## @@ -34,111 +34,333 @@ void ConsumeMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041281303 ## extensions/mqtt/processors/ConsumeMQTT.cpp: ## @@ -34,111 +34,333 @@ void ConsumeMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041280626 ## extensions/mqtt/processors/ConsumeMQTT.cpp: ## @@ -34,111 +34,333 @@ void ConsumeMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041268666 ## extensions/mqtt/processors/ConsumeMQTT.cpp: ## @@ -34,111 +34,333 @@ void ConsumeMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041258769 ## extensions/mqtt/processors/ConsumeMQTT.cpp: ## @@ -34,111 +34,333 @@ void ConsumeMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041159887 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -163,23 +200,259 @@ void AbstractMQTTProcessor::reconnect() { }

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041148586 ## libminifi/include/utils/Enum.h: ## @@ -127,7 +128,7 @@ namespace utils { #define SMART_ENUM(Clazz, ...) \ struct Clazz { \ using Base =

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1040850939 ## extensions/mqtt/processors/AbstractMQTTProcessor.h: ## @@ -46,150 +44,178 @@ class AbstractMQTTProcessor : public core::Processor {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1040845912 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -163,23 +200,259 @@ void AbstractMQTTProcessor::reconnect() { }

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039819121 ## libminifi/include/utils/Enum.h: ## @@ -39,6 +39,7 @@ namespace utils { constexpr Clazz(Type value = static_cast(-1)) : value_{value} {} \

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039826380 ## PROCESSORS.md: ## @@ -2364,6 +2380,8 @@ In the list below, the names of required properties appear in bold. Any other pr ### Description Routes

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039825741 ## PROCESSORS.md: ## @@ -337,28 +337,34 @@ This Processor gets the contents of a FlowFile from a MQTT broker for a specifie In the list below, the

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039823934 ## libminifi/include/utils/Enum.h: ## @@ -127,7 +128,7 @@ namespace utils { #define SMART_ENUM(Clazz, ...) \ struct Clazz { \ using Base =

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039819121 ## libminifi/include/utils/Enum.h: ## @@ -39,6 +39,7 @@ namespace utils { constexpr Clazz(Type value = static_cast(-1)) : value_{value} {} \

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1021602103 ## extensions/mqtt/processors/PublishMQTT.cpp: ## @@ -34,76 +34,267 @@ void PublishMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1021602511 ## extensions/mqtt/processors/PublishMQTT.cpp: ## @@ -34,76 +34,267 @@ void PublishMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1021156290 ## extensions/mqtt/processors/ConsumeMQTT.h: ## @@ -68,63 +77,82 @@ class ConsumeMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1021135374 ## extensions/mqtt/processors/PublishMQTT.cpp: ## @@ -34,76 +34,267 @@ void PublishMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1020323673 ## extensions/mqtt/processors/ConsumeMQTT.cpp: ## @@ -34,111 +34,325 @@ void ConsumeMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1020313074 ## extensions/mqtt/processors/ConsumeMQTT.cpp: ## @@ -34,111 +34,325 @@ void ConsumeMQTT::initialize() { setSupportedRelationships(relationships());

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1020294046 ## extensions/mqtt/processors/ConsumeMQTT.h: ## @@ -35,27 +36,35 @@ namespace org::apache::nifi::minifi::processors { -#define MQTT_TOPIC_ATTRIBUTE

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1020292687 ## extensions/mqtt/processors/ConsumeMQTT.h: ## @@ -68,63 +77,82 @@ class ConsumeMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1019320537 ## extensions/mqtt/processors/ConsumeMQTT.h: ## @@ -125,14 +119,14 @@ class ConsumeMQTT : public processors::AbstractMQTTProcessor { void

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1019200246 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -163,23 +200,261 @@ void AbstractMQTTProcessor::reconnect() { }

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1019199181 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -163,23 +200,261 @@ void AbstractMQTTProcessor::reconnect() { }

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1019193763 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -137,19 +148,45 @@ void AbstractMQTTProcessor::onSchedule(const

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1019193763 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -137,19 +148,45 @@ void AbstractMQTTProcessor::onSchedule(const

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1019185396 ## extensions/mqtt/processors/AbstractMQTTProcessor.cpp: ## @@ -20,51 +20,49 @@ #include #include "utils/StringUtils.h" +#include

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

adam-markovics commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1019170650 ## extensions/librdkafka/PublishKafka.cpp: ## @@ -266,8 +266,8 @@ class ReadCallback { status_ = 0; called_ = true; -