adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r552445577
##
File path: libminifi/src/utils/StringUtils.cpp
##
@@ -94,37 +94,39 @@ bool StringUtils::StringToFloat(std::string input, float
,
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551985634
##
File path: nanofi/include/sitetosite/CPeer.h
##
@@ -88,7 +88,7 @@ static void setPort(struct SiteToSiteCPeer * peer, uint16_t
port) {
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551902820
##
File path: main/AgentDocs.cpp
##
@@ -47,7 +47,7 @@ std::string AgentDocs::extractClassName(const std::string
) const {
auto lastOfIdx
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551912512
##
File path: nanofi/include/sitetosite/CPeer.h
##
@@ -79,15 +79,15 @@ static void setHostName(struct SiteToSiteCPeer * peer,
const char *
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551912512
##
File path: nanofi/include/sitetosite/CPeer.h
##
@@ -79,15 +79,15 @@ static void setHostName(struct SiteToSiteCPeer * peer,
const char *
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551912512
##
File path: nanofi/include/sitetosite/CPeer.h
##
@@ -79,15 +79,15 @@ static void setHostName(struct SiteToSiteCPeer * peer,
const char *
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551912172
##
File path: nanofi/tests/CTestsBase.h
##
@@ -138,7 +138,8 @@ class TestControllerWithTemporaryWorkingDirectory {
}
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551902820
##
File path: main/AgentDocs.cpp
##
@@ -47,7 +47,7 @@ std::string AgentDocs::extractClassName(const std::string
) const {
auto lastOfIdx
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551902469
##
File path: libminifi/test/unit/ZlibStreamTests.cpp
##
@@ -97,7 +106,8 @@ TEST_CASE("gzip compression and decompression pipeline",
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551895592
##
File path: libminifi/src/utils/StringUtils.cpp
##
@@ -95,21 +95,23 @@ bool StringUtils::StringToFloat(std::string input, float
,
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551893946
##
File path: libminifi/src/utils/StringUtils.cpp
##
@@ -95,21 +95,23 @@ bool StringUtils::StringToFloat(std::string input, float
,
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551891837
##
File path: libminifi/src/provenance/Provenance.cpp
##
@@ -189,8 +192,8 @@ bool
adamdebreceni commented on a change in pull request #964:
URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551891610
##
File path: libminifi/src/provenance/Provenance.cpp
##
@@ -178,8 +181,8 @@ bool
13 matches
Mail list logo