[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969665 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246974404 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246976098 ## File path: libminifi/include/core/TypedValues.h ## @@ -141,6 +141,47 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246976098 ## File path: libminifi/include/core/TypedValues.h ## @@ -141,6 +141,47 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971930 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969665 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246974404 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246973810 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246972159 ## File path: libminifi/include/core/TypedValues.h ## @@ -141,6 +141,47 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971930 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971930 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971618 ## File path: libminifi/include/core/TypedValues.h ## @@ -141,6 +141,47 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971581 ## File path: libminifi/include/core/TypedValues.h ## @@ -141,6 +141,47 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971559 ## File path: libminifi/src/c2/protocols/RESTProtocol.cpp ## @@ -129,7 +129,7

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971275 ## File path: libminifi/include/core/TypedValues.h ## @@ -163,7 +204,11 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246970833 ## File path: libminifi/include/core/TypedValues.h ## @@ -141,6 +141,47 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969665 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969601 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969481 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969407 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@