[GitHub] ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all
ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all URL: https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321744073 @markusthoemmes , i have modified again, please review again ^^ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all
ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all URL: https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321429242 @markusthoemmes i have removed `defaultLimits` from `ansible/group_vars/all` and have `limits` only This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all
ningyougang commented on issue #2595: Move variable limits to
ansible/group_vars/all
URL:
https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321212609
@markusthoemmes ,for `defaultLimits` and `limits`, i just know it is using
for `benchmarks test`, i don't know here why remove `defaultLimits`, if
remove, below statements will also be removed
```
"DEFAULTLIMITS_ACTIONS_INVOKES_PERMINUTE": "{{
defaultLimits.actions.invokes.perMinute }}"
"DEFAULTLIMITS_ACTIONS_INVOKES_CONCURRENT": "{{
defaultLimits.actions.invokes.concurrent }}"
"DEFAULTLIMITS_TRIGGERS_FIRES_PERMINUTE": "{{
defaultLimits.triggers.fires.perMinute }}"
"DEFAULTLIMITS_ACTIONS_INVOKES_CONCURRENTINSYSTEM": "{{
defaultLimits.actions.invokes.concurrentInSystem }}"
"DEFAULTLIMITS_ACTIONS_SEQUENCE_MAXLENGTH": "{{
defaultLimits.actions.sequence.maxLength }}"
```
Has any bad influences?
What's the difference between `defaultLimits` and `limits`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all
ningyougang commented on issue #2595: Move variable limits to
ansible/group_vars/all
URL:
https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321212609
@markusthoemmes ,for `defaultLimits` and `limits`, i just know it is using
for `benchmarks test`, i don't know here why remove `defaultLimits`, if
remove, below statements will also be removed
```
"DEFAULTLIMITS_ACTIONS_INVOKES_PERMINUTE": "{{
defaultLimits.actions.invokes.perMinute }}"
"DEFAULTLIMITS_ACTIONS_INVOKES_CONCURRENT": "{{
defaultLimits.actions.invokes.concurrent }}"
"DEFAULTLIMITS_TRIGGERS_FIRES_PERMINUTE": "{{
defaultLimits.triggers.fires.perMinute }}"
"DEFAULTLIMITS_ACTIONS_INVOKES_CONCURRENTINSYSTEM": "{{
defaultLimits.actions.invokes.concurrentInSystem }}"
"DEFAULTLIMITS_ACTIONS_SEQUENCE_MAXLENGTH": "{{
defaultLimits.actions.sequence.maxLength }}"
```
Has any bad influences?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all
ningyougang commented on issue #2595: Move variable limits to
ansible/group_vars/all
URL:
https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321198752
@markusthoemmes , i have tested `local` and `distributed` env, it is ok.
But for `mac` and `docker-machine`, i don't have these envs in my local, so
can't test it.
But i am sure for `mac` and `docker-machine`, it will work well, why?
You can see variable `defaultLimits` is defined in
`ansible/groups_vars/all` only,
the `- name: (re)start controller` ansible task has a ENV
`"DEFAULTLIMITS_ACTIONS_INVOKES_PERMINUTE": "{{
defaultLimits.actions.invokes.perMinute }}"`. so after modified for `limits`,
`limits` and `defaultLimits` are symmetrical
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all
ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all URL: https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321192863 Sorry, I will test it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
