Re: [PR] PHOENIX-7155 Validate Partial Index support with JSON [phoenix]

2023-12-18 Thread via GitHub
kadirozde commented on code in PR #1767: URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430318335 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java: ## @@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()

[jira] [Commented] (PHOENIX-7155) Validate Partial Index support with JSON

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798253#comment-17798253 ] ASF GitHub Bot commented on PHOENIX-7155: - kadirozde commented on code in PR #1767: URL:

Re: [PR] PHOENIX-7155 Validate Partial Index support with JSON [phoenix]

2023-12-18 Thread via GitHub
kadirozde commented on code in PR #1767: URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430335984 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java: ## @@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()

[jira] [Commented] (PHOENIX-7155) Validate Partial Index support with JSON

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798255#comment-17798255 ] ASF GitHub Bot commented on PHOENIX-7155: - kadirozde commented on code in PR #1767: URL:

Re: [PR] PHOENIX-7155 Validate Partial Index support with JSON [phoenix]

2023-12-18 Thread via GitHub
kadirozde commented on code in PR #1767: URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430321012 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java: ## @@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()

[jira] [Commented] (PHOENIX-7155) Validate Partial Index support with JSON

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798252#comment-17798252 ] ASF GitHub Bot commented on PHOENIX-7155: - kadirozde commented on code in PR #1767: URL:

Re: [PR] PHOENIX-7155 Validate Partial Index support with JSON [phoenix]

2023-12-18 Thread via GitHub
kadirozde commented on code in PR #1767: URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430324025 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java: ## @@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()

Re: [PR] PHOENIX-7155 Validate Partial Index support with JSON [phoenix]

2023-12-18 Thread via GitHub
kadirozde commented on code in PR #1767: URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430324025 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java: ## @@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()

[jira] [Commented] (PHOENIX-7155) Validate Partial Index support with JSON

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798257#comment-17798257 ] ASF GitHub Bot commented on PHOENIX-7155: - kadirozde commented on code in PR #1767: URL:

[jira] [Commented] (PHOENIX-7155) Validate Partial Index support with JSON

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798248#comment-17798248 ] ASF GitHub Bot commented on PHOENIX-7155: - kadirozde commented on code in PR #1767: URL:

[jira] [Commented] (PHOENIX-7155) Validate Partial Index support with JSON

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798249#comment-17798249 ] ASF GitHub Bot commented on PHOENIX-7155: - kadirozde commented on code in PR #1767: URL:

Re: [PR] PHOENIX-7155 Validate Partial Index support with JSON [phoenix]

2023-12-18 Thread via GitHub
kadirozde commented on code in PR #1767: URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430334103 ## phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java: ## @@ -110,6 +111,8 @@ private String getValue(PDataType type) {

[jira] [Commented] (PHOENIX-7155) Validate Partial Index support with JSON

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798125#comment-17798125 ] ASF GitHub Bot commented on PHOENIX-7155: - ranganathg opened a new pull request, #1767: URL:

[PR] PHOENIX-7155 Validate Partial Index support with JSON [phoenix]

2023-12-18 Thread via GitHub
ranganathg opened a new pull request, #1767: URL: https://github.com/apache/phoenix/pull/1767 [PHOENIX-7155](https://issues.apache.org/jira/browse/PHOENIX-7155) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (PHOENIX-7155) Validate Partial Index support with JSON

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798272#comment-17798272 ] ASF GitHub Bot commented on PHOENIX-7155: - ranganathg commented on code in PR #1767: URL:

[jira] [Commented] (PHOENIX-7155) Validate Partial Index support with JSON

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798273#comment-17798273 ] ASF GitHub Bot commented on PHOENIX-7155: - ranganathg commented on code in PR #1767: URL:

Re: [PR] PHOENIX-7155 Validate Partial Index support with JSON [phoenix]

2023-12-18 Thread via GitHub
ranganathg commented on code in PR #1767: URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430371350 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java: ## @@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()

Re: [PR] PHOENIX-7155 Validate Partial Index support with JSON [phoenix]

2023-12-18 Thread via GitHub
ranganathg commented on code in PR #1767: URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430370140 ## phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java: ## @@ -110,6 +111,8 @@ private String getValue(PDataType type) {