[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395030#comment-16395030
]
ASF GitHub Bot commented on SCB-387:
asifdxtreme closed pull request #303: SCB-387 Add ASF headers for
auto-generated files
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docs/api-docs.html b/docs/api-docs.html
index 74aa2b36..3f221c53 100644
--- a/docs/api-docs.html
+++ b/docs/api-docs.html
@@ -1,3 +1,19 @@
+
diff --git a/docs/release/Readme.md b/docs/release/Readme.md
index 1a06194d..09f6994c 100644
--- a/docs/release/Readme.md
+++ b/docs/release/Readme.md
@@ -27,14 +27,12 @@ cp apache-rat-0.12/apache-rat-0.12.jar ./
Run the Rat tool using the below command
```
-java -jar apache-rat-0.12.jar -a -d incubator-servicecomb-service-center/ -e
*.md *.MD .gitignore .gitmodules .travis.yml *.json *.yaml *.tmpl *.conf *.html
*.pb.go services.proto broker.proto manifest **vendor** **licenses**
+java -jar apache-rat-0.12.jar -a -d incubator-servicecomb-service-center/ -e
*.md *.MD .gitignore .gitmodules .travis.yml manifest **vendor** **licenses**
```
Below is the list of the files which has been excluded from the list of RAT
tool.
- *.md *.MD *.html: Skip all the Readme and Documentation file like Api
Docs.
- .gitignore .gitmodules .travis.yml : Skip the git files and travis file.
- - *.json *.yaml *.tmpl *.conf : Skip all the json files , yaml files, temp
DockerFile and configuration files.
- - *.pb.go services.proto : Skip the Protobuf auto-generated codes.
- manifest **vendor : Skip manifest and all the files under vendor.
You can access the latest RAT report [here](/docs/release/rat-report)
diff --git a/etc/conf/app.conf b/etc/conf/app.conf
index a4fa9bfd..cae53915 100644
--- a/etc/conf/app.conf
+++ b/etc/conf/app.conf
@@ -1,3 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
component_name = service_center
#run mode could be many options to specify the env like prod,dev
runmode = dev
@@ -111,4 +126,4 @@ logfile = ""
# Frontend Configurations
###
frontend_host_ip=127.0.0.1
-frontend_host_port=30103
\ No newline at end of file
+frontend_host_port=30103
diff --git a/examples/service_center/body/add_dependency_request.json
b/examples/service_center/body/add_dependency_request.json
index b8797e26..1caf38dc 100644
--- a/examples/service_center/body/add_dependency_request.json
+++ b/examples/service_center/body/add_dependency_request.json
@@ -1,3 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
{
"dependencies": [
{
diff --git a/examples/service_center/body/create_service_response.json
b/examples/service_center/body/create_service_response.json
index 46ea5d03..da249e0c 100644
--- a/examples/service_center/body/create_service_response.json
+++ b/examples/service_center/body/create_service_response.json
@@ -1 +1,16 @@
-{"serviceId":"160ec1686cf911e7b7bc286ed488ff40"}
\ No newline at end of file
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the
[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394968#comment-16394968
]
ASF GitHub Bot commented on SCB-387:
yangbor commented on issue #303: SCB-387 Add ASF headers for auto-generated
files
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372232771
For the JSON files, perhaps we can use the form {"ASF_HEADER" : "This
product..."} to add the header without making those json files invalid.
But as those files are just for demostration, neither our program nor
clients' use those files directly, it can be left as is.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
> ./server/broker/broker.pb.go
> ./server/broker/broker.proto
> ./server/core/proto/services.pb.go
> ./server/core/proto/services.proto
> ./server/core/swagger/v3.yaml
> ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it
> for checking. But the .proto files should have the ASF header.
> bin:
> ./conf/app.conf
> The apache policy states that only files that have no creativity and some
> simple template files for code generation can have the header omitted. Other
> files should all have the header included.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394957#comment-16394957
]
ASF GitHub Bot commented on SCB-387:
yangbor commented on issue #303: SCB-387 Add ASF headers for auto-generated
files
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372232771
For the JSON files, perhaps we can use the form {"ASF_HEADER" : "This
product..."} to add the header without making those json files invalid.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Somefiles are lacking ASF header in Service Center
> --
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: Yang Bo
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
> ./server/broker/broker.pb.go
> ./server/broker/broker.proto
> ./server/core/proto/services.pb.go
> ./server/core/proto/services.proto
> ./server/core/swagger/v3.yaml
> ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it
> for checking. But the .proto files should have the ASF header.
> bin:
> ./conf/app.conf
> The apache policy states that only files that have no creativity and some
> simple template files for code generation can have the header omitted. Other
> files should all have the header included.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[ https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394949#comment-16394949 ] ASF GitHub Bot commented on SCB-387: codecov-io commented on issue #303: SCB-387 Add ASF headers for auto-generated files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212467 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=h1) Report > Merging [#303](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bfe06665e640d4473ef68e54671d395e4f7ca3f6?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #303 +/- ## === Coverage 70.39% 70.39% === Files 17 17 Lines3455 3455 === Hits 2432 2432 Misses853 853 Partials 170 170 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `75.43% <0%> (-0.59%)` | :arrow_down: | | [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `77.25% <0%> (+0.42%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=footer). Last update [bfe0666...1b3a012](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Somefiles are lacking ASF header in Service Center > -- > > Key: SCB-387 > URL: https://issues.apache.org/jira/browse/SCB-387 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0-m1 > > > The following files does not have ASF headers > src: > ./server/broker/broker.pb.go > ./server/broker/broker.proto > ./server/core/proto/services.pb.go > ./server/core/proto/services.proto > ./server/core/swagger/v3.yaml > ./server/core/swagger/v4.yaml > The pb.go files are generated by protobuf utility, perhaps we can exclude it > for checking. But the .proto files should have the ASF header. > bin: > ./conf/app.conf > The apache policy states that only files that have no creativity and some > simple template files for code generation can have the header omitted. Other > files should all have the header included. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[ https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394948#comment-16394948 ] ASF GitHub Bot commented on SCB-387: coveralls commented on issue #303: SCB-387 Add ASF headers for auto-generated files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212464 [](https://coveralls.io/builds/15922904) Coverage increased (+0.2%) to 74.112% when pulling **1b3a0128c7a9cecea6729efd10daad1489c4a85f on asifdxtreme:master** into **bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Somefiles are lacking ASF header in Service Center > -- > > Key: SCB-387 > URL: https://issues.apache.org/jira/browse/SCB-387 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0-m1 > > > The following files does not have ASF headers > src: > ./server/broker/broker.pb.go > ./server/broker/broker.proto > ./server/core/proto/services.pb.go > ./server/core/proto/services.proto > ./server/core/swagger/v3.yaml > ./server/core/swagger/v4.yaml > The pb.go files are generated by protobuf utility, perhaps we can exclude it > for checking. But the .proto files should have the ASF header. > bin: > ./conf/app.conf > The apache policy states that only files that have no creativity and some > simple template files for code generation can have the header omitted. Other > files should all have the header included. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[ https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394945#comment-16394945 ] ASF GitHub Bot commented on SCB-387: coveralls commented on issue #303: SCB-387 Add ASF headers for auto-generated files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212464 [](https://coveralls.io/builds/15922873) Coverage increased (+0.1%) to 74.063% when pulling **1b3a0128c7a9cecea6729efd10daad1489c4a85f on asifdxtreme:master** into **bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Somefiles are lacking ASF header in Service Center > -- > > Key: SCB-387 > URL: https://issues.apache.org/jira/browse/SCB-387 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0-m1 > > > The following files does not have ASF headers > src: > ./server/broker/broker.pb.go > ./server/broker/broker.proto > ./server/core/proto/services.pb.go > ./server/core/proto/services.proto > ./server/core/swagger/v3.yaml > ./server/core/swagger/v4.yaml > The pb.go files are generated by protobuf utility, perhaps we can exclude it > for checking. But the .proto files should have the ASF header. > bin: > ./conf/app.conf > The apache policy states that only files that have no creativity and some > simple template files for code generation can have the header omitted. Other > files should all have the header included. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[ https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394920#comment-16394920 ] ASF GitHub Bot commented on SCB-387: coveralls commented on issue #303: SCB-387 Add ASF headers for auto-generated files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212464 [](https://coveralls.io/builds/15922358) Coverage increased (+0.1%) to 74.063% when pulling **0fdb7cf9057ec96ff99316b1de045e3d6f03c5a8 on asifdxtreme:master** into **bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Somefiles are lacking ASF header in Service Center > -- > > Key: SCB-387 > URL: https://issues.apache.org/jira/browse/SCB-387 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0-m1 > > > The following files does not have ASF headers > src: > ./server/broker/broker.pb.go > ./server/broker/broker.proto > ./server/core/proto/services.pb.go > ./server/core/proto/services.proto > ./server/core/swagger/v3.yaml > ./server/core/swagger/v4.yaml > The pb.go files are generated by protobuf utility, perhaps we can exclude it > for checking. But the .proto files should have the ASF header. > bin: > ./conf/app.conf > The apache policy states that only files that have no creativity and some > simple template files for code generation can have the header omitted. Other > files should all have the header included. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[ https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394919#comment-16394919 ] ASF GitHub Bot commented on SCB-387: codecov-io commented on issue #303: SCB-387 Add ASF headers for auto-generated files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212467 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=h1) Report > Merging [#303](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bfe06665e640d4473ef68e54671d395e4f7ca3f6?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #303 +/- ## === Coverage 70.39% 70.39% === Files 17 17 Lines3455 3455 === Hits 2432 2432 Misses853 853 Partials 170 170 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=footer). Last update [bfe0666...0fdb7cf](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Somefiles are lacking ASF header in Service Center > -- > > Key: SCB-387 > URL: https://issues.apache.org/jira/browse/SCB-387 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0-m1 > > > The following files does not have ASF headers > src: > ./server/broker/broker.pb.go > ./server/broker/broker.proto > ./server/core/proto/services.pb.go > ./server/core/proto/services.proto > ./server/core/swagger/v3.yaml > ./server/core/swagger/v4.yaml > The pb.go files are generated by protobuf utility, perhaps we can exclude it > for checking. But the .proto files should have the ASF header. > bin: > ./conf/app.conf > The apache policy states that only files that have no creativity and some > simple template files for code generation can have the header omitted. Other > files should all have the header included. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[ https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394898#comment-16394898 ] ASF GitHub Bot commented on SCB-387: coveralls commented on issue #303: SCB-387 Add ASF headers for auto-generated files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212464 [](https://coveralls.io/builds/15922065) Coverage remained the same at 73.961% when pulling **4b60ee6896259312952da4ebaf8f51c6abb3b318 on asifdxtreme:master** into **bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Somefiles are lacking ASF header in Service Center > -- > > Key: SCB-387 > URL: https://issues.apache.org/jira/browse/SCB-387 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0-m1 > > > The following files does not have ASF headers > src: > ./server/broker/broker.pb.go > ./server/broker/broker.proto > ./server/core/proto/services.pb.go > ./server/core/proto/services.proto > ./server/core/swagger/v3.yaml > ./server/core/swagger/v4.yaml > The pb.go files are generated by protobuf utility, perhaps we can exclude it > for checking. But the .proto files should have the ASF header. > bin: > ./conf/app.conf > The apache policy states that only files that have no creativity and some > simple template files for code generation can have the header omitted. Other > files should all have the header included. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[ https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394899#comment-16394899 ] ASF GitHub Bot commented on SCB-387: codecov-io commented on issue #303: SCB-387 Add ASF headers for auto-generated files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212467 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=h1) Report > Merging [#303](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bfe06665e640d4473ef68e54671d395e4f7ca3f6?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=tree) ```diff @@Coverage Diff @@ ## master #303 +/- ## == - Coverage 70.39% 70.36% -0.03% == Files 17 17 Lines3455 3455 == - Hits 2432 2431 -1 Misses853 853 - Partials 170 171 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `75.43% <0%> (-0.59%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=footer). Last update [bfe0666...4b60ee6](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Somefiles are lacking ASF header in Service Center > -- > > Key: SCB-387 > URL: https://issues.apache.org/jira/browse/SCB-387 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0-m1 > > > The following files does not have ASF headers > src: > ./server/broker/broker.pb.go > ./server/broker/broker.proto > ./server/core/proto/services.pb.go > ./server/core/proto/services.proto > ./server/core/swagger/v3.yaml > ./server/core/swagger/v4.yaml > The pb.go files are generated by protobuf utility, perhaps we can exclude it > for checking. But the .proto files should have the ASF header. > bin: > ./conf/app.conf > The apache policy states that only files that have no creativity and some > simple template files for code generation can have the header omitted. Other > files should all have the header included. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center
[ https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394886#comment-16394886 ] ASF GitHub Bot commented on SCB-387: asifdxtreme opened a new pull request #303: SCB-387 Add ASF headers for auto-generated files URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Somefiles are lacking ASF header in Service Center > -- > > Key: SCB-387 > URL: https://issues.apache.org/jira/browse/SCB-387 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0-m1 > > > The following files does not have ASF headers > src: > ./server/broker/broker.pb.go > ./server/broker/broker.proto > ./server/core/proto/services.pb.go > ./server/core/proto/services.proto > ./server/core/swagger/v3.yaml > ./server/core/swagger/v4.yaml > The pb.go files are generated by protobuf utility, perhaps we can exclude it > for checking. But the .proto files should have the ASF header. > bin: > ./conf/app.conf > The apache policy states that only files that have no creativity and some > simple template files for code generation can have the header omitted. Other > files should all have the header included. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
