[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656989#comment-16656989 ] ASF GitHub Bot commented on SCB-953: coveralls commented on issue #459: SCB-953 Make clusters configuration convenient URL: https://github.com/apache/incubator-servicecomb-service-center/pull/459#issuecomment-431412591 [](https://coveralls.io/builds/19618940) Coverage increased (+0.008%) to 62.589% when pulling **48260c724ca544542d6123a026454ae121f7a9f0 on little-cui:dev** into **3fe59edb7c6de5c58fb19aeb7b29a1158124e03e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656988#comment-16656988 ] ASF GitHub Bot commented on SCB-953: codecov-io commented on issue #459: SCB-953 Make clusters configuration convenient URL: https://github.com/apache/incubator-servicecomb-service-center/pull/459#issuecomment-431412295 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr=h1) Report > Merging [#459](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3fe59edb7c6de5c58fb19aeb7b29a1158124e03e?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr=tree) ```diff @@Coverage Diff @@ ## master #459 +/- ## == + Coverage60.1% 60.16% +0.05% == Files 156 156 Lines 1341413414 == + Hits 8063 8071 +8 + Misses 4770 4762 -8 Partials 581 581 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.78% <0%> (-0.16%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.3% <0%> (+0.56%)` | :arrow_up: | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `78.87% <0%> (+9.85%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr=footer). Last update [3fe59ed...48260c7](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656356#comment-16656356 ] ASF GitHub Bot commented on SCB-953: little-cui opened a new pull request #459: SCB-953 Make clusters configuration convenient URL: https://github.com/apache/incubator-servicecomb-service-center/pull/459 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[
https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654894#comment-16654894
]
ASF GitHub Bot commented on SCB-953:
asifdxtreme closed pull request #458: SCB-953 Support sync distinct Kubernetes
service types to service-center
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/README.md b/README.md
index e2fd849f..ecdf7d9c 100644
--- a/README.md
+++ b/README.md
@@ -7,7 +7,7 @@ Apache ServiceComb (incubating) Service-Center is a Restful
based service-regist
- **[`Open API`](/server/core/swagger/v4.yaml)**: API doc(Open API format)
management for microservice
- **Metadata**: Metadata management for both microservice and microservice
instance
- **Dependency**: Microservice dependency management
- - **Seperated**: Seperated microservice and microservice instance entity
management
+ - **Separated**: Separated microservice and microservice instance entity
management
- **Domains**: Logical multiple domains management
- **Security**: White and back list configuration for service discovery
- **Discovery**: Support query instance by criteria
@@ -17,8 +17,12 @@ Apache ServiceComb (incubating) Service-Center is a Restful
based service-regist
- **Performance**: Performance/Caching design
- **[`Metrics`](/docs/integration-grafana.md)**: Able to expose Prometheus
metric API automatically
- **[`Tracing`](/docs/tracing.md)**: Able to report tracing data to Zipkin
server
- - **[`Multi Datacenter`](/docs/multidcs.md)**: Additional layer of
abstraction to clusters deployed in multiple datacenters
- - **[`Dynmaic Plug-in`](/docs/plugin.md)**: Able to load custom
authentication, tls and other dynamic libraries
+ - **[`Pluginable`](/docs/plugin.md)**: Able to load custom authentication,
tls and other dynamic libraries
+ - **[`CLI`](/scctl/pkg/plugin/README.md)**: Easy to control service center
+ - **[`Kubernetes`](/docs/kubeclusters.md)**: Embrace kubernetes ecosystem and
support multi cluster service discovery
+ - **[`Datacenters`](/docs/multidcs.md)**: Additional layer of abstraction to
clusters deployed in multiple datacenters
+ - **[`Aggregation`](/docs/aggregate.md)**: Able to aggregate microservices
from multiple registry platforms and
+support platform registry and client side registry at the same time
## Documentation
diff --git a/docs/README.md b/docs/README.md
index c827fb4d..0d9d7197 100644
--- a/docs/README.md
+++ b/docs/README.md
@@ -30,7 +30,7 @@ Swagger
[`v4`](/server/core/swagger/v4.yaml)|[`v3`](/server/core/swagger/v3.yaml
+ **Kubernetes**
- [Helm Chart](/docs/helm.md)
- [Access Distinct Clusters](/docs/kubeclusters.md)
- - [Multiple Platforms Micro-services Manage](/docs/aggregate.md)
+ - [Multiple Registry Aggregation](/docs/aggregate.md)
Monitoring Service-Center
diff --git a/docs/helm.md b/docs/helm.md
index 9c04507a..405ea11f 100644
--- a/docs/helm.md
+++ b/docs/helm.md
@@ -72,25 +72,11 @@ cd ${PROJECT_ROOT}/examples/infrastructures/k8s
# install etcd cluster
helm install --name coreos --namespace default etcd/
# install sc cluster
-helm install --name dc1 --namespace default \
---set frontend.deployment=false \
---set sc.image.repository="desktop-0028:5000/servicecomb/service-center" \
---set sc.discovery.type="aggregate" \
---set sc.discovery.aggregate="etcd\,servicecenter" \
---set
sc.discovery.clusters="sc-1=http://c1-etcd-client:2379\,sc-2=http://dc2-service-center:30100;
\
---set sc.registry.enabled=true \
---set sc.registry.type="etcd" \
---set sc.registry.name="sc-1" \
-service-center/
-helm install --name dc2 --namespace default \
---set frontend.deployment=false \
---set sc.image.repository="desktop-0028:5000/servicecomb/service-center" \
---set sc.discovery.type="aggregate" \
---set sc.discovery.aggregate="etcd\,servicecenter" \
---set
sc.discovery.clusters="sc-2=http://c2-etcd-client:2379\,sc-1=http://dc1-service-center:30100;
\
+helm install --name servicecomb --namespace default \
+--set sc.discovery.type="etcd" \
+--set sc.discovery.clusters="http://coreos-etcd-client:2379; \
--set sc.registry.enabled=true \
--set sc.registry.type="etcd" \
---set sc.registry.name="sc-2" \
service-center/
```
diff --git a/docs/multidcs.md b/docs/multidcs.md
index ecba0eac..3354ff60 100644
--- a/docs/multidcs.md
+++ b/docs/multidcs.md
@@ -14,6 +14,15 @@ isolated from each other. Another implementation of the
discovery plug-in, `Serv
access multiple SC instances and periodically pull up micro-service instance
information so that if
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654878#comment-16654878 ] ASF GitHub Bot commented on SCB-953: coveralls edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430517550 [](https://coveralls.io/builds/19588678) Coverage increased (+0.06%) to 62.608% when pulling **286f8c1b1f9cfb9bad4433623dfce08257491bf5 on little-cui:master** into **8ddbc2f1bbcda497fb059bac928efb93433e9808 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654877#comment-16654877 ] ASF GitHub Bot commented on SCB-953: codecov-io edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430272510 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=h1) Report > Merging [#458](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8ddbc2f1bbcda497fb059bac928efb93433e9808?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `40%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) ```diff @@Coverage Diff @@ ## master #458 +/- ## == - Coverage 60.18% 60.16% -0.03% == Files 156 156 Lines 1341113414 +3 == - Hits 8072 8070 -2 - Misses 4760 4763 +3 - Partials 579 581 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `85.74% <100%> (-0.57%)` | :arrow_down: | | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `71.73% <25%> (-2.68%)` | :arrow_down: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.86% <0%> (+0.59%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=footer). Last update [8ddbc2f...286f8c1](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654829#comment-16654829 ] ASF GitHub Bot commented on SCB-953: coveralls edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430517550 [](https://coveralls.io/builds/19587959) Coverage decreased (-0.01%) to 62.532% when pulling **2b9603442103276831e7e44209fbad65b87d05bf on little-cui:master** into **8ddbc2f1bbcda497fb059bac928efb93433e9808 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654786#comment-16654786 ] ASF GitHub Bot commented on SCB-953: codecov-io edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430272510 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=h1) Report > Merging [#458](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8ddbc2f1bbcda497fb059bac928efb93433e9808?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `40%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) ```diff @@Coverage Diff @@ ## master #458 +/- ## == - Coverage 60.18% 60.16% -0.03% == Files 156 156 Lines 1341113414 +3 == - Hits 8072 8071 -1 - Misses 4760 4763 +3 - Partials 579 580 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `85.74% <100%> (-0.57%)` | :arrow_down: | | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `71.73% <25%> (-2.68%)` | :arrow_down: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `96.15% <0%> (+1.28%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=footer). Last update [8ddbc2f...2b96034](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653708#comment-16653708 ] ASF GitHub Bot commented on SCB-953: coveralls edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430517550 [](https://coveralls.io/builds/19572470) Coverage decreased (-0.04%) to 62.503% when pulling **bf972c5d29c7f1feaa6b975b9386af349f228fee on little-cui:master** into **8ddbc2f1bbcda497fb059bac928efb93433e9808 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653241#comment-16653241 ] ASF GitHub Bot commented on SCB-953: codecov-io edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430272510 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=h1) Report > Merging [#458](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8ddbc2f1bbcda497fb059bac928efb93433e9808?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) ```diff @@Coverage Diff @@ ## master #458 +/- ## == - Coverage 60.18% 60.17% -0.02% == Files 156 156 Lines 1341113411 == - Hits 8072 8070 -2 - Misses 4760 4762 +2 Partials 579 579 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `81.93% <0%> (-1.94%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: | | [server/service/notification/stream.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3N0cmVhbS5nbw==) | `69.56% <0%> (+4.34%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=footer). Last update [8ddbc2f...30db6db](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653242#comment-16653242 ] ASF GitHub Bot commented on SCB-953: coveralls edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430517550 [](https://coveralls.io/builds/19565952) Coverage increased (+0.06%) to 62.602% when pulling **30db6dbf8684fe95336f0dc47ca4e8dc32911fd4 on little-cui:master** into **8ddbc2f1bbcda497fb059bac928efb93433e9808 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653136#comment-16653136 ] ASF GitHub Bot commented on SCB-953: codecov-io edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430272510 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=h1) Report > Merging [#458](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8ddbc2f1bbcda497fb059bac928efb93433e9808?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) ```diff @@Coverage Diff @@ ## master #458 +/- ## == + Coverage 60.18% 60.21% +0.02% == Files 156 156 Lines 1341113411 == + Hits 8072 8076 +4 Misses 4760 4760 + Partials 579 575 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.86% <0%> (+0.59%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `61.19% <0%> (+1.49%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=footer). Last update [8ddbc2f...2400e1c](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653138#comment-16653138 ] ASF GitHub Bot commented on SCB-953: coveralls edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430517550 [](https://coveralls.io/builds/19564545) Coverage increased (+0.05%) to 62.598% when pulling **2400e1cf84a06e89b0038514496b1b033da8e425 on little-cui:master** into **8ddbc2f1bbcda497fb059bac928efb93433e9808 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653132#comment-16653132 ] ASF GitHub Bot commented on SCB-953: coveralls edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430517550 [](https://coveralls.io/builds/19564471) Coverage increased (+0.09%) to 62.63% when pulling **2400e1cf84a06e89b0038514496b1b033da8e425 on little-cui:master** into **8ddbc2f1bbcda497fb059bac928efb93433e9808 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653109#comment-16653109 ] ASF GitHub Bot commented on SCB-953: coveralls commented on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430517550 [](https://coveralls.io/builds/19564309) Coverage increased (+0.1%) to 62.677% when pulling **e04135340490e3ee8f4aed1b354a2825a83a8596 on little-cui:master** into **8ddbc2f1bbcda497fb059bac928efb93433e9808 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653107#comment-16653107 ] ASF GitHub Bot commented on SCB-953: codecov-io edited a comment on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430272510 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=h1) Report > Merging [#458](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8ddbc2f1bbcda497fb059bac928efb93433e9808?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #458 +/- ## === Coverage 60.18% 60.18% === Files 156 156 Lines 1341113411 === Hits 8072 8072 Misses 4760 4760 Partials 579 579 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [pkg/util/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `67.56% <0%> (+1.35%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=footer). Last update [8ddbc2f...2400e1c](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651859#comment-16651859 ] ASF GitHub Bot commented on SCB-953: codecov-io commented on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430272510 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=h1) Report > Merging [#458](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8ddbc2f1bbcda497fb059bac928efb93433e9808?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) ```diff @@Coverage Diff @@ ## master #458 +/- ## == + Coverage 60.18% 60.19% +<.01% == Files 156 156 Lines 1341113411 == + Hits 8072 8073 +1 Misses 4760 4760 + Partials 579 578 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=footer). Last update [8ddbc2f...bc24da1](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651817#comment-16651817 ] ASF GitHub Bot commented on SCB-953: little-cui opened a new pull request #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
